beb5314cb9d546942bdc8137bf5ac9b2c8a5d8ec: Bug 1293957 part.2 TSFTextStore::GetTextExt() shouldn't return TS_E_NOLAYOUT after hacking the query range r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Aug 2016 19:11:11 +0900 - rev 401400
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1293957 part.2 TSFTextStore::GetTextExt() shouldn't return TS_E_NOLAYOUT after hacking the query range r=m_kato When TSFTextStore::GetTextExt() needs to hack the queried range, it means that the method should not return TS_E_NOLAYOUT since the hacks are implemented for that. However, currently, if hacked offset is still at modified offset, it returns TS_E_NOLAYOUT. This causes flicking IME windows. For avoiding that, this patch adjust the hacked offset to the last unmodified offset or offset of the start of composition string. Even if there is no modified character in the composition string, we can use the offset since even if there is no character at the offset, query content event returns caret rect at the offset and if there are old characters, it returns its rect which the user still see. So, the rect at the composition start is useful until layout is modified actually. MozReview-Commit-ID: 4zo9mF3m9u9
e75a8aa973d784d30b33872a2dcd279b506514ad: Bug 1293957 part.1 TSFTextStore::Content::mMinTextModifiedOffset should be treated as the first offset of modified characters r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Aug 2016 18:48:50 +0900 - rev 401399
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1293957 part.1 TSFTextStore::Content::mMinTextModifiedOffset should be treated as the first offset of modified characters r=m_kato Currently, TSFTextStore::GetTextExt() checks the offset with mContentForTSF.MinOffsetOfLayoutChanged() as "the first offset of modified characters", however, TSFTextStore::Content::IsLayoutChangedAfter() needs actual offset - 1. This is really not useful. So, we should rename it to IsLayoutChangedAt() and check the offset simply. Additonally, TSFTextStore::GetTextExt() should set previous offset of MinOffsetOfLayoutChanged() when it hacks the queried range for avoiding bug of active TIP since setting offsets to the result of MinOffsetOfLayoutChanged() means the offset's layout is always not computed yet. MozReview-Commit-ID: 182BMuubtFc
791641aca0f80086370d707dcc897cd6449eccf9: Bug 1274167 - Add Linter(flake8) support for Firefox-ui and Puppeteer.r=whimboo
Piyush Sinha <sinha.piyush0609@gmail.com> - Mon, 15 Aug 2016 02:16:18 +0530 - rev 401398
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1274167 - Add Linter(flake8) support for Firefox-ui and Puppeteer.r=whimboo MozReview-Commit-ID: Ga3iaEH54yH
055efa24a88382d02c2f7f8a4eb6551efcb1bf77: Bug 1293106 - Ignore 'spacing' if dom.animations-api.core.enabled is false. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Wed, 10 Aug 2016 17:58:49 +0800 - rev 401397
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1293106 - Ignore 'spacing' if dom.animations-api.core.enabled is false. r=birtles MozReview-Commit-ID: K7hbCjLP6vB
8430fc70c1086da468cc1169adac6f2d7b423dd1: Backed out 2 changesets (bug 1275913) for static analysis bustage
Phil Ringnalda <philringnalda@gmail.com> - Mon, 15 Aug 2016 22:27:16 -0700 - rev 401396
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Backed out 2 changesets (bug 1275913) for static analysis bustage CLOSED TREE Backed out changeset 4420244e8fba (bug 1275913) Backed out changeset 324554b04f19 (bug 1275913)
4420244e8fbabab35b1fce03af44d65c5883cd35: Bug 1275913 - Add Borrowed types for sharing arcs with Rust; r=bholley
Manish Goregaokar <manishsmail@gmail.com> - Tue, 16 Aug 2016 10:40:05 +0530 - rev 401395
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1275913 - Add Borrowed types for sharing arcs with Rust; r=bholley MozReview-Commit-ID: 8FyVPXRogDV
324554b04f191fb5efdce2c30db384ddd69df347: Bug 1275913 - Use already_addrefed properly when dealing with arcs sent from servo to gecko; r=bholley
Manish Goregaokar <manishsmail@gmail.com> - Tue, 16 Aug 2016 10:38:46 +0530 - rev 401394
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1275913 - Use already_addrefed properly when dealing with arcs sent from servo to gecko; r=bholley MozReview-Commit-ID: 5FDS8J2Fo1G
f52f2fc046e28b71772f85ce2fd15913bac89239: Bug 1295177 - Convert STYLE_FILL_RULE_* to an enum class; r=xidorn
Manish Goregaokar <manishsmail@gmail.com> - Mon, 15 Aug 2016 21:47:04 +0530 - rev 401393
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1295177 - Convert STYLE_FILL_RULE_* to an enum class; r=xidorn MozReview-Commit-ID: HnNFNyD4oVJ
4f39f2e1324b8c631dc700f86500f49b9680458d: Bug 1258870 - Don't push late video frames to the compositor, drop them. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Mon, 15 Aug 2016 13:35:52 +1200 - rev 401392
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1258870 - Don't push late video frames to the compositor, drop them. r=jwwang We can get out of A/V sync if the decode is struggling to keep up. This is because of the loop in VideoSink::UpdateRenderedVideoFrames(). If this function runs while there's only one frame in the video queue, we won't drop that one frame if it's late. If we're struggling to keep up, it's increasingly likely that we'll end up running this function with only one frame in the video queue. That results in us entering VideoSink::RenderVideoFrames() with only 1 late frame, which the compositor dutifully draws. Resulting in a late frame being drawn, and thus broken A/V sync. This change makes VideoSink::UpdateRenderedVideoFrames() drop all late frames, even the last one in the video queue. We now keep A/V sync when the decode is struggling to keep up. However, if I do this, we end up dropping (and reporting that we drop) a lot more frames, and thus rendering a lot fewer. But since we when we drop the frames we report them as dropped, a well written MSE player can detect that we've failing miserably to keep up, and and lower their bitrate. MozReview-Commit-ID: ybkq48mKk2
8146a675a477c67534886dcf10937e62d0c1da68: Bug 1294628 - Replace block reflow input flags with a bit fields struct. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 12 Aug 2016 15:28:45 +0800 - rev 401391
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1294628 - Replace block reflow input flags with a bit fields struct. r=dholbert MozReview-Commit-ID: 2ZSm9hTrsuh
09c45bad0ba5394b4326289d4b283d9ab3e5e387: Back out 26a015091dbc (bug 1293212) for OS X failures in /html/webappapis/system-state-and-capabilities/the-navigator-object/protocol.html
Phil Ringnalda <philringnalda@gmail.com> - Mon, 15 Aug 2016 19:42:54 -0700 - rev 401390
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Back out 26a015091dbc (bug 1293212) for OS X failures in /html/webappapis/system-state-and-capabilities/the-navigator-object/protocol.html
b63dfece689a7be20b71dcfde43bb9fb5a4e95ca: Bug 1295146 - add assertions to debug null-deref. r=jya
JW Wang <jwwang@mozilla.com> - Tue, 16 Aug 2016 09:38:29 +0800 - rev 401389
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1295146 - add assertions to debug null-deref. r=jya MozReview-Commit-ID: 966DpcaT1p8
c89c51c5414d2688e8a5c236f082febcdd82939a: Bug 1291944 - Verify makensis binary is 32-bits; r=glandium
Gregory Szorc <gps@mozilla.com> - Mon, 15 Aug 2016 18:11:48 -0700 - rev 401388
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1291944 - Verify makensis binary is 32-bits; r=glandium This required implementing a utility function to resolve the binary type. I used GetBinaryTypeW via ctypes because this seems the fastest. I arbitrarily limited the function to testing 32-bit and 64-bit Windows executables because hopefully those are the only executables we'll ever encounter. We can expand the binary detection later, if needed. This includes support for running on non-Windows platforms. MozReview-Commit-ID: CYwyDWQrePc
0253b9b9684a7a716003db28baff826f568a3984: Bug 1291944 - Search for nsis in msys environment; r=glandium
Gregory Szorc <gps@mozilla.com> - Mon, 15 Aug 2016 17:34:42 -0700 - rev 401387
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1291944 - Search for nsis in msys environment; r=glandium Previously, configure found nsis on PATH, likely from MozillaBuild. In our msys2 environment, nsis is installed under /mingw32. We supplement moz.configure to look for nsis in this location. MozReview-Commit-ID: 34mjoCrI7B6
72696d61d5fcb97440ed1cda8a4f9b5767d62f91: Bug 1183951 - use the uid instead of the email address as the key into the login manager storage for FxA account information. r=kitcambridge
Mark Hammond <mhammond@skippinet.com.au> - Tue, 16 Aug 2016 11:29:35 +1000 - rev 401386
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1183951 - use the uid instead of the email address as the key into the login manager storage for FxA account information. r=kitcambridge MozReview-Commit-ID: 9oRWMSIOIM4
7f8b1c2a08029a8844e1efec679278d9a3e0d55e: Bug 1295111 part 2 - Add static_assert to ensure that is updated properly. r=dbaron
Xidorn Quan <xidorn+moz@upsuper.org> - Mon, 15 Aug 2016 20:52:05 +1000 - rev 401385
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1295111 part 2 - Add static_assert to ensure that is updated properly. r=dbaron MozReview-Commit-ID: G2RNUcXs4yQ
df6e1c83af8dbae04892a46f2d3d81d8eb063fa4: Bug 1295111 part 1 - Add UpdateBackgroundPosition hint to ChangeHintToString. r=dbaron
Xidorn Quan <xidorn+moz@upsuper.org> - Mon, 15 Aug 2016 20:51:32 +1000 - rev 401384
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1295111 part 1 - Add UpdateBackgroundPosition hint to ChangeHintToString. r=dbaron MozReview-Commit-ID: 3AeIoad5XE4
620e1894c6d59e2d00c6d8ad0ec5501a56722251: Bug 1294920 - Fix test expectation on high-density screens in browser_ext_browserAction_pageAction_icon_permissions r=billm
Rob Wu <rob@robwu.nl> - Fri, 12 Aug 2016 19:15:28 -0700 - rev 401383
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1294920 - Fix test expectation on high-density screens in browser_ext_browserAction_pageAction_icon_permissions r=billm MozReview-Commit-ID: 8iQXNEmsMJ5
86c39a5b482dd479d7f0d63109a9117bfc90e9ee: Bug 1290157 - Always pass an array to tabs.executeScript on success r=kmag
Rob Wu <rob@robwu.nl> - Tue, 09 Aug 2016 00:28:47 -0700 - rev 401382
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1290157 - Always pass an array to tabs.executeScript on success r=kmag MozReview-Commit-ID: Ctw8RUtfEZC
a327a15f5d55fd391882a951bc936b73ef1f8504: Bug 1287626,1288279 - Make IDs unique across processes r=billm
Rob Wu <rob@robwu.nl> - Wed, 10 Aug 2016 16:23:56 -0700 - rev 401381
Push 26442 by gsquelart@mozilla.com at Tue, 16 Aug 2016 23:01:32 +0000
Bug 1287626,1288279 - Make IDs unique across processes r=billm MozReview-Commit-ID: 78xgt8wqbng
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip