bc63b56a88dd722252c8c5fe9b63afc3ef83a581: Bug 1354465 P1 - dispatch a mozvideoonlyseekbegin event while starting a video-only seek; r=jwwang
Kaku Kuo <kaku@mozilla.com> - Fri, 07 Apr 2017 16:11:34 +0800 - rev 560257
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1354465 P1 - dispatch a mozvideoonlyseekbegin event while starting a video-only seek; r=jwwang MozReview-Commit-ID: 6PjQs88vUV2
649da44e21340ad03bfef7095a0dcbc50836d617: Bug 1354977 - Update timestamp when gamepadpose is changed; r=qdot
Daosheng Mu <daoshengmu@gmail.com> - Thu, 06 Apr 2017 18:37:29 +0800 - rev 560256
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1354977 - Update timestamp when gamepadpose is changed; r=qdot MozReview-Commit-ID: 2glmvw5xUCH
5b7e7bd0878992ca8f178f1bfd9f66f473fe8c21: Bug 1355083 - Switch from using a #define to alter a sandbox policy to a normal param r=haik
Alex Gaynor <agaynor@mozilla.com> - Mon, 10 Apr 2017 09:53:47 -0400 - rev 560255
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1355083 - Switch from using a #define to alter a sandbox policy to a normal param r=haik r=haik MozReview-Commit-ID: KqmRra6NqPa
23546115feb2e2e997da17aa1f78cacc5b93c6f0: Bug 1345491 - Fix intermittent caused by closing window before extension is unloaded r=gbrown
Matthew Wein <mwein@mozilla.com> - Mon, 10 Apr 2017 02:21:01 -0400 - rev 560254
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1345491 - Fix intermittent caused by closing window before extension is unloaded r=gbrown MozReview-Commit-ID: KGk1YGrhX9X
5813e4358a17fc8ad81d60d3d9284c1ff94e1108: bug 1323311 make tabs.move on multiple tabs more reliable r=kmag
Andy McKay <amckay@mozilla.com> - Mon, 10 Apr 2017 11:18:04 -0700 - rev 560253
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
bug 1323311 make tabs.move on multiple tabs more reliable r=kmag MozReview-Commit-ID: 9o4huF1f60g
27e624cd94796146934ca29e98f8934b61243809: Bug 1311935 - P4. GTest for safebrowsing v4 caching. r=francois
DimiL <dlee@mozilla.com> - Fri, 07 Apr 2017 14:31:04 +0800 - rev 560252
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1311935 - P4. GTest for safebrowsing v4 caching. r=francois MozReview-Commit-ID: ExR5NJUvzNg
4c0381ab099046d316200e0779616e717606da0d: Bug 1311935 - P3. Implement safebrowsing v4 caching logic. r=francois
dimi <dlee@mozilla.com> - Mon, 10 Apr 2017 14:21:08 +0800 - rev 560251
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1311935 - P3. Implement safebrowsing v4 caching logic. r=francois LookupCacheV4::Has implements safebrowsing v4 caching logic. 1. Check if fullhash match any prefix in local database: - If not, the URL is safe. 2. Check if prefix is in the cache(prefix is always the first 4-byte of the fullhash, Bug 1323953): - If not, send fullhash request 3. Check if fullhash is in the positive cache: - If fullhash is found and it is not expired, the URL is not safe. - If fullhash is found and it is expired, send fullhash request. 4. If fullhash is not found, check negative cache expired time: - If negative cache time is not expired, the URL is safe. - If negative cache time is expired, send fullhash request. MozReview-Commit-ID: GRX7CP8ig49
73587838ef1620aef0ce63abad7b8c824f5eacf6: Bug 1311935 - P2. Process fullHashes.find response. r=francois
dimi <dlee@mozilla.com> - Mon, 10 Apr 2017 16:20:09 +0800 - rev 560250
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1311935 - P2. Process fullHashes.find response. r=francois This patch includes following changes: 1. nsUrlClassifierHashCompleter.js nsUrlClassifierHashCompleter.idl - Add completionV4 interface for hashCompleter to pass response data to DB service. - Process response data includes negative cache duration, matched full hashes and cache duration for each match. Full matches are passed through nsIFullHashMatch interface. - Change _requests.responses from array contains matched fullhashes to dictionary so that it can store additional information likes negative cache duration. 2. nsUrlClassifierDBService.cpp - Implement CompletionV4 interface, store response data to CacheResultV4 object. Expired duration to expired time is handled here. - Add CacheResultToTableUpdate function to convert V2 & V4 cache result to TableUpdate object. 3. LookupCache.h - Extend CacheResult to CacheResultV2 and CacheResultV4 so we can store response data in CompletionV2 and CompletionV4. 4. HashStore.h - Add API and member variable in TableUpdateV4 to store response data. TableUpdate object is used by DB service to pass update data or gethash response to Classifier, so we need to extend TableUpdateV4 to be able to store fullHashes.find response. 6. Entry.h - Define the structure about how we cache fullHashes.find response. MozReview-Commit-ID: KgR1NASl7GC
a5a6c0f79733688fc11c3a03a0d2ea9b2ae1d8aa: Bug 1311935 - P1. Make ActiveTables() work for safebrowsing v4. r=francois
DimiL <dlee@mozilla.com> - Fri, 07 Apr 2017 14:30:11 +0800 - rev 560249
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1311935 - P1. Make ActiveTables() work for safebrowsing v4. r=francois This patch fixes that Classifier::ActiveTables doesn't return v4 tables. Classifier::mActiveTablesCache is generated by scanning safebrowsing directory. We use Classifier::ScanStoreDir to do the work, but it will ignore subdirectory. Since v4 tables are stored in subdirectory 'google4', mActiveTablesCache doesn't include v4 tables. Fix this issue by checking subdirectory recursively in ScanStoreDir. MozReview-Commit-ID: I6pa6e4bFND
4e4bd12cc11cab7e9227bd240424311d4acf596a: Merge m-c to autoland a=merge
Wes Kocher <wkocher@mozilla.com> - Mon, 10 Apr 2017 16:55:21 -0700 - rev 560248
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Merge m-c to autoland a=merge
88e9938ce64ca0281c4f6ed2dd8ca93a0bfe5100: servo: Merge #16338 - Disable bytecode generation in mach (from Wafflespeanut:byte); r=jdm
Ravi Shankar <wafflespeanut@gmail.com> - Mon, 10 Apr 2017 17:53:37 -0500 - rev 560247
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
servo: Merge #16338 - Disable bytecode generation in mach (from Wafflespeanut:byte); r=jdm Recently, [@]froydnj had some trouble with `mach`, and after half an hour of struggle, a simple `git clean` and `git reset --hard` seemed to fix the issue. Apparently, sometimes (though I'm not sure when, and I don't even have a convincing argument), the changes to `mach` scripts don't really seem to reflect on the related bytecode files (when it absolutely should've!). Having bytecode files is just a matter of optimization (i.e., we don't have to compile the scripts again), but when it comes to our simple build system, "not having them" doesn't add a great overhead. So, we could just disable their creation to avoid such issues in the future. Existing users can do `find ./python -name '*.pyc' -delete` for a cleanup (and maybe remove the `python/_virtualenv` directory too, though not necessary) Source-Repo: https://github.com/servo/servo Source-Revision: ca3cd64d6b1999292d634bfa237c2705e6d575c1
92fb427b464c49134341747d146ddef6f43c87b4: servo: Merge #16285 - layout: Use the margin box of an inline block when computing the inline size (from stshine:inline-block-margin); r=emilio
Pu Xingyu <pu.stshine@gmail.com> - Mon, 10 Apr 2017 15:07:06 -0500 - rev 560246
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
servo: Merge #16285 - layout: Use the margin box of an inline block when computing the inline size (from stshine:inline-block-margin); r=emilio <!-- Please describe your changes on the following line: --> When computing the inline size of an inline block in inline formating context, use the margin box of the underling block. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12413 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 4013e9d7a0be666343ef9d806408af5c0a852d91
d508a91f09e9de268da1b7831c823c6a42f16526: Bug 1345529 - fix inspector DocumentWaler children() method;r=pbro
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Apr 2017 23:17:03 +0200 - rev 560245
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1345529 - fix inspector DocumentWaler children() method;r=pbro The inspector's DocumentWalker had several issues when trying to retrieve children for a given node, especially if the starting node was filtered out by the filter function of the walker. If the starting node was provided by options.center or options.start and if this starting node was filtered out by the walker's filter then the walker would fallback to the first valid parent of this node. eg with parent1 > parent2 > [valid-node, invalid-node, valid-node] When asking for the children of parent2, if the walker started on "invalid-node", then the walker would instead use parent2 and in turn we would retrieve the children of parent 1 To fix that we can either tell the walker wether it should fallback to a sibling of the starting node or to a parent, or make sure that the nodes provided to the walker are valid. A second issue was with the utility methods _readForward and _readBackward. They both use the next/previousSibling() methods of a walker in order to collect all the valid siblings of the walker's current node. But they were always including the current node of the walker in their return array. And there is no guarantee that the walker's currentNode is actually valid for it's filter. eg with a walker containing [invalid-node-1, invalid-node-2, valid-node]. Let's say the walker is currently on valid-node and we call previousSibling The walker will do 3 steps: - this.walker.previousSibling() > returns invalid-node-2, fails filtering - this.walker.previousSibling() > returns invalid-node-1, fails filtering - this.walker.previousSibling() > returns null, stop looping and return null But at this stage the internal walker still points to the last visited node (invalid-node-1). So if _readForward/Backward blindly add the current node of the walker, we might be returning invalid nodes. MozReview-Commit-ID: 72Be7DP5ky6
e2bcdd1501405f8bc8e5841a06088fd3fc179878: bug 1354216 - fix cctools-port build scripts. r=mshal
Ted Mielczarek <ted@mielczarek.org> - Mon, 10 Apr 2017 15:38:24 -0400 - rev 560244
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
bug 1354216 - fix cctools-port build scripts. r=mshal The cctools-port build scripts were pulling and building the master branch of the cctools-port repo, which means they'd build whatever was there when they get triggered. I think this was copied from my build-cctools script which did the same thing, so it's my fault in the end! This patch pins a revision in the script so we'll build the same thing until we explicitly update. I also fixed the scripts to use git instead of tc-vcs, since tc-vcs prints misleading error messages, and nothing else uses that anymore. Finally, I removed the build-cctools script, since all the builds are using cctools-port now so it doesn't serve any useful purpose. MozReview-Commit-ID: 5myqHS4duor
6aec2cb43d81e7829d3524de31afefee2247131a: Bug 1355179 part 2: Add comment about porting B2G checks to be Android checks in test_event_target_radius.html. r=kats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 10 Apr 2017 12:53:29 -0700 - rev 560243
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1355179 part 2: Add comment about porting B2G checks to be Android checks in test_event_target_radius.html. r=kats MozReview-Commit-ID: G0zCLxHzfYs
67ed44b3f67e2855bc4998adf70c3054975d70d5: Bug 1355179 part 1: Remove always-true-now checks for !=B2G in test_reftests_with_caret.html. r=kats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 10 Apr 2017 12:47:39 -0700 - rev 560242
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1355179 part 1: Remove always-true-now checks for !=B2G in test_reftests_with_caret.html. r=kats MozReview-Commit-ID: CVizePCiI7W
74d44ad1533ecb0c924da862171e8b9dcee56e83: Bug 1350053 - Part 2 - Update tests to check the arrow panel to appear, instead of the notification bar. r=mossop
Mike de Boer <mdeboer@mozilla.com> - Mon, 10 Apr 2017 16:17:36 +0200 - rev 560241
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1350053 - Part 2 - Update tests to check the arrow panel to appear, instead of the notification bar. r=mossop MozReview-Commit-ID: G4Hkb7KQ79X
5c0565ed332fd9fb97ba28b0196a608f30ecf426: Bug 1350053 - Part 1 - Change install flow of Light-weight Themes (LWT) to use PopupNotifications, instead of notification boxes. r=mossop
Mike de Boer <mdeboer@mozilla.com> - Mon, 10 Apr 2017 16:16:50 +0200 - rev 560240
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1350053 - Part 1 - Change install flow of Light-weight Themes (LWT) to use PopupNotifications, instead of notification boxes. r=mossop The newer Theming API follows the WebExtension install flow, which uses PopupNotifications to request permission before installation, show progress and notify upon install completion. This patch makes sure that older LWTs follow that same flow. MozReview-Commit-ID: C7X2si0a47J
1ec9038f1b164f455d67e37d64f0897f0e2fc511: Bug 1348415 - Use present tense for method names and remove redundant public modifiers for GeckoView interface method names r=jchen
Nitish <nitishplus98@gmail.com> - Sat, 18 Mar 2017 12:56:00 +0530 - rev 560239
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1348415 - Use present tense for method names and remove redundant public modifiers for GeckoView interface method names r=jchen MozReview-Commit-ID: 3B82Gn7yBzZ
0e7cd0312ecfff88068f1be445f7b3e86e0af830: Bug 1341761 - stylo: Update test expectations for -moz-element. r=bzbarsky
Nazım Can Altınova <canaltinova@gmail.com> - Sat, 08 Apr 2017 17:40:18 +0300 - rev 560238
Push 53365 by jichen@mozilla.com at Tue, 11 Apr 2017 08:35:12 +0000
Bug 1341761 - stylo: Update test expectations for -moz-element. r=bzbarsky MozReview-Commit-ID: 3bKWDW2bJ9V
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip