bc53cf75bba5477aaf019777fa7c61f75cfb30d8: No bug - Remove extra words to make the sentence coherent. r=me
Benjamin Peterson <benjamin@python.org> - Sun, 09 Nov 2014 13:45:27 -0500 - rev 226137
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
No bug - Remove extra words to make the sentence coherent. r=me
401cf10930293fd2305bfbae2294ffe0e7e55baf: No bug - fix typo r=me
Benjamin Peterson <benjamin@python.org> - Sat, 08 Nov 2014 14:35:00 -0500 - rev 226136
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
No bug - fix typo r=me
c2369f6c3a3557b59bfa90e013bc67c25537fb80: Bug 270292 - "Unable to drag multiple attachments to OS file folder" [r=jmathies]
Jonathan Meier <mr_sandman> - Tue, 26 Aug 2014 15:24:00 +0300 - rev 226135
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 270292 - "Unable to drag multiple attachments to OS file folder" [r=jmathies]
a84fe0cefd77c06af4801613195ac00b4373880a: Bug 1060529, send the enabled state of child process commands to the parent on update, r=smaug,ehsan
Neil Deakin <neil@mozilla.com> - Fri, 07 Nov 2014 15:47:39 -0500 - rev 226134
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1060529, send the enabled state of child process commands to the parent on update, r=smaug,ehsan
41536afea9b39595727186826e89032292dec5b7: Bug 1060529, don't treat a raise of the child process window specially, r=smaug
Neil Deakin <neil@mozilla.com> - Fri, 07 Nov 2014 15:47:36 -0500 - rev 226133
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1060529, don't treat a raise of the child process window specially, r=smaug
e021487d1297f81b1fa8dfd49e5af483ba12e7fa: Bug 575094 - Modify how prefservice is accessed so that it's from the parent process and not from the child process. Also re-enable test_bug528292_wrap.js. r=jdm
Connor <cojojennings@gmail.com> - Wed, 29 Oct 2014 23:58:03 -0400 - rev 226132
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 575094 - Modify how prefservice is accessed so that it's from the parent process and not from the child process. Also re-enable test_bug528292_wrap.js. r=jdm
dac60d6bef5642cff46a24d339bfe4237175b1fb: Bug 1090293 - Fix failure to get audio on first getUserMedia after start r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 07 Nov 2014 23:25:22 -0500 - rev 226131
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090293 - Fix failure to get audio on first getUserMedia after start r=jesup fix GetTrackTypesAvailable to not report placeholder tracks
aca93ae7eeede8e712b0cf39fc0a47c4e79bcaa0: Bug 1090537, part 12 - Change SetNonexistentProperty to use only receiver, not obj. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Sat, 25 Oct 2014 11:24:55 -0500 - rev 226130
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 12 - Change SetNonexistentProperty to use only receiver, not obj. No change in behavior. r=efaust. (The behavior doesn't change because Unqualified is only passed from two call sites, and in both places, the same object is passed for both receiver and obj.)
1d518eed470edbac5d5a1b79ad350e0849084df0: Bug 1090537, part 11 - Delete a special case for arrays in SetNonexistentProperty that is (a) unreachable; (b) redundant with a check in DefinePropertyOrElement. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 28 Oct 2014 12:49:17 -0500 - rev 226129
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 11 - Delete a special case for arrays in SetNonexistentProperty that is (a) unreachable; (b) redundant with a check in DefinePropertyOrElement. r=efaust. The code being deleted would be ineffective even if we did have Reflect.set, but Reflect.set does enable a very near miss (where receiver, not obj, is an array), so we leave a sleeper test for that case.
542bb68249cef4537f7401c970ab0caf6da855aa: Bug 1090537, part 10 - Factor out SetNonexistentProperty. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Fri, 07 Nov 2014 13:02:49 -0600 - rev 226128
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 10 - Factor out SetNonexistentProperty. No change in behavior. r=efaust.
4678a751e9c880e91d5927855a5d4435defffb24: Bug 1090537, part 9 - Just move SetPropertyByDefining. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Fri, 07 Nov 2014 13:00:50 -0600 - rev 226127
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 9 - Just move SetPropertyByDefining. No change in behavior. r=efaust.
fd58d09bcf1cbc142a8d816ed394c2c806da12c9: Bug 1090537, part 8 - In SetPropertyHelper, if defining a new data property, define it on receiver, not obj. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Sat, 18 Oct 2014 16:49:50 -0500 - rev 226126
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 8 - In SetPropertyHelper, if defining a new data property, define it on receiver, not obj. r=efaust. Most of the diff is just renaming an argument. The only new code is necessary because unlike obj, receiver can be non-native.
724e3e6efb7bbda09b1b3d3a646549f8a88d8882: Bug 1090537, part 7 - Eliminate useless attrs argument to SetPropertyByDefining. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Sat, 18 Oct 2014 16:43:25 -0500 - rev 226125
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 7 - Eliminate useless attrs argument to SetPropertyByDefining. No change in behavior. r=efaust.
1791020afc6f362725b8008869c85cb9a97ce01a: Bug 1090537, part 6 - Factor out a big chunk of SetPropertyHelper into a separate function template, SetPropertyByDefining. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Sat, 18 Oct 2014 16:30:32 -0500 - rev 226124
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 6 - Factor out a big chunk of SetPropertyHelper into a separate function template, SetPropertyByDefining. No change in behavior. r=efaust.
9317cf955dc77e6dbd914b0afd47303087d31dc5: Bug 1090537, part 5 - Remove legacy special case in baseops::SetPropertyHelper that cloned the getter and setter of JSPROP_SHADOWABLE properties when shadowed on another native object. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 15 Oct 2014 14:05:29 -0500 - rev 226123
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 5 - Remove legacy special case in baseops::SetPropertyHelper that cloned the getter and setter of JSPROP_SHADOWABLE properties when shadowed on another native object. r=Waldo.
be9e874aea12cbb0d4b3cc67e7870530d245439b: Bug 1090537, part 4 - Take NativeSet private. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 15 Oct 2014 12:08:37 -0500 - rev 226122
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 4 - Take NativeSet private. No change in behavior. r=efaust.
eeb6ee106d15f08ac943068d7ca9a55ebbc7feac: Bug 1090537, part 3 - Pass receiver argument through from JSObject::setGeneric and setElement to Proxy::set. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 15 Oct 2014 22:54:57 -0500 - rev 226121
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 3 - Pass receiver argument through from JSObject::setGeneric and setElement to Proxy::set. r=efaust. ES6 specifies [[Set]] as an operation taking both a "this" object and a "receiver" parameter. Both JSObject::setGeneric and Proxy::set support the receiver parameter, but ObjectOps::setGeneric does not; in this patch, we add a little workaround for that. The test shows how this is observable using only standard builtins. The changes in JSObject::setElement are untestable since currently all call sites pass the same value for obj as for receiver. (This was reviewed as "part 2" but it was necessary to switch parts 2 and 3 and add part 2b.)
c8da5fb6460db9ff47a4d1170e67065fe4cb1831: Bug 1090537, part 2b - In Proxy::set, do not assume that proxy == receiver or that both have the same handler. r=efaust, r=bholley.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 28 Oct 2014 20:58:36 -0500 - rev 226120
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 2b - In Proxy::set, do not assume that proxy == receiver or that both have the same handler. r=efaust, r=bholley.
d5d1001d440329a15ec8f402309fb37dcb6a165b: Bug 1090537, part 2a - In BaseProxyHandler::set(), do not assume that proxy == receiver or that both have the same handler. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Thu, 16 Oct 2014 08:06:13 -0500 - rev 226119
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 2a - In BaseProxyHandler::set(), do not assume that proxy == receiver or that both have the same handler. r=efaust. (This was reviewed as "part 3" but it was necessary to switch parts 2 and 3 and add part 2b.)
c5b66928f1aa6a7ee5ae5774803a8a80547a35e9: Bug 1090537, part 1 - Remove an old hack where Proxy::hasOwn permitted SET access. r=bholley.
Jason Orendorff <jorendorff@mozilla.com> - Fri, 17 Oct 2014 07:33:57 -0500 - rev 226118
Push 36 by dburns@mozilla.com at Mon, 10 Nov 2014 15:14:02 +0000
Bug 1090537, part 1 - Remove an old hack where Proxy::hasOwn permitted SET access. r=bholley. The comments being deleted here are incorrect; Proxy::set no longer calls handler->hasOwn().
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip