bbe9d528bcf59644fc99b076c8a1ad1597dc9c41: Bug 775624 Part 9 - Convert NS_FRAME_REFLOW_NEXTINFLOW to use bit-field and methods. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 13 Feb 2017 14:56:45 +0800 - rev 488661
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 775624 Part 9 - Convert NS_FRAME_REFLOW_NEXTINFLOW to use bit-field and methods. r=dholbert MozReview-Commit-ID: 1TXOShK62X8
74d9f315b9000eb8be2f9ce50a769659bd66a38c: Bug 775624 Part 8 - Remove NS_FRAME_SET_OVERFLOW_INCOMPLETE. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 11 Feb 2017 23:18:04 +0800 - rev 488660
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 775624 Part 8 - Remove NS_FRAME_SET_OVERFLOW_INCOMPLETE. r=dholbert This patch is written by the help of the following script. function rename() { find layout\ -type f\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -r "s/$1/$2/g" "{}" \; } rename "NS_FRAME_SET_OVERFLOW_INCOMPLETE\(\*([a-zA-Z0-9.*]*)\)" "\1->SetOverflowIncomplete()" rename "NS_FRAME_SET_OVERFLOW_INCOMPLETE\(([a-zA-Z0-9.*]*)\)" "\1.SetOverflowIncomplete()" MozReview-Commit-ID: EJOIs84vwev
167b50e9d5845d65c599801614ce8a60bd2b5a37: Bug 775624 Part 7 - Remove NS_FRAME_SET_INCOMPLETE. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 11 Feb 2017 23:06:17 +0800 - rev 488659
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 775624 Part 7 - Remove NS_FRAME_SET_INCOMPLETE. r=dholbert This patch is written by the help of the following script. function rename() { find layout\ -type f\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -r "s/$1/$2/g" "{}" \; } rename "NS_FRAME_SET_INCOMPLETE\(\*([a-zA-Z0-9.*]*)\)" "\1->SetIncomplete()" rename "NS_FRAME_SET_INCOMPLETE\(([a-zA-Z0-9.*]*)\)" "\1.SetIncomplete()" MozReview-Commit-ID: GOd4y2N6dcz
86aa651c4736670f40671b9816a5c898d3c13bc3: Bug 775624 Part 6 - Remove NS_FRAME_OVERFLOW_IS_INCOMPLETE. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 11 Feb 2017 22:54:26 +0800 - rev 488658
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 775624 Part 6 - Remove NS_FRAME_OVERFLOW_IS_INCOMPLETE. r=dholbert This patch is written by the help of the following script. function rename() { find layout\ -type f\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -r "s/$1/$2/g" "{}" \; } rename "NS_FRAME_OVERFLOW_IS_INCOMPLETE\(([a-zA-Z0-9.*]*)\)" "\1.IsOverflowIncomplete()" MozReview-Commit-ID: GOd4y2N6dcz
2cb25268cfbb3d268b06e316f37d0b2af505c530: Bug 775624 Part 5 - Remove NS_FRAME_IS_COMPLETE. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 11 Feb 2017 22:45:07 +0800 - rev 488657
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 775624 Part 5 - Remove NS_FRAME_IS_COMPLETE. r=dholbert This patch is written by the help of the following script. function rename() { find layout\ -type f\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -r "s/$1/$2/g" "{}" \; } rename "NS_FRAME_IS_COMPLETE\(([a-zA-Z0-9.*]*)\)" "\1.IsComplete()" MozReview-Commit-ID: GOd4y2N6dcz
385c006f46b2273ffbcba6fd6e1b5b933bc441cb: Bug 775624 Part 4 - Remove NS_FRAME_IS_FULLY_COMPLETE. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 11 Feb 2017 22:38:48 +0800 - rev 488656
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 775624 Part 4 - Remove NS_FRAME_IS_FULLY_COMPLETE. r=dholbert This patch is written by the help of the following script. function rename() { find layout\ -type f\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -r "s/$1/$2/g" "{}" \; } rename "NS_FRAME_IS_FULLY_COMPLETE\(([a-zA-Z0-9.*]*)\)" "\1.IsFullyComplete()" MozReview-Commit-ID: GOd4y2N6dcz
9f1508490ddf657da9cc3b29c423ad39aba52891: Bug 775624 Part 3 - Remove NS_FRAME_IS_NOT_COMPLETE. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 11 Feb 2017 22:17:26 +0800 - rev 488655
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 775624 Part 3 - Remove NS_FRAME_IS_NOT_COMPLETE. r=dholbert This patch is written by the help of the following script. function rename() { find layout\ -type f\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -r "s/$1/$2/g" "{}" \; } rename "NS_FRAME_IS_NOT_COMPLETE\(([a-zA-Z0-9.*]*)\)" "\1.IsIncomplete()" MozReview-Commit-ID: GOd4y2N6dcz
0d9fd874b0507b79c4ed5e8abc6be4f7a58c14e2: Bug 775624 Part 2 - Add bit-fields and methods for frame completion status. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 13 Feb 2017 15:25:50 +0800 - rev 488654
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 775624 Part 2 - Add bit-fields and methods for frame completion status. r=dholbert MozReview-Commit-ID: B2DEaWYTtAE
907e7b586ed2dc54ce61669d7cdd09404269d8fe: Bug 775624 Part 1 - Convert nsReflowStatus to a class mimicking uint32_t. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 10 Feb 2017 17:29:10 +0800 - rev 488653
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 775624 Part 1 - Convert nsReflowStatus to a class mimicking uint32_t. r=dholbert Lay down the foundation for this refactor work so that nsReflowStatus could be converted to bit-fields piece by piece, and each patch can be built (but may not pass tests). This change causes some build warnings, due to some debug logs printing nsReflowStatus as an integer, but that will be fixed by Part 24 later. All the operators related to uint32_t will be removed at the end of this patch series by Part 23. The yoda conditions are swapped in order to build successfully. DisplayReflowExit() incorrectly declares aStatus as uint32_t. Change it to const reference because nsReflowStatus is now a class. MozReview-Commit-ID: 5DOpaP85ywJ
8ceb1224123129e5cd6cd8e14dcfdf2f7e549cb8: Bug 1192818 - part4 : only mute media element if there is alive track. r=jwwang
Alastor Wu <alwu@mozilla.com> - Thu, 23 Feb 2017 14:16:44 +0800 - rev 488652
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 1192818 - part4 : only mute media element if there is alive track. r=jwwang If we don't have any alive track in MediaTrackList, we don't need to mute MediaElement. MozReview-Commit-ID: 9vY692O7N0e
be2f9c0ee32e695167a19dfaa6b47e29453f2916: Bug 1192818 - part3 : modify test. r=baku
Alastor Wu <alwu@mozilla.com> - Thu, 23 Feb 2017 14:15:49 +0800 - rev 488651
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 1192818 - part3 : modify test. r=baku MozReview-Commit-ID: HNXcbFbYfor
ede7e1b580958b49de8c12e7f0974d00a30a154c: Bug 1192818 - part2 : only dispatch DOMAudioPlaybackStarted when there is audible sound. r=baku
Alastor Wu <alwu@mozilla.com> - Thu, 23 Feb 2017 14:15:47 +0800 - rev 488650
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 1192818 - part2 : only dispatch DOMAudioPlaybackStarted when there is audible sound. r=baku The DOMAudioPlaybackStarted event would affect the tabbrowser's attribute, "soundPlaying", and this attribute should indicate whether the tab is audible or not. However, in present codebase, even the tab has "soundplaying", it doens't mean the tab has audible sound, you need to check extra attribute, "muted". After applying this patch, tabbrowser can only own one of the attributes ("soundplaying" or "mute"). These attributes won't exist at the same time, so we can easily know whether the tab is audible by checking "soundPlaying". Let's see an example, step1. playing a playing audio - tab owns "soundPlaying" step2. mute the tab - tab owns "muted" step3. stop audio - tab owns "muted" step4. replay the audio - tab owns "muted" step5. unmute the tab - tab owns "soundPlaying" step6. stop audio - tab owns "" MozReview-Commit-ID: EEKEbAVzsVm
53900c65dbe1c3fdfffa3fe7ff81232c0460b9cb: Bug 1192818 - part1 : dispatch DOMAudioPlaybackStopped when mute the tab. r=baku
Alastor Wu <alwu@mozilla.com> - Thu, 23 Feb 2017 14:15:45 +0800 - rev 488649
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 1192818 - part1 : dispatch DOMAudioPlaybackStopped when mute the tab. r=baku The root cause of the intermittent fail is because "DOMAudioPlaybackStopped" has no directly relationship with browser.mute()/unmute(). In [1], the "DOMAudioPlaybackStopped" is caused by audio stop playing, not by calling the browser.mute(). If the audio stops playing before calling the wait_for_event(), the test would be time-out. I guess the bug 1302280 is also caused by same reason. So this patch would do two thinngs, 1. dispatch "DOMAudioPlaybackStopped" when we mute tab 2. loop the audio in test file, to make sure the "DOMAudioPlaybackStopped" is dispatched when muting the audio, not the file ended. [1] https://goo.gl/ymUv8P MozReview-Commit-ID: 5RnyBRE73lQ
925704aab093cb0704b88a6a208ad6a11c4a90f1: Bug 1326114 - only do duration checking for active-media. r=sebastian
Alastor Wu <alwu@mozilla.com> - Thu, 23 Feb 2017 12:13:49 +0800 - rev 488648
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 1326114 - only do duration checking for active-media. r=sebastian Since we don't want to show the media control for the short sound, so we added the duration checking. And this checking only needs to be run when the media is active, we don't need to check the inactive media. MozReview-Commit-ID: AaVGi77nXJ1
1ac7781188d2977c0b0ab00746d67e24ca04e608: Backed out 2 changesets (bug 1303060) for Windows static-analysis bustage
Phil Ringnalda <philringnalda@gmail.com> - Wed, 22 Feb 2017 21:55:15 -0800 - rev 488647
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Backed out 2 changesets (bug 1303060) for Windows static-analysis bustage CLOSED TREE Backed out changeset 729a1b8c7e47 (bug 1303060) Backed out changeset 604605ca738c (bug 1303060)
729a1b8c7e476cada52be64b5063c5f49444438c: Bug 1303060: Additions to ipc/mscom for out-of-process components; r=jimm
Aaron Klotz <aklotz@mozilla.com> - Fri, 17 Feb 2017 16:20:51 -0700 - rev 488646
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 1303060: Additions to ipc/mscom for out-of-process components; r=jimm MozReview-Commit-ID: IYjONGbBraG
604605ca738cab9e3b20cd2716e10c72ecd5b859: Bug 1303060: ipc/mscom changes for handler and payload support; r=jimm
Aaron Klotz <aklotz@mozilla.com> - Fri, 17 Feb 2017 17:30:03 -0700 - rev 488645
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 1303060: ipc/mscom changes for handler and payload support; r=jimm MozReview-Commit-ID: 13NFW1pgxix
212bad17569eb87422dbbde1c8290650c7f64bbe: Bug 1339066 - Don't add a private tab opened while viewing the normal-mode tab strip. r=sebastian
Tom Klein <twointofive@gmail.com> - Thu, 16 Feb 2017 07:25:54 -0600 - rev 488644
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 1339066 - Don't add a private tab opened while viewing the normal-mode tab strip. r=sebastian MozReview-Commit-ID: AZEZq4boaJW
cbf216f00dba92561fdd37df679e92e4b146aa60: Backed out changeset 437ff32b12ea (bug 1340446) for Mac and Windows build bustage
Phil Ringnalda <philringnalda@gmail.com> - Wed, 22 Feb 2017 20:27:17 -0800 - rev 488643
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Backed out changeset 437ff32b12ea (bug 1340446) for Mac and Windows build bustage CLOSED TREE
9294b1e9b7e2c0b0b6a74e4d22634874433f11e4: Bug 1340191 - reverse the checking condition. r=sebastian
Alastor Wu <alwu@mozilla.com> - Wed, 22 Feb 2017 15:51:08 +0800 - rev 488642
Push 46599 by dlee@mozilla.com at Thu, 23 Feb 2017 15:07:52 +0000
Bug 1340191 - reverse the checking condition. r=sebastian Since BBC website puts their audio in another iframe, we can't get the media element to check its duration, so we always return false. The ideal way to fix it is to get every iframe and check its element, but I think it's not very easy to do considering the flexibility of using iframe and the cost time. First, if we want to get the information inside iframe, we need to listen the onload event, but it's async operation. If there are lots iframe, we need to spend lots time to wait every iframe. The worst situation is we got the nested iframe, it would need lots time and effect to wait every iframe loaded and get the element we want. Therefore, I would prefer the workaround which is to reverse the checking condition, that is we only check duration for the main window. MozReview-Commit-ID: F93BjbzRMXO
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip