bb346dab5291a34049fec602043064c9b7ddccb7: Bug 1467611 [wpt PR 11389] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Thu, 14 Jun 2018 19:50:03 +0000 - rev 814254
Push 115144 by bmo:gl@mozilla.com at Wed, 04 Jul 2018 20:51:10 +0000
Bug 1467611 [wpt PR 11389] - Update wpt metadata, a=testonly wpt-pr: 11389 wpt-type: metadata
38085bdf4fd448fb9e2d94e6d798ae3045b109cb: Bug 1467611 [wpt PR 11389] - Add test for URL issue 348, a=testonly
achristensen07 <achristensen07@gmail.com> - Mon, 02 Jul 2018 17:23:51 +0000 - rev 814253
Push 115144 by bmo:gl@mozilla.com at Wed, 04 Jul 2018 20:51:10 +0000
Bug 1467611 [wpt PR 11389] - Add test for URL issue 348, a=testonly Automatic update from web-platform-testsURL: test ' in queries For https://github.com/whatwg/url/pull/395. -- wpt-commits: 0e084a927078d434bcc1952a2ab99fb541f2c25d wpt-pr: 11389
457f6c74f828fcef7323a070e36bdb32db9892b4: Bug 1468829 [wpt PR 11424] - Revert "WebKit export of https://bugs.webkit.org/show_bug.cgi?id=1861…, a=testonly
Frédéric Wang <fred.wang@free.fr> - Mon, 02 Jul 2018 17:22:31 +0000 - rev 814252
Push 115144 by bmo:gl@mozilla.com at Wed, 04 Jul 2018 20:51:10 +0000
Bug 1468829 [wpt PR 11424] - Revert "WebKit export of https://bugs.webkit.org/show_bug.cgi?id=1861…, a=testonly Automatic update from web-platform-testsRevert "WebKit export of https://bugs.webkit.org/show_bug.cgi?id=186127 (#11279)" (#11424) This reverts commit 57fea798e1e933e1d5291608d9d12da661185bcb. According to @birtles, Mozilla CI can have several tens of seconds between two frames while the test assumes only hundreds of milliseconds. So this is likely to be flacky. -- wpt-commits: fb6713ed45c4f285fff02db91bf631dd89b84250 wpt-pr: 11424
6130d9fa58be942c695ac0c17fa7ab54473b1322: Bug 1468826 [wpt PR 11421] - [PageLifecycle] Add sendBeacon to the freeze WPT test, a=testonly
Fadi Meawad <fmeawad@chromium.org> - Mon, 02 Jul 2018 17:21:13 +0000 - rev 814251
Push 115144 by bmo:gl@mozilla.com at Wed, 04 Jul 2018 20:51:10 +0000
Bug 1468826 [wpt PR 11421] - [PageLifecycle] Add sendBeacon to the freeze WPT test, a=testonly Automatic update from web-platform-tests[PageLifecycle] Add sendBeacon to the freeze WPT test navigator.sendBeacon should be allowed during the onfreeze callback, there was no changes in the code needed to enable it since it is implemented using fetch-keepalive, that is already allowed. This CL adds a test to make sure that this does not regress. Bugi: chromium:838684 Change-Id: I71b628ccce4dfbf1f2bd012c24866cd908f56d30 Reviewed-on: https://chromium-review.googlesource.com/1091638 Reviewed-by: Shubhie Panicker <panicker@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#565478} -- wpt-commits: ee048e6c440fb14aa63b96ca8900208cd122cacb wpt-pr: 11421
2081132acb9d50c5e2039f8c69b0cec06efa3685: Bug 1465912 [wpt PR 11282] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 01 Jun 2018 21:04:26 +0000 - rev 814250
Push 115144 by bmo:gl@mozilla.com at Wed, 04 Jul 2018 20:51:10 +0000
Bug 1465912 [wpt PR 11282] - Update wpt metadata, a=testonly wpt-pr: 11282 wpt-type: metadata
f51b3102f67331c6c5337325218a858454f4d43f: Bug 1465912 [wpt PR 11282] - Convert word-wrap to an alias of overflow-wrap, a=testonly
Chris Nardi <cnardi@chromium.org> - Mon, 02 Jul 2018 17:19:41 +0000 - rev 814249
Push 115144 by bmo:gl@mozilla.com at Wed, 04 Jul 2018 20:51:10 +0000
Bug 1465912 [wpt PR 11282] - Convert word-wrap to an alias of overflow-wrap, a=testonly Automatic update from web-platform-testsConvert word-wrap to an alias of overflow-wrap word-wrap was previously defined as its own property in CSSProperties.json5, but with the same behavior as overflow-wrap. However, this meant that word-wrap showed up alongside word-wrap in cssText. This patch converts word-wrap to be an alias of overflow-wrap, as this will prevent the issue of both properties showing up in cssText and matches the resolution in https://github.com/w3c/csswg-drafts/issues/866. Bug: 679068 Change-Id: I3d415eb1cde9a92dffa2a045ba5fa8b015eeb2d7 Reviewed-on: https://chromium-review.googlesource.com/1073677 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565331} -- wpt-commits: 71aca0a171ce75d1acfc43e1e523f709612addb8 wpt-pr: 11282
2681ff515c697868ec9842681da8c3bcb9afe60d: Bug 1465616 - Add a mochitest for position:fixed hit-testing. r?botond draft
Kashav Madan <kmadan@mozilla.com> - Wed, 04 Jul 2018 16:17:31 -0400 - rev 814248
Push 115143 by bmo:kmadan@mozilla.com at Wed, 04 Jul 2018 20:50:07 +0000
Bug 1465616 - Add a mochitest for position:fixed hit-testing. r?botond MozReview-Commit-ID: IC82JZoVgPs
7c67757778d6d9ce3a1bccda87518363371daaf1: Bug 1465616 - Add reftests for fixed and sticky elements. r?botond draft
Kashav Madan <kmadan@mozilla.com> - Wed, 04 Jul 2018 16:16:09 -0400 - rev 814247
Push 115143 by bmo:kmadan@mozilla.com at Wed, 04 Jul 2018 20:50:07 +0000
Bug 1465616 - Add reftests for fixed and sticky elements. r?botond MozReview-Commit-ID: IzSUQqvjrUp
61d32603f91a7a53f72ef7505d11e5f3e9e2f1f0: Bug 1465616 - Use viewport size to compute visible rect for fixed position elements. r?botond,r?mstange draft
Kashav Madan <kmadan@mozilla.com> - Wed, 04 Jul 2018 16:10:04 -0400 - rev 814246
Push 115143 by bmo:kmadan@mozilla.com at Wed, 04 Jul 2018 20:50:07 +0000
Bug 1465616 - Use viewport size to compute visible rect for fixed position elements. r?botond,r?mstange Since fixed position elements are now scrollable, we need to ensure that they're drawn inside the viewport instead of only the SPC-SPS, since otherwise they'd be clipped when scrolled. MozReview-Commit-ID: 4p3pWnwluvz
210d178a8ef3841e8d128f3993ab72cc804876be: Bug 1465616 - Remove call to AlignFixedAndStickyLayers for RCD-RSF. r?botond draft
Kashav Madan <kmadan@mozilla.com> - Wed, 04 Jul 2018 15:52:03 -0400 - rev 814245
Push 115143 by bmo:kmadan@mozilla.com at Wed, 04 Jul 2018 20:50:07 +0000
Bug 1465616 - Remove call to AlignFixedAndStickyLayers for RCD-RSF. r?botond When applying transformations to the RCD-RSF with zoom-enabled, avoid re-aligning fixed/sticky layers to make them appear static relative to the visual viewport. This is a partial fix and will require changes to how the async transform is computed, which will be done in Bug 1465618. MozReview-Commit-ID: B8HH6mbjTnv
c4e7cf68f9bf428a6175def50e5e01a672cd5d07: Bug 1465616 - Don't use SPC-SPS to layout fixed position elements. r?botond,r?mstange draft
Kashav Madan <kmadan@mozilla.com> - Wed, 04 Jul 2018 15:16:17 -0400 - rev 814244
Push 115143 by bmo:kmadan@mozilla.com at Wed, 04 Jul 2018 20:50:07 +0000
Bug 1465616 - Don't use SPC-SPS to layout fixed position elements. r?botond,r?mstange MozReview-Commit-ID: 5D4ErVFx8Bm
68ae55c2cd9b7736ba426ba870c9a1dceac3ca21: Bug 1471025: Part 8 - Add tests for shared memory preferences. r?njn draft
Kris Maglione <maglione.k@gmail.com> - Tue, 03 Jul 2018 20:17:15 -0700 - rev 814243
Push 115142 by maglione.k@gmail.com at Wed, 04 Jul 2018 20:49:19 +0000
Bug 1471025: Part 8 - Add tests for shared memory preferences. r?njn MozReview-Commit-ID: 8452JoTBHCU
3f396f1384efcc7e2e5070e8dd3357ebc09661dd: Bug 1471025: Part 7c - Clear the dynamic hashtable in the parent process after snapshotting. r?njn draft
Kris Maglione <maglione.k@gmail.com> - Mon, 02 Jul 2018 22:48:40 -0700 - rev 814242
Push 115142 by maglione.k@gmail.com at Wed, 04 Jul 2018 20:49:19 +0000
Bug 1471025: Part 7c - Clear the dynamic hashtable in the parent process after snapshotting. r?njn The preference storage in the shared memory snapshot is much more compact than the dynamic hashtable, and is already mapped in memory, so there's no need to keep the full hashtable in memory in the parent process after the snapshot is created. This patch empties the hashtable and the name string arena after the snapshot. It also removes the accounting for preferences which have changed after init, since those are, by definition, exactly the set of entries in the dynamic hashtable. MozReview-Commit-ID: L6VGq2z4foH
0fed3d56e34e6517e7b2a842188a6acebf0927d2: Bug 1471025: Part 7b - Don't load preference files in the content process. r?njn draft
Kris Maglione <maglione.k@gmail.com> - Mon, 02 Jul 2018 20:15:27 -0700 - rev 814241
Push 115142 by maglione.k@gmail.com at Wed, 04 Jul 2018 20:49:19 +0000
Bug 1471025: Part 7b - Don't load preference files in the content process. r?njn With the parent sending a snapshot of its preference state at content process startup, we're guaranteed to have the full set of built-in preferences in the shared map at initialization time, so there's no need to load them again. This also applies to static preference default values, so we skip setting those, as well. However, we do need to make sure that we update static preference cache entries whose default values don't match the value in the shared map, since they may have been changed by user preference files. In order to deal with that, we iterate over all preferences in the map, and dispatch callbacks for any that have user values. MozReview-Commit-ID: DlRUbg7Qor3
9b7ff7289d127cba6b872212115429cb75e6c735: Bug 1471025: Part 7a - Look up preferences from both dynamic and shared preference tables. r?njn draft
Kris Maglione <maglione.k@gmail.com> - Mon, 02 Jul 2018 22:52:53 -0700 - rev 814240
Push 115142 by maglione.k@gmail.com at Wed, 04 Jul 2018 20:49:19 +0000
Bug 1471025: Part 7a - Look up preferences from both dynamic and shared preference tables. r?njn This patch changes our preference look-up behavior to first check the dynamic hashtable, and then fall back to the shared map. In order for this to work, we need to make several other changes as well: - Attempts to modify a preference that only exists in the shared table requires that we copy it to the dynamic table, and change the value of the new entry. - Attempts to clear a user preference with no default value, but which also exists in the shared map, requires that we keep an entry in the dynamic table to mask the shared entry. To make this work, we change the type of these entries to None, and ignore them during look-ups and iteration. - Iteration needs to take both hashtables into consideration. The serialization iterator for changed preferences only needs to care about dynamic values, so it remains unchanged. Most of the others need to use PrefsIter() instead. MozReview-Commit-ID: 9PWmSZxoC9Z
a3f31eb6707228c6b59e3da691033cb663e11dab: Bug 1471025: Part 6 - Optimize preference lookups while dispatching callbacks. r?njn draft
Kris Maglione <maglione.k@gmail.com> - Mon, 02 Jul 2018 19:31:02 -0700 - rev 814239
Push 115142 by maglione.k@gmail.com at Wed, 04 Jul 2018 20:49:19 +0000
Bug 1471025: Part 6 - Optimize preference lookups while dispatching callbacks. r?njn Since lookups in the snapshotted hashtable are currently O(log n) rather than O(n), they're expected to be slightly more expensive than the previous purely-dynamic lookups. In general, I expect this not to be a major issue. The main concern is pref cache lookups while initializing the database. Initialization in the parent process will still always use only a dynamic hashtable, so the performance characteristics there won't change. In the child process, though, we'll still need to notify observers of preferences in the snapshot when they have user values, which could require any number of lookups at startup (though in practice probably will not). This patch solves that problem by caching the wrapper for the current known preference value when dispatching callbacks, and optimizing lookups for that value when it is present. MozReview-Commit-ID: 2CAn0rM0bE9
7fd2682d6fa6bf0e1970dfe881cd2bbc1b44a5fa: Bug 1471025: Part 5 - Add a range iterator helper for iterating both static and dynamic preferences. r?njn draft
Kris Maglione <maglione.k@gmail.com> - Mon, 02 Jul 2018 18:17:48 -0700 - rev 814238
Push 115142 by maglione.k@gmail.com at Wed, 04 Jul 2018 20:49:19 +0000
Bug 1471025: Part 5 - Add a range iterator helper for iterating both static and dynamic preferences. r?njn For memory efficiency in content processes, we need to be able to store changed preferences in a separate dynamic hashtable when their values don't match the snapshot values. That makes iteration over the full set of preferences somewhat more complicated, since not only do we need to iterate over two tables, but we also need to ignore preferences in the snapshot table if they also exist in the dynamic hashtable. This patch solves that problem by adding an iterator helper which iterates over values in both tables, and skips values in the static table if they also exist in the dynamic table. In order to support completely deleting preferences that exist in the base table, it also ignores all dynamic entries with the None type, so that they can completely mask deleted base table values. MozReview-Commit-ID: LCIwyPJMByj
39eb8d76e6b46d12e6353d0a336554f503e792df: Bug 1471025: Part 4 - Add a wrapper class that can access either static or dynamic prefs. r?njn draft
Kris Maglione <maglione.k@gmail.com> - Sun, 01 Jul 2018 23:23:48 -0700 - rev 814237
Push 115142 by maglione.k@gmail.com at Wed, 04 Jul 2018 20:49:19 +0000
Bug 1471025: Part 4 - Add a wrapper class that can access either static or dynamic prefs. r?njn The in-memory format of shared-memory preferences is significantly different from the format used by dynamic preferences, which means that we need different classes to access their properties. Virtual classes would be a potential solution to this problem, but I don't think the performance characteristics would be acceptable for preferences code. And since the wrapper classes used for static prefs are temporary, they would add the additional snag of figuring out how to keep a valid pointer alive. So, instead, this patch adds a wrapper class that can access eaither type of preference, based on known type flags in a Variant. It also moves some of the logic for deciding which preference value to return to the wrapper, so that it doesn't need to be duplicated for each representation. MozReview-Commit-ID: LameIIbYcD3
11c6ff7f39306f173fa07ed17f52af1a7d821326: Bug 1471025: Part 3c - Also pass the shared preference map handle to Android content processes. r?jld draft
Kris Maglione <maglione.k@gmail.com> - Mon, 02 Jul 2018 15:17:48 -0700 - rev 814236
Push 115142 by maglione.k@gmail.com at Wed, 04 Jul 2018 20:49:19 +0000
Bug 1471025: Part 3c - Also pass the shared preference map handle to Android content processes. r?jld MozReview-Commit-ID: CTjDzVC9gcD
58e6d5a2d7dbc383ec210caf37c0e43496c5159c: Bug 1471025: Part 3b - Refactor Android shared FD API to require fewer modifications per change. r?jld draft
Kris Maglione <maglione.k@gmail.com> - Mon, 02 Jul 2018 15:01:25 -0700 - rev 814235
Push 115142 by maglione.k@gmail.com at Wed, 04 Jul 2018 20:49:19 +0000
Bug 1471025: Part 3b - Refactor Android shared FD API to require fewer modifications per change. r?jld Adding or removing an FD from this API currently requires changes in about a half dozen places. Ignoring the Java side of things. This patch changes the API to pass a struct, rather than additional arguments for each FD, so that adding and removing FDs only requires changing one declaration, and the two call sites that add and comsume the FDs. MozReview-Commit-ID: CToSEVp1oqP
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip