b8d0e98b3bc72538c5ae307998ae25a1d1163621: Bug 1306549 part.8 Get rid of |virtualKey| and |isKeyDown| from KeyboardLayout::InitNativeKey() and KeyboardLayout::MaybeInitNativeKeyAsDeadKey() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 30 Sep 2016 15:40:40 +0900 - rev 419949
Push 31049 by masayuki@d-toybox.com at Mon, 03 Oct 2016 00:49:26 +0000
Bug 1306549 part.8 Get rid of |virtualKey| and |isKeyDown| from KeyboardLayout::InitNativeKey() and KeyboardLayout::MaybeInitNativeKeyAsDeadKey() r?m_kato For preventing wrapping long lines, old KeyboardLayout::InitNativeKey() uses two variables |virtualKey| and |isKeyDown| which are never modified. However, they may be not clear for some developers where they came from. Additionally, preceding patches reduced a lot of users of them and indent level. Therefore, even if we remove these variables, we don't need additional line breaks in most cases. So, removing them is better for easier to understand. MozReview-Commit-ID: 680bYVINPAE
b3db838d9fa87c8f032bf8e85c82bd5cc9d72390: Bug 1306549 part.7 Create KeyboardLayout::MaybeInitNativeKeyAsDeadKey() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 30 Sep 2016 16:06:00 +0900 - rev 419948
Push 31049 by masayuki@d-toybox.com at Mon, 03 Oct 2016 00:49:26 +0000
Bug 1306549 part.7 Create KeyboardLayout::MaybeInitNativeKeyAsDeadKey() r?m_kato This patch creates KeyboardLayout::MaybeInitNativeKeyAsDeadKey() for wrapping dead key handling code in KeyboardLayout::InitNativeKey(). This makes InitNativeKey() code simpler. Now, any developers must be able to understand what InitNativeKey() does easier than before fixing this bug. MozReview-Commit-ID: C59ESUXeTxU
30a06667293150ff57f3d2cb617994eab4fff95c: Bug 1306549 part.6 Create KeyboardLayout::ActivateDeadKeyState() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 19:09:12 +0900 - rev 419947
Push 31049 by masayuki@d-toybox.com at Mon, 03 Oct 2016 00:49:26 +0000
Bug 1306549 part.6 Create KeyboardLayout::ActivateDeadKeyState() r?m_kato There is DeactivateDeadKeyState() but not ActivateDeadKeyState(). There should be both of them and hides the dead key state management into them. MozReview-Commit-ID: JvAPE5f2HVy
24b722f6d9b1f23613da80d98d6c56fd9d34b470: Bug 1306549 part.5 Create KeyboardLayout::GetCompositeChar() for wrapping VirtualKey::GetCompositeChar() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 18:54:48 +0900 - rev 419946
Push 31049 by masayuki@d-toybox.com at Mon, 03 Oct 2016 00:49:26 +0000
Bug 1306549 part.5 Create KeyboardLayout::GetCompositeChar() for wrapping VirtualKey::GetCompositeChar() r?m_kato VirtualKey::GetCompositeChar() needs index of virtual keycode which may make around the caller messy. So, KeyboardLayout::GetCompositeChar() should wrap it and KeyboardLayout::MaybeInitNativeKeyWithCompositeChar() should use it. MozReview-Commit-ID: 8KLTJpCFZ8u
fda7375f25bbd7b7feb15d212dbfca5dcc5fcbf9: Bug 1306549 part.4 Create KeyboardLayout::GetNativeUniCharsAndModifiers() for wrapping VirtualKey::GetNativeUniChars() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 18:38:53 +0900 - rev 419945
Push 31049 by masayuki@d-toybox.com at Mon, 03 Oct 2016 00:49:26 +0000
Bug 1306549 part.4 Create KeyboardLayout::GetNativeUniCharsAndModifiers() for wrapping VirtualKey::GetNativeUniChars() r?m_kato Similar to VirtualKey::GetUniChars(), VirtualKey::GetNativeUniChars() needs key index. So, it should be wrapped by a new helper method, KeyboardLayout::GetNativeUniCharsAndModifiers(), and KeyboardEvent::InitNativeKey() should use this instead of accessing its member's GetNativeUniChars(). MozReview-Commit-ID: 7M9OlNF698Y
83a8f05136f279c3b8581ef64103bac9aead6c29: Bug 1306549 part.3 KeyboardLayout::InitNativeKey() should use GetUniCharsAndModifiers() instead of using VirtualKey::GetUniChars() directly r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 18:22:12 +0900 - rev 419944
Push 31049 by masayuki@d-toybox.com at Mon, 03 Oct 2016 00:49:26 +0000
Bug 1306549 part.3 KeyboardLayout::InitNativeKey() should use GetUniCharsAndModifiers() instead of using VirtualKey::GetUniChars() directly r?m_kato When InitNativeKey() retrieves UniCharsAndModifiers for a key, it needs key index for the given virtual keycode. Therefore, wrapping the code with GetUniCharsAndModifiers() makes InitNativeKey() code simpler since each call specifies the virtual keycode to the method instead of key index. MozReview-Commit-ID: Azy8chXexaz
320696ffbc13508ec9079e90b059e286b4f6d02a: Bug 1306549 part.2 Create overload methods which take ModifierKeyState instead of VirtualKey::ShiftState r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 30 Sep 2016 15:32:10 +0900 - rev 419943
Push 31049 by masayuki@d-toybox.com at Mon, 03 Oct 2016 00:49:26 +0000
Bug 1306549 part.2 Create overload methods which take ModifierKeyState instead of VirtualKey::ShiftState r?m_kato This patch gets rid of |shiftState| from KeyboardLayout::InitNativeKey() and make each caller clearer. This must make other developers understand what modifier state is used at each call. MozReview-Commit-ID: 6zydP1jkffv
9b3b4fe8aa265e7d0c494d6250feb57e38da2a76: Bug 1306549 part.1 KeyboardLayout::InitNativeKey() should use KeyboardLayout::IsDeadKey() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 17:24:39 +0900 - rev 419942
Push 31049 by masayuki@d-toybox.com at Mon, 03 Oct 2016 00:49:26 +0000
Bug 1306549 part.1 KeyboardLayout::InitNativeKey() should use KeyboardLayout::IsDeadKey() r?m_kato KeyboardLayout::InitNativeKey() is very messy because it handles a lot of cases without helper methods. It's important to make it simpler implementation for preventing regressions caused by some patches which are written with misunderstanding. So, let's rewrite the method with helper method. First, this patch make InitNativeKey() use IsDeadKey() instead of referring the table because calling IsDeadKey() is easier to understand. MozReview-Commit-ID: DtN9qoh7Gz7
75fe7331044e4afbc3393ee08671c375325a75f9: Bug 1267884 - Touch CLOBBER file. r=sebastian draft
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 11 May 2016 15:32:28 +0200 - rev 419941
Push 31048 by ahunt@mozilla.com at Mon, 03 Oct 2016 00:46:15 +0000
Bug 1267884 - Touch CLOBBER file. r=sebastian MozReview-Commit-ID: 4uHivbQsLjX
70d9731245af9a1a883ef6f579f7c0dbc6319438: Bug 1267884 - Add empty updateVisuals() to GeckoCustomTabsService to match customtabs-23.4 r=sebastian draft
Andrzej Hunt <ahunt@mozilla.com> - Fri, 30 Sep 2016 09:18:10 -0700 - rev 419940
Push 31048 by ahunt@mozilla.com at Mon, 03 Oct 2016 00:46:15 +0000
Bug 1267884 - Add empty updateVisuals() to GeckoCustomTabsService to match customtabs-23.4 r=sebastian MozReview-Commit-ID: FCDCqOLJDDt
4c4728c643c058f4e0b62a59b93e26be4b4d6c65: Bug 1267884 - Upgrade support libraries to 23.4 r=sebastian draft
Andrzej Hunt <ahunt@mozilla.com> - Fri, 30 Sep 2016 09:16:23 -0700 - rev 419939
Push 31048 by ahunt@mozilla.com at Mon, 03 Oct 2016 00:46:15 +0000
Bug 1267884 - Upgrade support libraries to 23.4 r=sebastian MozReview-Commit-ID: C7LWrLfYlQU
19c9698fe7c3c724485604c9b6ba530ebb539550: Backed out changeset d64bcb6d78e5 (bug 1205371) for browser_animation_pseudo_elements.js and browser_markup_dragdrop_invalidNodes.js failures
Phil Ringnalda <philringnalda@gmail.com> - Sun, 02 Oct 2016 11:41:47 -0700 - rev 419938
Push 31048 by ahunt@mozilla.com at Mon, 03 Oct 2016 00:46:15 +0000
Backed out changeset d64bcb6d78e5 (bug 1205371) for browser_animation_pseudo_elements.js and browser_markup_dragdrop_invalidNodes.js failures
d64bcb6d78e58612d6dcfafbfa6e32817f80f42f: Bug 1205371 - Multi-state pseudo-class lock indicator. r=gl
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 26 Feb 2016 14:09:00 +0000 - rev 419937
Push 31048 by ahunt@mozilla.com at Mon, 03 Oct 2016 00:46:15 +0000
Bug 1205371 - Multi-state pseudo-class lock indicator. r=gl
9fd5b3f366580befc1ddb2d099d623e223f3f352: Bug 1307016 - Have puppeteer __str__ encode fields to assii. r?maja_zf draft
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 03 Oct 2016 11:56:50 +1300 - rev 419936
Push 31047 by bvandyk@mozilla.com at Mon, 03 Oct 2016 00:25:10 +0000
Bug 1307016 - Have puppeteer __str__ encode fields to assii. r?maja_zf At least some of the environments the tests are running in do not appear to play nice with non-ascii characters. Some of the jenkins runs are currently unhappy due to this. This patch sees that all fields are encoded as ascii with non-compatible characters replaced. MozReview-Commit-ID: 6qSCyUujMLE
e22f1b6d649be57fe3c460c2531fbe20bf7210f4: Bug 1295002 - don't accept nested view-source: references in nsDefaultURIFixup, r?baku draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Sun, 02 Oct 2016 22:54:20 +0100 - rev 419935
Push 31046 by gijskruitbosch@gmail.com at Sun, 02 Oct 2016 21:56:29 +0000
Bug 1295002 - don't accept nested view-source: references in nsDefaultURIFixup, r?baku This seems like much the simplest way to prevent the recursion. Other alternatives include some kind of member var to track state (which wouldn't be threadsafe, though I don't know that that really matters for this component) or adding a field on nsIDefaultURIFixupInfo, which seems ugly. This is a bit hacky, but it seems to work. MozReview-Commit-ID: 7CCVvENSRVD
3188259ceffdce54b877b7b216ee065c75dda54c: Bug 1000458 - stop races in location bar <return> handling code, r?mak draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 28 Sep 2016 19:54:25 +0100 - rev 419934
Push 31045 by gijskruitbosch@gmail.com at Sun, 02 Oct 2016 15:59:36 +0000
Bug 1000458 - stop races in location bar <return> handling code, r?mak MozReview-Commit-ID: IcQCNj0FcCu
914819c579c863aee0d20019c45d04b36c36100f: Bug 1000458 - stop races in location bar <return> handling code, r?mak draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 28 Sep 2016 19:54:25 +0100 - rev 419933
Push 31044 by gijskruitbosch@gmail.com at Sun, 02 Oct 2016 14:01:27 +0000
Bug 1000458 - stop races in location bar <return> handling code, r?mak MozReview-Commit-ID: IcQCNj0FcCu
c0af0281f175bc06dc4b9c9de845103d1d22881d: Bug 1287007 - Fix timing issue in browser_ext_tabs_onUpdated.js r?billm draft
Rob Wu <rob@robwu.nl> - Sat, 01 Oct 2016 01:07:22 +0200 - rev 419932
Push 31043 by bmo:rob@robwu.nl at Sun, 02 Oct 2016 11:57:33 +0000
Bug 1287007 - Fix timing issue in browser_ext_tabs_onUpdated.js r?billm Reload about:blank tab after opening it and registering the `tabs.onUpdated` event. This is needed because about:blank loads very fast, before the callback of `tabs.create` is invoked. This effect is amplified by the fact that the APIs are now proxied. MozReview-Commit-ID: DgPtIqHSUDx
cb8720cb56e5de58b09181fbe62d5e6f554dc027: Bug 1287007 - Remove contextMenusInternal.onClicked r?billm draft
Rob Wu <rob@robwu.nl> - Sat, 01 Oct 2016 00:46:19 +0200 - rev 419931
Push 31043 by bmo:rob@robwu.nl at Sun, 02 Oct 2016 11:57:33 +0000
Bug 1287007 - Remove contextMenusInternal.onClicked r?billm contextMenusInternal.onClicked is already inlined in context_menus.json. It should be removed because otherwise the `browser.contextMenusInternal.onClicked` API would be generated. MozReview-Commit-ID: LAKd2IGM5GU
517ad67a1a877163d89083c7813507b1f825e749: Bug 1176218 - Reject resolutions that are too big for Windows - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Thu, 29 Sep 2016 15:13:55 +1000 - rev 419930
Push 31042 by gsquelart@mozilla.com at Sun, 02 Oct 2016 05:32:25 +0000
Bug 1176218 - Reject resolutions that are too big for Windows - r?jya MozReview-Commit-ID: E0jvpgKzsQM
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip