b736a7fb68bd2164b66e9c8275df1474b442d9e4: Bug 1450526 - Part 3: Update node front when the indicated node was re-generated. r?pbro
draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 21 May 2018 18:53:32 +0900 - rev 797673
Push
110532 by bmo:dakatsuka@mozilla.com at Mon, 21 May 2018 10:23:12 +0000
Bug 1450526 - Part 3: Update node front when the indicated node was re-generated. r?pbro
MozReview-Commit-ID: 4e9XOSTzW8X
646e146a15cdc1f782f0379cd32c3167cd339d8e: Bug 1450526 - Part 2: Change the target node of animation on pseudo element in the actor to proper node. r?pbro
draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 21 May 2018 18:40:43 +0900 - rev 797672
Push
110532 by bmo:dakatsuka@mozilla.com at Mon, 21 May 2018 10:23:12 +0000
Bug 1450526 - Part 2: Change the target node of animation on pseudo element in the actor to proper node. r?pbro
In this patch fix not only new animation inspector, but also previous one.
MozReview-Commit-ID: KYdaUXXea70
e76cbbfc2fdfa9edd8c6d1a7c4c92572dbbe32c5: Bug 1450526 - Part 1: Make pseudo element to be available in new animation inspector. r?pbro
draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 21 May 2018 18:40:40 +0900 - rev 797671
Push
110532 by bmo:dakatsuka@mozilla.com at Mon, 21 May 2018 10:23:12 +0000
Bug 1450526 - Part 1: Make pseudo element to be available in new animation inspector. r?pbro
MozReview-Commit-ID: 1GE4VIKCIS1
36cabb95f016c98023fa34edbb823cd774eaae45: Bug 1454392 - Part 5: Add test whether proper currentTime was set for each animations. r?pbro
draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 21 May 2018 18:33:29 +0900 - rev 797670
Push
110532 by bmo:dakatsuka@mozilla.com at Mon, 21 May 2018 10:23:12 +0000
Bug 1454392 - Part 5: Add test whether proper currentTime was set for each animations. r?pbro
MozReview-Commit-ID: 9qUNhRMCy7Q
c8ebf86b6efabd44f360ee738eed069357d81a04: Bug 1454392 - Part 4: Add test whether the graph layout was not broken. r?pbro
draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 21 May 2018 18:33:26 +0900 - rev 797669
Push
110532 by bmo:dakatsuka@mozilla.com at Mon, 21 May 2018 10:23:12 +0000
Bug 1454392 - Part 4: Add test whether the graph layout was not broken. r?pbro
MozReview-Commit-ID: 6dJpS9RGcpQ
70ea911ace699ca5709c56a5108ca7b22b1c5d98: Bug 1454392 - Part 3: Change the scrubber to createdTime base. r?pbro
draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 21 May 2018 18:33:05 +0900 - rev 797668
Push
110532 by bmo:dakatsuka@mozilla.com at Mon, 21 May 2018 10:23:12 +0000
Bug 1454392 - Part 3: Change the scrubber to createdTime base. r?pbro
MozReview-Commit-ID: 1aEZeOjtVxz
cd77d04e995478df825ce60c592237cd725e1f12: Bug 1454392 - Part 2: Apply createdTime to summary graph so as keeping proper graph. r?pbro
draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 21 May 2018 18:30:27 +0900 - rev 797667
Push
110532 by bmo:dakatsuka@mozilla.com at Mon, 21 May 2018 10:23:12 +0000
Bug 1454392 - Part 2: Apply createdTime to summary graph so as keeping proper graph. r?pbro
MozReview-Commit-ID: 4udVcj2Zy5C
2923373cdcddcfd9310594faf9b5673676d756cf: Bug 1454392 - Part 1: Introduce createdTime variable which holds time that animation created. r?pbro
draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 21 May 2018 18:30:23 +0900 - rev 797666
Push
110532 by bmo:dakatsuka@mozilla.com at Mon, 21 May 2018 10:23:12 +0000
Bug 1454392 - Part 1: Introduce createdTime variable which holds time that animation created. r?pbro
MozReview-Commit-ID: bM2cZdPAYp
b43f783b5a4613c43cbd22f758edb59bf977c718: Bug 1447931 - NetworkActivity becomes IOActivity - r?valentin,baku,mak
draft
Tarek Ziadé <tarek@mozilla.com> - Mon, 21 May 2018 12:16:57 +0200 - rev 797665
Push
110531 by tziade@mozilla.com at Mon, 21 May 2018 10:19:05 +0000
Bug 1447931 - NetworkActivity becomes IOActivity - r?valentin,baku,mak
Generalizes NetworkActivity so it can be used for sockets but also disk files.
The host/port data becomes a single location string prefixed with socket://
or file:// and we're not using the FD as the identifier anymore.
IOActivityMonitor is now used in three places:
- nsFileStreams for plain files
- TelemetryVFS for sqlite files
- nsSocketTransport & nsUDPSocket for UDP & TCP sockets
MozReview-Commit-ID: GNu5o400PaV
7dece6c7694373f119135b672aa7ad8838c7c345: Bug 1461907 - Set sidebar arrows the same colors as in the console output; r=Honza.
draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 21 May 2018 12:17:51 +0200 - rev 797664
Push
110530 by bmo:nchevobbe@mozilla.com at Mon, 21 May 2018 10:18:36 +0000
Bug 1461907 - Set sidebar arrows the same colors as in the console output; r=Honza.
MozReview-Commit-ID: 3tuBPN6mPDI
06d189d3aff93e83e95bd8493f931cc001422d05: Bug 1457083 - part 7: Remove methods of TextEditRules and HTMLEditRules, which just return NS_OK r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 10 May 2018 16:04:06 +0900 - rev 797663
Push
110529 by masayuki@d-toybox.com at Mon, 21 May 2018 10:03:18 +0000
Bug 1457083 - part 7: Remove methods of TextEditRules and HTMLEditRules, which just return NS_OK r?m_kato
Some Did*() of TextEditRules and HTMLEditRules do nothing except returning
NS_OK. Let's remove them since there is no reason to keep them.
MozReview-Commit-ID: Jcdh5rnm5Yc
7ca38e65281269ea4186d899e03df8a6472f1bf7: Bug 1457083 - part 6: Get rid of unnecessary Selection argument from all protected/private methods of TextEditRules and HTMLEditRules r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 10 May 2018 15:03:21 +0900 - rev 797662
Push
110529 by masayuki@d-toybox.com at Mon, 21 May 2018 10:03:18 +0000
Bug 1457083 - part 6: Get rid of unnecessary Selection argument from all protected/private methods of TextEditRules and HTMLEditRules r?m_kato
Now, each protected/private method of TextEditRules and HTMLEditRules can
retrieve Selection instance safely and quickly. Therefore, their pointer or
reference of Selection arguments are not necessary. Therefore, this patch
removes them.
MozReview-Commit-ID: 1SPmKXmd7kz
9aae5ce90219950eee682897f9583d69e8bfdf23: Bug 1457083 - part 5: Make all users of Selection in TextEditRules and HTMLEditRules use TextEditRules::SelectionRef() r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 08 May 2018 17:30:05 +0900 - rev 797661
Push
110529 by masayuki@d-toybox.com at Mon, 21 May 2018 10:03:18 +0000
Bug 1457083 - part 5: Make all users of Selection in TextEditRules and HTMLEditRules use TextEditRules::SelectionRef() r?m_kato
After this patch applies, most methods of TextEditRules and HTMLEditRules
don't need to take Selection as their arguments. Therefore, next patch will
remove them.
MozReview-Commit-ID: 99r3ZkfG2In
d07efe1667246d14238d9988e7fd3736ebd617b7: Bug 1457083 - part 4: Replace mHTMLEditor in HTMLEditRules with HTMLEditorRef() r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Apr 2018 01:42:22 +0900 - rev 797660
Push
110529 by masayuki@d-toybox.com at Mon, 21 May 2018 10:03:18 +0000
Bug 1457083 - part 4: Replace mHTMLEditor in HTMLEditRules with HTMLEditorRef() r?m_kato
Although, this patch removes first check of mHTMLEditor in each method. If
this causes some security issues, we should add now. However, automated
tests don't indicate it.
Anyway, it should be fixed by
bug 1454900 in same cycle.
MozReview-Commit-ID: 3LAtOQHyR5J
64f7cf6bcfceb598849572277a48c057573d6493: Bug 1457083 - part 3: Replace mTextEditor in TextEditRules with TextEditorRef() r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Apr 2018 00:09:10 +0900 - rev 797659
Push
110529 by masayuki@d-toybox.com at Mon, 21 May 2018 10:03:18 +0000
Bug 1457083 - part 3: Replace mTextEditor in TextEditRules with TextEditorRef() r?m_kato
This patch adds a debug methods to check if AutoSafeEditorData as expected and
inserting top of each method whose mTextEditor is replaced with TextEditorRef().
MozReview-Commit-ID: 8yjHsypLMRx
b27a78ea059c423e71f2fb9016df63ddfe66c20a: Bug 1457083 - part 2: Make all observer methods of HTMLEditRules create AutoSafeEditorData r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 26 Apr 2018 23:27:50 +0900 - rev 797658
Push
110529 by masayuki@d-toybox.com at Mon, 21 May 2018 10:03:18 +0000
Bug 1457083 - part 2: Make all observer methods of HTMLEditRules create AutoSafeEditorData r?m_kato
Except HTMLEditRules::WillJoinNodes(), observer methods of HTMLEditRules
accesses mHTMLEditor. Therefore, we need to make them create AutoSafeEditorData
instance in the stack.
Note that for reducing EditorBase::GetSelection() calls, this patch adds
Selection& argument to all of them.
MozReview-Commit-ID: 6mjuD2gZwVp
56ce36dad38a6863cfcfc95929baaf3b6f8473eb: Bug 1457083 - part 1: Make public methods of TextEditUtils and HTMLEditUtils guarantee that the editor instance and selection instance won't be destroyed while it handles any edit actions r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 26 Apr 2018 22:41:34 +0900 - rev 797657
Push
110529 by masayuki@d-toybox.com at Mon, 21 May 2018 10:03:18 +0000
Bug 1457083 - part 1: Make public methods of TextEditUtils and HTMLEditUtils guarantee that the editor instance and selection instance won't be destroyed while it handles any edit actions r?m_kato
This patch creates a stack class in TextEditRules, its name is
AutoSafeEditorData and make all public methods (except editor observer methods)
which may change DOM tree, fire some DOM events or calling some XPCOM listeners
create its instance in the stack. Then, it grabs associated editor instance
and its selection instance.
Next patch will make remaining public methods create AutoSafeEditorData.
MozReview-Commit-ID: 8oshdhL3ONQ
d6f865bc3dd07ee447ff2f9eb3abab7465308080: Bug 1451149 - P2. Don't fire the "stalled" event when using MSE. r?bryce
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 14 May 2018 11:32:09 +0200 - rev 797656
Push
110528 by bmo:jyavenard@mozilla.com at Mon, 21 May 2018 09:51:23 +0000
Bug 1451149 - P2. Don't fire the "stalled" event when using MSE. r?bryce
When using a media element with a Media Source, the resource fetching algorithm is to be called in "local" mode:
https://www.w3.org/TR/media-source/#mediasource-attach
"Continue the resource fetch algorithm by running the remaining "Otherwise (mode is local)" steps, with these clarifications"
https://html.spec.whatwg.org/multipage/media.html#concept-media-load-resource
Under the local mode, the steps that would cause the element to fire suspend, stalled or progress can never occur.
We only prevent the stalled event to be fired, many websites rely on the progress event to be fired (such as when the init segment has been parsed). The HTML5 media spec will be amended to clearly indicate that progress is to be fired even with mediasource
MozReview-Commit-ID: DkoQzoV0JzO
8a8a3bfad3120cef153a2ba7473df04caa87fbad: Bug 1451149 - P1. Fix HTMLMediaElement style. r?bryce
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 14 May 2018 11:11:18 +0200 - rev 797655
Push
110528 by bmo:jyavenard@mozilla.com at Mon, 21 May 2018 09:51:23 +0000
Bug 1451149 - P1. Fix HTMLMediaElement style. r?bryce
Partially apply clang-format so that we limit the scope of changes while ensuring consistency in declarations.
MozReview-Commit-ID: Km9sKBbFhKx
c53ed3829c50e431ee7fe6d452fffb5d5b6bad70: Bug 1458208 - telemetry.js: DevTools code should always go through telemetry.js r?jdescottes
draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 10 May 2018 15:14:01 +0100 - rev 797654
Push
110527 by bmo:mratcliffe@mozilla.com at Mon, 21 May 2018 09:33:40 +0000
Bug 1458208 - telemetry.js: DevTools code should always go through telemetry.js r?jdescottes
MozReview-Commit-ID: 9cUGY2CjjZG