Bug 1419128 - Look for extra lines in nightly whitelist; r?build Before, the whitelist['nightly'] entries could contain lines that didn't actually occur in the mozconfig. With this commit, we require that all lines in the whitelist actually exist in the mozconfig. MozReview-Commit-ID: LdHfFAcBzgv

Bug 1419128 - Remove unreferenced entries in nightly whitelist; r?build None of these are defined in any "nightly" mozconfigs. Some of these lines may occur and be set by mozconfigs. But the entire premise of compare-mozconfigs is flawed because it only compares file content: not the end result of mozconfig evaluation. (mozconfigs are shell scripts and a lot of logic occurs in other sourced shell scripts.) MozReview-Commit-ID: 2Nwo3ePJreb

Bug 1419128 - Remove last reference to CLIENT_PY_ARGS; r?build This variable isn't consumed anywhere. I have no clue where it was consumed. It appears to be the product of an old era. MozReview-Commit-ID: 6iRdLW89ZjW

Bug 1419128 - Remove last references to PROFILE_GEN_SCRIPT; r?build There are no other references to PROFILE_GEN_SCRIPT outside of the mozconfig whitelist file. The deleted entries from the whitelist file were meaningless. MozReview-Commit-ID: IhOV8Hlfmhl

Bug 1419128 - Remove MOZ_MAKE_FLAGS references from mozconfigs whitelists; r?build We no longer define MOZ_MAKE_FLAGS in the in-repo mozconfigs. Nor do we pass MOZ_MAKE_FLAGS from any automation configs as far as I can tell. MozReview-Commit-ID: LYU1dI44uhX

Bug 1419128 - Consolidate mozconfig comparison logic into compare-mozconfigs.py; r?build Hopefully this makes it more obvious how all of this is hooked together. MozReview-Commit-ID: 1jeyIZgHYht

Bug 1419128 - Pass topsrcdir into compare-mozconfigs.py; r?build We currently have the logic for compare-mozconfigs spread across 2 Python files. I'd like to move the logic into 1 file so we can do nicer things more easily. In preparation for this, change compare-mozconfigs.py to receive an argument that is the path to the topsrcdir. Also, switch to argparse because it is more modern. MozReview-Commit-ID: 7oFQzAdmcim

Bug 1419128 - Clean up value checking; r?build MozReview-Commit-ID: LAS0Iaf40nI

Bug 1419128 - Remove functionality for downloading mozconfigs; r?build Pretty sure this is a relic of running this check in automation outside the context of a source check. compare-mozconfigs.py is essentially a source lint. I don't see a need for this feature to exist. MozReview-Commit-ID: 1FUbJayg1sO

Bug 1419128 - Don't use mutable default argument value; r?build We always passed this argument in so this change doesn't fix any bugs. I just didn't like the code smell. MozReview-Commit-ID: IXzj1gRbkJ6

Bug 1419128 - Hard code whitelist key; r?build We only call this function once. Behavior doesn't need to be parameterized. MozReview-Commit-ID: BR6WU4GSeyO

Bug 1419128 - Remove unused required keys feature; r?build Nobody passes in the "required" argument. Remove it and functionality related to it. MozReview-Commit-ID: IB8s4CiDy6a

Bug 1407423 - Part 3: Update Puppet Device Implementation - Update prefs to accomodate tests, disabling enumeration throttling - Updated Puppet display and controller implementation to act more like the actual devices. - Updated tests to ensure that they explicitly create a VR mock display and don't create duplicate mock displays. MozReview-Commit-ID: 7GSoYVxmqgM

Bug 1419128 - Look for extra lines in nightly whitelist; r?build Before, the whitelist['nightly'] entries could contain lines that didn't actually occur in the mozconfig. With this commit, we require that all lines in the whitelist actually exist in the mozconfig. MozReview-Commit-ID: LdHfFAcBzgv

Bug 1419128 - Remove unreferenced entries in nightly whitelist; r?build None of these are defined in any "nightly" mozconfigs. Some of these lines may occur and be set by mozconfigs. But the entire premise of compare-mozconfigs is flawed because it only compares file content: not the end result of mozconfig evaluation. (mozconfigs are shell scripts and a lot of logic occurs in other sourced shell scripts.) MozReview-Commit-ID: 2Nwo3ePJreb

Bug 1419128 - Remove last reference to CLIENT_PY_ARGS; r?build This variable isn't consumed anywhere. I have no clue where it was consumed. It appears to be the product of an old era. MozReview-Commit-ID: 6iRdLW89ZjW

Bug 1419128 - Remove last references to PROFILE_GEN_SCRIPT; r?build There are no other references to PROFILE_GEN_SCRIPT outside of the mozconfig whitelist file. The deleted entries from the whitelist file were meaningless.

Bug 1419128 - Remove MOZ_MAKE_FLAGS references from mozconfigs whitelists; r?build We no longer define MOZ_MAKE_FLAGS in the in-repo mozconfigs. Nor do we pass MOZ_MAKE_FLAGS from any automation configs as far as I can tell. MozReview-Commit-ID: LYU1dI44uhX

Bug 1419128 - Consolidate mozconfig comparison logic into compare-mozconfigs.py; r?build Hopefully this makes it more obvious how all of this is hooked together.

Bug 1419128 - Pass topsrcdir into compare-mozconfigs.py; r?build We currently have the logic for compare-mozconfigs spread across 2 Python files. I'd like to move the logic into 1 file so we can do nicer things more easily. In preparation for this, change compare-mozconfigs.py to receive an argument that is the path to the topsrcdir. Also, switch to argparse because it is more modern.