b6258cfeb4be3d12147272bbbc09fe2b4153a8b3: Bug 1419128 - Look for extra lines in nightly whitelist; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:55:29 -0800 - rev 700829
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Look for extra lines in nightly whitelist; r?build Before, the whitelist['nightly'] entries could contain lines that didn't actually occur in the mozconfig. With this commit, we require that all lines in the whitelist actually exist in the mozconfig. MozReview-Commit-ID: LdHfFAcBzgv
33b5e7c05e9be13fc7624c7a9bc2091eb32f3750: Bug 1419128 - Remove unreferenced entries in nightly whitelist; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 15:07:43 -0800 - rev 700828
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Remove unreferenced entries in nightly whitelist; r?build None of these are defined in any "nightly" mozconfigs. Some of these lines may occur and be set by mozconfigs. But the entire premise of compare-mozconfigs is flawed because it only compares file content: not the end result of mozconfig evaluation. (mozconfigs are shell scripts and a lot of logic occurs in other sourced shell scripts.) MozReview-Commit-ID: 2Nwo3ePJreb
f981d5ec9a2089b492b3620d5188400feb9ddf4a: Bug 1419128 - Remove last reference to CLIENT_PY_ARGS; r?build draft
Gregory Szorc <gps@mozilla.com> - Tue, 31 Oct 2017 13:56:12 -0700 - rev 700827
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Remove last reference to CLIENT_PY_ARGS; r?build This variable isn't consumed anywhere. I have no clue where it was consumed. It appears to be the product of an old era. MozReview-Commit-ID: 6iRdLW89ZjW
c136423a62371e9641a66c3ef5606f2544aa9dad: Bug 1419128 - Remove last references to PROFILE_GEN_SCRIPT; r?build draft
Gregory Szorc <gps@mozilla.com> - Wed, 08 Nov 2017 16:40:46 -0800 - rev 700826
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Remove last references to PROFILE_GEN_SCRIPT; r?build There are no other references to PROFILE_GEN_SCRIPT outside of the mozconfig whitelist file. The deleted entries from the whitelist file were meaningless. MozReview-Commit-ID: IhOV8Hlfmhl
de0a045f1dd67faa88a643e66fef6add99a4cb45: Bug 1419128 - Remove MOZ_MAKE_FLAGS references from mozconfigs whitelists; r?build draft
Gregory Szorc <gps@mozilla.com> - Tue, 31 Oct 2017 14:29:21 -0700 - rev 700825
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Remove MOZ_MAKE_FLAGS references from mozconfigs whitelists; r?build We no longer define MOZ_MAKE_FLAGS in the in-repo mozconfigs. Nor do we pass MOZ_MAKE_FLAGS from any automation configs as far as I can tell. MozReview-Commit-ID: LYU1dI44uhX
5e1a56dc7757ea2f5bd86f9926ed2f91a74145da: Bug 1419128 - Consolidate mozconfig comparison logic into compare-mozconfigs.py; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:47:01 -0800 - rev 700824
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Consolidate mozconfig comparison logic into compare-mozconfigs.py; r?build Hopefully this makes it more obvious how all of this is hooked together. MozReview-Commit-ID: 1jeyIZgHYht
3a03ffd6dd8a5f4ec5732bab9a57f0b1fdf66c67: Bug 1419128 - Pass topsrcdir into compare-mozconfigs.py; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:34:50 -0800 - rev 700823
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Pass topsrcdir into compare-mozconfigs.py; r?build We currently have the logic for compare-mozconfigs spread across 2 Python files. I'd like to move the logic into 1 file so we can do nicer things more easily. In preparation for this, change compare-mozconfigs.py to receive an argument that is the path to the topsrcdir. Also, switch to argparse because it is more modern. MozReview-Commit-ID: 7oFQzAdmcim
b364f0e81d21dc6a2f4d448fc77178c1632a0684: Bug 1419128 - Clean up value checking; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:27:13 -0800 - rev 700822
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Clean up value checking; r?build MozReview-Commit-ID: LAS0Iaf40nI
9eb58b3f546a32978a66cf3db7a92fa23f68f521: Bug 1419128 - Remove functionality for downloading mozconfigs; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:18:46 -0800 - rev 700821
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Remove functionality for downloading mozconfigs; r?build Pretty sure this is a relic of running this check in automation outside the context of a source check. compare-mozconfigs.py is essentially a source lint. I don't see a need for this feature to exist. MozReview-Commit-ID: 1FUbJayg1sO
183b17c0c55da8f2f9ba3fc22e1c886e34c2a6e3: Bug 1419128 - Don't use mutable default argument value; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:14:56 -0800 - rev 700820
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Don't use mutable default argument value; r?build We always passed this argument in so this change doesn't fix any bugs. I just didn't like the code smell. MozReview-Commit-ID: IXzj1gRbkJ6
2ca87964fef1e8ed4d8719142b6a74c45e4beda8: Bug 1419128 - Hard code whitelist key; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:09:47 -0800 - rev 700819
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Hard code whitelist key; r?build We only call this function once. Behavior doesn't need to be parameterized. MozReview-Commit-ID: BR6WU4GSeyO
625240c63b91a1fc85df77484a20d16b7782e999: Bug 1419128 - Remove unused required keys feature; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:06:35 -0800 - rev 700818
Push 89986 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:17:58 +0000
Bug 1419128 - Remove unused required keys feature; r?build Nobody passes in the "required" argument. Remove it and functionality related to it. MozReview-Commit-ID: IB8s4CiDy6a
c63b926a1f65fe692d3f421e718515c5e608722c: Bug 1407423 - Part 3: Update Puppet Device Implementation draft
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Tue, 14 Nov 2017 16:03:50 -0800 - rev 700817
Push 89985 by kgilbert@mozilla.com at Mon, 20 Nov 2017 23:17:02 +0000
Bug 1407423 - Part 3: Update Puppet Device Implementation - Update prefs to accomodate tests, disabling enumeration throttling - Updated Puppet display and controller implementation to act more like the actual devices. - Updated tests to ensure that they explicitly create a VR mock display and don't create duplicate mock displays. MozReview-Commit-ID: 7GSoYVxmqgM
fb910d7d8c69c59d6b77830d0f226a2378404e4e: Bug 1419128 - Look for extra lines in nightly whitelist; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:55:29 -0800 - rev 700816
Push 89984 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:14:50 +0000
Bug 1419128 - Look for extra lines in nightly whitelist; r?build Before, the whitelist['nightly'] entries could contain lines that didn't actually occur in the mozconfig. With this commit, we require that all lines in the whitelist actually exist in the mozconfig. MozReview-Commit-ID: LdHfFAcBzgv
97b4d341e1c848cdd60f8771f643f2031fc9d731: Bug 1419128 - Remove unreferenced entries in nightly whitelist; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 15:07:43 -0800 - rev 700815
Push 89984 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:14:50 +0000
Bug 1419128 - Remove unreferenced entries in nightly whitelist; r?build None of these are defined in any "nightly" mozconfigs. Some of these lines may occur and be set by mozconfigs. But the entire premise of compare-mozconfigs is flawed because it only compares file content: not the end result of mozconfig evaluation. (mozconfigs are shell scripts and a lot of logic occurs in other sourced shell scripts.) MozReview-Commit-ID: 2Nwo3ePJreb
6d8db2f172e24a00e5c9d4529095a692d4bd0c76: Bug 1419128 - Remove last reference to CLIENT_PY_ARGS; r?build draft
Gregory Szorc <gps@mozilla.com> - Tue, 31 Oct 2017 13:56:12 -0700 - rev 700814
Push 89984 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:14:50 +0000
Bug 1419128 - Remove last reference to CLIENT_PY_ARGS; r?build This variable isn't consumed anywhere. I have no clue where it was consumed. It appears to be the product of an old era. MozReview-Commit-ID: 6iRdLW89ZjW
cbf887639e657f5003f55f8a9bca623b2ddb4bd0: Bug 1419128 - Remove last references to PROFILE_GEN_SCRIPT; r?build draft
Gregory Szorc <gps@mozilla.com> - Wed, 08 Nov 2017 16:40:46 -0800 - rev 700813
Push 89984 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:14:50 +0000
Bug 1419128 - Remove last references to PROFILE_GEN_SCRIPT; r?build There are no other references to PROFILE_GEN_SCRIPT outside of the mozconfig whitelist file. The deleted entries from the whitelist file were meaningless.
0a034506feb9c670e57fa8cc92234f19038f53aa: Bug 1419128 - Remove MOZ_MAKE_FLAGS references from mozconfigs whitelists; r?build draft
Gregory Szorc <gps@mozilla.com> - Tue, 31 Oct 2017 14:29:21 -0700 - rev 700812
Push 89984 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:14:50 +0000
Bug 1419128 - Remove MOZ_MAKE_FLAGS references from mozconfigs whitelists; r?build We no longer define MOZ_MAKE_FLAGS in the in-repo mozconfigs. Nor do we pass MOZ_MAKE_FLAGS from any automation configs as far as I can tell. MozReview-Commit-ID: LYU1dI44uhX
c5e3f1cdd82f14d74c99357c19aa6a7b6d94eabc: Bug 1419128 - Consolidate mozconfig comparison logic into compare-mozconfigs.py; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:47:01 -0800 - rev 700811
Push 89984 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:14:50 +0000
Bug 1419128 - Consolidate mozconfig comparison logic into compare-mozconfigs.py; r?build Hopefully this makes it more obvious how all of this is hooked together.
05aa5b6d20db84c360546d91c88210e71c1a502b: Bug 1419128 - Pass topsrcdir into compare-mozconfigs.py; r?build draft
Gregory Szorc <gps@mozilla.com> - Mon, 20 Nov 2017 14:34:50 -0800 - rev 700810
Push 89984 by bmo:gps@mozilla.com at Mon, 20 Nov 2017 23:14:50 +0000
Bug 1419128 - Pass topsrcdir into compare-mozconfigs.py; r?build We currently have the logic for compare-mozconfigs spread across 2 Python files. I'd like to move the logic into 1 file so we can do nicer things more easily. In preparation for this, change compare-mozconfigs.py to receive an argument that is the path to the topsrcdir. Also, switch to argparse because it is more modern.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip