b5631dd590ae14433676d09eb28fa75374f623dc: Bug 1364644 - Bookmark version tracking r=rnewman
Grigory Kruglov <gkruglov@mozilla.com> - Tue, 15 Aug 2017 17:28:56 -0400 - rev 648018
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1364644 - Bookmark version tracking r=rnewman MozReview-Commit-ID: EdN4pYSR8Ux
866bf0a5a6b6e8bb787fe6addc9798b62f656f73: Bug 1364644 - Migrate bookmarks schema and records to add version columns r=rnewman
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 14 Aug 2017 23:22:53 -0400 - rev 648017
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1364644 - Migrate bookmarks schema and records to add version columns r=rnewman Schema migration is simple: it adds localVersion and syncVersion columns to bookmarks table. Default values are: - localVersion=1 - syncVersion=0 ... indicating that a record needs to be uploaded. Data migration is also relatively simple: we need to ensure that records which are "up-to-date", according to the old timestamp-based tracking, are not marked for an upload, and vice versa - records which are either "new" or "changed" are marked for an upload. Since our default during schema migration is to mark everything for upload, the data migration concerns itself with the records which are considered as "up-to-date". See detailed description in the comments in the data migration function. MozReview-Commit-ID: J6aglurYwlo
d7e7927feaf3ec07ff60963149f4664d12212d5e: Bug 1364644 - Pre: Refactor bookmark and history sessions to allow for different superclasses r=rnewman
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 04 Aug 2017 18:43:49 -0400 - rev 648016
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1364644 - Pre: Refactor bookmark and history sessions to allow for different superclasses r=rnewman Versioned syncing work later in the patch series introduces functionality that is best suited to live within the RepositorySession inheritance chain. We'd like to introduce a new RepositorySession subclass which individual RepositorySessions are able to inherit. And that's when the current inheritance structure gets in the way: history and bookmarks both share a superclass, and we'd like to only introduce this new functionality for bookmarks. This makes our task, as stated, impossible without breaking apart the current inheritance structure. This patch introduces a few "delegate" objects: - SessionHelper --> HistorySessionHelper --> BookmarksSessionHelper ... which absorb most of the functionality from AndroidBrowserRepositorySession (removed) and bookmark and history repository sessions. This change is not functional - everything remains as before otherwise. MozReview-Commit-ID: 7WwUmY3Wql7
210d26d082942f10d706e357aa46d682c974aa65: Bug 1364644 - Pre: don't swallow runtime exceptions in the BrowserProvider's call interface r=rnewman
Grigory Kruglov <gkruglov@mozilla.com> - Thu, 27 Jul 2017 00:28:08 -0400 - rev 648015
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1364644 - Pre: don't swallow runtime exceptions in the BrowserProvider's call interface r=rnewman MozReview-Commit-ID: 3mgOrSvEFxU
2f69b4cb829c71fb76f4006d16f7982308af400a: Bug 1364644 - Pre: Move change tracking responsibilities into repositories r=rnewman
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 28 Jul 2017 17:15:22 -0400 - rev 648014
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1364644 - Pre: Move change tracking responsibilities into repositories r=rnewman As part of moving toward versioned syncing, we need to start decoupling change tracking concepts from parts of the system that facilitate flow of records. This allows us to track what changed differently for different data types, while maintaining a consistent and predictable API. A move toward that is to let repositories own determinining that a record has been modified. Repositories are now asked to provide modified records, instead of a very specific "records modified since". This patch does not change behaviour of the system: every repository still uses timestamp-based change tracking to actually provide modified records to the caller. A changeover to version tracking will come later in this series for bookmarks, and as part of Bug 1383894 for other repositories. MozReview-Commit-ID: LQuWYdlNHpt
3846782bf831982536fe0c62533563a7c9187a73: Bug 1364644 - Pre: Remove guidsSince RepositorySession interface r=rnewman
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 24 Jul 2017 14:48:38 -0400 - rev 648013
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1364644 - Pre: Remove guidsSince RepositorySession interface r=rnewman We're moving toward version-based syncing. This is one of the bricks in that road, removing an unused timestamp-based interface for accessing changed records. MozReview-Commit-ID: CYUyASWXrMW
9fae68b13ef90c700384cd30355b9b15832681b2: Bug 1371166 - Explicitly load videos via video.load to get a cross origin requests to take place. r=jib
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 11 Aug 2017 12:32:14 +1200 - rev 648012
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1371166 - Explicitly load videos via video.load to get a cross origin requests to take place. r=jib Change where load calls are used in media recorder principals test to more reliably force cross origin requests. MozReview-Commit-ID: 7La6ZIRmsTQ
72f9ce682a285f1c0713d342775947cd2c7c2fb4: Bug 1371166 - Drive by update to update var -> let in test. r=jib
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 21 Jul 2017 16:00:23 +1200 - rev 648011
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1371166 - Drive by update to update var -> let in test. r=jib MozReview-Commit-ID: TAP46fR2HP
e177651cbe61db1692dcab50a19e3ad92ba7f825: Bug 1371166 - Update media recorder principal test to behave more like MediaElement principal test. r=jib
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 21 Jul 2017 15:59:27 +1200 - rev 648010
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1371166 - Update media recorder principal test to behave more like MediaElement principal test. r=jib Update the MediaRecorder principal test to behave more like test_mixed_principals.html. This involves preloading metadata and using a longer video to test with. This particular combination currently results in multiple requests being made for the resource, however this is not a robust solution in that the behaviour of the MediaCache and associated objects may change and break this. This fixes the issue for now as best I can tell, but a follow up gtest or may be a more sensible long term solution. MozReview-Commit-ID: F9gnnzGt3Cu
d5e2b2fb7858dd0aa4f8dfe71e6cb93430b9e0c7: Bug 1390725 - Change the loading path of CDM host verification file on Mac. r=cpearce
James Cheng <jacheng@mozilla.com> - Thu, 17 Aug 2017 00:13:05 +0800 - rev 648009
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1390725 - Change the loading path of CDM host verification file on Mac. r=cpearce The plugin-container sig file is located in another place. Need to handle it as a special case. MozReview-Commit-ID: 2e2gbM4CVDG
ffe54db6e9b5780f6c0cb5592f04f72f85d30473: Bug 1390831 - Make test_bug635636.html e10s-aware r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 Aug 2017 21:03:18 +0900 - rev 648008
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1390831 - Make test_bug635636.html e10s-aware r=Ehsan test_bug655636.html refers gBrowser, however, it's available only in chrome process and it's referred only for listening to "pageshow" event instead of "load" event of the data URI. So, we must be able to use "unload" event of the previous URL instead. Although, this testcase (even without this change) won't cause crash even if backing out the patch for bug 635636 anymore. MozReview-Commit-ID: B8qOwVZqZQm
2a4b186e4836a5ab5ac6f00a62ee129273d561b4: servo: Merge #18112 - Use the is_absolute_containing_block method everywhere (from mrobinson:containing-block-helper); r=mbrubeck
Martin Robinson <mrobinson@igalia.com> - Wed, 16 Aug 2017 19:18:48 -0500 - rev 648007
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
servo: Merge #18112 - Use the is_absolute_containing_block method everywhere (from mrobinson:containing-block-helper); r=mbrubeck This is a better approach than relying on contains_positioned_fragments, because in the future other properties will create absolute containing blocks. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they do not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7806784eb4761bf9018d342d29594eb6c9058fc3
f34888c63675c57ee750c790a7f6e6720c9beb59: Bug 1356241 - Drop preference values that are already set in prefs_general.js. r=daisuke
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 17 Aug 2017 08:57:01 +0900 - rev 648006
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1356241 - Drop preference values that are already set in prefs_general.js. r=daisuke There are no other meta files that the preference values which were dropped in this patch are set explicitly. MozReview-Commit-ID: 6FXjj8gVPER
a369a533833ae6e9d208c75770bc45450d6c5c3c: Bug 1356241 - Return specified 'normal' value for column-gap computed value. r=dholbert
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 17 Aug 2017 08:56:00 +0900 - rev 648005
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1356241 - Return specified 'normal' value for column-gap computed value. r=dholbert In the spec [1], computed value for column-gap is defined as 'as specified, with <length>s made absolute'. [1] https://drafts.csswg.org/css-multicol-1/#column-gap MozReview-Commit-ID: IO22V33z8pz
1cbd18a18186c77fec91e0f7275301bc271c040a: Bug 1356241 - Set the pref for overflow-clip-box true since it's not contained in prefs_general.js. r=daisuke
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 17 Aug 2017 08:56:00 +0900 - rev 648004
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1356241 - Set the pref for overflow-clip-box true since it's not contained in prefs_general.js. r=daisuke MozReview-Commit-ID: 96FsyOjwiTV
bf581c606046b7c0c5cefd488dc08e71154f442f: Bug 1361952 - Update Firefox Account to match the spec r=jaws
Ricky Chien <ricky060709@gmail.com> - Thu, 17 Aug 2017 09:02:11 +0800 - rev 648003
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1361952 - Update Firefox Account to match the spec r=jaws
0dec0ba29bca55cc418e02788e3943c59e686176: Bug 1390739 - Dispatch the task to main thread if the callback of CDM does not on main thread. r=cpearce
James Cheng <jacheng@mozilla.com> - Wed, 16 Aug 2017 13:36:08 +0800 - rev 648002
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1390739 - Dispatch the task to main thread if the callback of CDM does not on main thread. r=cpearce MozReview-Commit-ID: E5sjEKR4bRQ
fd74c81eee5aec7c9567a93de8e2e4bea14795fc: Bug 1391114 - Make `mach artifact toolchain` validate toolchain downloads. r=gps
Mike Hommey <mh+mozilla@glandium.org> - Thu, 17 Aug 2017 09:36:27 +0900 - rev 648001
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1391114 - Make `mach artifact toolchain` validate toolchain downloads. r=gps Tooltool manifests contain digests that have been used to validate tooltool downloads. Toolchain artifacts don't benefit from that, and as a result, an incomplete download can be considered as finished, and unpack fail after that, without retrying, even with --retry. Fortunately, the chain of trust artifacts do contains digests for taskcluster artifacts, as long as the jobs that created the artifacts have chain of trust enabled. As of now, the goal is not cryptographic validation of the download, but to ensure that we got the complete file, and to trigger a new download if we haven't.
9a03b7830de965d8154e6848e1c06d266fb90260: Bug 1387973 - Modify transition test cases for {text,box}-shadow without color. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 16 Aug 2017 15:03:46 +0900 - rev 648000
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
Bug 1387973 - Modify transition test cases for {text,box}-shadow without color. r=birtles As for Gecko we can't interpolate between value with color and value without color yet (bug 726550) so that transition does not happen for the cases. As for Servo we can interpolate them but the results are wrong (bug 1390697). MozReview-Commit-ID: 9T0ELBUP0pL
8c675061d66e3ea575dd3da40c94ab5ff4730ab2: servo: Merge #18102 - Implement distance for shadow list (from hiikezoe:compute-distance-for-shadow-list); r=boris
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 16 Aug 2017 18:17:18 -0500 - rev 647999
Push 74592 by bmo:dakatsuka@mozilla.com at Thu, 17 Aug 2017 04:45:30 +0000
servo: Merge #18102 - Implement distance for shadow list (from hiikezoe:compute-distance-for-shadow-list); r=boris <!-- Please describe your changes on the following line: --> https://bugzilla.mozilla.org/show_bug.cgi?id=1387973 --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors Source-Repo: https://github.com/servo/servo Source-Revision: 846b6dcb0710e9343575621a1ddad97c0cd1952d
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip