b4e01a81c4b2bb9f9f2ee1e6e366869a7c602a5d: Bug 1398483 - Implement column and row gap for flexbox. draft
Mihir Iyer <miyer@mozilla.com> - Tue, 19 Jun 2018 10:28:31 -0700 - rev 811009
Push 114183 by bmo:miyer@mozilla.com at Tue, 26 Jun 2018 22:01:31 +0000
Bug 1398483 - Implement column and row gap for flexbox. MozReview-Commit-ID: 2EmaG3G0HRI
582ecaab653625986d322411c1d08bd33a245d05: Bug 1447116 - Require rust 1.26. r=froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 18:05:23 +0900 - rev 811008
Push 114182 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:57:41 +0000
Bug 1447116 - Require rust 1.26. r=froydnj We're well overdue for an upgrade of the rust compiler requirements. Now that we're building with 1.28 (albeit a beta, due to be bumped when it's released), we can bump the requirement away from 1.24 which is now old. 1.27 is too new, though, so settle for the older 1.26.
2bdc8da8e55e938f95ad8372c51946045a725419: Bug 1447116 - Update builders to rust 1.28. r=froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 17:34:28 +0900 - rev 811007
Push 114182 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:57:41 +0000
Bug 1447116 - Update builders to rust 1.28. r=froydnj
202593b0b66586711390b6f2766fb0841cf3d5eb: Bug 1471132 - Make building a binary component a compile-time error. r?froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 16:18:14 +0900 - rev 811006
Push 114182 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:57:41 +0000
Bug 1471132 - Make building a binary component a compile-time error. r?froydnj Loading binary components is not supported since bug 1314955.
29b22e61d2f490e25f8bd5d86bd72e7f762cd48d: Bug 1471132 - Change how static xpcom components are initialized. r?froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 16:10:30 +0900 - rev 811005
Push 114182 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:57:41 +0000
Bug 1471132 - Change how static xpcom components are initialized. r?froydnj The sStaticModules list is, practically speaking, a copy of the list of components we already have in libxul, augmented at runtime with a few other components for tests (for gtest and xpcshell). We don't actually need to keep that copy in memory. We can instead just use the pointers in libxul directly to register them to the component manager, and use a separate list, only for those extra components when they need to be registered.
110826dfc933d0e6e428e9cb3586243ddbda3203: Bug 1471132 - Change how static xpcom components are linked. r?froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 14:40:51 +0900 - rev 811004
Push 114182 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:57:41 +0000
Bug 1471132 - Change how static xpcom components are linked. r?froydnj Overall, this makes the whole setup less fragile, and make it work with LTO in more situations.
690f12eab92f289b1842e067f8bdebd9ef7a3961: Bug 1471132 - Avoid ASAN padding between NSModules. r?froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 14:39:49 +0900 - rev 811003
Push 114182 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:57:41 +0000
Bug 1471132 - Avoid ASAN padding between NSModules. r?froydnj
13b772305caca5b840e636fe2af530545d2d6799: Bug 1470127 - Move binary checks to a standalone script. r=froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Jun 2018 18:13:03 +0900 - rev 811002
Push 114182 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:57:41 +0000
Bug 1470127 - Move binary checks to a standalone script. r=froydnj We perform, on the binaries we build, a series of check, that are implemented as half-baked make commands, invoked after linking them. - check libstdc++ symbol versions to ensure binary compatibility with a baseline. - check glibc symbol versions to ensure binary compatibility with a baseline. - check that target binaries don't contain text relocations. - check that libmozglue is linked before libc on android. - on libxul, check that NSModules are laid out correctly. - on libxul, check that there is more than one PT_LOAD segment. Those checks happen to work where they matter, but their setup is unreliable. For example, the checks for symbol versions are supposed to work for libclang-plugin on cross osx builds, but in fact, don't, because the readelf path doesn't exist, and the command doesn't fail in that case. So move them all to a standalone script, performing the checks more thoroughly (especially the NSModules one, where we now also check that they are all adjacent), and more verbosely.
c883e0804c0f2183e08d3670aee1f13aaf5e420f: Bug 1471096 - Choose OOM hooking version to use at build time rather than configure time. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Sat, 23 Jun 2018 07:28:26 +0900 - rev 811001
Push 114182 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:57:41 +0000
Bug 1471096 - Choose OOM hooking version to use at build time rather than configure time. r?build When I originally implemented bug 1458161, this is how it was done, but it was suggested to use a configure-time check. This turned out to not be great, because the rust compiler changes regularly, and we don't run the configure tests when the version changes. When people upgraded their rust compiler to 1.27, the code subsequently failed to build because the features were still set for the previous version they had installed.
b7d3539fe768ae1aaf128b37944f34d48ff51fef: Bug 1471096 - Vendor rustc_version. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 10:00:26 +0900 - rev 811000
Push 114182 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:57:41 +0000
Bug 1471096 - Vendor rustc_version. r?build
29bdbe2f65d3115f53a304d1e26bc58b4e9cf667: Bug 1470701 - Use run-time page size when changing mapping permissions in elfhack injected code. r?froydnj draft
Mike Hommey <mh@glandium.org> - Sun, 24 Jun 2018 09:02:38 +0900 - rev 810999
Push 114182 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:57:41 +0000
Bug 1470701 - Use run-time page size when changing mapping permissions in elfhack injected code. r?froydnj When a binary has a PT_GNU_RELRO segment, the elfhack injected code uses mprotect to add the writable flag to relocated pages before applying relocations, removing it afterwards. To do so, the elfhack program uses the location and size of the PT_GNU_RELRO segment, and adjusts it to be aligned according to the PT_LOAD alignment. The problem here is that the PT_LOAD alignment doesn't necessarily match the actual page alignment, and the resulting mprotect may end up not covering the full extent of what the dynamic linker has protected read-only according to the PT_GNU_RELRO segment. In turn, this can lead to a crash on startup when trying to apply relocations to the still read-only locations. Practically speaking, this doesn't end up being a problem on x86, where the PT_LOAD alignment is usually 4096, which happens to be the page size, but on Debian armhf, it is 64k, while the run time page size can be 4k.
127b9cdbadda58c0b9843e744c5353cc42216d61: Bug 1340498 - Fix unified sources build errors r?mrbkap draft
Doug Thayer <dothayer@mozilla.com> - Fri, 13 Apr 2018 11:04:47 -0700 - rev 810998
Push 114181 by bmo:dothayer@mozilla.com at Tue, 26 Jun 2018 21:46:28 +0000
Bug 1340498 - Fix unified sources build errors r?mrbkap Adding the Places* files into unified sources pushed the unified sources into a situation that exposed a strangely large number of errors. This seems to be the minimum set of changes I could make to resolve all of the issues. MozReview-Commit-ID: C2H9ce8FmE4
2248593980f52c3645970d0e1fda94206077dbd6: Bug 1340498 - Update onVisits tests to use 'page-visited' r?mak draft
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:17:41 -0800 - rev 810997
Push 114181 by bmo:dothayer@mozilla.com at Tue, 26 Jun 2018 21:46:28 +0000
Bug 1340498 - Update onVisits tests to use 'page-visited' r?mak MozReview-Commit-ID: FxC3gcUF9hl
7c76e85d9cf8389a5c2a11b2e17b3b445c48a462: Bug 1340498 - Update onVisits uses to 'page-visited' r?mak draft
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:11:49 -0800 - rev 810996
Push 114181 by bmo:dothayer@mozilla.com at Tue, 26 Jun 2018 21:46:28 +0000
Bug 1340498 - Update onVisits uses to 'page-visited' r?mak Consuming the new 'page-visited' notification was fairly trivial, since it was already brought over to onVisits. There's not much to say about this other than that I'm a little bit uncertain about all the hoops we have to jump through to get a JSContext and GlobalObject from History.cpp (which is discussed in the earlier commit in the series). MozReview-Commit-ID: LHaBWSylyLI
112555faf430ad359fba33369e5b39dd6fc4fc60: Bug 1340498 - Implement new Places Observers interface r?mrbkap draft
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:06:15 -0800 - rev 810995
Push 114181 by bmo:dothayer@mozilla.com at Tue, 26 Jun 2018 21:46:28 +0000
Bug 1340498 - Implement new Places Observers interface r?mrbkap See the design doc[1] for further info. We would like to redesign the places observer system to be more performant and more friendly to consume. WebIDL was recommended as it simplifies creating simple dictionary payloads while allowing dynamic typing with `any`. There were some difficulties with WebIDL though, most of which revolved around allowing consumers to be weakly referenced, from both C++ and JS. The simplest solution I could come up with was to create a simple native interface for the C++ case, and a WebIDL wrapper for a JS callback in the JS case. Suggestions for simpler alternatives are very welcome though. [1] https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit?usp=sharing MozReview-Commit-ID: ACnAEfa5WxO
0fbe0936f83142a05570fd8aaebf09d8aa2c5c1a: Bug 1340498 - Add new globals to lint config draft
Doug Thayer <dothayer@mozilla.com> - Mon, 29 Jan 2018 11:07:28 -0800 - rev 810994
Push 114181 by bmo:dothayer@mozilla.com at Tue, 26 Jun 2018 21:46:28 +0000
Bug 1340498 - Add new globals to lint config MozReview-Commit-ID: 360gup8cWvi
ca22d95a6b0002a1d67aaa2cac9ac487f9927f72: Bug 1447116 - Require rust 1.26. r=froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 18:05:23 +0900 - rev 810993
Push 114180 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:43:49 +0000
Bug 1447116 - Require rust 1.26. r=froydnj We're well overdue for an upgrade of the rust compiler requirements. Now that we're building with 1.28 (albeit a beta, due to be bumped when it's released), we can bump the requirement away from 1.24 which is now old. 1.27 is too new, though, so settle for the older 1.26.
90c0edb9392ad03da6972d578e133548996e2273: Bug 1447116 - Update builders to rust 1.28. r=froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 17:34:28 +0900 - rev 810992
Push 114180 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:43:49 +0000
Bug 1447116 - Update builders to rust 1.28. r=froydnj
a84d7f5ed226e0d04e24efa320eb07ea5fa7f386: Bug 1471132 - Make building a binary component a compile-time error. r?froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 16:18:14 +0900 - rev 810991
Push 114180 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:43:49 +0000
Bug 1471132 - Make building a binary component a compile-time error. r?froydnj Loading binary components is not supported since bug 1314955.
fa8cd8fc0361753e7ffb0f672283949c92658d3d: Bug 1471132 - Change how static xpcom components are initialized. r?froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 16:10:30 +0900 - rev 810990
Push 114180 by bmo:mh+mozilla@glandium.org at Tue, 26 Jun 2018 21:43:49 +0000
Bug 1471132 - Change how static xpcom components are initialized. r?froydnj The sStaticModules list is, practically speaking, a copy of the list of components we already have in libxul, augmented at runtime with a few other components for tests (for gtest and xpcshell). We don't actually need to keep that copy in memory. We can instead just use the pointers in libxul directly to register them to the component manager, and use a separate list, only for those extra components when they need to be registered.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip