b39c3e56da87bcbe6c5c8f485c834b87f33e0346: Bug 1468711 - Part 1: Send a proper element for pseudo element to nsDOMWindowUtils::ComputeAnimationDistance. r?pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 27 Jun 2018 10:22:06 +0900 - rev 811187
Push 114222 by bmo:dakatsuka@mozilla.com at Wed, 27 Jun 2018 05:20:14 +0000
Bug 1468711 - Part 1: Send a proper element for pseudo element to nsDOMWindowUtils::ComputeAnimationDistance. r?pbro MozReview-Commit-ID: 4xTST1tBeEW
761e90ea65e8c844dfd322cf4f7c0db2d91c5fd0: Bug 1471491 - Add lld to the mac clang toolchain. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 27 Jun 2018 13:33:23 +0900 - rev 811186
Push 114221 by bmo:mh+mozilla@glandium.org at Wed, 27 Jun 2018 05:04:07 +0000
Bug 1471491 - Add lld to the mac clang toolchain. r?build
091e7aa5ab0ca61ac37bef8333291cb39b8f961f: Bug 1411491 - Add lld to the mac clang toolchain. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 27 Jun 2018 13:33:23 +0900 - rev 811185
Push 114220 by bmo:mh+mozilla@glandium.org at Wed, 27 Jun 2018 05:02:13 +0000
Bug 1411491 - Add lld to the mac clang toolchain. r?build
960b212b998e728f90bbf564f5899a92f65c9e0e: Bug 1471114 part 7 - Scripts used to generated the previous patches. r?emilio draft
Xidorn Quan <me@upsuper.org> - Wed, 27 Jun 2018 08:49:10 +1000 - rev 811184
Push 114219 by xquan@mozilla.com at Wed, 27 Jun 2018 05:01:47 +0000
Bug 1471114 part 7 - Scripts used to generated the previous patches. r?emilio MozReview-Commit-ID: E9dB5l9AmeS
bcd27ac7553e97c73f198f8314ff192be78373dc: Bug 1463919 - Tests for prompting for permission to autoplay. r?jya,r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Mon, 25 Jun 2018 15:35:33 +1200 - rev 811183
Push 114218 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:34:20 +0000
Bug 1463919 - Tests for prompting for permission to autoplay. r?jya,r?mconley Test that video that autoplays via a play() call or via autoplay attribute plays or is blocked or prompts with a doorhanger for approval and plays when "allow" clicked and doesn't when "block" clicked. MozReview-Commit-ID: CpftV6RQbtU
d191ad7c770396f4a5d84682d8563c6d87f5a423: Bug 1463919 - Test that starting play from tab audio indicator overrides block autoplay. r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Mon, 25 Jun 2018 13:25:34 +1200 - rev 811182
Push 114218 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:34:20 +0000
Bug 1463919 - Test that starting play from tab audio indicator overrides block autoplay. r?mconley MozReview-Commit-ID: 4k7c7qw6cCq
570c8b1085c5d203f9ad027bee2fd5caa05e9d51: Bug 1463919 - Ensure resuming via audio tab indicator bypasses autoplay permission check. r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Thu, 21 Jun 2018 14:14:20 +1200 - rev 811181
Push 114218 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:34:20 +0000
Bug 1463919 - Ensure resuming via audio tab indicator bypasses autoplay permission check. r?mconley If the user opens a tab in the background, and that tab tries to play media, we'll delay playing that media until the tab is brought to the foreground. But the user can explicitly start playback of such delayed media by clicking the "play" icon we show in the tab indicator. Then if autoplay is disabled, we'll block the play (unless the origin is whitelisted). This is bad, as the user has clearly indicated intent to play media in this tab. So this patch adds an override flag that we set when the user starts playback via the audio tab indicator that short-circuits the autoplay blocking logic, ensuring we play in this case. MozReview-Commit-ID: Koir3xhF696
a58d33423e65c695e4c9b147e455a7fcea67e4ff: Bug 1463919 - Adjust mochitests to pass after changes. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Wed, 27 Jun 2018 16:15:58 +1200 - rev 811180
Push 114218 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:34:20 +0000
Bug 1463919 - Adjust mochitests to pass after changes. r?jya Prior to the changes in this bug, a document would request autoplay permission for its own origin, and not use the top level document's origin for the permission check. Since now we use the top level document's origin for requesting autoplay permission, some mochitests need to change, namely: * test_autoplay_policy_permission.html can use file_autoplay_policy_activation_frame.html directly. The test was failing because its helper page was loaded same origin and the helper page was testing if cross origins iframes could play; since we use the top level document's permission request, this no longer effectively tests whether the cross origin child can autoplay, as the cross origin child just uses the top level window's origin for requests. So we can instead load the helper window cross orgin instead, and remove one helper layer. Also an issue here is the way I was waiting for a new window to load was racy, so now we wait for loading windows to send us a "ready" message. * test_autoplay_policy_activation.html; this test's helper needs to wait for loading windows to send it a "ready" message, as its helper is shared with the above test. MozReview-Commit-ID: LvRa4G7tqFw
ec210847b6fd605c560a1bd1f2fe8beef76258ef: Bug 1463919 - Remove dead code in browser_block_autoplay_media.js test. r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Wed, 27 Jun 2018 15:24:00 +1200 - rev 811179
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Remove dead code in browser_block_autoplay_media.js test. r?mconley eslint pointed failed with an error: browser_block_autoplay_media.js:25:7 | 'audio' is not defined. (no-undef) It turns out, the function this line resides in is never called, so we can remove it. MozReview-Commit-ID: EUe5cRwGhfA
f463b2628eec8d6fa08920851c2918cb09389a9f: Bug 1463919 - Tests for prompting for permission to autoplay. r?jya,r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Mon, 25 Jun 2018 15:35:33 +1200 - rev 811178
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Tests for prompting for permission to autoplay. r?jya,r?mconley Test that video that autoplays via a play() call or via autoplay attribute plays or is blocked or prompts with a doorhanger for approval and plays when "allow" clicked and doesn't when "block" clicked. MozReview-Commit-ID: CpftV6RQbtU
62c94ba5b54b91f7689e100bf9eb9460b10684c9: Bug 1463919 - Test that starting play from tab audio indicator overrides block autoplay. r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Mon, 25 Jun 2018 13:25:34 +1200 - rev 811177
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Test that starting play from tab audio indicator overrides block autoplay. r?mconley MozReview-Commit-ID: 4k7c7qw6cCq
52d3689808be4e09a9dc890040da8575795dfee5: Bug 1463919 - Ensure resuming via audio tab indicator bypasses autoplay permission check. r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Thu, 21 Jun 2018 14:14:20 +1200 - rev 811176
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Ensure resuming via audio tab indicator bypasses autoplay permission check. r?mconley If the user opens a tab in the background, and that tab tries to play media, we'll delay playing that media until the tab is brought to the foreground. But the user can explicitly start playback of such delayed media by clicking the "play" icon we show in the tab indicator. Then if autoplay is disabled, we'll block the play (unless the origin is whitelisted). This is bad, as the user has clearly indicated intent to play media in this tab. So this patch adds an override flag that we set when the user starts playback via the audio tab indicator that short-circuits the autoplay blocking logic, ensuring we play in this case. MozReview-Commit-ID: Koir3xhF696
bef1cad937d346e42ac55e1ed14cfc238c6d9d1b: Bug 1463919 - Adjust mochitests to pass after changes. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Wed, 27 Jun 2018 16:15:58 +1200 - rev 811175
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Adjust mochitests to pass after changes. r?jya Prior to the changes in this bug, a document would request autoplay permission for its own origin, and not use the top level document's origin for the permission check. Since now we use the top level document's origin for requesting autoplay permission, some mochitests need to change, namely: * test_autoplay_policy_permission.html can use file_autoplay_policy_activation_frame.html directly. The test was failing because its helper page was loaded same origin and the helper page was testing if cross origins iframes could play; since we use the top level document's permission request, this no longer effectively tests whether the cross origin child can autoplay, as the cross origin child just uses the top level window's origin for requests. So we can instead load the helper window cross orgin instead, and remove one layers of helpers. Also an issue here is the way I was waiting for a new window to load was racy, so now we wait for loading windows to send us a "ready" message. * test_autoplay_policy_activation.html; this test's helper needs to wait for loading windows to send it a "ready" message, as its helper is shared with the above test. MozReview-Commit-ID: LvRa4G7tqFw
eb6c2abb687140a1290b1a3b36fab56dd5f6cf93: Bug 1463919 - Call Play() when activating attribute based autoplay. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Tue, 26 Jun 2018 14:16:13 +1200 - rev 811174
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Call Play() when activating attribute based autoplay. r?jya When autoplay is requested by setting the "autoplay" attribute, we should check whether autoplay is allowed in HTMLMediaElement::CheckAutoplayDataReady() and if not we should prompt for user consent. This ensures that <video ... autoplay/> will prompt for consent when used on a page without a pre-existing allow/block permission. MozReview-Commit-ID: 77pJR2Ybn2i
119857f8cfcbae4791e6832b91ea86a5bac914f8: Bug 1463919 - Have HTMLMediaElement ask for autoplay permission when playback otherwise blocked. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Fri, 22 Jun 2018 10:14:33 +1200 - rev 811173
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Have HTMLMediaElement ask for autoplay permission when playback otherwise blocked. r?jya MozReview-Commit-ID: Ejv0UKBjSVf
abefff91d90a16a37c8038b66dffdd16031564e7: Bug 1463919 - Add AutoplayRequest to encapsulate asking for autoplay permission. r?smaug draft
Chris Pearce <cpearce@mozilla.com> - Fri, 22 Jun 2018 11:57:24 +1200 - rev 811172
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Add AutoplayRequest to encapsulate asking for autoplay permission. r?smaug Add an implementation of nsIContentPermissionRequest to encapsulate requesting permission from the user to autoplay audible media. All documents in the tab request permission using the top level document's origin, so the AutoplayRequest instance for a tab is stored on the top level content window of the tab. AutoplayRequest ensures that there's only a single prompt shown at once. MozReview-Commit-ID: 2u3aLnEa21z
13b71ced6f0cf08eef3ba7796e5912dbfd2aa69b: Bug 1463919 - Remove dead code in browser_block_autoplay_media.js test. r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Wed, 27 Jun 2018 15:24:00 +1200 - rev 811171
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Remove dead code in browser_block_autoplay_media.js test. r?mconley eslint pointed failed with an error: browser_block_autoplay_media.js:25:7 | 'audio' is not defined. (no-undef) It turns out, the function this line resides in is never called, so we can remove it. MozReview-Commit-ID: EUe5cRwGhfA
9261e2232aa934944c01a59fe9a1ba62fd303c69: Bug 1463919 - Adjust mochitests to pass after changes. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Tue, 26 Jun 2018 15:57:17 +1200 - rev 811170
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Adjust mochitests to pass after changes. r?jya Prior to the changes in this bug, a document would request autoplay permission for its own origin, and not use the top level document's origin for the permission check. Since now we use the top level document's origin for requesting autoplay permission, some mochitests need to change, namely: * test_autoplay_policy_permission.html can use file_autoplay_policy_activation_frame.html directly. The test was failing because its helper page was loaded same origin and the helper page was testing if cross origins iframes could play; since we use the top level document's permission request, this no longer effectively tests whether the cross origin child can autoplay, as the cross origin child just uses the top level window's origin for requests. So we can instead load the helper window cross orgin instead, and remove one layers of helpers. Also an issue here is the way I was waiting for a new window to load was racy, so now we wait for loading windows to send us a "ready" message. * test_autoplay_policy_activation.html; this test's helper needs to wait for loading windows to send it a "ready" message, as its helper is shared with the above test. MozReview-Commit-ID: LvRa4G7tqFw
5ec30d2124368165db67415e56a78f1a5aca3dd9: Bug 1463919 - Call Play() when activating attribute based autoplay. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Tue, 26 Jun 2018 14:16:13 +1200 - rev 811169
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Call Play() when activating attribute based autoplay. r?jya When autoplay is requested by setting the "autoplay" attribute, we should check whether autoplay is allowed in HTMLMediaElement::CheckAutoplayDataReady() and if not we should prompt for user consent. This ensures that <video ... autoplay/> will prompt for consent when used on a page without a pre-existing allow/block permission. MozReview-Commit-ID: 77pJR2Ybn2i
e09e70e18c2c96ff027eb9a65f0f0c6ec4e8a282: Bug 1463919 - Tests for prompting for permission to autoplay. r?jya,r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Mon, 25 Jun 2018 15:35:33 +1200 - rev 811168
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Tests for prompting for permission to autoplay. r?jya,r?mconley Test that video that autoplays via a play() call or via autoplay attribute plays or is blocked or prompts with a doorhanger for approval and plays when "allow" clicked and doesn't when "block" clicked. MozReview-Commit-ID: CpftV6RQbtU
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip