b2998f106294f4e76467382dfa796f3dfafab46c: Bug 1409133 - Avoid shrinking tabs through ::before elements when moving them. r=dao
Johann Hofmann <jhofmann@mozilla.com> - Tue, 14 Nov 2017 13:09:38 +0100 - rev 702227
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1409133 - Avoid shrinking tabs through ::before elements when moving them. r=dao As mentioned in the comment: Note that this doesn't perfectly solve the issue (dragged tabs may still resize very slightly) on some DPI settings with uneven scaling factors on Windows, because of bug 477157. We consider the fix in this patch good enough for now. MozReview-Commit-ID: BbpxLVq8AEb
366c4c091bb3dba617776f06a03ac63875fa6081: Bug 1416465 - Regression tests for process_install_manifest.py. r=mshal
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sat, 18 Nov 2017 11:31:04 +0900 - rev 702226
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1416465 - Regression tests for process_install_manifest.py. r=mshal MozReview-Commit-ID: LTqTddybtrr
257de1de1304548c1dcb2c7d8c66a20d26c021e6: Bug 1417017 - Check for content. usage at global and within add_task for no-cpows-in-tests. r=standard8
Ed Lee <edilee@mozilla.com> - Tue, 14 Nov 2017 02:17:57 -0800 - rev 702225
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1417017 - Check for content. usage at global and within add_task for no-cpows-in-tests. r=standard8 MozReview-Commit-ID: Asz6dM29uRJ
2541054da0cb9f23cfa5fdf3ef08379a4696baad: Bug 1416284: Have Wait allow expected exceptions when polling. r=maja_zf
David Burns <dburns@mozilla.com> - Tue, 21 Nov 2017 22:00:08 +0000 - rev 702224
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1416284: Have Wait allow expected exceptions when polling. r=maja_zf MozReview-Commit-ID: BPHVGOOjUaQ
572a54e7cbb77c8696fc8bd20938e7c2dc4fe86a: Bug 1416284: Update WDSpec tests expectations. r=ato
David Burns <dburns@mozilla.com> - Fri, 10 Nov 2017 19:46:40 +0000 - rev 702223
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1416284: Update WDSpec tests expectations. r=ato MozReview-Commit-ID: HrikhmLgamY
35dc4a31d7559d9d504032ced72bc34a1c1fb963: Bug 1416284: Dismiss alerts when we hit an UnexpectedAlertOpen error. r=ato
David Burns <dburns@mozilla.com> - Fri, 10 Nov 2017 17:25:50 +0000 - rev 702222
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1416284: Dismiss alerts when we hit an UnexpectedAlertOpen error. r=ato The Browser Testing and Tools group agreed that the webdriver endpoint, when asserting for a modal, that it clears the modal on the screen and raises an an Unexpected Alert Open error. See https://github.com/w3c/webdriver/pull/1145 MozReview-Commit-ID: 1OnT1AMM0tY
43cc5158449ceb49e5393c4e39d1801e2e1fa00a: servo: Merge #19335 - Unbreak docs build (from servo:jdm-patch-5); r=nox
Josh Matthews <josh@joshmatthews.net> - Wed, 22 Nov 2017 06:48:10 -0600 - rev 702221
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
servo: Merge #19335 - Unbreak docs build (from servo:jdm-patch-5); r=nox Running rustdoc on gecko-media is broken right now. Source-Repo: https://github.com/servo/servo Source-Revision: 3a08f87ec89456900da4cffda1356c02b6a9b8c8
aa2c49a11df2fceba71e44082e2663467d11deb2: Bug 1405252 - Enable browser_webconsole_console_logging_workers_api.js in the new frontend; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 21 Nov 2017 09:23:31 +0100 - rev 702220
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1405252 - Enable browser_webconsole_console_logging_workers_api.js in the new frontend; r=Honza. MozReview-Commit-ID: I7b45uLfNkw
adc5486435411f41eac3c44286318a94fd53f325: Bug 1409691 - Fix initialisation of doneReason in Capture (BackgroundPageThumbs.jsm). r=Mardak
Mark Banner <standard8@mozilla.com> - Wed, 22 Nov 2017 12:35:52 +0000 - rev 702219
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1409691 - Fix initialisation of doneReason in Capture (BackgroundPageThumbs.jsm). r=Mardak MozReview-Commit-ID: G30XiYMScHr
ab201316ebfd9b985c30405df2a3eaf94fd80bac: Bug 1415908 - Intermittent failure (nsIAutoCompleteController.getCommentAt) in browser_ext_omnibox.js. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Sun, 19 Nov 2017 21:58:14 +0100 - rev 702218
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1415908 - Intermittent failure (nsIAutoCompleteController.getCommentAt) in browser_ext_omnibox.js. r=adw Fixes a timing bug where in certain moments matchCount may not be in sync with the current search status, due to previous results not being cleared immediately. Still delays tree updates to avoid UI flickering. Fixes a theorical timing issue in unifiedComplete where a stopped search could notify a result. Removes the no more used OnUpdateSearchResult API. MozReview-Commit-ID: COoIN4oQT4v
7a3e5d9764999c06e46737cf4a9dcfecc7f77d20: Bug 1405832 - part 4: ContentCacheInParent::OnEventNeedingAckHandled() shouldn't crash in release build r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 23:30:18 +0900 - rev 702217
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1405832 - part 4: ContentCacheInParent::OnEventNeedingAckHandled() shouldn't crash in release build r=m_kato For protecting main process, we should stop crashing main process in release build even when we detect our bug. However, we should keep crashing with MOZ_DIAGNOSTIC_ASSER which is enabled only on Night and Developer Edition. MozReview-Commit-ID: 5BQ46IFzXXj
3e4e219b8aebf8e439d8ac40738321d7c7c81c6f: Bug 1405832 - part 3: ContentCacheInParent::RequestIMEToCommitComposition() should call nsIWidget::NotifyIME() via TextComposition::RequestToCommit() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 23:08:37 +0900 - rev 702216
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1405832 - part 3: ContentCacheInParent::RequestIMEToCommitComposition() should call nsIWidget::NotifyIME() via TextComposition::RequestToCommit() r=m_kato Now, TextComposition::RequestToCommit() manages if it has already requested IME to commit or cancel composition and this is important for redundant requests. Therefore, ContentCacheInParent::RequestIMEToCommitComposition() shouldn't call nsIWidget::NotifyIME() directly. MozReview-Commit-ID: 69VpgyK9Jk5
e8d7881af680c693612c2ed42d3486c5ad4c8e42: Bug 1405832 - part 2: TextComposition::RequestToCommit() should request IME to commit or cancel composition only when it hasn't been request it yet and hasn't received commit event yet r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 22:59:04 +0900 - rev 702215
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1405832 - part 2: TextComposition::RequestToCommit() should request IME to commit or cancel composition only when it hasn't been request it yet and hasn't received commit event yet r=m_kato According to the log in crash reports, eCompositionCommitRequestHandled is sent to ContentCacheInParent twice or more for a composition. This causes breaking mPendingCompositionCount and mPendingEventsNeedingAck management. Currently, nsIWidget::NotifyIME() should be called only by TextComposition::RequestToCommit(). Therefore, the method should manage if it should request it actually. If the composition has already received eCompositionCommit(AsIs) event, it shouldn't request it because parent process may have already stated new composition and it shouldn't be broken by request for old composition. MozReview-Commit-ID: 2ekSa6EIeRP
21522127515146fb7742f4e52c5d4c860bc71562: Bug 1405832 - part 1: ContentCacheInParent::RequestIMEToCommitComposition() should increment mPendingEventsNeedingAck itself if it treat the request handled synchronously without actually requesting IME to commit composition r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 22:20:02 +0900 - rev 702214
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1405832 - part 1: ContentCacheInParent::RequestIMEToCommitComposition() should increment mPendingEventsNeedingAck itself if it treat the request handled synchronously without actually requesting IME to commit composition r=m_kato This is a simple bug of ContentCacheInParent. When ContentCacheInParent::RequestIMEToCommitComposition() returns true, PuppetWidget::RequestIMEToCommitComposition() will send eCompositionCommitRequestHandled pseudo event message back to the main process. This causes counting down mPendingEventsNeedingAck in ContentCacheInParent::OnEventNeedingAckHandled(). Therefore, in the normal path, ContentCacheInParent::OnCompositionEvent() increments it for receiving the pseudo event message. However, if the tab parent has already lost focus, RequestIMEToCommitComposition() returns true without requesting native IME to commit composition. So, ContentCacheInParent::OnCompositionEvent() cannot increment mPendingEventsNeedingAck for coming eCompositionCommitRequestHandled. Therefore, RequestIMEToCommitComposition() needs to increment mPendingEventsNeedingAck by itself when it won't request IME to commit composition but it returns true. MozReview-Commit-ID: 4Alwfy8avB
e55035922259c5449c4004f23b87efe307c2606b: Bug 1381648 - Add non blocking time to the statistics panel of netmonitor; r=Honza
Vincent Lequertier <vi.le@autistici.org> - Fri, 06 Oct 2017 15:11:18 +0200 - rev 702213
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1381648 - Add non blocking time to the statistics panel of netmonitor; r=Honza MozReview-Commit-ID: Anw4hTlpPjH
dd5e0428476bb0dca53741e305db1c515513257b: Bug 1408401 - Release: Bump up devtools-reps bundle to 0.15.0; r=miker
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 21 Nov 2017 18:44:04 +0100 - rev 702212
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1408401 - Release: Bump up devtools-reps bundle to 0.15.0; r=miker MozReview-Commit-ID: ISudQK3C20A
84b90d871c2c14c24356f2840b5bbe9413a5e729: servo: Merge #19332 - moving :dir() param serialization FIXME (from wilsoniya:moving-fixme); r=emilio
Michael Wilson <wilsoniya@gmail.com> - Wed, 22 Nov 2017 04:04:39 -0600 - rev 702211
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
servo: Merge #19332 - moving :dir() param serialization FIXME (from wilsoniya:moving-fixme); r=emilio <!-- Please describe your changes on the following line: --> Per emilio's comment, https://github.com/servo/servo/pull/19195#discussion_r152205644, a `FIXME` regarding `:dir()` parameter serialization has been moved. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they only modify comment lines <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 3ecd0174cc7817cdd2007850c29b8b069a845b46
af8727e2028e660aa0f7525c0e1c784d8edafff7: Bug 1419456 - Disable full CSD support for XFCE as it does not support GDK_DECOR_BORDER, r=jhorak
Martin Stransky <stransky@redhat.com> - Tue, 21 Nov 2017 20:03:21 +0100 - rev 702210
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1419456 - Disable full CSD support for XFCE as it does not support GDK_DECOR_BORDER, r=jhorak MozReview-Commit-ID: BFOgxJ3abrT
b4a1ab50128ef069d2a1853c9f6ad462a1f7161d: Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks; r=smaug
Edgar Chen <echen@mozilla.com> - Tue, 03 Oct 2017 17:22:58 +0800 - rev 702209
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks; r=smaug Attribute changed callback now is fired only when the attribute is in observedAttributes list which is introduced in latest spec, so in this patch, we change the tests for attribute changed callback to use customElements.define() to register customElements definition instead. MozReview-Commit-ID: 2s1qj3UsFUS
18f77ef35a2231f8fa2d4ba37e3e5c7d3cbee469: Bug 1419665 - Support babel object-rest-spread syntax for launchpad r=Honza
Ricky Chien <ricky060709@gmail.com> - Wed, 22 Nov 2017 15:00:48 +0800 - rev 702208
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1419665 - Support babel object-rest-spread syntax for launchpad r=Honza MozReview-Commit-ID: JC6vWNMp3a7
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip