b25eb3712d90fcd87d5c0bcb5d572f89344f1f00: Bug 1399111 - Tabs that start loading in the background and haven't been selected before completing loading will show a lighter tab burst. r?gijs draft
Jared Wein <jwein@mozilla.com> - Wed, 27 Sep 2017 14:34:29 -0400 - rev 672248
Push 82203 by bmo:jaws@mozilla.com at Thu, 28 Sep 2017 23:26:44 +0000
Bug 1399111 - Tabs that start loading in the background and haven't been selected before completing loading will show a lighter tab burst. r?gijs MozReview-Commit-ID: FdXwaQr7Glt
21a3f6751fd65dee11796644ac073c006cc17432: Bug 1402151, part 9 - Implement gtest for FTP directory listing parsing. r=michal draft
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 11:19:33 -0700 - rev 672247
Push 82202 by bmo:continuation@gmail.com at Thu, 28 Sep 2017 23:25:40 +0000
Bug 1402151, part 9 - Implement gtest for FTP directory listing parsing. r=michal This test turns the existing stand alone test for the FTP directory listing parser into a gtest. MozReview-Commit-ID: 7n60TfcTXTJ
3f24da16bd488bacae8f946b189611a89d4b57d8: Bug 1402151, part 8 - Add an argument to ParseFTPList to return the current time. r=michal draft
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 13:27:09 -0700 - rev 672246
Push 82202 by bmo:continuation@gmail.com at Thu, 28 Sep 2017 23:25:40 +0000
Bug 1402151, part 8 - Add an argument to ParseFTPList to return the current time. r=michal If the year is omitted from a listing, then the parsing code assumes that the date occurred within the last year. To compute what the year should be, the code thus needs to know what the current year, month and day are. This patch parameterizes ParseFTPList over a function that returns a PRTime. This will allow the gtest to pass in a fixed time. Firefox itself will continue to use PR_Now to get the current time. MozReview-Commit-ID: 8IbVWbUBHYs
43bdcf89a5d1bad40ac5898c75a211dc01feb214: Bug 1402151, part 7 - Add a time zone argument to ParseFTPList. r=michal draft
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 11:45:27 -0700 - rev 672245
Push 82202 by bmo:continuation@gmail.com at Thu, 28 Sep 2017 23:25:40 +0000
Bug 1402151, part 7 - Add a time zone argument to ParseFTPList. r=michal In a few places, the FTP parser needs to know the time zone and daylight savings time correction, encapsulated in PRTimeParamFn. Before this patch, it would use the time zone of the current machine, which would obviously make automated testing difficult. This patch allows a caller to pass in a PRTimeParamFn, which will allow the gtest to use GMT instead of whatever the local time is. MozReview-Commit-ID: 81R3Zbndr43
5f17b01af40de27579f322d13f79219cf3e90beb: Bug 1402151, part 6 - Manual fixups for times in E-EPLF.out. r=michal draft
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 12:53:01 -0700 - rev 672244
Push 82202 by bmo:continuation@gmail.com at Thu, 28 Sep 2017 23:25:40 +0000
Bug 1402151, part 6 - Manual fixups for times in E-EPLF.out. r=michal After the automatic fixes in the previous patch, a few of the times in late March and early April are still off by an hour. Maybe this was affected by the changes in when daylight savings time or some bug in my conversion script. I have no idea. This patch just fixes the test to match the actual output. MozReview-Commit-ID: IghWfkWfxvi
a6af7e69d34ba92c2e9eeeb2aafb3b32d7c28002: Bug 1402151, part 5 - Adjust E-EPLF.out from Paris time to GMT. r=michal draft
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 12:50:35 -0700 - rev 672243
Push 82202 by bmo:continuation@gmail.com at Thu, 28 Sep 2017 23:25:40 +0000
Bug 1402151, part 5 - Adjust E-EPLF.out from Paris time to GMT. r=michal The dates in the input for this file are specified as seconds since Jan 1, 1970 or whenever. The conversion to a normal date depends on the current time zone. The original output seems to have been generated using GMT+1, with adjustments for daylight savings time at the appropriate parts of the year. To make this easier to test, this patch changes all of the times to GMT, without any daylight savings time adjustment. This change was automatically created by the Python script attached to the bug. MozReview-Commit-ID: 3uSAGtJYsMW
3bf08855521e0faa64bb36be8d58366d539c2d1f: Bug 1402151, part 4 - Fix some FTP parser tests. r=michal draft
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 11:26:18 -0700 - rev 672242
Push 82202 by bmo:continuation@gmail.com at Thu, 28 Sep 2017 23:25:40 +0000
Bug 1402151, part 4 - Fix some FTP parser tests. r=michal D-WinNT: The parser treats <JUNCTION> without an arrow as junk for some reason. Chrome's FTP directory listing parser doesn't seem to support <JUNCTION> at all, so it can't be too important. I just deleted that from the expected output to match Firefox's current behavior. I also added basic tests for three bugs that were fixed without any tests landed. E-EPLF.out: Add a license to the top. U-WinNT.out: We're not testing junk or comment output, and we don't use the list: prefix, so remove all of those. Also, we now output the proper year (2000 instead of 00, for instance), so fix that in the test output. Finally, the time in the output for this test is formatted differently, for whatever reason, so change it to match the actual output. V-VMS-mix.out: Fix file sizes. File sizes on VMS can only be approximated. When the FTP tests initially landed in 2002, this was handled by not trying. Bug 22299 landed in 2003 and changed our behavior to approximate the size, but the tests were not updated. MozReview-Commit-ID: 1DVfBfHh82y
356b610c410a959453e2213f11e4bff42eb6bca3: Bug 1402151, part 3 - Move parse-ftp unit tests into the gtest directory. r=michal draft
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 10:58:11 -0700 - rev 672241
Push 82202 by bmo:continuation@gmail.com at Thu, 28 Sep 2017 23:25:40 +0000
Bug 1402151, part 3 - Move parse-ftp unit tests into the gtest directory. r=michal This will make them easier to access from a gtest. MozReview-Commit-ID: 3lV4DwTosXT
e47d376e07d295ea1f874a4e60c0870fd3935fee: Bug 1402151, part 2 - Clamp the number of blocks for a VMS file. r=michal draft
Andrew McCreight <continuation@gmail.com> - Thu, 28 Sep 2017 09:32:48 -0700 - rev 672240
Push 82202 by bmo:continuation@gmail.com at Thu, 28 Sep 2017 23:25:40 +0000
Bug 1402151, part 2 - Clamp the number of blocks for a VMS file. r=michal strtoul returns an |unsigned long|, and clamps the return value to ULONG_MAX if the input is out of range. This means that the value returned for large numbers differs between 32-bit and 64-bit systems. To make testing easier, this patch clamps the return value to UINT32_MAX, ensuring that 32-bit and 64-bit builds of Firefox will be consistent. Explicitly declaring that the intermediate value numBlocks is a uint64_t also avoids (well-defined) integer overflow in the case of a large file. This patch also changes PRId64 to PRIu64, because the value being printed is unsigned. However, this should not make a difference in practice, because, with clamping, the maximum value being printed is |UINT32_MAX * 512|. I also cleaned up the comment that was a little garbled and contained information about both the old and new ways this was handled, and removed some code that has been ifdef'd out for at least 14 years. MozReview-Commit-ID: HELmWmtx24O
1a7cb266083daec1a3452d8b11557ac68aa904ab: Bug 1402151, part 1 - Improve handling of two digit years. r=michal draft
Andrew McCreight <continuation@gmail.com> - Thu, 21 Sep 2017 16:34:07 -0700 - rev 672239
Push 82202 by bmo:continuation@gmail.com at Thu, 28 Sep 2017 23:25:40 +0000
Bug 1402151, part 1 - Improve handling of two digit years. r=michal The tm_year field of PRExplodedTime is an absolute year, not years since 1900, so fix a few places that try to do the latter. I also made the conversion of 2 digit years more consistent. MozReview-Commit-ID: GetS2wmXHhA
02dcf9e6d7cb4132b44959b417ef592d6e3a1356: Bug 1396151: Remove fuzzy on macOS for backgr_layers-opacity.html -- no longer needed. draft
Brad Werth <bwerth@mozilla.com> - Tue, 26 Sep 2017 12:25:29 -0700 - rev 672238
Push 82201 by bwerth@mozilla.com at Thu, 28 Sep 2017 23:15:09 +0000
Bug 1396151: Remove fuzzy on macOS for backgr_layers-opacity.html -- no longer needed. MozReview-Commit-ID: KTuKUZDVsDm
6626748ec708f76205ebee95d51c9b3c4c40c5fc: Bug 1400457 - Part 2: Create new D3D11Device for WebVR draft
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Mon, 28 Aug 2017 15:56:43 -0700 - rev 672237
Push 82200 by kgilbert@mozilla.com at Thu, 28 Sep 2017 23:09:14 +0000
Bug 1400457 - Part 2: Create new D3D11Device for WebVR - As we are creating a separate VR process in Bug 1362578, we will need our own D3D11Device. - Eventually, we will be allowing the VR device runtimes to help select the appropriate adapter / device based on the physical connection. This function will be updated at that time. MozReview-Commit-ID: EewUkNxU3BI
143610c742812e22a025a064c681e0aa54ed6e1a: Bug 1400457 - Part 1: Isolate VR Rendering from Compositor draft
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Fri, 21 Jul 2017 17:30:34 -0700 - rev 672236
Push 82200 by kgilbert@mozilla.com at Thu, 28 Sep 2017 23:09:14 +0000
Bug 1400457 - Part 1: Isolate VR Rendering from Compositor - WebVR is no longer dependent on PTexture, TextureParent, TextureHost, and TextureChild. It continues to use TextureClient for pooling and coordinating locks with other Gecko code. - PreserveDrawingBuffer now behaving correctly for 2d display mirroring - Preparation for separating to VR process MozReview-Commit-ID: 2RGOulCInSu
2d45577392930a9679db245d7b4eb673e0a91d3d: Bug 1403279 - Set U2F version field on RegisterResponse r?keeler draft
J.C. Jones <jjones@mozilla.com> - Thu, 28 Sep 2017 16:04:10 -0700 - rev 672235
Push 82199 by bmo:jjones@mozilla.com at Thu, 28 Sep 2017 23:05:31 +0000
Bug 1403279 - Set U2F version field on RegisterResponse r?keeler The U2F specification defines the RegisterResponse.Version field as being set to "U2F_V2" [1] on successful registrations, which we appear to have overlooked. This sets the field and adds a few checks to the register test. [1] https://www.fidoalliance.org/specs/fido-u2f-v1.1-id-20160915/fido-u2f-javascript-api-v1.1-id-20160915.html#dictionary-u2fregisterrequest-members MozReview-Commit-ID: 9YqhM0x9itd
6dea0ee45b66b850c1ec62301724a67db901f81a: Merge autoland to central, a=merge
Wes Kocher <wkocher@mozilla.com> - Thu, 28 Sep 2017 15:49:14 -0700 - rev 672234
Push 82199 by bmo:jjones@mozilla.com at Thu, 28 Sep 2017 23:05:31 +0000
Merge autoland to central, a=merge MozReview-Commit-ID: LTZmzqpIUXI
76bcd22080322a7f4eb149b0abbed0c108558b0f: Bug 1404147 Fix up lengths draft
Tom Ritter <tom@mozilla.com> - Thu, 28 Sep 2017 18:01:58 -0500 - rev 672233
Push 82198 by bmo:tom@mozilla.com at Thu, 28 Sep 2017 23:03:25 +0000
Bug 1404147 Fix up lengths MozReview-Commit-ID: Cpo5Gd1puzd
2361b678b3725958749296c15ea1fec1295cd91d: Bug 1404147 Make thread id unsigned draft
Tom Ritter <tom@mozilla.com> - Thu, 28 Sep 2017 17:57:52 -0500 - rev 672232
Push 82198 by bmo:tom@mozilla.com at Thu, 28 Sep 2017 23:03:25 +0000
Bug 1404147 Make thread id unsigned MozReview-Commit-ID: KLXOaEjOPTr
a1302126fe6cf3cef1c937b8860a92bd6fcb2516: Bug 1404147 Resolve inconsistency between GetLastError (DWORD - unsigned) and HRESULT (signed) draft
Tom Ritter <tom@mozilla.com> - Thu, 28 Sep 2017 17:50:52 -0500 - rev 672231
Push 82198 by bmo:tom@mozilla.com at Thu, 28 Sep 2017 23:03:25 +0000
Bug 1404147 Resolve inconsistency between GetLastError (DWORD - unsigned) and HRESULT (signed) MozReview-Commit-ID: AzyiFjAG5Wt
daefefa9e76537dfe4f6a09de158581a01dfe965: Bug 1404147 Cast constants to the type they are compared to draft
Tom Ritter <tom@mozilla.com> - Thu, 28 Sep 2017 17:47:43 -0500 - rev 672230
Push 82198 by bmo:tom@mozilla.com at Thu, 28 Sep 2017 23:03:25 +0000
Bug 1404147 Cast constants to the type they are compared to MozReview-Commit-ID: JQDZTBOALZm
4e25429e951fddd27d3a2cf6f47ae6f91a52046c: Bug 1404147 Fix signed/unsigned comparison of uints draft
Tom Ritter <tom@mozilla.com> - Thu, 28 Sep 2017 17:45:46 -0500 - rev 672229
Push 82198 by bmo:tom@mozilla.com at Thu, 28 Sep 2017 23:03:25 +0000
Bug 1404147 Fix signed/unsigned comparison of uints MozReview-Commit-ID: 7z3JocWOrW5
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip