aefbea99383a127f3bcb457d4767c756f9509399: Bug 1387092 - Add support for proxyType "direct".
draft
Henrik Skupin <mail@hskupin.info> - Fri, 11 Aug 2017 11:55:51 +0200 - rev 644781
Push
73551 by bmo:hskupin@gmail.com at Fri, 11 Aug 2017 10:35:47 +0000
Bug 1387092 - Add support for proxyType "direct".
The webdriver spec has been updated a while ago and renamed the proxyType
for not using a proxy from "noProxy" to "direct".
MozReview-Commit-ID: FjDIK8XCba8
168d7a0f5bd76db51ed6dca2b14e42c3688d4b07: Bug 1387092 - Fix geckodriver tests for removed Marionette fallback prefs.
draft
Henrik Skupin <mail@hskupin.info> - Fri, 11 Aug 2017 10:39:00 +0200 - rev 644780
Push
73551 by bmo:hskupin@gmail.com at Fri, 11 Aug 2017 10:35:47 +0000
Bug 1387092 - Fix geckodriver tests for removed Marionette fallback prefs.
MozReview-Commit-ID: 3N7N1UTg0lu
8dba4ddd4657d3ce2303968db73ca9d4ffc2d6d0: Bug 1387092 - Read capabilities off top-level object. r=whimboo
draft
Henrik Skupin <mail@hskupin.info> - Fri, 11 Aug 2017 11:06:15 +0200 - rev 644779
Push
73551 by bmo:hskupin@gmail.com at Fri, 11 Aug 2017 10:35:47 +0000
Bug 1387092 - Read capabilities off top-level object. r=whimboo
geckodriver sends capabilities as a JSON Object in the body of the
command, like this:
[0,1,"newSession",{"acceptInsecureCerts":true}]
With https://bugzil.la/1387380 we wanted the Marionette Python client
to match this behaviour, however the patch overlooked the fact that
the server reads cmd.parameters.capabilities, meaning it looks for a
"capabilities" field on this object instead of treating the object as
the dictionary of capabilities.
As a follow-up to that bug, this patch removes the ability to override
the session ID by specifying a "sessionId" field. This functionality
was only used for in-app restart tests. When Firefox restarts, the
Marionette session is arguably not the same, and sessions should not
live on between restarts.
This patch will fix capabilities passed from geckodriver and align the
Marionette Python client.
For backwards compatibility reasons, it needs to be possible to use the
Python client with older Firefoxen that reads cmd.parameters.capabilities
instead of cmd.parameters. This is why we duplicate the capabilities
object, like geckodriver does.
MozReview-Commit-ID: DCpaxl9hOLe
536ab65f404fc82b427fa1a37a74e5496251707c: Bug 1387092 - Add support for proxyType "direct".
draft
Henrik Skupin <mail@hskupin.info> - Fri, 11 Aug 2017 11:55:51 +0200 - rev 644778
Push
73550 by bmo:hskupin@gmail.com at Fri, 11 Aug 2017 10:34:43 +0000
Bug 1387092 - Add support for proxyType "direct".
The webdriver spec has been updated a while ago and renamed the proxyType
for not using a proxy from "noProxy" to "direct".
MozReview-Commit-ID: FjDIK8XCba8
5316853271762dce6e8296ee44e92370d05ea38e: Bug 1387092 - Fix geckodriver tests for removed Marionette fallback prefs.
draft
Henrik Skupin <mail@hskupin.info> - Fri, 11 Aug 2017 10:39:00 +0200 - rev 644777
Push
73550 by bmo:hskupin@gmail.com at Fri, 11 Aug 2017 10:34:43 +0000
Bug 1387092 - Fix geckodriver tests for removed Marionette fallback prefs.
MozReview-Commit-ID: 3N7N1UTg0lu
c75a2e6439ac0f5371fadbe2602e927e8bbecb88: Bug 1388424 - Read capabilities off top-level object. r=whimboo
draft
Henrik Skupin <mail@hskupin.info> - Fri, 11 Aug 2017 11:06:15 +0200 - rev 644776
Push
73550 by bmo:hskupin@gmail.com at Fri, 11 Aug 2017 10:34:43 +0000
Bug 1388424 - Read capabilities off top-level object. r=whimboo
geckodriver sends capabilities as a JSON Object in the body of the
command, like this:
[0,1,"newSession",{"acceptInsecureCerts":true}]
With https://bugzil.la/1387380 we wanted the Marionette Python client
to match this behaviour, however the patch overlooked the fact that
the server reads cmd.parameters.capabilities, meaning it looks for a
"capabilities" field on this object instead of treating the object as
the dictionary of capabilities.
As a follow-up to that bug, this patch removes the ability to override
the session ID by specifying a "sessionId" field. This functionality
was only used for in-app restart tests. When Firefox restarts, the
Marionette session is arguably not the same, and sessions should not
live on between restarts.
This patch will fix capabilities passed from geckodriver and align the
Marionette Python client.
For backwards compatibility reasons, it needs to be possible to use the
Python client with older Firefoxen that reads cmd.parameters.capabilities
instead of cmd.parameters. This is why we duplicate the capabilities
object, like geckodriver does.
MozReview-Commit-ID: DCpaxl9hOLe
2d909ec24205e52e97a1d93829cbb89fea8a1a53: Bug 1388985 - Use GetBBox to calcute the area of frame(s) that clip-path basic-shape should apply to. r?cjku
draft
Louis Chang <lochang@mozilla.com> - Fri, 11 Aug 2017 18:33:34 +0800 - rev 644775
Push
73549 by lochang@mozilla.com at Fri, 11 Aug 2017 10:34:27 +0000
Bug 1388985 - Use GetBBox to calcute the area of frame(s) that clip-path basic-shape should apply to. r?cjku
MozReview-Commit-ID: 4pJnxSy6GQO
cb9e7abeaee84aaafa64f4da6169befa5ab93d49: Bug Part 1 - Add BBoxFlags::eIncludeOnlyCurrentFrameForNonSVGElement to determine whether include all continuations while computing bbox of a html frame.
draft
Louis Chang <lochang@mozilla.com> - Fri, 11 Aug 2017 18:19:47 +0800 - rev 644774
Push
73549 by lochang@mozilla.com at Fri, 11 Aug 2017 10:34:27 +0000
Bug Part 1 - Add BBoxFlags::eIncludeOnlyCurrentFrameForNonSVGElement to determine whether include all continuations while computing bbox of a html frame.
MozReview-Commit-ID: Fx11LjhBcrM
5d0d64cc122d84c03ed5598b7c21fe0a6f82dd59: Bug 1387956 - Overhaul ComputedValues measurement, and add style structs measurement. r?bholley.
draft
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 11 Aug 2017 16:37:33 +1000 - rev 644773
Push
73548 by nnethercote@mozilla.com at Fri, 11 Aug 2017 10:33:36 +0000
Bug 1387956 - Overhaul ComputedValues measurement, and add style structs measurement. r?bholley.
This patch moves measurement of ComputedValues objects from Rust to C++.
Measurement now happens (a) via DOM elements and (b) remaining elements via
the frame tree. Likewise for the style structs hanging off ComputedValues
objects.
Here is an example of the output.
> ├──27,600,448 B (26.49%) -- active/window(https://en.wikipedia.org/wiki/Barack_Obama)
> │ ├──12,772,544 B (12.26%) -- layout
> │ │ ├───4,483,744 B (04.30%) -- frames
> │ │ │ ├──1,653,552 B (01.59%) ── nsInlineFrame
> │ │ │ ├──1,415,760 B (01.36%) ── nsTextFrame
> │ │ │ ├────431,376 B (00.41%) ── nsBlockFrame
> │ │ │ ├────340,560 B (00.33%) ── nsHTMLScrollFrame
> │ │ │ ├────302,544 B (00.29%) ── nsContinuingTextFrame
> │ │ │ ├────156,408 B (00.15%) ── nsBulletFrame
> │ │ │ ├─────73,024 B (00.07%) ── nsPlaceholderFrame
> │ │ │ ├─────27,656 B (00.03%) ── sundries
> │ │ │ ├─────23,520 B (00.02%) ── nsTableCellFrame
> │ │ │ ├─────16,704 B (00.02%) ── nsImageFrame
> │ │ │ ├─────15,488 B (00.01%) ── nsTableRowFrame
> │ │ │ ├─────13,776 B (00.01%) ── nsTableColFrame
> │ │ │ └─────13,376 B (00.01%) ── nsTableFrame
> │ │ ├───3,412,192 B (03.28%) -- servo-style-structs
> │ │ │ ├──1,288,224 B (01.24%) ── Display
> │ │ │ ├────742,400 B (00.71%) ── Position
> │ │ │ ├────308,736 B (00.30%) ── Font
> │ │ │ ├────226,512 B (00.22%) ── Background
> │ │ │ ├────218,304 B (00.21%) ── TextReset
> │ │ │ ├────214,896 B (00.21%) ── Text
> │ │ │ ├────130,560 B (00.13%) ── Border
> │ │ │ ├─────81,408 B (00.08%) ── UIReset
> │ │ │ ├─────61,440 B (00.06%) ── Padding
> │ │ │ ├─────38,176 B (00.04%) ── UserInterface
> │ │ │ ├─────29,232 B (00.03%) ── Margin
> │ │ │ ├─────21,824 B (00.02%) ── sundries
> │ │ │ ├─────20,080 B (00.02%) ── Color
> │ │ │ ├─────20,080 B (00.02%) ── Column
> │ │ │ └─────10,320 B (00.01%) ── Effects
> │ │ ├───2,227,680 B (02.14%) -- computed-values
> │ │ │ ├──1,182,928 B (01.14%) ── non-dom
> │ │ │ └──1,044,752 B (01.00%) ── dom
> │ │ ├───1,500,016 B (01.44%) ── text-runs
> │ │ ├─────492,640 B (00.47%) ── line-boxes
> │ │ ├─────326,688 B (00.31%) ── frame-properties
> │ │ ├─────301,760 B (00.29%) ── pres-shell
> │ │ ├──────27,648 B (00.03%) ── pres-contexts
> │ │ └─────────176 B (00.00%) ── style-sets
The 'servo-style-structs' and 'computed-values' sub-trees are new. (Prior to
this patch, ComputedValues under DOM elements were tallied under the the
'dom/element-nodes' sub-tree, and ComputedValues not under DOM element were
ignored.) 'servo-style-structs/sundries' aggregates all the style structs that
are smaller than 8 KiB.
Other notable things done by the patch are as follows.
- It significantly changes the signatures of the methods measuring nsINode and
its subclasses, in order to handle the tallying of style structs separately
from element-nodes. Likewise for nsIFrame.
- It renames the 'layout/style-structs' sub-tree as
'layout/gecko-style-structs', to clearly distinguish it from the new
'layout/servo-style-structs' sub-tree.
- It adds some FFI functions to access various Rust-side data structures from
C++ code.
- There is a nasty hack used twice to measure Arcs, by stepping backwards from
an interior pointer to a base pointer. It works, but I want to replace it
with something better eventually. The "XXX WARNING" comments have details.
- It makes DMD print a line to the console if it sees a pointer it doesn't
recognise. This is useful for detecting when we are measuring an interior
pointer instead of a base pointer, which is bad but easy to do when Arcs are
involved.
- It removes the Rust code for measuring CVs, because it's now all done on the
C++ side.
* * *
[mq]: realign
MozReview-Commit-ID: BKebACLKtCi
bc31d31381670bbf484215cf7f269f6d8c6e003c: Bug 1385222 - Add the search functionality in the sitePermissions.xul dialog. r?johannh
draft
Prathiksha <prathikshaprasadsuman@gmail.com> - Tue, 08 Aug 2017 12:19:47 +0530 - rev 644772
Push
73547 by bmo:prathikshaprasadsuman@gmail.com at Fri, 11 Aug 2017 10:21:58 +0000
Bug 1385222 - Add the search functionality in the sitePermissions.xul dialog. r?johannh
MozReview-Commit-ID: JFkZPfL0hJl
e43ca2cc790ce90f160c700d77753d869ea04472: Bug 1389227 - Avoid accessing invalid array index in vr controllers when stopping vibrate; r?kip
draft
Daosheng Mu <daoshengmu@gmail.com> - Fri, 11 Aug 2017 18:10:29 +0800 - rev 644771
Push
73546 by bmo:dmu@mozilla.com at Fri, 11 Aug 2017 10:19:55 +0000
Bug 1389227 - Avoid accessing invalid array index in vr controllers when stopping vibrate; r?kip
MozReview-Commit-ID: NR5FLllABm
4be01797345bae00bdeedd196b4e4b26912de04d: Bug 1385745 Part 3 - Add test cases for box-decoration-break.
draft
Louis Chang <lochang@mozilla.com> - Fri, 11 Aug 2017 18:06:17 +0800 - rev 644770
Push
73545 by lochang@mozilla.com at Fri, 11 Aug 2017 10:06:46 +0000
Bug 1385745 Part 3 - Add test cases for box-decoration-break.
MozReview-Commit-ID: H0uLtr1O1Im
7876be4444bb66b6099ecc1c28b5ce2e598ed478: Bug 1385745 Part 2 - Check if aFirstContinuation is the first frame of current frame.
draft
Louis Chang <lochang@mozilla.com> - Fri, 11 Aug 2017 18:05:46 +0800 - rev 644769
Push
73545 by lochang@mozilla.com at Fri, 11 Aug 2017 10:06:46 +0000
Bug 1385745 Part 2 - Check if aFirstContinuation is the first frame of current frame.
MozReview-Commit-ID: 6NxjfT7SVQD
56bbdd0d6c4fe04a5d40818d4f1fdd4eaa4baba5: Bug 1389165 - Hide caption when no data for table in about:telemetry r?gfritzsche
draft
flyingrub <flyinggrub@gmail.com> - Fri, 11 Aug 2017 11:27:12 +0200 - rev 644768
Push
73544 by bmo:flyinggrub@gmail.com at Fri, 11 Aug 2017 10:05:52 +0000
Bug 1389165 - Hide caption when no data for table in about:telemetry r?gfritzsche
MozReview-Commit-ID: 7wO2VisFyzI
c5878ca721f526ded7a61dad5df096c5bd0db62c: Bug 1388494 - Fix 'undefined' text issue after you clicked "Ignore this warning".
draft
Henry Chang <hchang@mozilla.com> - Fri, 11 Aug 2017 17:18:58 +0800 - rev 644767
Push
73543 by hchang@mozilla.com at Fri, 11 Aug 2017 10:02:56 +0000
Bug 1388494 - Fix 'undefined' text issue after you clicked "Ignore this warning".
MozReview-Commit-ID: CLb1lVsybEg
1e7d7312ed2dd92af10ac089762926d85adbfaca: Bug 1387092 - Add support for proxyType "direct".
draft
Henrik Skupin <mail@hskupin.info> - Fri, 11 Aug 2017 11:55:51 +0200 - rev 644766
Push
73542 by bmo:hskupin@gmail.com at Fri, 11 Aug 2017 10:02:31 +0000
Bug 1387092 - Add support for proxyType "direct".
The webdriver spec has been updated a while ago and renamed the proxyType
for not using a proxy from "noProxy" to "direct".
MozReview-Commit-ID: FjDIK8XCba8
fe3533bbc6a023ebcc0af197685c699498fa37a6: Bug 1387092 - Fix geckodriver tests for removed Marionette fallback prefs.
draft
Henrik Skupin <mail@hskupin.info> - Fri, 11 Aug 2017 10:39:00 +0200 - rev 644765
Push
73542 by bmo:hskupin@gmail.com at Fri, 11 Aug 2017 10:02:31 +0000
Bug 1387092 - Fix geckodriver tests for removed Marionette fallback prefs.
MozReview-Commit-ID: 3N7N1UTg0lu
1d6c11d4debf1c974bf3268a6900a6c88f8a5f06: Bug 1387092 - Temporary until bug 1388424 is fixed.
draft
Henrik Skupin <mail@hskupin.info> - Fri, 11 Aug 2017 11:06:15 +0200 - rev 644764
Push
73542 by bmo:hskupin@gmail.com at Fri, 11 Aug 2017 10:02:31 +0000
Bug 1387092 - Temporary until
bug 1388424 is fixed.
MozReview-Commit-ID: F1NqMkprVUF
1765f35410f99b2bb463b650ce1da4796cf9ec86: Bug 1381401 - Add location, camera and microphone permissions along with their settings under the 'Permissions' heading in Firefox Preferences. r?johannh
draft
Prathiksha <prathikshaprasadsuman@gmail.com> - Sun, 30 Jul 2017 13:06:49 +0530 - rev 644763
Push
73541 by bmo:prathikshaprasadsuman@gmail.com at Fri, 11 Aug 2017 10:01:57 +0000
Bug 1381401 - Add location, camera and microphone permissions along with their settings under the 'Permissions' heading in Firefox Preferences. r?johannh
MozReview-Commit-ID: PdcUyUKAcN
706f8f7329cfee6f1aa6ae123adb4a08403672ee: Bug 1388348 - Use ch unit to set the width of search input to match Photon visual spec and avoid the long string issue.
draft
Evan Tseng <evan@tseng.io> - Wed, 09 Aug 2017 15:18:24 +0800 - rev 644762
Push
73540 by bmo:evan@tseng.io at Fri, 11 Aug 2017 10:01:33 +0000
Bug 1388348 - Use ch unit to set the width of search input to match Photon visual spec and avoid the long string issue.
MozReview-Commit-ID: LQ1Iq64LXcl