ab98657dbd7c35f190b1a6b40b2d8f378372c434: Bug 1460929 - code coverage no longer use _exit on exit draft
Raymond FOrbes <rforbes@mozilla.com> - Fri, 11 May 2018 15:53:22 -0700 - rev 794434
Push 109694 by bmo:rforbes@mozilla.com at Sat, 12 May 2018 06:54:29 +0000
Bug 1460929 - code coverage no longer use _exit on exit MozReview-Commit-ID: HtI4hC97dOK
4d104127c38b52c2b49a681375bd6f2282c6bca3: Bug 1461062: Part 2 - Remove dead code. r?aswan draft
Kris Maglione <maglione.k@gmail.com> - Fri, 11 May 2018 21:44:46 -0700 - rev 794433
Push 109693 by maglione.k@gmail.com at Sat, 12 May 2018 04:45:45 +0000
Bug 1461062: Part 2 - Remove dead code. r?aswan MozReview-Commit-ID: GgVkfO25tdt
d608b0559d11f74e07f8a86ff0bda16124d3efa2: Bug 1461062: Refactor bootstrap lifecycle management to be somewhat maintainable. r?aswan draft
Kris Maglione <maglione.k@gmail.com> - Fri, 11 May 2018 20:40:31 -0700 - rev 794432
Push 109693 by maglione.k@gmail.com at Sat, 12 May 2018 04:45:45 +0000
Bug 1461062: Refactor bootstrap lifecycle management to be somewhat maintainable. r?aswan MozReview-Commit-ID: 8OQhjqxzKYP
d341989e8815d3f8a8038f4dacd88dcb1d69c533: Bug 1461062: Refactor bootstrap lifecycle management to be somewhat maintainable. r?aswan draft
Kris Maglione <maglione.k@gmail.com> - Fri, 11 May 2018 20:40:31 -0700 - rev 794431
Push 109692 by maglione.k@gmail.com at Sat, 12 May 2018 03:44:01 +0000
Bug 1461062: Refactor bootstrap lifecycle management to be somewhat maintainable. r?aswan MozReview-Commit-ID: 8OQhjqxzKYP
7bdfa97fda86b4b47acf74103c67fbcfa2ae108b: Bug 1461045: Remove unused AddonInternal.bootstrap flag. r?aswan draft
Kris Maglione <maglione.k@gmail.com> - Fri, 11 May 2018 17:58:45 -0700 - rev 794430
Push 109692 by maglione.k@gmail.com at Sat, 12 May 2018 03:44:01 +0000
Bug 1461045: Remove unused AddonInternal.bootstrap flag. r?aswan MozReview-Commit-ID: 8NKCZaq0dVc
ad6caf1d4d23bc139562493ffbb8c0f199ed0b30: Bug 1385057: Remove most code for handling unpacked side-loaded extensions. r=aswan,keeler
Kris Maglione <maglione.k@gmail.com> - Wed, 09 May 2018 16:04:04 -0700 - rev 794429
Push 109692 by maglione.k@gmail.com at Sat, 12 May 2018 03:44:01 +0000
Bug 1385057: Remove most code for handling unpacked side-loaded extensions. r=aswan,keeler MozReview-Commit-ID: H4cSRBws4Ml
91f9e23430b3f41bcc6cd3647864d9856930561a: Bug 1457243 - Fix flake8. r=me, test-only DONTBUILD CLOSED TREE
Eric Rahm <erahm@mozilla.com> - Fri, 11 May 2018 18:04:17 -0700 - rev 794428
Push 109692 by maglione.k@gmail.com at Sat, 12 May 2018 03:44:01 +0000
Bug 1457243 - Fix flake8. r=me, test-only DONTBUILD CLOSED TREE
fc2a54e08dae7cadc7b0566e0abb76830270a428: Bug 1461056 - Remove the "remoteBreakpad" symbol rule, because it's no longer needed. r?dthayer draft
Markus Stange <mstange@themasta.com> - Fri, 11 May 2018 23:18:44 -0400 - rev 794427
Push 109691 by bmo:mstange@themasta.com at Sat, 12 May 2018 03:19:23 +0000
Bug 1461056 - Remove the "remoteBreakpad" symbol rule, because it's no longer needed. r?dthayer MozReview-Commit-ID: 6c2hWCtZ0UH
1465950b4316b51d56423c60c2011f7de0f36d39: Bug 1461053 - Treat SP marker frames as their own kind, instead of lumping them together with label frames. r?njn draft
Markus Stange <mstange@themasta.com> - Fri, 11 May 2018 23:10:34 -0400 - rev 794426
Push 109690 by bmo:mstange@themasta.com at Sat, 12 May 2018 03:10:58 +0000
Bug 1461053 - Treat SP marker frames as their own kind, instead of lumping them together with label frames. r?njn MozReview-Commit-ID: 5nQEIgBY4SP
1484091a5ee36d48eb8d6c80f0343aa3da2f3c5a: Bug 1461053 - Treat SP marker frames as their own kind, instead of lumping them together with label frames. r?njn draft
Markus Stange <mstange@themasta.com> - Fri, 20 Apr 2018 20:14:33 -0400 - rev 794425
Push 109689 by bmo:mstange@themasta.com at Sat, 12 May 2018 03:03:50 +0000
Bug 1461053 - Treat SP marker frames as their own kind, instead of lumping them together with label frames. r?njn MozReview-Commit-ID: 5nQEIgBY4SP
3f63ad4108906651e37901ccfb2cf211e0276fac: Bug 1461053 - Rename Cpp frames to label frames in the ProfilingStack. r?njn draft
Markus Stange <mstange@themasta.com> - Fri, 20 Apr 2018 17:22:12 -0400 - rev 794424
Push 109689 by bmo:mstange@themasta.com at Sat, 12 May 2018 03:03:50 +0000
Bug 1461053 - Rename Cpp frames to label frames in the ProfilingStack. r?njn The name Cpp was confusing, because C++ functions are in the native stack, not in the pseudo stack. The pseudo stack only contains frames for manually instrumented code that uses AutoProfilerLabel, and JS frames. MozReview-Commit-ID: 9ptfhREo0qy
7bd34191e04b621e75e15d26f674acee28ddefcc: Bug 1460733 - Rename nsTArrayHeader::sEmptyHdr to extern "C" { sEmptyTArrayHeader } so that thin-vec can link with it. r?froydnj draft
Markus Stange <mstange@themasta.com> - Thu, 10 May 2018 16:37:27 -0400 - rev 794423
Push 109688 by bmo:mstange@themasta.com at Sat, 12 May 2018 03:03:02 +0000
Bug 1460733 - Rename nsTArrayHeader::sEmptyHdr to extern "C" { sEmptyTArrayHeader } so that thin-vec can link with it. r?froydnj MozReview-Commit-ID: CjaE7udG9m2
cdd7f3d0a5286689521fdf4e6782ad6a277af65f: Bug 1460777 - Taskgraph tasks for retrieving remote content; r?dustin, glandium draft
Gregory Szorc <gps@mozilla.com> - Fri, 11 May 2018 19:15:23 -0700 - rev 794422
Push 109687 by bmo:gps@mozilla.com at Sat, 12 May 2018 02:16:09 +0000
Bug 1460777 - Taskgraph tasks for retrieving remote content; r?dustin, glandium Currently, many tasks fetch content from the Internets. A problem with that is fetching from the Internets is unreliable: servers may have outages or be slow; content may disappear or change out from under us. The unreliability of 3rd party services poses a risk to Firefox CI. If services aren't available, we could potentially not run some CI tasks. In the worst case, we might not be able to release Firefox. That would be bad. In fact, as I write this, gmplib.org has been unavailable for ~24 hours and Firefox CI is unable to retrieve the GMP source code. As a result, building GCC toolchains is failing. A solution to this is to make tasks more hermetic by depending on fewer network services (which by definition aren't reliable over time and therefore introduce instability). This commit attempts to mitigate some external service dependencies by introducing the *fetch* task kind. The primary goal of the *fetch* kind is to obtain remote content and re-expose it as a task artifact. By making external content available as a cached task artifact, we allow dependent tasks to consume this content without touching the service originally providing that content, thus eliminating a run-time dependency and making tasks more hermetic and reproducible over time. We introduce a single "fetch-url" "using" flavor to define tasks that fetch single URLs and then re-expose that URL as an artifact. Powering this is a new, minimal "fetch" Docker image that contains a "fetch-content" Python script that does the work for us. We have added tasks to fetch source archives used to build the GCC toolchains. Fetching remote content and re-exposing it as an artifact is not very useful by itself: the value is in having tasks use those artifacts. We introduce a taskgraph transform that allows tasks to define an array of "fetches." Each entry corresponds to the name of a "fetch" task kind. When present, the corresponding "fetch" task is added as a dependency. And the task ID and artifact path from that "fetch" task is added to the MOZ_FETCHES environment variable of the task depending on it. Our "fetch-content" script has a "task-artifacts-env" sub-command that tasks can execute to perform retrieval of all artifacts listed in MOZ_FETCHES. To prove all of this works, the code for fetching dependencies when building GCC toolchains has been updated to use `fetch-content`. The now-unused legacy code has been deleted. This commit improves the reliability and efficiency of GCC toolchain tasks. Dependencies now all come from task artifacts and should always be available in the common case. In addition, `fetch-content` downloads and extracts files concurrently. This makes it faster than the serial application which we were previously using. There are some things I don't like about this commit. First, a new Docker image and Python script for downloading URLs feels a bit heavyweight. The Docker image is definitely overkill as things stand. I can eventually justify it because I want to implement support for fetching and repackaging VCS repositories and for caching Debian packages. These will require more packages than what I'm comfortable installing on the base Debian image, therefore justifying a dedicated image. The `fetch-content static-url` sub-command could definitely be implemented as a shell script. But Python is readily available and is more pleasant to maintain than shell, so I wrote it in Python. `fetch-content task-artifacts-env` is more advanced and writing it in Python is more justified, IMO. FWIW, the script is Python 3 only, which conveniently gives us access to `concurrent.futures`, which facilitates concurrent download. `fetch-content` also duplicates functionality found elsewhere. generic-worker's task payload supports a "mounts" feature which facilitates downloading remote content, including from a task artifact. However, this feature doesn't exist on docker-worker. So we have to implement downloading inside the task rather than at the worker level. I concede that if all workers had generic-worker's "mounts" feature and supported concurrent download, `fetch-content` wouldn't need to exist. `fetch-content` also duplicates functionality of `mach artifact toolchain`. I probably could have used `mach artifact toolchain` instead of writing `fetch-content task-artifacts-env`. However, I didn't want to introduce the requirement of a VCS checkout. `mach artifact toolchain` has its origins in providing a feature to the build system. And "fetching artifacts from tasks" is a more generic feature than that. I think it should be implemented as a generic feature and not something that is "toolchain" specific. I think the best place for a generic "fetch content" feature is in the worker, where content can be defined in the task payload. But as explained above, that feature isn't universally available. The next best place is probably run-task. run-task already performs generic, very-early task preparation steps, such as performing a VCS checkout. I would like to fold `fetch-content` into run-task and make it all driven by environment variables. But run-task is currently Python 2 and achieving concurrency would involve a bit of programming (or adding package dependencies). I may very well port run-task to Python 3 and then fold fetch-content into it. Or maybe we leave `fetch-content` as a standalone script. MozReview-Commit-ID: AGuTcwNcNJR
044eb11c5e15ec7705ceacd66ea51fce31c835d3: Bug 1460777 - Extract GPG keys to standalone files; r?glandium draft
Gregory Szorc <gps@mozilla.com> - Fri, 11 May 2018 10:38:35 -0700 - rev 794421
Push 109687 by bmo:gps@mozilla.com at Sat, 12 May 2018 02:16:09 +0000
Bug 1460777 - Extract GPG keys to standalone files; r?glandium After this change, we consistently import GPG keys from files in the GCC build scripts. MozReview-Commit-ID: BcyvCQoGbMS
3672d4931f785ac9d4e30cada212790aeefee30f: Bug 1447978 - Update strings to remove first person, r?jaws draft
Alex <alexandersonone@gmail.com> - Fri, 11 May 2018 18:56:32 -0700 - rev 794420
Push 109686 by bmo:alexandersonone@gmail.com at Sat, 12 May 2018 01:57:10 +0000
Bug 1447978 - Update strings to remove first person, r?jaws MozReview-Commit-ID: FTSAo3bmxQz
5cfeddfda9fd6a26ca11f1f9d94358d6b14c4a33: Bug 1437036 - Implement GetLastTransactionId in WebRenderLayerManager. r?hiro draft
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 11 May 2018 21:50:04 -0400 - rev 794419
Push 109685 by kgupta@mozilla.com at Sat, 12 May 2018 01:50:21 +0000
Bug 1437036 - Implement GetLastTransactionId in WebRenderLayerManager. r?hiro MozReview-Commit-ID: CLymsb5w3pk
75f9744ef59f82530ac462d4f1bba062a4e538a1: Bug 1437036 - Stop the reftest harness from waiting for MozAfterPaint during infinite/superlong animations. r?hiro draft
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 11 May 2018 21:50:04 -0400 - rev 794418
Push 109685 by kgupta@mozilla.com at Sat, 12 May 2018 01:50:21 +0000
Bug 1437036 - Stop the reftest harness from waiting for MozAfterPaint during infinite/superlong animations. r?hiro These tests rely on an optimization within Gecko where it stops firing MozAfterPaint events if there was no visible change to the generated layers. This allows the reftest harness to exit the waiting-for-MozAfterPaint loop and proceed with the test. However, with webrender, this optimization does not exist and so the loop never exits. In order to solve this problem, this patch adds an explicit mechanism to exit the loop by means of a class attribute on the root element of the test page. MozReview-Commit-ID: 17ta5kLPDr9
ea3ee52ab893a5b1ca614465340d87fda223297a: Bug 1452390 - Implement paint-skipping support in WebRender. r?botond draft
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 11 May 2018 21:18:22 -0400 - rev 794417
Push 109684 by kgupta@mozilla.com at Sat, 12 May 2018 01:18:38 +0000
Bug 1452390 - Implement paint-skipping support in WebRender. r?botond The majority of this patch is just plumbing. The interesting parts are in WebRenderLayerManager and APZUpdater/WebRenderScrollData. Unlike ClientLayerManager, which updates the FrameMetrics on the client side and sends the modified version over to the compositor, this WR version just sends the update info over to the compositor, which then applies the update to the metrics saved in APZUpdater before triggering the hit-testing tree rebuild. MozReview-Commit-ID: 4latUMa8RFw
69af8d2d173e23e75ffb8444f7debf3a9ba7409e: Bug 1452390 - Make WebRenderScrollData::HasMetadataFor work properly on the parent side. r?botond draft
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 11 May 2018 21:18:21 -0400 - rev 794416
Push 109684 by kgupta@mozilla.com at Sat, 12 May 2018 01:18:38 +0000
Bug 1452390 - Make WebRenderScrollData::HasMetadataFor work properly on the parent side. r?botond MozReview-Commit-ID: A2ScgCFVZ8J
3341b1dd52addab116eeb2dd5279dc03c5687ea7: Bug 1461045: Remove unused AddonInternal.bootstrap flag. r?aswan draft
Kris Maglione <maglione.k@gmail.com> - Fri, 11 May 2018 17:58:45 -0700 - rev 794415
Push 109683 by maglione.k@gmail.com at Sat, 12 May 2018 01:03:21 +0000
Bug 1461045: Remove unused AddonInternal.bootstrap flag. r?aswan MozReview-Commit-ID: 8NKCZaq0dVc
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip