ab678196b68106dc8dec5fa5c4b9c033cb25fc87: Bug 1460874 - Expose font size/inflation options via GeckoRuntimeSettings. r?snorp draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 15 Jul 2018 20:16:12 +0200 - rev 819893
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1460874 - Expose font size/inflation options via GeckoRuntimeSettings. r?snorp MozReview-Commit-ID: K67j9l4EsOm
b84e44abacaf8b705a3f79af13d243874b6599d2: debug logging draft
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 02 Mar 2018 18:16:43 +0100 - rev 819892
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
debug logging
5a25eee8331f8188854e476626877c7f91ba0452: Bug 1414084 - Part 17 - Fix setting of private browsing theme state. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 02 Mar 2018 18:01:28 +0100 - rev 819891
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 17 - Fix setting of private browsing theme state. r?grisha Previously, this wasn't noticeable since adding/removing a PageAction would call refreshPageActionIcons(), which would do the correct thing, but now a newly created PageActionLayout can start with an already pre-populated mPageAction- List, which means that the subsequently arriving call to setPrivateMode() will erroneously activate the private mode tinting for all PageActions that support it. MozReview-Commit-ID: EvNx1Q9vwZ5
35f50c7f17b7655273c9382dd8316e229d78f13e: Bug 1414084 - Part 16 - Add some tests for the handling of PageActions. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 19 Mar 2018 20:27:01 +0100 - rev 819890
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 16 - Add some tests for the handling of PageActions. r?grisha MozReview-Commit-ID: EUl19vyK3Ra
598b2c6932d355902fec5c4adc7a9b3bbbd4991f: Bug 1414084 - Part 15 - Correctly remove already resolved PageActions, too. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 03 Mar 2018 18:11:57 +0100 - rev 819889
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 15 - Correctly remove already resolved PageActions, too. r?grisha When a PageActions:Remove message arrives and we cannot simply forward it, we need to remove not just pending PageActions:Add messages, but also any already present PageActions objects that a former PageActionLayout had handed to us. MozReview-Commit-ID: 3jnGsmMuVfa
9184cb46dc9b50208d3d515cabfc413fccd19138: Bug 1414084 - Part 14 - Rename isPwaAdded for more clarity. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 20:39:00 +0100 - rev 819888
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 14 - Rename isPwaAdded for more clarity. r?grisha Despite its name and the original purpose for which it was added, that function generically checks for duplicates among all PageActions, not just the PWA badge. MozReview-Commit-ID: Ae6FsLb9F3S
f5fe7abfdf2f1af79d44a6d19b97b51da0829d30: Bug 1414084 - Part 13 - Cache PageActions. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 26 Feb 2018 21:50:50 +0100 - rev 819887
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 13 - Cache PageActions. r?grisha Since converting a PageAction message into an actual PageAction object also en- tails parsing the image data URL into a drawable, we leave that task to the PageActionLayout. This means that the PageAction cache needs to operate slightly differently than the MenuItem cache. First, we store all PageAction BundleEvent messages that arrive while no PageActionLayout is ready and then forward them en masse when one becomes available. Secondly, if the PageActionLayout is going away again, we then also take a list of already parsed PageAction objects for safekeeping. MozReview-Commit-ID: AcPPONXqe46
2512b5753c3fcb0a405148a259ce6c6f6f5b0dd3: Bug 1414084 - Part 12 - Add some tests for the processing of Menu messages. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 19 Mar 2018 20:06:32 +0100 - rev 819886
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 12 - Add some tests for the processing of Menu messages. r?grisha MozReview-Commit-ID: D8Aujo1PgIk
890b67215165ae17005f56618381b9439c177e48: Bug 1414084 - Part 11 - Use a Map for the MenuItemInfo list. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 18:07:16 +0100 - rev 819885
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 11 - Use a Map for the MenuItemInfo list. r?grisha Since all related EventDispatcher messages use UUIDs, it makes sense to store our MenuItemInfos in a Map, so we can access them directly by UUID instead of having to iterate over them until we've found the desired one. Since we want to preserve the order in which MenuItemInfos were added, we use a LinkedHashMap. MozReview-Commit-ID: BEtJ59tX59m
355e7c218f978389a9c949994c37846faf8c3722: Bug 1414084 - Part 10 - Init MenuItemInfo list right from the start. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 17:47:33 +0100 - rev 819884
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 10 - Init MenuItemInfo list right from the start. r?grisha The small savings in initialising this on demand the first time a menu item is added, are not worth the additional complexity in null checks and the like. MozReview-Commit-ID: Lcz09Ds8NxJ
2ff1980a187b0ce8dd5eba9d99f8086ff8e9a398: Bug 1414084 - Part 9 - Move add-on menu item cache out of BrowserApp. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 25 Feb 2018 22:22:37 +0100 - rev 819883
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 9 - Move add-on menu item cache out of BrowserApp. r?grisha Bug 832990 solved the issue of us losing the menu item cache if BrowserApp was destroyed, however the issue remains that we'll miss any Menu:... messages that are sent while BrowserApp doesn't exist, e.g. if Gecko is initially loaded through a GeckoView-based activity. Therefore we now move the menu item cache and the listener for those messages into a separate class, whose lifetime better matches that of Gecko. Apart from any necessary changes, we move the existing code as is. The only additional change is that we make addAddonMenuItemToMenu() static, because we can. MozReview-Commit-ID: BJleonLnjmo
4dc5e4435c962b2de62afb850b7b2ec6cac8c671: Bug 1414084 - Part 8 - Unify menu item EventDispatcher messages. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 16:42:57 +0100 - rev 819882
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 8 - Unify menu item EventDispatcher messages. r?grisha As a final step, these can be merged as well. The same reasoning as in the previous patch applies with regards to additional functionality that isn't (yet) used by webextensions. MozReview-Commit-ID: Ezx2mQY0s85
32fd6b0fa2780c8779a796d4bdd3f22f147ddbc6: Bug 1414084 - Part 7 - Use one set of functions for managing MenuItems in the UI. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 14:17:03 +0100 - rev 819881
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 7 - Use one set of functions for managing MenuItems in the UI. r?grisha The original add-on functions have some additional capabilities regarding e.g. checkboxes, disabling the menu, etc. that right now aren't required for Webextensions (yet?), but in that case they will simply not be used - in any case BrowserActions.jsm controls what functionality is actually exposed to add-ons. MozReview-Commit-ID: DPT8gV2gb6q
0c9499e0ba6902440d8f6a9f593e5c4c7d31a19a: Bug 1414084 - Part 6 - Use only one list to store menu items added from Gecko. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 23 Mar 2018 19:58:18 +0100 - rev 819880
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 6 - Use only one list to store menu items added from Gecko. r?grisha Now that the UI code for handling both the old NativeWindow API and Web- extensions is more or less the same and both are using the same MenuItemInfo class, there's no longer any real need to keep items added through the two APIs in separate lists - in fact doing so makes it harder to preserve the ordering of menu items if the activity and its menu are destroyed and need to be re- created later on from the stored lists of MenuItemInfos. MozReview-Commit-ID: KlJdvO9WhhY
eaa16a654c74b60ab38c5147be086d230c35c484: Bug 1414084 - Part 5 - Unify menu click event handling. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 14:24:15 +0100 - rev 819879
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 5 - Unify menu click event handling. r?grisha Now that both Webextensions and the NativeWindow API manage their onClick call- back handling by UUID, we can start using the same EventDispatcher message for both. MozReview-Commit-ID: J3RRXrwPdTI
a62c488fabfa5f493f988d568ce79d98dd5877d1: Bug 1414084 - Part 4 - Move menu item ID generation into the UI. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 15:43:27 +0100 - rev 819878
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 4 - Move menu item ID generation into the UI. r?grisha Since the NativeWindow API now only uses UUIDs as well when dealing with its consumers, we can leave generation of the menu to the Android UI code of Firefox. MozReview-Commit-ID: 1qDLDnePfFE
2c99f37d2294871c7ffc20108eaf7df9c0ceb320: Bug 1414084 - Part 3 - Store NativeWindow menu callbacks by UUID. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:33:42 +0100 - rev 819877
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 3 - Store NativeWindow menu callbacks by UUID. r?grisha MozReview-Commit-ID: 7nEhAUxOIsW
3c8c15f7339662b006660c3c19581f46d288f799: Bug 1414084 - Part 2 - Use UUIDs for the NativeWindow menu API, too. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:26:16 +0100 - rev 819876
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 2 - Use UUIDs for the NativeWindow menu API, too. r?grisha At the moment, the code for handling of JS-created main menu items is more or less duplicated between the old NativeWindow API and Webextensions, with the only real difference being that the former communicates directly via menu item IDs, while the latter uses UUIDs for messaging between Gecko and the UI. By switching the NativeWindow API to using UUIDs as well, we will be able to start unifying this code again. As for backward compatibility - the return value of NativeWindow.menu.add is valid for the current session only, so no migration is necessary - the return value of NativeWindow.menu add was already effectively only an opaque value which only had real meaning for subsequent calls to menu.add, menu.update and menu.remove, so it shouldn't really matter whether we return a plain numeric ID or an UUID in string form - old-style add-ons are now unsupported for better or for worse and our one in- tree caller won't have any problems with this change MozReview-Commit-ID: HdRNhrx1pu7
283d6ce47c71de7fd75c7606ca101947b31950d2: Bug 1414084 - Part 1 - No longer track MenuItemInfo "added" data. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:49:31 +0100 - rev 819875
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 1 - No longer track MenuItemInfo "added" data. r?grisha We no longer use that value anywhere, so we can just stop keeping track of it. MozReview-Commit-ID: D1IgX1t8SKI
083d16d794ca1947815dc2fcbdb9d759b92ef801: Bug 1414084 - Part 0 - Cleanups. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 25 Feb 2018 20:53:01 +0100 - rev 819874
Push 116682 by mozilla@buttercookie.de at Wed, 18 Jul 2018 18:44:20 +0000
Bug 1414084 - Part 0 - Cleanups. r?grisha MozReview-Commit-ID: B3ZGN2X8JXH
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip