ab506eb205231a24151dcb97e2431e81a9c7c27c: Bug 1414406: Remove the inline options feature for add-ons. draft
Dave Townsend <dtownsend@oxymoronical.com> - Mon, 13 Nov 2017 15:09:00 -0800 - rev 697779
Push 89087 by dtownsend@mozilla.com at Tue, 14 Nov 2017 16:58:12 +0000
Bug 1414406: Remove the inline options feature for add-ons. MozReview-Commit-ID: 4ycTaMzqWgx
a348f989b74c08fb9e3aef08f1fd4bf0ae089568: Bug 1414406: Remove inline options from talos tabswitch test add-on. r?mconley draft
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 14 Nov 2017 08:54:08 -0800 - rev 697778
Push 89087 by dtownsend@mozilla.com at Tue, 14 Nov 2017 16:58:12 +0000
Bug 1414406: Remove inline options from talos tabswitch test add-on. r?mconley MozReview-Commit-ID: 4XTJgkBdBsa
c1a706605fc986af13bf82096939b63474335095: Bug 1302468 - use UpdateUtils to determine the update channel for UITour, r?MattN draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 14 Nov 2017 15:58:17 +0000 - rev 697777
Push 89086 by gijskruitbosch@gmail.com at Tue, 14 Nov 2017 16:37:02 +0000
Bug 1302468 - use UpdateUtils to determine the update channel for UITour, r?MattN MozReview-Commit-ID: 2FvxdWSfDLK
7821c9a873ab283b0f972c3ca2b30d5ceec0bfc5: Bug 1417101 - Don't fetch bookmark info or notify observers for anno changes that don't update last modified. r?mak draft
Kit Cambridge <kit@yakshaving.ninja> - Tue, 14 Nov 2017 08:12:39 -0800 - rev 697776
Push 89085 by bmo:kit@mozilla.com at Tue, 14 Nov 2017 16:36:34 +0000
Bug 1417101 - Don't fetch bookmark info or notify observers for anno changes that don't update last modified. r?mak MozReview-Commit-ID: G3rNFNoV7g0
fefc0231065626f7e77ea34196d0e130bd6efe7f: Bug 1411230 - Move synctab sidebar search icon to left. r?dao draft
Dale Harvey <dale@arandomurl.com> - Tue, 14 Nov 2017 14:05:40 +0000 - rev 697775
Push 89084 by bmo:dharvey@mozilla.com at Tue, 14 Nov 2017 16:34:39 +0000
Bug 1411230 - Move synctab sidebar search icon to left. r?dao MozReview-Commit-ID: 39ctqQlNNOG
2417f88cbdbf44ec0ac558daaff803bcfd3e370a: Bug 1417017 - Check for content. usage at global and within add_task for no-cpows-in-tests. r?Standard8 draft
Ed Lee <edilee@mozilla.com> - Tue, 14 Nov 2017 02:17:57 -0800 - rev 697774
Push 89083 by bmo:edilee@mozilla.com at Tue, 14 Nov 2017 16:30:11 +0000
Bug 1417017 - Check for content. usage at global and within add_task for no-cpows-in-tests. r?Standard8 MozReview-Commit-ID: Asz6dM29uRJ
1f7c88d962e2bbe929c93f881e5c5a3e4adcabcb: Bug 1414329 - Make WebDriver:ClickElement wait for click events r?jgraham,whimboo draft
Andreas Tolfsen <ato@sny.no> - Fri, 03 Nov 2017 19:20:46 +0000 - rev 697773
Push 89082 by bmo:ato@sny.no at Tue, 14 Nov 2017 16:20:52 +0000
Bug 1414329 - Make WebDriver:ClickElement wait for click events r?jgraham,whimboo This changes interaction.flushEventLoop from relying on the beforeunload DOM event to determine when to bail in case the document navigates. Instead, it now relies on the unload event which should not affect bfcache. It also changes flushEventLoop to append a click event listener to the targetted element's container element. Because this event will be added last, the intention is that all preceding click evens will have had time to fire and propagate before our listener spins the event loop through setTimeout once. Our listeners are added using the privileged mozSystemGroup option so that a potential invocation of EventTarget.stopImmediatePropagation does not prevent our listener from firing. MozReview-Commit-ID: 2Ehxwg2p6Fo
d8aed1087086411376a5dc7fac3c84138e6562b0: Bug 1302468 - use UpdateUtils to determine the update channel for UITour, r?MattN draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 14 Nov 2017 15:58:17 +0000 - rev 697772
Push 89081 by gijskruitbosch@gmail.com at Tue, 14 Nov 2017 16:02:05 +0000
Bug 1302468 - use UpdateUtils to determine the update channel for UITour, r?MattN MozReview-Commit-ID: 2FvxdWSfDLK
694ead5f298e0c830a7c291cf9f73a0b9d40c56c: Bug 1412143 - Add `mozIAsyncLivemarks.invalidateCachedLivemarks`. r?mak draft
Kit Cambridge <kit@yakshaving.ninja> - Fri, 08 Sep 2017 15:27:32 -0700 - rev 697771
Push 89080 by bmo:kit@mozilla.com at Tue, 14 Nov 2017 15:57:26 +0000
Bug 1412143 - Add `mozIAsyncLivemarks.invalidateCachedLivemarks`. r?mak This patch uses a promise queue to serialize reads and writes to the livemarks cache. MozReview-Commit-ID: 8R7N6ORxrtV
c3e1d2271b678065549f4c006d54c72ee1f66433: Bug 1415556 - P11. Remove unecessary locking. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 11 Nov 2017 10:20:59 +0100 - rev 697770
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P11. Remove unecessary locking. r?padenot The method doesn't use any MSG member, only dispatching a task. MozReview-Commit-ID: 7uZbTvq9OQt
67d5e245da1a505a5682b43e0a2e1f3d875cfb58: Bug 1415556 - P10. Make functions const where needed. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 20:01:27 +0100 - rev 697769
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P10. Make functions const where needed. r?padenot MozReview-Commit-ID: EBEgDVCTewa
d9be39b0b0835736f6f224ed3cba77460f429bd3: Bug 1415556 - P9. Remove unused member. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 19:00:12 +0100 - rev 697768
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P9. Remove unused member. r?padenot MozReview-Commit-ID: 2LbqhBkmDBF
de2835c301980152ea1ad951956ec49239c139a0: Bug 1415556 - P8. Assert on proper access of mStreams member. r?padenot. draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:56:29 +0100 - rev 697767
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P8. Assert on proper access of mStreams member. r?padenot. mStreams should only ever be accessed on the MSG thread. However, under some shutdown circumstances, it can be accessed on the main thread while the MSG thread is still alive. This will be corrected in bug 1408276. MozReview-Commit-ID: 6xWzxxV1Dv3
7f39b13de9026c0260bc5d597fac8e6e91c2d2fe: Bug 1415556 - P7. Remove unecessary locking. r?padenot. draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:53:23 +0100 - rev 697766
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P7. Remove unecessary locking. r?padenot. mForceShutdownTicket and mShutdownTimer are only ever accessed on the main thread. We don't need the use of the monitor to reset them. MozReview-Commit-ID: 1DL8bLmzEH5
63a368392d81edcf426ddc2a622677966f3bcc9b: Bug 1415556 - P6. Ensure mLifecycleState member is always accessed safely. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:38:02 +0100 - rev 697765
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P6. Ensure mLifecycleState member is always accessed safely. r?padenot We only access mLifecycleState via a helper which strongly enforced how the member can be accessed. Two non-safe accesses are corrected. MozReview-Commit-ID: 6LYk7t4rSyB
d99a3cd585d722779026a0839bc4040c7483b86e: Bug 1415556 - P5. Use helper to set mDriver. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:28:42 +0100 - rev 697764
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P5. Use helper to set mDriver. r?padenot MozReview-Commit-ID: Fres1YwcYYM
ce96f07d63a3c3946b23fd9753f675a4827ff41b: Bug 1415556 - P4. Make members atomics. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:27:39 +0100 - rev 697763
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P4. Make members atomics. r?padenot They are accessed across multiple threads without the use of monitors. While it could be argued that some use of the monitor in functions accessing those members would set in place memory barriers, making them atomics remove all doubts as to the thread safetyness of their use. MozReview-Commit-ID: tyTqeGgDNM
2de596232fe1bc8a6e93a38279890a91b9d46e3a: Bug 1415556 - P3. clearly mark functions' thread use. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:24:20 +0100 - rev 697762
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P3. clearly mark functions' thread use. r?padenot MozReview-Commit-ID: BXmdk4zBo28
055c54acf707166a550cbe4423ed74a72203dd61: Bug 1415556 - P2. Make member const. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 17:30:19 +0100 - rev 697761
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P2. Make member const. r?padenot MozReview-Commit-ID: JPDW5cX8RvH
384d339f0c29062878ea3921d97a294182306635: Bug 1415556 - P1. Add precision on thread access with some members. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 17:28:59 +0100 - rev 697760
Push 89079 by bmo:jyavenard@mozilla.com at Tue, 14 Nov 2017 15:28:18 +0000
Bug 1415556 - P1. Add precision on thread access with some members. r?padenot Describe which members are accessed on the main threads. Other members are only accessed on MSG thread. MozReview-Commit-ID: CFU4ipRHB1P
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip