ab3820a7849a477f4dd737d3b59593c4d3c46f77: Bug 1356843 - Fix -Wcomma warnings in toolkit/. r?mossop draft
Chris Peterson <cpeterson@mozilla.com> - Wed, 05 Apr 2017 01:23:45 -0700 - rev 563342
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warnings in toolkit/. r?mossop clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter. toolkit/components/startup/nsAppStartup.cpp:436:58 [-Wcomma] possible misuse of comma operator here toolkit/components/statusfilter/nsBrowserStatusFilter.cpp:165:66 [-Wcomma] possible misuse of comma operator here toolkit/xre/CreateAppData.cpp:60:51 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: HuZRoOjQTGj
c34669f7fcc033eb598d18371183e748a010f173: Bug 1356843 - Fix -Wcomma warning in netwerk/protocol/http/Http2Stream.cpp. r?jhao draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:42:21 -0700 - rev 563341
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warning in netwerk/protocol/http/Http2Stream.cpp. r?jhao clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. netwerk/protocol/http/Http2Stream.cpp:436:59 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: AsmNPTjKlYB
51c53cfbc346151d4aa685ec891bce6837be1742: Bug 1356843 - Fix -Wcomma warning in modules/libjar/nsZipArchive.cpp. r?aklotz draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:39:36 -0700 - rev 563340
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warning in modules/libjar/nsZipArchive.cpp. r?aklotz clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression. modules/libjar/nsZipArchive.cpp:651:25 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: 9PjB915D81f
b3c001789e3e36dc721d8d206da8f5e831c91366: Bug 1356843 - Fix -Wcomma warnings in js/. r?jorendorff draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 09 Apr 2017 21:15:01 -0700 - rev 563339
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warnings in js/. r?jorendorff clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression. js/src/builtin/MapObject.cpp:786:48 [-Wcomma] possible misuse of comma operator here js/src/builtin/MapObject.cpp:1371:48 [-Wcomma] possible misuse of comma operator here js/src/builtin/RegExp.cpp:1266:62 [-Wcomma] possible misuse of comma operator here js/src/jit/x64/BaseAssembler-x64.h:624:99 [-Wcomma] possible misuse of comma operator here js/src/jsarray.cpp:2416:27 [-Wcomma] possible misuse of comma operator here js/src/jscompartment.cpp:120:48 [-Wcomma] possible misuse of comma operator here js/src/jsstr.cpp:3346:14 [-Wcomma] possible misuse of comma operator here js/xpconnect/src/XPCWrappedNativeJSOps.cpp:316:71 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: BbT4otUXczV
1b929c1f305a54249df4c7ce72d8edf250e2d757: Bug 1356843 - Fix -Wcomma warning in intl/uconv/util/nsUCSupport.cpp. r?jshin draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 08 Apr 2017 01:05:19 -0700 - rev 563338
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warning in intl/uconv/util/nsUCSupport.cpp. r?jshin clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. intl/uconv/util/nsUCSupport.cpp:552:34 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: Emk05qDJHbm
c8fb654450a5c209f66d50486588a7c34a66860b: Bug 1356843 - Fix -Wcomma warnings in gfx/layers/Layers.cpp. r?mchang draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:29:42 -0700 - rev 563337
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warnings in gfx/layers/Layers.cpp. r?mchang clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. gfx/layers/Layers.cpp:1944:33 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1945:33 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1946:33 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1949:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1950:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1951:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1952:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1953:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1954:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1955:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1956:37 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: 9lMJZrPRtTV
e9d2ad62a2647c2eacda59a833e03e5a0ed50bb5: Bug 1356843 - Fix -Wcomma warnings in dom/. r?dholbert draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 19:41:50 -0700 - rev 563336
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warnings in dom/. r?dholbert clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression. Note that this warning indicates that nsXMLFragmentContentSink::CloseElement() has been calling aContent->IsHTMLElement(nsGkAtoms::script) but not using its return value to determine when to call PreventExecution() since bug 1134280 changed this code in 2015! dom/base/nsGlobalWindow.cpp:9344:55 [-Wcomma] possible misuse of comma operator here dom/svg/SVGGeometryElement.h:117:21 [-Wcomma] possible misuse of comma operator here dom/svg/SVGGeometryElement.h:117:41 [-Wcomma] possible misuse of comma operator here dom/svg/SVGGeometryElement.h:128:14 [-Wcomma] possible misuse of comma operator here dom/svg/SVGGeometryElement.h:128:23 [-Wcomma] possible misuse of comma operator here dom/svg/SVGGeometryElement.h:128:40 [-Wcomma] possible misuse of comma operator here dom/xml/nsXMLFragmentContentSink.cpp:227:50 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: DontBxeHqGI
ce69b6e1773e9e0d0a190ce899f34b1658e66ca4: Bug 1347709 and Bug 1356569 - Bump eslint plugin version to resolve conflict. r=instruction-by-florian a=bustage-fix
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 15 Apr 2017 20:05:51 +0200 - rev 563335
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1347709 and Bug 1356569 - Bump eslint plugin version to resolve conflict. r=instruction-by-florian a=bustage-fix MozReview-Commit-ID: 2zp9hXqxT26
d65b53cf8fd9f7747c7ee4e3ea96f12434917daa: merge mozilla-inbound to mozilla-central. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 15 Apr 2017 19:59:24 +0200 - rev 563334
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
merge mozilla-inbound to mozilla-central. r=merge a=merge MozReview-Commit-ID: JpAhOPjgvkF
ed88aa504601fc1a97ad83f8b4f3c17182a09425: Bug 1324700 - Update reftest expectations. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:35 +0900 - rev 563333
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Update reftest expectations. r=heycam MozReview-Commit-ID: 38Gk7MCIjJD
0ba623e978ef4cff4ee2c7b39de16832b1373f3a: Bug 1324700 - Update assertion counts which had been caused by font handling in canvas element. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:35 +0900 - rev 563332
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Update assertion counts which had been caused by font handling in canvas element. r=heycam MozReview-Commit-ID: KPhujlE54vL
eb6ce1493b85650a3667b9d89520a3d0cf40ed56: Bug 1324700 - Drop warnings for stylo. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:35 +0900 - rev 563331
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Drop warnings for stylo. r=heycam The code path no longer happens on stylo. MozReview-Commit-ID: LdQFPNd5YnX
6b13b4abe4a979db814afffea0a38d4cc73f9e8e: Bug 1324700 - Resolve filter property for servo. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:35 +0900 - rev 563330
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Resolve filter property for servo. r=heycam MozReview-Commit-ID: 6IHs682rZfH
8dafc925b03493da7b9fbb0056300ad6a8ba9f0c: Bug 1324700 - Add a function which is equivalent to ResolveStyleForFilter for servo. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:35 +0900 - rev 563329
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Add a function which is equivalent to ResolveStyleForFilter for servo. r=heycam Also ResolveStyleForFilter is renamed to ResolveFilterStyle for consistency. MozReview-Commit-ID: IEOxNexpnl5
e959737822e5471e1e4e2c9c0e79d72a0b96889d: Bug 1324700 - Resolve font property for servo. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:35 +0900 - rev 563328
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Resolve font property for servo. r=heycam MozReview-Commit-ID: BvQXFMP0Zr9
1876d89c8f37fb06dd2e20bee33f69333565b669: Bug 1324700 - Add a function which is equivalent to GetFontStyleContext() for servo. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:35 +0900 - rev 563327
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Add a function which is equivalent to GetFontStyleContext() for servo. r=heycam MozReview-Commit-ID: K4KvPk4fJTb
3d2bbd149e04885f71d481aad342ab6e176a05c4: Bug 1324700 - Add an FFI which returns computed values for a given declaration block with/without parent_style. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:35 +0900 - rev 563326
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Add an FFI which returns computed values for a given declaration block with/without parent_style. r=heycam The function uses document's default computed values if the parent style is not specified. MozReview-Commit-ID: ICd3phAi0C6
3e19c81c80fc84dc1ee688076277f39f006618f3: Bug 1324700 - Add a function that checks PropertyDeclarationBlock has a CSSWideKeyword for a given property. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:34 +0900 - rev 563325
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Add a function that checks PropertyDeclarationBlock has a CSSWideKeyword for a given property. r=heycam It will be used to check whether the PropertyDeclarationBlock has 'inherit', 'initial' or 'unset'. MozReview-Commit-ID: JxlxAJJSNJI
b38bae9c02febd46891db88efb674fd9b5c11b66: Bug 1324700 - Add a function which is equivalent to CreateDeclaration() for servo. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:34 +0900 - rev 563324
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Add a function which is equivalent to CreateDeclaration() for servo. r=heycam MozReview-Commit-ID: 8zgpqLzftbV
b116710343a71f0079382c8b704f649ac711a42c: Bug 1324700 - Add ResolveServoTransientStyle to get servo's computed values instead of nsStyleContext. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Apr 2017 07:37:34 +0900 - rev 563323
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1324700 - Add ResolveServoTransientStyle to get servo's computed values instead of nsStyleContext. r=heycam Also this patch add nsIAtom as an argument to ResolveTransientStyle() to call the new function ResolveServoTransientStyle easier. The only call site of the ResolveTransientStyle() has already nsIAtom* there. MozReview-Commit-ID: IwxqZbaCSpB
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip