a91894c9c75e2dc2423275b380aa6d175415be0b: Bug 1336734 - Part 3 - Don't stop the GeckoNetworkManager unless we're really backgrounded. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 05 Feb 2017 15:47:51 +0100 - rev 479511
Push
44274 by mozilla@buttercookie.de at Mon, 06 Feb 2017 20:19:35 +0000
Bug 1336734 - Part 3 - Don't stop the GeckoNetworkManager unless we're really backgrounded. r?sebastian
Launching a new activity within our app triggers both onActivityPause() (the current activity) and onActivityResume() (the new activity) in GeckoApplication. The most prominent example at the moment are probably our preferences - entering/exiting/navigating within them always triggers a pause/resume combo. This means that currently, each time this happens the network manager is stopped only to be immediately restarted.
To avoid this, we stop the network manager only when Gecko is actually being paused.
MozReview-Commit-ID: 6NdScT5cLYL
2c6dc9721c25fd660293e619092be8c531fb54c7: Bug 1336734 - Part 2 - Implement GeckoActivityStatus for the FxAccountStatusActivity. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 06 Feb 2017 20:30:20 +0100 - rev 479510
Push
44274 by mozilla@buttercookie.de at Mon, 06 Feb 2017 20:19:35 +0000
Bug 1336734 - Part 2 - Implement GeckoActivityStatus for the FxAccountStatusActivity. r?sebastian
Since we're no longer pausing Gecko when entering this activity, it must implement this interface so we can still properly pause Gecko if we get backgrounded while on the Sync preferences screen.
Most actions here are actually done via the application context (i.e. GeckoApplication), so overriding startActivity et al. and using mGeckoActivityOpened doesn't achieve all that much for most cases, but since we currently at most exit the screen (activity is finishing, so won't trigger a GeckoThread.onPause() call) and stay within our application (open a new tab in Firefox), we're still fine.
MozReview-Commit-ID: 3760hXMjckX
0a151c549e8d80f64fc6d18da458a3fa2ed3ed0b: Bug 809492 - Rename num_constructors test to num_static_constructors r?jmaher
draft
William Lachance <wlachance@mozilla.com> - Mon, 06 Feb 2017 15:17:07 -0500 - rev 479509
Push
44273 by wlachance@mozilla.com at Mon, 06 Feb 2017 20:17:32 +0000
Bug 809492 - Rename num_constructors test to num_static_constructors r?jmaher
MozReview-Commit-ID: 3bw2MDL8iuI
4a4503fed3747eea5432d295b8f4410f64d11faf: Bug 1330836 - Only send 'network config/status changed' events to Gecko if something actually changed r=jchen
draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 06 Feb 2017 12:17:57 -0800 - rev 479508
Push
44272 by gkruglov@mozilla.com at Mon, 06 Feb 2017 20:16:50 +0000
Bug 1330836 - Only send 'network config/status changed' events to Gecko if something actually changed r=jchen
MozReview-Commit-ID: CrlRDu8MbhY
4700225cf5af08c60d8f53a430acb33ef97e21d4: Part 2: Bug 1295807 - Implement the Proxy API. r?kmag
draft
Matthew Wein <mwein@mozilla.com> - Thu, 17 Nov 2016 18:58:15 -0800 - rev 479507
Push
44271 by mwein@mozilla.com at Mon, 06 Feb 2017 20:15:43 +0000
Part 2:
Bug 1295807 - Implement the Proxy API. r?kmag
MozReview-Commit-ID: 3jgGbIl3j0v
39ce988c2d2a28653a2a25d1b16b4f37abf99b8e: Part 1: Bug 1295807 - Add a Javascript Module for registering proxy scripts. r?kmag,robwu
draft
Matthew Wein <mwein@mozilla.com> - Mon, 06 Feb 2017 20:07:13 +0000 - rev 479506
Push
44271 by mwein@mozilla.com at Mon, 06 Feb 2017 20:15:43 +0000
Part 1:
Bug 1295807 - Add a Javascript Module for registering proxy scripts. r?kmag,robwu
MozReview-Commit-ID: HLokEivMpmp
610fbe49d21aec2f777be120d6630fc0397a830f: Bug 1335890 - Factor out nsContentUtils::SubjectPrincipal version that takes JSContext
draft 1335890-subjectPrincipal
Tomislav Jovanovic <tomica@gmail.com> - Sun, 05 Feb 2017 23:19:26 +0100 - rev 479505
Push
44270 by bmo:tomica@gmail.com at Mon, 06 Feb 2017 20:06:42 +0000
Bug 1335890 - Factor out nsContentUtils::SubjectPrincipal version that takes JSContext
MozReview-Commit-ID: CGRipgKUm7g
6b7b7dd941c5567ca233c38eb0f310d2995184c4: Bug 1336937 - Add aria-pressed to the filter buttons in new console. r=jdescottes
draft
Nicolas Chevobbe <chevobbe.nicolas@gmail.com> - Mon, 06 Feb 2017 13:41:08 +0100 - rev 479504
Push
44269 by chevobbe.nicolas@gmail.com at Mon, 06 Feb 2017 20:00:33 +0000
Bug 1336937 - Add aria-pressed to the filter buttons in new console. r=jdescottes
MozReview-Commit-ID: FEvuSd3RQ67
808099b6bbf3adb5769eaec940ad7eec103000d6: Bug 1319237 - Fix calls to session.find; r?maja_zf
draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 03 Feb 2017 16:32:16 +0000 - rev 479503
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Fix calls to session.find; r?maja_zf
MozReview-Commit-ID: 5afoA6aKgCV
f6307a929cf1496e936d2d7a5eb5d1024b06fe3a: Bug 1319237 - Disable WebDriver navigation to file: protocol test; r?maja_zf
draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 03 Feb 2017 16:31:57 +0000 - rev 479502
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Disable WebDriver navigation to file: protocol test; r?maja_zf
MozReview-Commit-ID: 3SlvHmggRET
6c8ff63464cabfc426b4509aa7ab485c0c009c65: Bug 1319237 - Enable WebDriver context test; r?maja_zf
draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 03 Feb 2017 16:31:19 +0000 - rev 479501
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Enable WebDriver context test; r?maja_zf
MozReview-Commit-ID: EQZHO6npFtH
cc5a413a54b0f9c6452f638cb7955dfb99ed6bd3: Bug 1319237 - Avoid reposition waiting if position is unchanged; r?maja_zf
draft
Andreas Tolfsen <ato@mozilla.com> - Thu, 02 Feb 2017 14:58:36 +0000 - rev 479500
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Avoid reposition waiting if position is unchanged; r?maja_zf
When the requested window position is the same as the current position,
we should avoid the wait condition.
MozReview-Commit-ID: 3koG5BeOkFC
a11b5c09012062be32a88cd2e2ed18fb4ab5bc15: Bug 1319237 - Improve window position test assertions; r?maja_zf
draft
Andreas Tolfsen <ato@mozilla.com> - Thu, 02 Feb 2017 14:57:19 +0000 - rev 479499
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Improve window position test assertions; r?maja_zf
MozReview-Commit-ID: qmFS0JEqx3
13a943e346c7ce0aaf02ab0922a220fdee88fff4: Bug 1319237 - Donate window position test to Mozilla; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Thu, 02 Feb 2017 14:46:58 +0000 - rev 479498
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Donate window position test to Mozilla; r?automatedtester
The window positioning test has been sufficiently rewritten that it can
no longer be considered a derived work from Selenium.
MozReview-Commit-ID: 9FtGEPeMXQs
b2761563cc4c9f68e80948afa286f011ecd829bc: Bug 1319237 - Make GeckoDriver#setWindowSize synchronous; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:44:22 +0100 - rev 479497
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Make GeckoDriver#setWindowSize synchronous; r?automatedtester
Return from the Set Window Size command only after the window resize
DOM event has occurred.
MozReview-Commit-ID: 7ygZuNJZzq2
ccf24ce456074d95579512ca68a392ccc6c75d18: Bug 1319237 - Make GeckoDriver#setWindowPosition synchronous; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:43:35 +0100 - rev 479496
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Make GeckoDriver#setWindowPosition synchronous; r?automatedtester
This change makes the Set Window Position command synchronous by waiting
for the original window position to change before returning.
MozReview-Commit-ID: 3gOv6bNPASV
6cef8dd2476350c105231ebdeed628d72547f34a: Bug 1319237 - Generalise wait condition utility; r?automatedtester,maja_zf
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:41:20 +0100 - rev 479495
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Generalise wait condition utility; r?automatedtester,maja_zf
This makes the `implicitWaitFor` utility from
testing/marionette/element.js generally available in Marionette.
It improves on the design of the old wait utility by providing
promise-like resolve and reject options to the evaluated function. These
can be used to indicate success or failure of waiting. If resolved, the
provided value is returned immediately. When rejected, the function is
evaluated over again until the timeout is reached or an error is thrown.
It is useful to indicate success and failure state because it saves the
calling code from guessing based on the return value. Guessing from
the return value can be problematic since there are certain types and
values in JavaScript that are ambigeous or misleading, such as the fact
that empty arrays are evaluated as a truthy value.
MozReview-Commit-ID: G8F99tdbiNb
6d6900adfcedb494a635d73f376d32107d287f39: Bug 1319237 - Make session fixture module scoped; r?jgraham
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:39:42 +0100 - rev 479494
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Make session fixture module scoped; r?jgraham
I recently changed it to function scoped, which was a mistake.
pytest complains if it is not module scoped.
MozReview-Commit-ID: GYP9Ky1avks
0946938ec4800925203b0020fede5388ebc1a05b: Bug 1319237 - Allow pytests to be skipped imperatively at runtime; r?jgraham
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:38:42 +0100 - rev 479493
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Allow pytests to be skipped imperatively at runtime; r?jgraham
It is required to skip certain WebDriver tests imperatively at runtime,
such as for the Get Window Size and Get Window Position commands, which
are only available at certain configurations.
MozReview-Commit-ID: 9ERYkYm34iI
7e30c373f5d5023b39f6bb7a24633d9f69770276: Bug 1319237 - Assign GeckoDriver#getWindowSize return value in one statement; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:36:29 +0100 - rev 479492
Push
44268 by bmo:ato@mozilla.com at Mon, 06 Feb 2017 19:54:40 +0000
Bug 1319237 - Assign GeckoDriver#getWindowSize return value in one statement; r?automatedtester
MozReview-Commit-ID: BGH1WkgH91p