a7d4fe8d03e91fd72198e8791dbd2099a2732fad: Bug 902825 - Update buildconfig.py to use PartialConfigEnvironment; r?glandium draft
Mike Shal <mshal@mozilla.com> - Thu, 24 Aug 2017 22:52:01 -0400 - rev 656194
Push 77110 by bmo:mshal@mozilla.com at Wed, 30 Aug 2017 20:35:48 +0000
Bug 902825 - Update buildconfig.py to use PartialConfigEnvironment; r?glandium By using the PartialConfigEnvironment, the clients of buildconfig will depend on config.statusd/ files instead of config.status directly. Clients can access substs and defines using buildconfig.get_subst() or buildconfig.get_define(), and then collect file-level dependencies for make using buildconfig.get_dependencies(). Things that still need the full config can use buildconfig.config.defines to access the original config.status structures. Doing so does create a dependency on the config.status file, which is always updated during configure, so use of this for build-time code is discouraged. However, it is acceptable to use buildconfig.config during packaging or other post-build automation steps. As a result of this commit, re-running configure will no longer cause the world to be rebuilt. Although config.status is updated, no build steps use config.status directly and instead depend on values in config.statusd/, which are written with FileAvoidWrite. Since those files are not official targets according to the make backend, make won't try to continually rebuild the backend when those files are out of date. And since they are FileAvoidWrite, make will only re-run dependent steps if the actual configure value has changed. MozReview-Commit-ID: 2pJ4s3TVeS8
59867598f1d3432c1da2b6cc2b33fa1ea0bd7bd4: Bug 902825 - Use PartialConfigEnvironment in process_define_files.py; r?glandium draft
Mike Shal <mshal@mozilla.com> - Mon, 21 Aug 2017 15:34:07 -0400 - rev 656193
Push 77110 by bmo:mshal@mozilla.com at Wed, 30 Aug 2017 20:35:48 +0000
Bug 902825 - Use PartialConfigEnvironment in process_define_files.py; r?glandium This removes the dependency on config.status for CONFIGURE_DEFINE_FILES. Instead, each file depends on the specific configure values that it uses. MozReview-Commit-ID: H4oLmJei1KR
93622b07bb005d22910528dd077561be30c3be8e: Bug 902825 - Create config.statusd directory; r?glandium draft
Mike Shal <mshal@mozilla.com> - Fri, 18 Aug 2017 10:41:50 -0400 - rev 656192
Push 77110 by bmo:mshal@mozilla.com at Wed, 30 Aug 2017 20:35:48 +0000
Bug 902825 - Create config.statusd directory; r?glandium The config.statusd directory is created alongside config.status, which contains the same information but is split across many files instead of all in a single file. This allows the build system to track dependencies on individual configure values. MozReview-Commit-ID: 2DbwKCJuNSX
7fb3117e08044c73da2f8b9a345fd03b2a50e5e0: Bug 1395322: Add some info messages to layout/style/test/chrome/test_stylesheet_clone_import_rule.html. draft
Brad Werth <bwerth@mozilla.com> - Wed, 30 Aug 2017 13:10:42 -0700 - rev 656191
Push 77109 by bwerth@mozilla.com at Wed, 30 Aug 2017 20:33:40 +0000
Bug 1395322: Add some info messages to layout/style/test/chrome/test_stylesheet_clone_import_rule.html. MozReview-Commit-ID: 8ea7J5ExmzH
9b0db4acbddf3d017ee4b241e2bf6f04a5536cdc: Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r?jfkthame draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 30 Aug 2017 13:33:14 -0700 - rev 656190
Push 77108 by dholbert@mozilla.com at Wed, 30 Aug 2017 20:33:32 +0000
Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r?jfkthame Some benchmarks & use-cases cause nsTextFrame::CharacterDataChanged to be called multiple times for the same text between reflows. Each call triggers a slightly-expensive call to shell->FrameNeedsReflow(), for each affected nsTextFrame in the continuation chain. (Though it's not quite that bad -- we skip the FrameNeedsReflow calls for siblings, since the ancestor notifications/tweaks would all be the same.) This patch makes us set a bit on the nsTextFrame that lets us indicate that a reflow has *already* been requested by this chunk of code, so we can skip the FrameNeedsReflow() call (or dirty-bit-setting) on the next invocation. We clear this bit when the reflow happens. MozReview-Commit-ID: 5nmbZHEFFDi
69ae50953daaacbb30b77cdf7cbae26239dc95ea: Bug 1393098 part 0: Capture "if" condition in a helper bool, in nsTextFrame::CharacterDataChanged (and improve documentation). r?jfkthame draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 30 Aug 2017 13:20:12 -0700 - rev 656189
Push 77108 by dholbert@mozilla.com at Wed, 30 Aug 2017 20:33:32 +0000
Bug 1393098 part 0: Capture "if" condition in a helper bool, in nsTextFrame::CharacterDataChanged (and improve documentation). r?jfkthame MozReview-Commit-ID: 7dEflfiERYB
2749a844a9f3e091d1944edf3fd93245cb5e7d5e: No bug - Add comments to explain why they are ignored by clang-format r=me DONTBUILD
Sylvestre Ledru <sledru@mozilla.com> - Wed, 30 Aug 2017 18:53:35 +0200 - rev 656188
Push 77108 by dholbert@mozilla.com at Wed, 30 Aug 2017 20:33:32 +0000
No bug - Add comments to explain why they are ignored by clang-format r=me DONTBUILD MozReview-Commit-ID: B8fsjYiWzkm
a8369cf48aebbe56520e308e30d4ef82abaec4ce: Bug 1395141 - RequestInit dictionary must have AbortSignal as optional, r=bkelly
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 30 Aug 2017 18:47:23 +0200 - rev 656187
Push 77108 by dholbert@mozilla.com at Wed, 30 Aug 2017 20:33:32 +0000
Bug 1395141 - RequestInit dictionary must have AbortSignal as optional, r=bkelly
70cacce59ff8611b18af2fa2894cc344c53bb458: Bug 902825 - Remove MOZ_CALLGRIND from mozilla-config.h; r?glandium draft
Mike Shal <mshal@mozilla.com> - Tue, 17 Jan 2017 11:17:03 -0500 - rev 656186
Push 77107 by bmo:mshal@mozilla.com at Wed, 30 Aug 2017 20:33:18 +0000
Bug 902825 - Remove MOZ_CALLGRIND from mozilla-config.h; r?glandium MozReview-Commit-ID: 4FxAcPq2bao
8c673173641ded8e9329416ff8fd6ffe0f7f7d92: Bug 902825 - Add some hacks to avoid rebuilding world; r?glandium draft
Mike Shal <mshal@mozilla.com> - Tue, 18 Apr 2017 09:54:48 -0400 - rev 656185
Push 77107 by bmo:mshal@mozilla.com at Wed, 30 Aug 2017 20:33:18 +0000
Bug 902825 - Add some hacks to avoid rebuilding world; r?glandium Since MOZ_CONFIGURE_OPTIONS changes every time you enable or disable a configure option, we have to remove that from autoconf.mk in order to avoid rebuilding the world whenever it changes. This works around the fact that everything depends on autoconf.mk in the RecursiveMake backend. We also remove any mozconfig_defines from ALLSUBSTS to avoid modifying that file for the same reason, in case the define is also a subst. This means that any relevant Makefile.in code that uses a subst from autoconf.mk must be converted to moz.build before a define can be created as a mozconfig_define. As of this commit, it is possible to set a define with mozconfig_header=True in moz.configure, and add corresponding #includes in C++ code. Doing so will no longer change the globally included mozilla-config.h when the flag is toggled. Instead, only the C++ code that uses the define will be recompiled. MozReview-Commit-ID: 5r8q4yfTeK3
227f6ce85bf928f97758b79e9da4f5b00c9bfd50: Bug 902825 - Allow generating dist/include/mozconfig/*.h; r?glandium draft
Mike Shal <mshal@mozilla.com> - Wed, 14 Dec 2016 16:03:49 -0500 - rev 656184
Push 77107 by bmo:mshal@mozilla.com at Wed, 30 Aug 2017 20:33:18 +0000
Bug 902825 - Allow generating dist/include/mozconfig/*.h; r?glandium Using the defines from the config environment, we can generate a set of header files in dist/include/mozconfig/ so that source files can include them to get access to specific configure values. Instead of rebuilding the whole world when a single define changes (due to its presence in mozilla-config.h), we can recompile only the set of files that actually depend on its value. This begins the process by generating the individual headers from all of the mozconfig_defines in moz.configure, as well as providing an easy way to declare a mozconfig_defines in set_define(). mozconfig_defines are essentially non_global_defines that have the following properties: 1) They are used in C/C++ code by doing #include "mozconfig/DEFINE_NAME.h" And if the define is also a subst, then: 2) They are used in Python code with buildconfig.get_subst() 3) They are not used in Makefile.in's or included .mk files, because the values are not exported to autoconf.mk We have to use a new structure for mozconfig_defines, because not all non_global_defines can be removed from ALLSUBSTS since some values are still used in Makefile.in's (for example, NECKO_WIFI is used in an ifdef in browser/installer/Makefile.in). MozReview-Commit-ID: 22jiYaamSo2
507d5af122a666997f69de84fba46b6b592fd27d: Bug 902825 - Update buildconfig.py to use PartialConfigEnvironment; r?glandium draft
Mike Shal <mshal@mozilla.com> - Thu, 24 Aug 2017 22:52:01 -0400 - rev 656183
Push 77107 by bmo:mshal@mozilla.com at Wed, 30 Aug 2017 20:33:18 +0000
Bug 902825 - Update buildconfig.py to use PartialConfigEnvironment; r?glandium By using the PartialConfigEnvironment, the clients of buildconfig will depend on config.statusd/ files instead of config.status directly. Clients can access substs and defines using buildconfig.get_subst() or buildconfig.get_define(), and then collect file-level dependencies for make using buildconfig.get_dependencies(). Things that still need the full config can use buildconfig.config.defines to access the original config.status structures. Doing so does create a dependency on the config.status file, which is always updated during configure, so use of this for build-time code is discouraged. However, it is acceptable to use buildconfig.config during packaging or other post-build automation steps. As a result of this commit, re-running configure will no longer cause the world to be rebuilt. Although config.status is updated, no build steps use config.status directly and instead depend on values in config.statusd/, which are written with FileAvoidWrite. Since those files are not official targets according to the make backend, make won't try to continually rebuild the backend when those files are out of date. And since they are FileAvoidWrite, make will only re-run dependent steps if the actual configure value has changed. MozReview-Commit-ID: 2pJ4s3TVeS8
3a1b7cfff57bde9bbd8209aeb3665fb9889b1110: Bug 902825 - Use PartialConfigEnvironment in process_define_files.py; r?glandium draft
Mike Shal <mshal@mozilla.com> - Mon, 21 Aug 2017 15:34:07 -0400 - rev 656182
Push 77107 by bmo:mshal@mozilla.com at Wed, 30 Aug 2017 20:33:18 +0000
Bug 902825 - Use PartialConfigEnvironment in process_define_files.py; r?glandium This removes the dependency on config.status for CONFIGURE_DEFINE_FILES. Instead, each file depends on the specific configure values that it uses. MozReview-Commit-ID: H4oLmJei1KR
c7a8a56b56122aec979c28bafbe224ada342038e: Bug 902825 - Create config.statusd directory; r?glandium draft
Mike Shal <mshal@mozilla.com> - Fri, 18 Aug 2017 10:41:50 -0400 - rev 656181
Push 77107 by bmo:mshal@mozilla.com at Wed, 30 Aug 2017 20:33:18 +0000
Bug 902825 - Create config.statusd directory; r?glandium The config.statusd directory is created alongside config.status, which contains the same information but is split across many files instead of all in a single file. This allows the build system to track dependencies on individual configure values. MozReview-Commit-ID: 2DbwKCJuNSX
881d7b6b9f1d03fc7a4de4097acef0d12c4c0af3: Bug 1395319 - Disable private browsing about:home test when Activity Stream is enabled for about:home. draft
Andrei Oprea <andrei.br92@gmail.com> - Wed, 30 Aug 2017 22:26:27 +0200 - rev 656180
Push 77106 by bmo:andrei.br92@gmail.com at Wed, 30 Aug 2017 20:30:17 +0000
Bug 1395319 - Disable private browsing about:home test when Activity Stream is enabled for about:home. MozReview-Commit-ID: FIcaPQCayI7
82c012534ed4d5105cead580c9d7daed82b04b9b: Bug 1393274: Correct webpage RTL padding/margins. r=liuche draft
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 13:27:20 -0700 - rev 656179
Push 77105 by michael.l.comella@gmail.com at Wed, 30 Aug 2017 20:28:24 +0000
Bug 1393274: Correct webpage RTL padding/margins. r=liuche Previously, I added a comment to explain why the explicit 0dp padding/margins are necessary for RTL but since it's required everywhere padding/margins are used, it's unsustainable and I chose not to do it here. MozReview-Commit-ID: H7H9xgeLy8b
d0cd6eae039f76ed3b09668892e47d4368b4122f: Bug 1393274: Align webpage item row text to right in RTL, left in LTR. r=liuche draft
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 13:24:46 -0700 - rev 656178
Push 77105 by michael.l.comella@gmail.com at Wed, 30 Aug 2017 20:28:24 +0000
Bug 1393274: Align webpage item row text to right in RTL, left in LTR. r=liuche MozReview-Commit-ID: 6VSF73V6Mda
9369fd07eb959caf800cad58b37e543b83402b08: Bug 1393274: Rename card_history_item -> webpage_item_row & friends. r=liuche draft
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 11:45:27 -0700 - rev 656177
Push 77105 by michael.l.comella@gmail.com at Wed, 30 Aug 2017 20:28:24 +0000
Bug 1393274: Rename card_history_item -> webpage_item_row & friends. r=liuche Unrelated to RTL changes but these names are awful and gotta go! MozReview-Commit-ID: Kud6tgfEGkk
ad6d333d729c18da32d93d4b83b2ffda0ceaf3ef: Bug 1395319 - Disable private browsing about:home test when Activity Stream is enabled.
Andrei Oprea <andrei.br92@gmail.com> - Wed, 30 Aug 2017 22:26:27 +0200 - rev 656176
Push 77104 by bmo:andrei.br92@gmail.com at Wed, 30 Aug 2017 20:28:16 +0000
Bug 1395319 - Disable private browsing about:home test when Activity Stream is enabled. MozReview-Commit-ID: FIcaPQCayI7
be7d072391a41e75d68f35efabce4526febb9679: Bug 1271998 - Part 4 - Use a touch delegate to increase the clickable area of the URL bar. r?walkingice,jwu draft
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 29 Aug 2017 20:34:17 +0200 - rev 656175
Push 77103 by mozilla@buttercookie.de at Wed, 30 Aug 2017 20:26:57 +0000
Bug 1271998 - Part 4 - Use a touch delegate to increase the clickable area of the URL bar. r?walkingice,jwu Originally, the listeners that trigger editing mode and the URL bar's context menu were attached to the BrowserToolbar itself. As this doesn't work properly in conjunction with wrapping the URL TextView into a ScrollView, the listeners were moved onto the TextView itself. Bug 1389164 reduced the height of the TextView in order to better support lightweight themes with the new toolbar design, which in conjunction with the changes to support the ScrollView has the unfortunate side effect of also reducing the URL bar's hit target area. Therefore, we increase it back to its old levels by using a TouchDelegate on the ScrollView. Because Android's ScrollView implementation doesn't support TouchDelegates, we have to add the missing bits of logic back in from the default View implementation. MozReview-Commit-ID: 1nTrrNGvBza
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip