a4dded63672b7c3a1b4887831f9d4080d8d6b1fc: Bug 1343442 - decode-error/warning tests - r?gijs draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 11 Apr 2017 09:35:17 +1200 - rev 560840
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - decode-error/warning tests - r?gijs MozReview-Commit-ID: A0HO6RrnpMC
a74e566ff286a51725d84af89cfadb41ef4be9b7: Bug 1343442 - Handle decode-error/warning in browser-media.js - r?gijs draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 11 Apr 2017 13:37:52 +1200 - rev 560839
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - Handle decode-error/warning in browser-media.js - r?gijs Open webcompat.com in new tab, similar to what "Report Site Issue" button does. MozReview-Commit-ID: 1ESOY3upHgc
dc902fcb84d60d3c882c0ab9a43d5d2158902c44: Bug 1343442 - Re-enable browser_decoderDoctor.js on Mac - r?gijs draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 11 Apr 2017 08:18:22 +1200 - rev 560838
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - Re-enable browser_decoderDoctor.js on Mac - r?gijs Thanks to the previous patch, these tests can now be run on Mac, though they don't do anything useful there just yet. MozReview-Commit-ID: 3HyN7ms1EPl
4022c9d730c64697e40496f05a0c0a238fa923ba: Bug 1343442 - Refactored DecDoc browser tests for extensibility - r?gijs draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 10 Apr 2017 16:31:44 +1200 - rev 560837
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - Refactored DecDoc browser tests for extensibility - r?gijs Mostly moved things around to make future tests (using different parameter sets) easier to write. Also, all tests are now run on all platforms, but we're expecting nothing to happen in those cases that were previously skipped. It will be useful when we add tests that actually need to run on all platforms. MozReview-Commit-ID: AZTz9lr2eIJ
43c4c7bd3e48770bb1cdb5aa3e310e4420aa2540: Bug 1343442 - Analyze eDecodeError/Warning issues - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 24 Mar 2017 17:09:41 +1100 - rev 560836
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - Analyze eDecodeError/Warning issues - r?jya MozReview-Commit-ID: 97AhQz2Hgmi
6ba03a16ae03767aaee98116ce727446dc83d1fa: Bug 1343442 - Provide appropriate params to console message - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Thu, 23 Mar 2017 10:21:27 +1100 - rev 560835
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - Provide appropriate params to console message - r?jya MozReview-Commit-ID: HiaY20UqksU
f61ae9e102c78c81e61b9b20692bea809fcb6511: Bug 1343442 - Move NotificationAndReportStringId closer to first use - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 22 Mar 2017 15:37:41 +1100 - rev 560834
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - Move NotificationAndReportStringId closer to first use - r?jya MozReview-Commit-ID: IBn5jsHTsKx
738694f4e574d57c37f4c2f3cd31ad5e11d3348c: Bug 1343442 - Allow MediaDecodeError/Warning user notifications in Nightly - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 24 Mar 2017 16:37:45 +1100 - rev 560833
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - Allow MediaDecodeError/Warning user notifications in Nightly - r?jya We want the new MediaDecodeError messages to be forwarded to the front-end in browser-media.js (even though they won't be handled just yet; an upcoming patch will add the handling code). This is limited to Nightly for now, like the "Report Site Issues" button, because we forward URLs to webcompat.com (at the user's request). And MediaDecodeWarning was not added, as it may cause too much annoyance, but it is available for testers to get more diagnostics information if needed. MozReview-Commit-ID: HPDpA1mg4HX
7522590fa8fad5f630d1c8b3c5c73baad8cf10b6: Bug 1343442 - MediaDecodeError/Warning user notification messages - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 24 Mar 2017 16:47:23 +1100 - rev 560832
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - MediaDecodeError/Warning user notification messages - r?jya These messages will be displayed in the Decoder Doctor drop-down notification bar. The message ids are also used internally to identify corresponding issues. MozReview-Commit-ID: MmKxCEoTok
1ec54438befc112695e97dfd71bc95609246775f: Bug 1343442 - Decode-error/warning webidl notification types and data - r=smaug draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 22 Mar 2017 16:13:41 +1100 - rev 560831
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - Decode-error/warning webidl notification types and data - r=smaug Decoder Doctor webidl additions: DecoderDoctorNotificationType.decode-error and decode-warning DecoderDoctorNotification.decodeIssue, docURL and resourceURL MozReview-Commit-ID: FK0YOCeuQMX
572166bdf33bc1d1f3ac0b6081ab961d3f4d50c0: Bug 1341483 - MP4Metadata::GetTrackIndice() now also returns a success/error code - r?kinetik draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 15 Mar 2017 16:55:50 +1100 - rev 560830
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1341483 - MP4Metadata::GetTrackIndice() now also returns a success/error code - r?kinetik MozReview-Commit-ID: BIgvy5eKNJl
53766f81f74ef80a491427523039c2c8d9703147: Bug 1341483 - MP4Metadata::Crypto() now also returns a success/error code - r?kinetik draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 21:32:03 +1100 - rev 560829
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1341483 - MP4Metadata::Crypto() now also returns a success/error code - r?kinetik MozReview-Commit-ID: EywDv5JuDK6
3b4997e74995cc88af1642d03ccc32c8d01c44ae: Bug 1341483 - MP4Metadata::GetTrackInfo() now also returns a success/error code - r?kinetik draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 17:05:41 +1100 - rev 560828
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1341483 - MP4Metadata::GetTrackInfo() now also returns a success/error code - r?kinetik MozReview-Commit-ID: KQ3fJzZkrGW
5fdb247997247e282232b05ba95c0300ebcc0582: Bug 1341483 - MP4Metadata::GetNumberTracks() now also returns a success/error code - r?kinetik draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 13:36:59 +1100 - rev 560827
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1341483 - MP4Metadata::GetNumberTracks() now also returns a success/error code - r?kinetik In addition to the returned MediaResult, a special number-of-tracks value (not just 0) indicates an unrecoverable error. For Rust-vs-Stagefright comparison purposes, an error is considered the same as 0 (because Stagefright never returns errors, but Rust may, so complaining about that would be too noisy, and useless to us.) MozReview-Commit-ID: IwadWSOIWr4
0f0824d4def213e0f1e311106a0546cbf056bae7: Bug 1341483 - MP4Metadata::Metadata() now also returns a success/error code - r?kinetik draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 13:01:11 +1100 - rev 560826
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1341483 - MP4Metadata::Metadata() now also returns a success/error code - r?kinetik The returned MediaResult is used as error or warning in MP4Demuxer::Init(). MozReview-Commit-ID: Bnv4xG8bCJ4
520d1afa8740579915b4db629c409654f93cfa46: Bug 1343437 - 'media.playback.warnings-as-errors' pref - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 03 Mar 2017 16:10:48 +1100 - rev 560825
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343437 - 'media.playback.warnings-as-errors' pref - r?jya If 'media.playback.warnings-as-errors' is true, demuxing and decoding warnings (i.e., non-fatal errors) will be treated as errors, causing playback to fail. Currently set to false by default. This could be later changed to catch and diagnose more issues. MozReview-Commit-ID: BTaZ6TbIbNG
bd91a8ad1e0a9c721ed2114da3da429aa0484fc1: Bug 1343437 - TBM::OnDemuxer{Init,Reset}Done forward non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 14 Mar 2017 01:08:39 +1100 - rev 560824
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343437 - TBM::OnDemuxer{Init,Reset}Done forward non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya Similarly to the MediaFormatReader, TrackBuffersManager can forward warnings from the demuxer initialization to the associated HTMLMediaElement. Note that errors (sent to OnDemuxerInitFailed) are currently *not* forwarded to the HTMLMediaElement by design. In the future, we may want to add this feature so that mediasource errors can also be reported to webcompat. MozReview-Commit-ID: GjluZbpmC9q
89af89ab5687d285531d7e180880a68bfdbdb661: Bug 1343437 - MFR::OnDemuxerInitDone forwards non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 06 Mar 2017 15:22:17 +1100 - rev 560823
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343437 - MFR::OnDemuxerInitDone forwards non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya The MediaFormatReader now takes the MediaResult from the Demuxer::Init promise resolution, and if there are no other errors but the MediaResult is not NS_OK it will forward that warning to the decoder owner (i.e., the associated HTMLMediaElement). MozReview-Commit-ID: 5rTmzqqPLI0
cd9b965cf3ccd98cfc376ba4b1b8b787a41eab02: Bug 1343437 - MP4Demuxer::Init resolves with a MediaResult - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 10:10:28 +1100 - rev 560822
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343437 - MP4Demuxer::Init resolves with a MediaResult - r?jya If MP4Demuxer::Init detects some recoverable error (e.g., invalid tracks when others may still be usable), it will eventually Resolve the promise with the first warning. Later on, errors/warnings from the MP4Metadata parser will also be handled, to provide even better diagnostics. MozReview-Commit-ID: E9Rly9dhXW3
bad4713ab14340a7227ca7fbddb4668966807320: Bug 1343437 - MediaDataDemuxer::InitPromise resolve-value is now a MediaResult - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 28 Feb 2017 16:24:57 +1100 - rev 560821
Push 53551 by gsquelart@mozilla.com at Tue, 11 Apr 2017 23:47:44 +0000
Bug 1343437 - MediaDataDemuxer::InitPromise resolve-value is now a MediaResult - r?jya In case of successful initialization, there could still be some warning about a recoverable error. To carry more information about this potential warning, the resolve-value type of the promise is changed from nsresult to MediaResult. Existing code doesn't need to be changed: - In Resolve() calls, the stored MediaResult can implicitly be constructed from an nsresult -- always NS_OK at the moment anyway. - In following Then(), the promise's MediaResult can implicitly be converted to an nsresult. Future patches will modify some of the Resolve's and Then's, to forward warning details to some Decoder Doctor object... MozReview-Commit-ID: J0bXDFxXQHQ
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip