a1b313ae2de4425c050346505f83cfad0642acfe: Bug 1356718 - Query gtk settings schemas to avoid crashing when schema is missing. r?jfkthame draft
Zibi Braniecki <gandalf@mozilla.com> - Sun, 16 Apr 2017 00:13:07 -0700 - rev 563357
Push 54262 by zbraniecki@mozilla.com at Sun, 16 Apr 2017 07:13:20 +0000
Bug 1356718 - Query gtk settings schemas to avoid crashing when schema is missing. r?jfkthame MozReview-Commit-ID: 2rqO4XpLbfO
57ff1bb6c8ef8436d105c4b7fc91dccdd35e494b: Bug 1353057 - Split requests summary button into multiple labels. r?Honza draft
Vangelis Katsikaros <vkatsikaros@gmail.com> - Tue, 11 Apr 2017 22:41:26 +0300 - rev 563356
Push 54261 by vkatsikaros@gmail.com at Sun, 16 Apr 2017 06:43:09 +0000
Bug 1353057 - Split requests summary button into multiple labels. r?Honza MozReview-Commit-ID: 1lwmft6Nucy
16e1b51169e0246390e9951c648b78cd47cd0f2e: Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r?pike, r=pike draft
Zibi Braniecki <gandalf@mozilla.com> - Sat, 11 Mar 2017 18:43:11 -0800 - rev 563355
Push 54260 by zbraniecki@mozilla.com at Sun, 16 Apr 2017 06:38:28 +0000
Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r?pike, r=pike I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify most of the callsites that are looking for the first of the requested locales. In most cases, I'm just matching the behavior of the code with reusing LocaleService API instead of direct manipulation on the prefs. That includes how I handle error case scenarios. In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over the custom one from the file since the ones in LocaleService are just more correct and unified accross the whole platform. In case of FallbackEncoding I have to turn it into a nsIObserver to listen to intl:requested-locales-changed. MozReview-Commit-ID: 7rOr2CovLK
ea9b83be8450902c736931604aea3efc2608d658: Bug 1341372 - Part 10: Update css-transitions/reftest-stylo.list. draft
Boris Chiou <boris.chiou@gmail.com> - Fri, 07 Apr 2017 15:01:07 +0800 - rev 563354
Push 54259 by bmo:boris.chiou@gmail.com at Sun, 16 Apr 2017 06:29:51 +0000
Bug 1341372 - Part 10: Update css-transitions/reftest-stylo.list. All pass. MozReview-Commit-ID: 99o8zcSKh1f
c4de49e4fa010067a31d269f22a51a3dc68b8bbe: Bug 1341372 - Part 9: Update mochitest expectations. draft
Boris Chiou <boris.chiou@gmail.com> - Thu, 06 Apr 2017 13:23:42 +0800 - rev 563353
Push 54259 by bmo:boris.chiou@gmail.com at Sun, 16 Apr 2017 06:29:51 +0000
Bug 1341372 - Part 9: Update mochitest expectations. Also update test_transitions_dynamic_changes.html because we don't support "font" property for stylo now. According to its context and purpose, we only need a property other than "text-indent", so it is not necessary to use "font". Besides, we don't support shorthand properties for transitions, so test_transitions.html have two intermittents. Mark the expect number as '*' until we fix shorthand properties for transitions. MozReview-Commit-ID: HyuOV29AJ9a
95749c12bdd6da38df977e57d6adbc557dadf177: Bug 1341372 - Part 8: Rename needs_update_animations. draft
Boris Chiou <boris.chiou@gmail.com> - Fri, 14 Apr 2017 10:44:38 +0800 - rev 563352
Push 54259 by bmo:boris.chiou@gmail.com at Sun, 16 Apr 2017 06:29:51 +0000
Bug 1341372 - Part 8: Rename needs_update_animations. MozReview-Commit-ID: 2bJlBbdX543
9d92760cc6aa2465ced080040e445a71202823f4: Bug 1341372 - Part 7: Add a utility method to get AnimationCollection by Element and nsIAtom. draft
Boris Chiou <boris.chiou@gmail.com> - Fri, 14 Apr 2017 10:17:43 +0800 - rev 563351
Push 54259 by bmo:boris.chiou@gmail.com at Sun, 16 Apr 2017 06:29:51 +0000
Bug 1341372 - Part 7: Add a utility method to get AnimationCollection by Element and nsIAtom. We need a utility method to get the AnimationCollection by dom::Element and the pseudo element tag. MozReview-Commit-ID: KCOY6EKFFX5
c99869c661b25cd5da51d6b1f434dbaa77ae46e0: Bug 1341372 - Part 6: Trigger transitions. draft
Boris Chiou <boris.chiou@gmail.com> - Fri, 31 Mar 2017 15:43:37 +0800 - rev 563350
Push 54259 by bmo:boris.chiou@gmail.com at Sun, 16 Apr 2017 06:29:51 +0000
Bug 1341372 - Part 6: Trigger transitions. 1. We need to call get_after_change_style, which is the computed styles without transition rules, while process_animations. 2. If we have after-change style, we may replace the new computed values with after-change style, according to whether we really need to update transitions. 3. There are some cases we don't update transitions, so we need to early return. might_needs_transitions_update() will check it first and it will filter out most common cases. 4. needs_transitions_update() will check each property and existing running transitions to make sure we really don't need to update transitions. The logic of this function is similar with that of nsTransitionManager::DoUpdateTransitions(). MozReview-Commit-ID: 9eLd8fxmNd9
d99ad92ef75ae4bbf0b7bc945f2c15179c5b29b0: Bug 1356843 - Enable -Wcomma clang warnings. r?glandium draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 08 Apr 2017 12:36:48 -0700 - rev 563349
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Enable -Wcomma clang warnings. r?glandium Warn about possible misuse of the comma operator such as between two statements or to call a function for side effects within an expression. Only enable these -Wcomma warnings for C++ code because there are almost two hundred -Wcomma warnings in third-party C libraries. I reviewed the C warnings and confirmed none of them were latent bugs. We won't fix these libraries' warnings so they are just noise. MozReview-Commit-ID: 1JXJumg6DsJ
007462b7dc00e188382982ddf4a03f0c43be83e3: Bug 1356843 - Fix -Wcomma warning in tools/profiler/lul/LulDwarf.cpp. r?jseward draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 09 Apr 2017 21:43:29 -0700 - rev 563348
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warning in tools/profiler/lul/LulDwarf.cpp. r?jseward clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. tools/profiler/lul/LulDwarf.cpp:604:15: warning: possible misuse of comma operator here [-Wcomma] MozReview-Commit-ID: 6ZP79hgtrAD
528afe0a605c341a79d98ed2396a058ab1536e1e: Bug 1356843 - Fix -Wcomma warnings in layout/. r?dholbert draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 09 Apr 2017 21:11:45 -0700 - rev 563347
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warnings in layout/. r?dholbert clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression. In addition to fixing the warnings, replace some char16_t(' ') casts of char literals with shorter UTF-16 character literals u' '. layout/painting/FrameLayerBuilder.cpp:3647:31 [-Wcomma] possible misuse of comma operator here layout/painting/FrameLayerBuilder.cpp:3657:41 [-Wcomma] possible misuse of comma operator here layout/painting/nsCSSRenderingBorders.cpp:3336:33 [-Wcomma] possible misuse of comma operator here layout/painting/nsCSSRenderingBorders.cpp:3336:60 [-Wcomma] possible misuse of comma operator here layout/painting/nsCSSRenderingBorders.cpp:3337:33 [-Wcomma] possible misuse of comma operator here layout/painting/nsCSSRenderingBorders.cpp:3337:60 [-Wcomma] possible misuse of comma operator here layout/style/Declaration.cpp:808:41 [-Wcomma] possible misuse of comma operator here layout/style/Declaration.cpp:812:42 [-Wcomma] possible misuse of comma operator here layout/style/FontFaceSet.cpp:1118:60 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: 9tfcIsnnBwM
6285a5d92c1c0a0f8d0249945cd5c81d9c105ec7: Bug 1356843 - Fix -Wcomma warning in xpfe/appshell/nsXULWindow.cpp. r?mstange draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 08 Apr 2017 00:59:47 -0700 - rev 563346
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warning in xpfe/appshell/nsXULWindow.cpp. r?mstange clang's -Wcomma warning warns about suspicious use of the comma operator such as calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter. xpfe/appshell/nsXULWindow.cpp:2154:50 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: Dbe4NDDhqY1
cf3e1f896c8a9709cb6115f3cf17f4598d5d7864: Bug 1356843 - Fix -Wcomma warnings in widget/cocoa/nsDeviceContextSpecX.mm. r?spohl draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:26:25 -0700 - rev 563345
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warnings in widget/cocoa/nsDeviceContextSpecX.mm. r?spohl clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. widget/cocoa/nsDeviceContextSpecX.mm:246:26 [-Wcomma] possible misuse of comma operator here widget/cocoa/nsDeviceContextSpecX.mm:247:32 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: GhZQgNemLAE
969ec8a3c8f23d77271f88a0038babbf348024e1: Bug 1356843 - Fix -Wcomma warnings in xpcom/io/nsLocalFileUnix.cpp. r?froydnj draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 03 Apr 2017 11:05:57 -0700 - rev 563344
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warnings in xpcom/io/nsLocalFileUnix.cpp. r?froydnj clang's -Wcomma warning warns about suspicious use of the comma operator such as calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter. xpcom/io/nsLocalFileUnix.cpp:725:48 [-Wcomma] possible misuse of comma operator here xpcom/io/nsLocalFileUnix.cpp:1053:39 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: aebrgc5Wqk
f6a76f264d2f021934bb8eff2b9ecd6a396ceb68: Bug 1356843 - Fix -Wcomma warning in extensions/spellcheck/src/mozSpellChecker.cpp. r?masayuki draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:24:35 -0700 - rev 563343
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warning in extensions/spellcheck/src/mozSpellChecker.cpp. r?masayuki clang's -Wcomma warning warns about suspicious use of the comma operator such as calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter. extensions/spellcheck/src/mozSpellChecker.cpp:532:54 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: 3GnKVvx8Nu4
ab3820a7849a477f4dd737d3b59593c4d3c46f77: Bug 1356843 - Fix -Wcomma warnings in toolkit/. r?mossop draft
Chris Peterson <cpeterson@mozilla.com> - Wed, 05 Apr 2017 01:23:45 -0700 - rev 563342
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warnings in toolkit/. r?mossop clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter. toolkit/components/startup/nsAppStartup.cpp:436:58 [-Wcomma] possible misuse of comma operator here toolkit/components/statusfilter/nsBrowserStatusFilter.cpp:165:66 [-Wcomma] possible misuse of comma operator here toolkit/xre/CreateAppData.cpp:60:51 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: HuZRoOjQTGj
c34669f7fcc033eb598d18371183e748a010f173: Bug 1356843 - Fix -Wcomma warning in netwerk/protocol/http/Http2Stream.cpp. r?jhao draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:42:21 -0700 - rev 563341
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warning in netwerk/protocol/http/Http2Stream.cpp. r?jhao clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. netwerk/protocol/http/Http2Stream.cpp:436:59 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: AsmNPTjKlYB
51c53cfbc346151d4aa685ec891bce6837be1742: Bug 1356843 - Fix -Wcomma warning in modules/libjar/nsZipArchive.cpp. r?aklotz draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:39:36 -0700 - rev 563340
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warning in modules/libjar/nsZipArchive.cpp. r?aklotz clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression. modules/libjar/nsZipArchive.cpp:651:25 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: 9PjB915D81f
b3c001789e3e36dc721d8d206da8f5e831c91366: Bug 1356843 - Fix -Wcomma warnings in js/. r?jorendorff draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 09 Apr 2017 21:15:01 -0700 - rev 563339
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warnings in js/. r?jorendorff clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression. js/src/builtin/MapObject.cpp:786:48 [-Wcomma] possible misuse of comma operator here js/src/builtin/MapObject.cpp:1371:48 [-Wcomma] possible misuse of comma operator here js/src/builtin/RegExp.cpp:1266:62 [-Wcomma] possible misuse of comma operator here js/src/jit/x64/BaseAssembler-x64.h:624:99 [-Wcomma] possible misuse of comma operator here js/src/jsarray.cpp:2416:27 [-Wcomma] possible misuse of comma operator here js/src/jscompartment.cpp:120:48 [-Wcomma] possible misuse of comma operator here js/src/jsstr.cpp:3346:14 [-Wcomma] possible misuse of comma operator here js/xpconnect/src/XPCWrappedNativeJSOps.cpp:316:71 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: BbT4otUXczV
1b929c1f305a54249df4c7ce72d8edf250e2d757: Bug 1356843 - Fix -Wcomma warning in intl/uconv/util/nsUCSupport.cpp. r?jshin draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 08 Apr 2017 01:05:19 -0700 - rev 563338
Push 54258 by cpeterson@mozilla.com at Sun, 16 Apr 2017 05:52:14 +0000
Bug 1356843 - Fix -Wcomma warning in intl/uconv/util/nsUCSupport.cpp. r?jshin clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. intl/uconv/util/nsUCSupport.cpp:552:34 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: Emk05qDJHbm
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip