a0fe362559a5245162d1b9eac850e46e966be9a1: Bug 1450859 - Remove layout.css.expensive-style-struct-assertions.enabled pref. r?emilio draft
Cameron McCormack <cam@mcc.id.au> - Tue, 03 Apr 2018 15:58:32 +1000 - rev 776455
Push 104887 by bmo:cam@mcc.id.au at Tue, 03 Apr 2018 06:07:18 +0000
Bug 1450859 - Remove layout.css.expensive-style-struct-assertions.enabled pref. r?emilio With the old style system removed, this pref has no effect.
fb548b1cdbc856d1a94cc210dc7895a86e4f706e: Bug 1442531 - Make chevron button of devtool to be exclusive and apply the photon design. r?jdescottes draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Tue, 03 Apr 2018 13:34:31 +0900 - rev 776454
Push 104886 by bmo:mantaroh@gmail.com at Tue, 03 Apr 2018 04:37:50 +0000
Bug 1442531 - Make chevron button of devtool to be exclusive and apply the photon design. r?jdescottes This patch will: * change detecting overflow to using resize event. * make chevron menu and tab menu to be exclusive. * use photon design chevron menu. * modify the related tests. In this patch, the toolbox will calculate the displayed tab button size after rendering element since each width of toolbox tab is not fixed size.(i.e. each toolbox tab size is different from another size) MozReview-Commit-ID: EQ0nU6WzCg1
eb8304dc9eee03285ad9505b9ba07d56bd63d3b3: Bug 1438688, part 6 - Compile XPT information to C++ at build time. r=glandium,njn draft
Andrew McCreight <continuation@gmail.com> - Mon, 12 Mar 2018 10:30:35 -0700 - rev 776453
Push 104885 by bmo:continuation@gmail.com at Tue, 03 Apr 2018 04:22:05 +0000
Bug 1438688, part 6 - Compile XPT information to C++ at build time. r=glandium,njn This patch handles the actual generation of the static data structures used to represent XPT information. XPT files are generated in the same way as they are now, but they are used only as an intermediate representation to speed up incremental compilation rather than something used by Firefox itself. Instead of linking XPTs into a single big XPT file at packaging time, they are linked into a single big C++ file at build time, that defines the various static consts in XPTHeader. In xpt.py, every data structure that can get written to disk gets an additional code_gen() method that returns a representation of that data structure as C++ source code. CodeGenData aggregates this information together, handling deduplication and the final source code generation. The ctors are needed for XPTConstValue to statically initialize the different union cases without resorting to designated initializers, which are part of C99, not C++. Designated initializers appear to be supported in C++ code by Clang and GCC, but not MSVC. The ctors must be constexpr to ensure they are actually statically initialized so they can be shared between Firefox processes. I also removed an unnecessary "union" in XPTConstDescriptor. Together, these patches reduce the amount of memory reported by xpti-working-set from about 860,000 bytes to about 200,000 bytes. The remaining memory is used for xptiInterface and xptiTypelibGuts (which are thin wrappers around the XPT interfaces and header) and hash tables to speed up looking up interfaces by name or IID. That could potentially be eliminated from dynamic allocations in follow up work. These patches did not affect memory reporting because XPT arenas are still used by the remaining XPTI data structures. MozReview-Commit-ID: Jvi9ByCPa6H
e0fac8ff05b26fab6d4e1b9eccae231c85f9cba0: Bug 1438688, part 5 - Merge XPTInterfaceDirectoryEntry and XPTInterfaceDescriptor. r=njn draft
Andrew McCreight <continuation@gmail.com> - Mon, 12 Mar 2018 13:36:15 -0700 - rev 776452
Push 104885 by bmo:continuation@gmail.com at Tue, 03 Apr 2018 04:22:05 +0000
Bug 1438688, part 5 - Merge XPTInterfaceDirectoryEntry and XPTInterfaceDescriptor. r=njn With fully linked XPT data, there is exactly one directory entry per descriptor, plus one per unresolved interface. There are 1200 of the former and 40 of the latter. By merging them, we save a 32 bit int per directory entry, at the cost of 11 bytes per unresolved interface. This will make VerifyAndAddEntryIfNew slightly slower because it has to do an nsID equality check rather than a null check, but I can't imagine that will matter. My main goal for this patch is to reduce the size of the executable, to avoid a regression with my static XPT information patches, but it should reduce memory a little bit, too. MozReview-Commit-ID: L35YdOuAyF4
5d64453b5cc280a5f029a0ae3b8494b32316c4f1: Bug 1438688, part 4 - Hoist arrays to XPTHeader. r=njn draft
Andrew McCreight <continuation@gmail.com> - Wed, 28 Feb 2018 15:12:07 -0800 - rev 776451
Push 104885 by bmo:continuation@gmail.com at Tue, 03 Apr 2018 04:22:05 +0000
Bug 1438688, part 4 - Hoist arrays to XPTHeader. r=njn To allow XPT information to be shared between processes, it needs to not contain any pointers, because they cause relocations. I've eliminated pointers by hoisting all of the variable length data structures to XPTHeader, into a single array for each type of data. These data structures now use an index into these arrays to find their first element. Strings are similar, but they are mashed into a single giant string, including embedded null terminators. Modifying the accessor methods to support this is easy, because there is only a single global instance of each of these arrays in XPTHeader. MozReview-Commit-ID: 5rgwaEBvDYl
6dabe8e940fc35fd7a7e04b1e80948f8c5d86653: Bug 1438688, part 3 - Remove XPT files from the packaging process. r=glandium draft
Andrew McCreight <continuation@gmail.com> - Mon, 05 Mar 2018 14:27:29 -0800 - rev 776450
Push 104885 by bmo:continuation@gmail.com at Tue, 03 Apr 2018 04:22:05 +0000
Bug 1438688, part 3 - Remove XPT files from the packaging process. r=glandium Now that XPT files are not loaded from files at runtime, code for packaging XPT files can be removed. This means that a couple of test XPIDL interfaces will get shipped in builds to users that weren't before, but I don't think that matters much. This also puts XPT files into the local objdir for the XPIDL makefile, instead of dist/bin, because they are no longer part of the distribution. MozReview-Commit-ID: 7gWj8KWUun3
a38a06a48f317467ce389985146c448b5ee9a8a7: Bug 1438688, part 2b - Eliminate XPTHeader data structure. r=njn draft
Andrew McCreight <continuation@gmail.com> - Tue, 27 Mar 2018 14:04:01 -0700 - rev 776449
Push 104885 by bmo:continuation@gmail.com at Tue, 03 Apr 2018 04:22:05 +0000
Bug 1438688, part 2b - Eliminate XPTHeader data structure. r=njn Now that there is only one XPTHeader, we can devolve the fields in it to avoid some indirection. The biggest part here is getting rid of the mHeader field on xptiTypelibGuts. The array is [] instead of * to avoid a relocation, by ensuring that XPTHeader::kInterfaceDirectory as well as the data it points to cannot be changed. MozReview-Commit-ID: AzvNTNZKkfi
4117371debe4dac26bf1c144eea55f8ddb349e4d: Bug 1438688, part 2 - Load XPT information from a static variable instead of a file. r=njn draft
Andrew McCreight <continuation@gmail.com> - Wed, 28 Feb 2018 12:51:39 -0800 - rev 776448
Push 104885 by bmo:continuation@gmail.com at Tue, 03 Apr 2018 04:22:05 +0000
Bug 1438688, part 2 - Load XPT information from a static variable instead of a file. r=njn This patch removes C++ code related to reading in XPT information from files. (Code related to packaging XPT files will be removed in the next patch.) This includes code in the manifest parser, in addition to the actual code for parsing files. XPT information is now loaded directly from a single static data structure, XPTHeader::kHeader, which will be automatically generated at compile time from .idl files (via .xpt files). Note that the script to do that is not added until part 6 of this patch series, so linking will fail on parts 2 through 5. I inlined XPTInterfaceInfoManager::RegisterXPTHeader into the ctor, because that is the only caller. It feels like the lock there should not be needed any more, but I left it alone for now. The forward declaration of XPTArena in xptiprivate.h is needed because it was being bootlegged via xpt_xdr.h. Some of the data structures in reflect/xptinfo/ (which wrap the xpt_struct.h data structures) are still allocated using XPTArena. Hopefully we can get rid of that in followup work. I also deleted a lot of comments in xpt_struct.h that talk about the on-disk format. I also deleted checking of the major version number, because that should not matter when the XPT information is baked into the executable. MozReview-Commit-ID: 6NJdaCWRBhU
52a8e171d87561cd7db0f96ef650afb40137ccba: Bug 1438688, part 1 - Add methods for accessing arrays in xpt_struct.h. r=njn draft
Andrew McCreight <continuation@gmail.com> - Wed, 28 Feb 2018 10:07:45 -0800 - rev 776447
Push 104885 by bmo:continuation@gmail.com at Tue, 03 Apr 2018 04:22:05 +0000
Bug 1438688, part 1 - Add methods for accessing arrays in xpt_struct.h. r=njn This lets us hide later changes to how these arrays are stored. There should be no behavioral change. Some methods in xpt_struct.h are declared inline at the end of the header due to the order that classes are declared in the header. MozReview-Commit-ID: KAxUKn3sDOD
cd35ab7fd626d49d27722090588dd400e6600ca8: Bug 1448222 - Remove MediaPrefs. r=cpearce draft
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 20 Mar 2018 09:48:56 +1100 - rev 776446
Push 104884 by nnethercote@mozilla.com at Tue, 03 Apr 2018 03:28:36 +0000
Bug 1448222 - Remove MediaPrefs. r=cpearce This patch converts all the prefs in MediaPrefs to the new StaticPrefs system. Note that the "media.wmf.skip-blacklist" pref was present in both MediaPrefs and gfxPrefs. The copy in MediaPrefs was never used; this explains why this patch does not add an entry for it to StaticPrefList.h MozReview-Commit-ID: IfHP37NbIjY
d5ea91989390ccfbf195698ec4de176a5aec7d03: Bug 1449833 - Use StaticPrefs in nsJSEnvironment.cpp. r=sfink draft
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 27 Mar 2018 13:26:38 +1100 - rev 776445
Push 104884 by nnethercote@mozilla.com at Tue, 03 Apr 2018 03:28:36 +0000
Bug 1449833 - Use StaticPrefs in nsJSEnvironment.cpp. r=sfink MozReview-Commit-ID: GELa2l1ZonV
71bb41571e4df73afc26ead3126dbda0d15b22ea: [mq]: StaticPrefs-Stylo-servo draft
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 03 Apr 2018 11:53:58 +1000 - rev 776444
Push 104884 by nnethercote@mozilla.com at Tue, 03 Apr 2018 03:28:36 +0000
[mq]: StaticPrefs-Stylo-servo MozReview-Commit-ID: 8W8tNXhG1Jy
b136930a83fd165552ef8c62f529f8d639484f83: Bug 1448732 - Part 3: Adjust requestLongerTimeout. r=pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 03 Apr 2018 12:26:57 +0900 - rev 776443
Push 104883 by bmo:dakatsuka@mozilla.com at Tue, 03 Apr 2018 03:27:41 +0000
Bug 1448732 - Part 3: Adjust requestLongerTimeout. r=pbro MozReview-Commit-ID: Ia4mjyHyBci
98a9bb6339d34872009ce6e57fc81f36b415fa7e: Bug 1448732 - Part 2: Open detail pane by clicking on summary graph instead of selecting the node. r=pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 03 Apr 2018 12:26:36 +0900 - rev 776442
Push 104883 by bmo:dakatsuka@mozilla.com at Tue, 03 Apr 2018 03:27:41 +0000
Bug 1448732 - Part 2: Open detail pane by clicking on summary graph instead of selecting the node. r=pbro MozReview-Commit-ID: CeMj2VJwRR5
78f80b588fa9ff47af4f9b608c7ad6b817a93dfc: Bug 1448732 - Part 1: Remove extra animated elements before open animation inspector. r=pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 03 Apr 2018 12:26:10 +0900 - rev 776441
Push 104883 by bmo:dakatsuka@mozilla.com at Tue, 03 Apr 2018 03:27:41 +0000
Bug 1448732 - Part 1: Remove extra animated elements before open animation inspector. r=pbro MozReview-Commit-ID: Ds7fNJKDYc7
6cfc7515faf587ee0dfe03377d9529c461ad4ae2: Bug 1448732 - Part 0: Modify variables and code format for consistency. r=pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 03 Apr 2018 12:25:44 +0900 - rev 776440
Push 104883 by bmo:dakatsuka@mozilla.com at Tue, 03 Apr 2018 03:27:41 +0000
Bug 1448732 - Part 0: Modify variables and code format for consistency. r=pbro In this patch, modify the following things: * Modify variable name of test data list to "TEST_DATA" * Modify variable name of testing animation target class name to "targetClass" * Some comments format MozReview-Commit-ID: J33RRcm4chO
5a5451e34b0474dc6e1995456e843c66b12b1030: Bug 1446202 - 2. Don't pass pointer events to datetime inputs; r=jchen draft
Jim Chen <nchen@mozilla.com> - Mon, 02 Apr 2018 23:26:11 -0400 - rev 776439
Push 104882 by bmo:nchen@mozilla.com at Tue, 03 Apr 2018 03:27:13 +0000
Bug 1446202 - 2. Don't pass pointer events to datetime inputs; r=jchen Like the way we treat select fields, don't pass pointer events to date/time input fields either. MozReview-Commit-ID: Eucfbu6MizX
6be3f1d29c1d58b4824ea91cd0a024ff4bb7d679: Bug 1446202 - 1. Return correct locale string to Gecko; r?droeh draft
Jim Chen <nchen@mozilla.com> - Mon, 02 Apr 2018 23:25:27 -0400 - rev 776438
Push 104882 by bmo:nchen@mozilla.com at Tue, 03 Apr 2018 03:27:13 +0000
Bug 1446202 - 1. Return correct locale string to Gecko; r?droeh Locale.toString() doesn't return the correct locale format that Gecko expects, so reformat the locale string before returning. (for example, Locale.toString() returns "en_US_POSIX#Latn" whereas Gecko expects "en-Latn-US-POSIX"). The incorrect locale format was preventing intl code (and the datetime box) from initializing. MozReview-Commit-ID: JmDYkDj31pL
9d7b74c8531d3290e991fb85e80225bd60c33fdc: Bug 1448732 - Part 3: Adjust requestLongerTimeout. r=pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 03 Apr 2018 12:19:48 +0900 - rev 776437
Push 104881 by bmo:dakatsuka@mozilla.com at Tue, 03 Apr 2018 03:22:58 +0000
Bug 1448732 - Part 3: Adjust requestLongerTimeout. r=pbro MozReview-Commit-ID: 1WgODwZpdzA
832f72793ad6a35822c2ce90d5649db84165d98c: Bug 1448732 - Part 2: Open detail pane by clicking on summary graph instead of selecting the node. r=pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 03 Apr 2018 12:18:57 +0900 - rev 776436
Push 104881 by bmo:dakatsuka@mozilla.com at Tue, 03 Apr 2018 03:22:58 +0000
Bug 1448732 - Part 2: Open detail pane by clicking on summary graph instead of selecting the node. r=pbro MozReview-Commit-ID: HDuNlR4Wwzr
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip