9f6cd52fc7f02ef2e124c982789a10e223f0fcb7: Bug 1415556 - P12. Remove unecessary locking. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 11 Nov 2017 10:20:59 +0100 - rev 696759
Push 88781 by bmo:jyavenard@mozilla.com at Sat, 11 Nov 2017 09:23:59 +0000
Bug 1415556 - P12. Remove unecessary locking. r?padenot The method doesn't use any MSG member, only dispatching a task. MozReview-Commit-ID: 7uZbTvq9OQt
c9099f4416c635d6128a830dac1b43cad4da27e3: Bug 1415556 - P11. Make functions const where needed. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 20:01:27 +0100 - rev 696758
Push 88781 by bmo:jyavenard@mozilla.com at Sat, 11 Nov 2017 09:23:59 +0000
Bug 1415556 - P11. Make functions const where needed. r?padenot MozReview-Commit-ID: EBEgDVCTewa
b2a3b8bc3fa346a03d2d2acdefe4a98583d0478b: Bug 1415556 - P10. Remove unused member. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 19:00:12 +0100 - rev 696757
Push 88781 by bmo:jyavenard@mozilla.com at Sat, 11 Nov 2017 09:23:59 +0000
Bug 1415556 - P10. Remove unused member. r?padenot MozReview-Commit-ID: 2LbqhBkmDBF
52460ed79c78de18600297eca859c5450614bf94: Bug 1415556 - P9. Assert on proper access of mStreams member. r?padenot. draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:56:29 +0100 - rev 696756
Push 88781 by bmo:jyavenard@mozilla.com at Sat, 11 Nov 2017 09:23:59 +0000
Bug 1415556 - P9. Assert on proper access of mStreams member. r?padenot. mStreams should only ever be accessed on the MSG thread. However, under some shutdown circumstances, it can be accessed on the main thread while the MSG thread is still alive. This will be corrected in bug 1408276. MozReview-Commit-ID: 6xWzxxV1Dv3
c8ad9f3f59ebe067cba6d97dbdb4b735fe0d12d8: Bug 1415556 - P8. Remove unecessary locking. r?padenot. draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:53:23 +0100 - rev 696755
Push 88781 by bmo:jyavenard@mozilla.com at Sat, 11 Nov 2017 09:23:59 +0000
Bug 1415556 - P8. Remove unecessary locking. r?padenot. mForceShutdownTicket and mShutdownTimer are only ever accessed on the main thread. We don't need the use of the monitor to reset them. MozReview-Commit-ID: 1DL8bLmzEH5
becfe0449ed35f2622a7500a3c93acc6e325cd9e: Bug 1415556 - P7. Remove handling of non-used case. r?padenot. draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:51:57 +0100 - rev 696754
Push 88781 by bmo:jyavenard@mozilla.com at Sat, 11 Nov 2017 09:23:59 +0000
Bug 1415556 - P7. Remove handling of non-used case. r?padenot. We now assert that DestroyNonRealtimeInstance must be used in combination of StartNonRealtimeProcessing, as this is how its always used. MozReview-Commit-ID: 7c30FuucdP4
79db6cec9548275d14012ba7d112a72ba44a5756: Bug 1415556 - P6. Ensure mLifecycleState member is always accessed safely. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:38:02 +0100 - rev 696753
Push 88781 by bmo:jyavenard@mozilla.com at Sat, 11 Nov 2017 09:23:59 +0000
Bug 1415556 - P6. Ensure mLifecycleState member is always accessed safely. r?padenot We only access mLifecycleState via a helper which strongly enforced how the member can be accessed. Two non-safe accesses are corrected. MozReview-Commit-ID: 6LYk7t4rSyB
7925479fd30a430459feecfb98dee4d1e723948e: Bug 1415556 - P5. Use helper to set mDriver. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:28:42 +0100 - rev 696752
Push 88781 by bmo:jyavenard@mozilla.com at Sat, 11 Nov 2017 09:23:59 +0000
Bug 1415556 - P5. Use helper to set mDriver. r?padenot MozReview-Commit-ID: Fres1YwcYYM
129c1bb2eb3f7e5df024f32d73cbd5217bf7e32e: Bug 1415556 - P4. Make members atomics. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:27:39 +0100 - rev 696751
Push 88781 by bmo:jyavenard@mozilla.com at Sat, 11 Nov 2017 09:23:59 +0000
Bug 1415556 - P4. Make members atomics. r?padenot They are accessed across multiple threads without the use of monitors. While it could be argued that some use of the monitor in functions accessing those members would set in place memory barriers, making them atomics remove all doubts as to the thread safetyness of their use. MozReview-Commit-ID: tyTqeGgDNM
4f843377d92ca5e592560849dee0ef806ba00082: Bug 1415556 - P3. clearly mark functions' thread use. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 10 Nov 2017 18:24:20 +0100 - rev 696750
Push 88781 by bmo:jyavenard@mozilla.com at Sat, 11 Nov 2017 09:23:59 +0000
Bug 1415556 - P3. clearly mark functions' thread use. r?padenot MozReview-Commit-ID: BXmdk4zBo28
1fa71577e40c4bc09eb05588c9535e9f72bf9fc1: Bug 1319597 - Move DPR text into the DPR menu options. r=jryans draft
abhinav <abhinav.koppula@gmail.com> - Tue, 07 Nov 2017 23:11:50 +0530 - rev 696749
Push 88780 by bmo:abhinav.koppula@gmail.com at Sat, 11 Nov 2017 09:15:41 +0000
Bug 1319597 - Move DPR text into the DPR menu options. r=jryans MozReview-Commit-ID: 8gTzkWvVdfn
8a6ae3b98f3ca9986af44ef679318261eca9c81c: Bug 1416028 - Prevent browser_pluginCrashedCommentAndURL.js from leaking crash dump files; r?mconley draft
Gabriele Svelto <gsvelto@mozilla.com> - Mon, 06 Nov 2017 16:16:13 +0100 - rev 696748
Push 88779 by gsvelto@mozilla.com at Sat, 11 Nov 2017 07:23:53 +0000
Bug 1416028 - Prevent browser_pluginCrashedCommentAndURL.js from leaking crash dump files; r?mconley This patch also checks for I/O errors when deleting leftover crashdump files in the test harness and reports them if the files couldn't be deleted. This won't prevent tests from leaking crash dumps if they're not written correctly, but it will make their presence visible and won't cause the harness to hang if it cannot delete them. MozReview-Commit-ID: FLvBJxEKkH5
9300de6ba636c2f4e16ce63241c2cd231815ec1d: Bug 1414824 - Enable stricter linting in taskcluster yaml files. r?Callek draft
Steve Armand <stevea1@mac.com> - Sat, 11 Nov 2017 00:36:41 -0500 - rev 696747
Push 88778 by bmo:stevea1@mac.com at Sat, 11 Nov 2017 05:41:22 +0000
Bug 1414824 - Enable stricter linting in taskcluster yaml files. r?Callek MozReview-Commit-ID: FH0ntvwfaG8
0c62b39476d307881d68cd61eeef82c9c50595a2: Bug 1414824 - Lint more taskcluster yaml. r?Callek draft
Steve Armand <stevea1@mac.com> - Sat, 11 Nov 2017 00:36:41 -0500 - rev 696746
Push 88777 by bmo:stevea1@mac.com at Sat, 11 Nov 2017 05:38:19 +0000
Bug 1414824 - Lint more taskcluster yaml. r?Callek MozReview-Commit-ID: 4BmswfkVsBv
91675759981c8e6185e6dc67ed88103265b135d8: Bug 1402850 Don't include runtime permissions in prompts for webextension updates draft
Andrew Swan <aswan@mozilla.com> - Wed, 08 Nov 2017 17:14:11 -0800 - rev 696745
Push 88776 by aswan@mozilla.com at Sat, 11 Nov 2017 05:17:24 +0000
Bug 1402850 Don't include runtime permissions in prompts for webextension updates MozReview-Commit-ID: 1cnNsWLVGmg
995d7bc2c4fd372572115c685671055b9a5b4dcd: Bug 1415470 - build: Enable VS2017 C5038 initializer list order warnings (like gcc -Wreorder). r?glandium draft
Chris Peterson <cpeterson@mozilla.com> - Tue, 07 Nov 2017 19:52:10 -0800 - rev 696744
Push 88775 by cpeterson@mozilla.com at Sat, 11 Nov 2017 04:30:06 +0000
Bug 1415470 - build: Enable VS2017 C5038 initializer list order warnings (like gcc -Wreorder). r?glandium C5038 is a new warning in VS2017, similar to gcc and clang's -Wreorder, which is enabled by -Wall. We should enable C5038 so Windows developers can see these warnings locally instead of when gcc and clang fail with warnings-as-errors on Try. https://blogs.msdn.microsoft.com/vcblog/2017/07/21/diagnostic-improvements-in-vs2017-15-3-0/ We need to suppress C5038 warnings from Windows Runtime Library header files (wrl.h) included in ANGLE and widget/windows: z:\build\build\src\vs2017_15.4.2\SDK\Include\10.0.15063.0\winrt\wrl\wrappers\corewrappers.h(515): error C5038: data member 'Microsoft::WRL::Wrappers::Details::SyncLockWithStatusT<Microsoft::WRL::Wrappers::HandleTraits::SemaphoreTraits>::sync_' will be initialized after data member 'Microsoft::WRL::Wrappers::Details::SyncLockWithStatusT<Microsoft::WRL::Wrappers::HandleTraits::SemaphoreTraits>::status_' ... And suppress C5038 warnings in upstream webrtc code: media/webrtc/trunk/webrtc/modules/video_capture/windows/BaseFilter.cpp(176): error C5038: data member 'mozilla::media::BaseFilter::mClsId' will be initialized after data member 'mozilla::media::BaseFilter::mState' media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp(169): error C5038: data member 'mozilla::media::BasePin::mFilter' will be initialized after data member 'mozilla::media::BasePin::mLock' media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp(170): error C5038: data member 'mozilla::media::BasePin::mLock' will be initialized after data member 'mozilla::media::BasePin::mName' media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp(172): error C5038: data member 'mozilla::media::BasePin::mDirection' will be initialized after data member 'mozilla::media::BasePin::mQualitySink' MozReview-Commit-ID: BMDVkvQXNoq
d79c324dd748ddb92a2aa113d081fbed8b2a8937: Bug 1415470 - build: Remove always-true version check for VS >= 2015. r?glandium draft
Chris Peterson <cpeterson@mozilla.com> - Fri, 10 Nov 2017 18:24:53 -0800 - rev 696743
Push 88775 by cpeterson@mozilla.com at Sat, 11 Nov 2017 04:30:06 +0000
Bug 1415470 - build: Remove always-true version check for VS >= 2015. r?glandium MozReview-Commit-ID: 1e4Xsw3U3LR
e1ef3a81611b560fb98c790279f14ff540078b26: Bug 1415470 - a11y: Fix VS2017 initializer list order warnings. r=yzen draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 06 Nov 2017 23:54:53 -0800 - rev 696742
Push 88775 by cpeterson@mozilla.com at Sat, 11 Nov 2017 04:30:06 +0000
Bug 1415470 - a11y: Fix VS2017 initializer list order warnings. r=yzen Reorder DocAccessibleParent's and DocAccessibleChild's constructor initializer lists to fix these VS2017 warnings: a11y/DocAccessibleParent.h(32): warning C5038: data member 'mozilla::a11y::DocAccessibleParent::mShutdown' will be initialized after data member 'mozilla::a11y::DocAccessibleParent::mEmulatedWindowHandle' accessible/ipc/win/DocAccessibleChild.cpp(22): warning C5038: data member 'mozilla::a11y::DocAccessibleChild::mEmulatedWindowHandle' will be initialized after data member 'mozilla::a11y::DocAccessibleChild::mIsRemoteConstructed' MozReview-Commit-ID: 8flWtpe13ob
03c6ff933ce8082dd99c87959acae93343388d46: Bug 1412554 - Return GL_OOM if memory counter in ResourceManager11 overflow draft
Chih-Yi Leu <subsevenx2001@gmail.com> - Wed, 08 Nov 2017 10:36:18 +0800 - rev 696741
Push 88774 by bmo:cleu@mozilla.com at Sat, 11 Nov 2017 03:36:56 +0000
Bug 1412554 - Return GL_OOM if memory counter in ResourceManager11 overflow MozReview-Commit-ID: AgDd95NlNZq
a5b286787843d23a812cba6ac137d3a1f5a20f6f: Bug 1416407: Fix imports for WDSpec New Session tests. r?jgraham draft
David Burns <dburns@mozilla.com> - Sat, 11 Nov 2017 03:23:33 +0000 - rev 696740
Push 88773 by bmo:dburns@mozilla.com at Sat, 11 Nov 2017 03:24:55 +0000
Bug 1416407: Fix imports for WDSpec New Session tests. r?jgraham MozReview-Commit-ID: BUakWe8fhee
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip