9e166b2418ca1dbb82c0c6a1bdf9fdcf3de78f6b: Bug 1315065 When selection is collapsed in an empty text node, Backspace/Delete key press should modify the nearest text node r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 Nov 2016 12:24:21 +0900 - rev 437788
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1315065 When selection is collapsed in an empty text node, Backspace/Delete key press should modify the nearest text node r=smaug Currently, when selection is collapsed at an empty text node, the behavior of each major browser is different. When you remove the last character of non-empty text node followed by empty text nodes, Chromium removes all following empty text nodes. However, Edge never removes empty text nodes even when selection is collapsed at an empty text node. With this patch, our behavior becomes same as Edge. I think that we should take this for keeping backward compatibility since Gecko never removes empty text nodes. So, in other words, this patch makes Backspace key press at an empty text node modify the preceding non-empty text node. When you remove the first character of non-empty text node preceded with empty text nodes, Edge removes all preceding empty text nodes. However, Chromium and Gecko keeps previous empty text nodes than caret position. So, we should keep current behavior for backward compatibility. In other words, this patch makes Delete key press at an empty text node modify the following non-empty text node and keep current behavior. The fixing approach of this is, making WSRunObject::PriorVisibleNode() and WSRunObject::NextVisibleNode() ignore empty text node. This should make sense because empty text node is not a visible node. (On the other hand, when the DOMPoint has a null character, it should treat as visible character. That is visible with Unicode codepoint.) MozReview-Commit-ID: 11YtqBktEvK
d284cdb3ad6e0609a53a275df6efcff4255c30ec: merge autoland to mozilla-central a=merge
Carsten "Tomcat" Book <cbook@mozilla.com> - Fri, 11 Nov 2016 16:32:08 +0100 - rev 437787
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
merge autoland to mozilla-central a=merge
4769fe1cc0041723b7fef9da422719cf3125a4c7: Backed out changeset 9cfc41a2869e (bug 1267810) for eslint failures
Carsten "Tomcat" Book <cbook@mozilla.com> - Fri, 11 Nov 2016 09:08:33 +0100 - rev 437786
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Backed out changeset 9cfc41a2869e (bug 1267810) for eslint failures
0b58909e7626c6c36aa00fa52cab7143205e912f: Backed out changeset 7ef35cccfd7b (bug 1267810)
Carsten "Tomcat" Book <cbook@mozilla.com> - Fri, 11 Nov 2016 09:08:18 +0100 - rev 437785
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Backed out changeset 7ef35cccfd7b (bug 1267810)
8b8c3c3b29c93c0efb810b682bca08364164f960: Backed out 2 changesets (bug 1315407) for test-addon-installer.js.test and browser_bug553455.js failures a=backout
Wes Kocher <wkocher@mozilla.com> - Thu, 10 Nov 2016 23:36:48 -0800 - rev 437784
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Backed out 2 changesets (bug 1315407) for test-addon-installer.js.test and browser_bug553455.js failures a=backout Backed out changeset 7f747c8f6c60 (bug 1315407) Backed out changeset 95ef280ccc1b (bug 1315407)
2a0faaf8a4ffa86bd72cf437cb890e0271964121: Backed out changeset 15886f6c3dd1 (bug 1311576) for test_ext_webrequest_filter.html failures a=backout
Wes Kocher <wkocher@mozilla.com> - Thu, 10 Nov 2016 23:36:07 -0800 - rev 437783
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Backed out changeset 15886f6c3dd1 (bug 1311576) for test_ext_webrequest_filter.html failures a=backout
422c83e9e3be7c82e63ffdd43ad7ffc997975e0e: Bug 1308153 - part4 : add tooltip for unblock icon. r=jaws
Alastor Wu <alwu@mozilla.com> - Fri, 11 Nov 2016 10:43:21 +0800 - rev 437782
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1308153 - part4 : add tooltip for unblock icon. r=jaws MozReview-Commit-ID: LkfYpYGaG0e
a1dcb0e936b0fb26f98627f46f7ada95ac89ac2b: Bug 1308153 - part3 : implement the logic about showing the unblocking icon. r=jaws
Alastor Wu <alwu@mozilla.com> - Fri, 11 Nov 2016 10:42:40 +0800 - rev 437781
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1308153 - part3 : implement the logic about showing the unblocking icon. r=jaws Showing unblocking icon when the tab's media is blocked, and hide the icon when user clicks unblocking icon or opens that tab. MozReview-Commit-ID: LHxop9qL0uf
0dcd1140565dca7d936d0d625e1f03cad4d1bb3c: Bug 1308153 - part2 : Add media-unblocking icon. r=jaws
Alastor Wu <alwu@mozilla.com> - Fri, 11 Nov 2016 10:42:38 +0800 - rev 437780
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1308153 - part2 : Add media-unblocking icon. r=jaws Add the new svg for unblocking icon. See bug1308399 for more UX details. MozReview-Commit-ID: 6AYXJsFRQTh
daaf3d17df3229983b8b825453ce0f3fe5ad008a: Bug 1308153 - part1 : notify tabbrowser when the tab was blocked. r=baku,jaws
Alastor Wu <alwu@mozilla.com> - Fri, 11 Nov 2016 10:42:35 +0800 - rev 437779
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1308153 - part1 : notify tabbrowser when the tab was blocked. r=baku,jaws We need to notify tabbrowser about media-blocking so that we can show the unblocking tab icon. See bug1308399 for more UX details. MozReview-Commit-ID: E25lEhZLCZk
7ef35cccfd7b37a69354f08bfa4d118e4fcc4dd3: Bug 1267810 - Use the new module to implement the omnibox api. r=aswan,robwu
Matthew Wein <mwein@mozilla.com> - Fri, 11 Nov 2016 02:06:43 +0000 - rev 437778
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1267810 - Use the new module to implement the omnibox api. r=aswan,robwu MozReview-Commit-ID: GYzueGSijyd
9cfc41a2869ee9a880aaae5d22a34e2daa7b64b6: Bug 1267810 - Add a module for registering keywords and handling keyword input sessions. r=adw
Matthew Wein <mwein@mozilla.com> - Fri, 11 Nov 2016 02:06:14 +0000 - rev 437777
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1267810 - Add a module for registering keywords and handling keyword input sessions. r=adw MozReview-Commit-ID: Ghqe5xLw67Y
117b0fa754f7879063174e138cfdf05d1c8dfabb: Bug 1300016 - only suspend web-speech when mUtterance exists. r=eeejay
Alastor Wu <alwu@mozilla.com> - Mon, 07 Nov 2016 17:49:13 +0800 - rev 437776
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1300016 - only suspend web-speech when mUtterance exists. r=eeejay MozReview-Commit-ID: E29qJ1sgZ5c
1fdb1f8a9ddd74fde0ce54694fb096e5317adce7: Bug 1303051 - Printing Issue: Page Setup not being respected since upgrade to 48.01 on Mac; r=mconley
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 09 Nov 2016 17:37:40 -0800 - rev 437775
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1303051 - Printing Issue: Page Setup not being respected since upgrade to 48.01 on Mac; r=mconley Adds serialization of native print settings values so that correct page size, scaling, orientation are sent to the child after the print dialog is displayed. Changes the Mac print dialog code to load native print settings from the "print.macosx.pagesetup-2" pref and ignore what is passed in. Overwrites the scaling percentage specified in the print dialog when "Ignore Scaling and Shrink to Fit Page Width" is checked. Scaling on Nightly (remote printing) needs more work to be done in a follow up bug. MozReview-Commit-ID: B12ZeHuiYFJ
8d8337d3199c80c015caf726e9b205ca82cd8334: Bug 1316249: tooltool: specify binary mode in all open(..) calls; r=gps
Dustin J. Mitchell <dustin@mozilla.com> - Thu, 10 Nov 2016 15:08:38 +0000 - rev 437774
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1316249: tooltool: specify binary mode in all open(..) calls; r=gps From upstream https://github.com/mozilla/build-tooltool/pull/33 MozReview-Commit-ID: FRex4g9OB2x
bc22ca7ff05bbe74b770f9c41ca7bcadfe188d98: Bug 1315938 - Don't crash if tabs aren't initialised yet r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Tue, 08 Nov 2016 13:07:24 +0100 - rev 437773
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1315938 - Don't crash if tabs aren't initialised yet r=sebastian getSelectedTab() specifies that it can return null "if we're doing a session restore after a crash and Gecko isn't ready yet". This seems to occasionally be happening, resulting in crashes. (What isn't clear is why this would be happening more regularly in 51, it's possible some completely unrelated changes are either making the rendering of TopSites faster, causing this call to be made earlier, or session restore has simply gotten slower. We have also had a crash spike recently due to library loading issues, which would likely further exacerbate the whole issue.) MozReview-Commit-ID: GLFOoXFrAkj
86d2e155758ce5eb42f29f3cfae120a647189e95: Bug 1315717 - Add ripple feedback to AS context menu buttons on Android >= 5 r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Tue, 08 Nov 2016 10:11:02 -0500 - rev 437772
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1315717 - Add ripple feedback to AS context menu buttons on Android >= 5 r=sebastian The circular ripple is only available on API >= 21. We can fallback to a different solution for older devices, see following patch. MozReview-Commit-ID: C0aBqsKsuZ5
f1c1918210f7e34b0ce3cf7f89f202f25c60c33d: Bug 1315717 - Pre: rearrange higlights padding to increase area for menu button r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Tue, 08 Nov 2016 10:09:08 -0500 - rev 437771
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1315717 - Pre: rearrange higlights padding to increase area for menu button r=sebastian The ripple added using selectableItemBackgroundBorderless is scaled to the actual View area. By rearranging our margins+padding we are able to make the empty space around the menu button part of its padding, which results in a more naturally sized ripple. Without this patch the circular ripple is tiny and looks odd. MozReview-Commit-ID: 3jHWiubMtDD
15886f6c3dd16e121952be48e2559ba7b00f1a17: Bug 1311576 fix webrequest filter for tabId and windowId, r=kmag
Shane Caraveo <scaraveo@mozilla.com> - Thu, 10 Nov 2016 09:54:34 -0800 - rev 437770
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1311576 fix webrequest filter for tabId and windowId, r=kmag MozReview-Commit-ID: Gfg3Wv7JGI6
7f747c8f6c60d87ab282d79899e9f10655d8ec82: Bug 1315407 Refactor AddonInstall r=mossop,rhelmer
Andrew Swan <aswan@mozilla.com> - Wed, 09 Nov 2016 13:04:30 -0800 - rev 437769
Push 35513 by eglassercamp@mozilla.com at Fri, 11 Nov 2016 16:14:07 +0000
Bug 1315407 Refactor AddonInstall r=mossop,rhelmer MozReview-Commit-ID: Hj88zv7cBhI
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip