9c22df3f6ac5e9c9f9ccd95a84edb94646927ffb: Bug 1374207 - part2: TextComposition, IMEContentObserver and IMEStateManager should use EditorBase instead of nsIEditor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 20 Jun 2017 19:23:44 +0900 - rev 597583
Push 64964 by masayuki@d-toybox.com at Tue, 20 Jun 2017 17:30:46 +0000
Bug 1374207 - part2: TextComposition, IMEContentObserver and IMEStateManager should use EditorBase instead of nsIEditor r?m_kato MozReview-Commit-ID: IdHmseTiv2t
862c9f5211bf0193bee8e7d1c629b7819c562bba: Bug 1374207 - part1: nsTextEditorState should use mozilla::TextEditor instead of editor interfaces r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 20 Jun 2017 22:57:08 +0900 - rev 597582
Push 64964 by masayuki@d-toybox.com at Tue, 20 Jun 2017 17:30:46 +0000
Bug 1374207 - part1: nsTextEditorState should use mozilla::TextEditor instead of editor interfaces r?smaug Using concrete class rather than interface classes (nsI*Editor) will allow to reduce QI and some virtual calls. Therefore, Editor classes should be used as concrete class as far as possible. Unfortunately, if classes referring editor is initialized via scriptable interface, we cannot do this. E.g., inline spellchecker and nsIDocShell. Such remaining cases should be investigated after XUL addons are banned. Note that this patch also creates nsIdentifierMapEntry.h which is separated from nsDocument.h because ShadowRoot.h needs the class but exposing nsDocument.h to the global and includes it causes bustage on Linux and Android. Therefore, for fixing the include hell, this patch touches them and ContentChild.cpp. MozReview-Commit-ID: i6fLWw6Qeo
8f9cf08dc8ae5a567c9bf5a476e83f32008db9cf: Bug 596501 TextEditRules::WillOutputText() should handle itself if it can return only the text of first text node r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Jun 2017 19:08:10 +0900 - rev 597581
Push 64964 by masayuki@d-toybox.com at Tue, 20 Jun 2017 17:30:46 +0000
Bug 596501 TextEditRules::WillOutputText() should handle itself if it can return only the text of first text node r?m_kato TextEditor::OutputToString() uses DocumentEncoder if TextEditRules::WillOutputText() doesn't handle it. However, TextEditRules::WillOutputText() doesn't handle it even if it's really simple case of <input type="text"> and <textarea>. This patch makes TextEditRules::WillOutputText() handle it if DOM tree in the editor root element is expected and there is no special flag which requires complicated handling. MozReview-Commit-ID: 3HvdTAWRpw0
ee84cbd299172426529a34383f1f12ce1215743f: Bug 1357021 - Part 2: Add browser_onboarding_tours.js test, r=mossop draft
Fischer.json <fischer.json@gmail.com> - Sun, 18 Jun 2017 17:14:09 +0800 - rev 597580
Push 64963 by bmo:fliu@mozilla.com at Tue, 20 Jun 2017 17:28:50 +0000
Bug 1357021 - Part 2: Add browser_onboarding_tours.js test, r=mossop This commit - renames browser_onboarding_hide_tours.js to browser_onboarding_tours.js - adds test_click_action_button_to_set_tour_completed and test_set_right_tour_completed_style_on_overlay test cases - updates test_hide_onboarding_tours test case to test the changes of prefs of tours complete state MozReview-Commit-ID: A0jD0lZWywL
3c8de6540970e31b7caf0603dd23008795225763: Bug 1355625 - Part 2: Tweak the Gradle build to agree more with moz.build. r=sebastian draft
Nick Alexander <nalexander@mozilla.com> - Tue, 20 Jun 2017 10:18:59 -0700 - rev 597579
Push 64962 by nalexander@mozilla.com at Tue, 20 Jun 2017 17:25:34 +0000
Bug 1355625 - Part 2: Tweak the Gradle build to agree more with moz.build. r=sebastian MozReview-Commit-ID: DMoxPnla3Ij
d9f770a520bc8715d465260d97ca3eff16195c27: Bug 1355625 - Part 1: Invoke aapt using py_action. r=mshal draft
Nick Alexander <nalexander@mozilla.com> - Tue, 20 Jun 2017 10:24:28 -0700 - rev 597578
Push 64962 by nalexander@mozilla.com at Tue, 20 Jun 2017 17:25:34 +0000
Bug 1355625 - Part 1: Invoke aapt using py_action. r=mshal This adds a py_action invocation wrapping aapt and implements a hacky implementation of the Gradle build system's resource merging algorithm; once we have the moz.build and Gradle resources identical, we'll be one big step closer to producing bit-identical builds and flipping the switch in favour of Gradle. With this, the R.txt produced by the aapt invocation is the same as the R.txt produced by the py_action invocation. Originally I wrote this to use GENERATED_FILES, but it produced a world of pain. Since Android's aapt tool is fundamentally directory oriented, not file oriented, it required adding support for FORCE to GENERATED_FILES and required directory crawling and FileAvoidWrite in the wrapper. After getting that working I was eventually stymied by the arcane requirements of the Android re-packaging system, which interacts with the l10n system. I would have required support for building GENERATED_FILES in the libs tier rather than the misc tier. After that realization I gave up and turned to py_action: the dependencies on branding are just too entangled with l10n to use GENERATED_FILES. And, in the not-so-distant future, all of this moz.build and Makefile.in chicanery will be deleted in favour of invoking Gradle at the appropriate points! MozReview-Commit-ID: 4ueVNa7gzgs
2fccb140d16f0e4038638f6cfd7a3d45894248e8: Bug 1373271 - Handle crashes in preloaded browsers in tabbrowser draft bug1373271
k88hudson <khudson@mozilla.com> - Thu, 15 Jun 2017 12:27:06 -0400 - rev 597577
Push 64961 by khudson@mozilla.com at Tue, 20 Jun 2017 17:24:56 +0000
Bug 1373271 - Handle crashes in preloaded browsers in tabbrowser MozReview-Commit-ID: IVMQOOsyMnZ
ecbc4b87fd859c8dd97a8af6a95d1544e563a40a: Bug 1355625 - Part 2: Tweak the Gradle build to agree more with moz.build. r=sebastian draft
Nick Alexander <nalexander@mozilla.com> - Tue, 20 Jun 2017 10:18:59 -0700 - rev 597576
Push 64960 by nalexander@mozilla.com at Tue, 20 Jun 2017 17:21:46 +0000
Bug 1355625 - Part 2: Tweak the Gradle build to agree more with moz.build. r=sebastian MozReview-Commit-ID: DMoxPnla3Ij
fb6a48a94f92de3b4a5b37bca1a0ddcbf457e40a: Bug 1355625 - Part 1: Invoke aapt using py_action. r=mshal draft
Nick Alexander <nalexander@mozilla.com> - Mon, 19 Jun 2017 15:42:22 -0700 - rev 597575
Push 64960 by nalexander@mozilla.com at Tue, 20 Jun 2017 17:21:46 +0000
Bug 1355625 - Part 1: Invoke aapt using py_action. r=mshal This adds a py_action invocation wrapping aapt and implements a hacky implementation of the Gradle build system's resource merging algorithm; once we have the moz.build and Gradle resources identical, we'll be one big step closer to producing bit-identical builds and flipping the switch in favour of Gradle. With this, the R.txt produced by the aapt invocation is the same as the R.txt produced by the py_action invocation. Originally I wrote this to use GENERATED_FILES, but it produced a world of pain. Since Android's aapt tool is fundamentally directory oriented, not file oriented, it required adding support for FORCE to GENERATED_FILES and required directory crawling and FileAvoidWrite in the wrapper. After getting that working I was eventually stymied by the arcane requirements of the Android re-packaging system, which interacts with the l10n system. I would have required support for building GENERATED_FILES in the libs tier rather than the misc tier. After that realization I gave up and turned to py_action: the dependencies on branding are just too entangled with l10n to use GENERATED_FILES. And, in the not-so-distant future, all of this moz.build and Makefile.in chicanery will be deleted in favour of invoking Gradle at the appropriate points! MozReview-Commit-ID: 4ueVNa7gzgs
42715799b0f112d647e03802d97d49c9e7a17a7a: Bug 1357021 - Part 2: Add browser_onboarding_tours.js test, r=mossop draft
Fischer.json <fischer.json@gmail.com> - Sun, 18 Jun 2017 17:14:09 +0800 - rev 597574
Push 64959 by bmo:fliu@mozilla.com at Tue, 20 Jun 2017 17:19:27 +0000
Bug 1357021 - Part 2: Add browser_onboarding_tours.js test, r=mossop This commit - renames rowser_onboarding_hide_tours.js to browser_onboarding_tours.js - adds test_click_action_button_to_set_tour_completed and test_set_right_tour_completed_style_on_overlay test cases - updates test_hide_onboarding_tours test case to test the changes of prefs of tours complete state MozReview-Commit-ID: A0jD0lZWywL
cbd21ad46fdcb8a24231ba87041c07423ddbd1f8: Bug 1357021 - Part 1: Handle tour completed state, r=mossop draft
Fischer.json <fischer.json@gmail.com> - Sun, 18 Jun 2017 14:46:09 +0800 - rev 597573
Push 64959 by bmo:fliu@mozilla.com at Tue, 20 Jun 2017 17:19:27 +0000
Bug 1357021 - Part 1: Handle tour completed state, r=mossop This commit - turns on the `onboarding-complete` css style for completed tours - sets individual tour as completed when action button of that tour is clicked - sets all tours as completed if hide-the-tour checkbox is checked after toggling the overlay MozReview-Commit-ID: mps3BrdhOz
8590fc780ae9365bb1c105f16fb372acb2fd6542: Bug 1373339 - Add a button in the rules view to toggle the CSS shapes highlighter. r=zer0 draft
Mike Park <mikeparkms@gmail.com> - Tue, 20 Jun 2017 11:23:32 -0400 - rev 597572
Push 64958 by bmo:mpark@mozilla.com at Tue, 20 Jun 2017 17:15:27 +0000
Bug 1373339 - Add a button in the rules view to toggle the CSS shapes highlighter. r=zer0 Requires pref "devtools.inspector.shapesHighlighter.enabled" to be true. MozReview-Commit-ID: Ispw7ulV5o6
d6a48f28ccf3c89c211529b24e6a88c8018ee3ef: Bug 1364238 - Add the sidebar button into the default toolbar set;r=Gijs draft
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 20 Jun 2017 08:42:28 -0700 - rev 597571
Push 64957 by bgrinstead@mozilla.com at Tue, 20 Jun 2017 17:01:16 +0000
Bug 1364238 - Add the sidebar button into the default toolbar set;r=Gijs MozReview-Commit-ID: 7Z0ukSPu6pL
274136cf40459f012776213b18e51f9062d68eb5: Bug 862178 - Remove main thread I/O from CrashSubmit.jsm and KeyValuParser.jsm, replacing with OS.File. r=gsvelto
Perry Jiang <jiangperry@gmail.com> - Mon, 19 Jun 2017 17:04:03 -0700 - rev 597570
Push 64956 by bmo:jiangperry@gmail.com at Tue, 20 Jun 2017 17:01:07 +0000
Bug 862178 - Remove main thread I/O from CrashSubmit.jsm and KeyValuParser.jsm, replacing with OS.File. r=gsvelto MozReview-Commit-ID: 6WIvz15Xtp3
6b2ee06cfffcfa150f8e5b5e9b1dd21940f44bec: Bug 1374705 - Clean up some unused variables and some unnecessary run_test functions in toolkit/components/places/tests. r?mak draft
Mark Banner <standard8@mozilla.com> - Tue, 20 Jun 2017 17:55:54 +0100 - rev 597569
Push 64955 by bmo:standard8@mozilla.com at Tue, 20 Jun 2017 16:57:41 +0000
Bug 1374705 - Clean up some unused variables and some unnecessary run_test functions in toolkit/components/places/tests. r?mak MozReview-Commit-ID: IBHzwGnV5rS
41c595eb1a0b587b054dad69b7bcf99a76e3876b: Bug 1374650 - Fix the indentation for panelview toolbar items that are text-only. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Tue, 20 Jun 2017 17:34:53 +0200 - rev 597568
Push 64955 by bmo:standard8@mozilla.com at Tue, 20 Jun 2017 16:57:41 +0000
Bug 1374650 - Fix the indentation for panelview toolbar items that are text-only. r=Gijs MozReview-Commit-ID: AXsTBhaTMYY
4bceea59d062033370230bc94c57454d44c941e8: Bug 1372922 - Don't log suite_start a second time in reftest if recovering from a crash, r=jmaher
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 14 Jun 2017 12:10:10 -0400 - rev 597567
Push 64955 by bmo:standard8@mozilla.com at Tue, 20 Jun 2017 16:57:41 +0000
Bug 1372922 - Don't log suite_start a second time in reftest if recovering from a crash, r=jmaher MozReview-Commit-ID: 45lYTfrCyxN
2cdcf3c7cd25e413f5e24700e3d00066575d815a: servo: Merge #17431 - style: Cleanup after #17427, and remove extra-optimistic optimization added in #17429 (from emilio:restyle-hints-xbl); r=emilio
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 20 Jun 2017 08:13:05 -0700 - rev 597566
Push 64955 by bmo:standard8@mozilla.com at Tue, 20 Jun 2017 16:57:41 +0000
servo: Merge #17431 - style: Cleanup after #17427, and remove extra-optimistic optimization added in #17429 (from emilio:restyle-hints-xbl); r=emilio This just addresses my review comments in #17427, and removes a wrong optimization I added in #17429 thinking it was correct. Source-Repo: https://github.com/servo/servo Source-Revision: b50cf33efd67fe319aaccb94b476d473901c79d8
8f29b2c912151284f4c47a2d95c11ad2231c2216: Bug 1368438 - Add -j to mach try, r=chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 15 Jun 2017 08:14:22 -0400 - rev 597565
Push 64955 by bmo:standard8@mozilla.com at Tue, 20 Jun 2017 16:57:41 +0000
Bug 1368438 - Add -j to mach try, r=chmanchester The -j try syntax specifies a "job" task. Job tasks are different from unittests in that they typically don't require a build and run from the source tree. Examples include linters (eslint, flake8, etc), python tests (mozbase, mochitest, etc) and misc things like doc generation. Sometimes, developers might only want to run a specific "job" task with a syntax like "./mach try -j mozbase". This means a few assumptions need to be broken in |mach try|. Platforms and unittests should no longer be required if -j was specified. Most of the changes in this patch revolve around dealing with those broken assumptions. MozReview-Commit-ID: O0y6V2Wwej
64406d3921f3bce828aa9934fcc8a910403efda3: Bug 1368438 - Make it possible to only schedule builds with |mach try|, r=chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 15 Jun 2017 08:14:17 -0400 - rev 597564
Push 64955 by bmo:standard8@mozilla.com at Tue, 20 Jun 2017 16:57:41 +0000
Bug 1368438 - Make it possible to only schedule builds with |mach try|, r=chmanchester Currently if no unittests, paths or tags are specified it will error out. MozReview-Commit-ID: O0y6V2Wwej
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip