9ad123fb9ce5fd3211c6f675e8acbe452296880b: Bug 1404421 - Add an empty slot to the test PKCS#11 module r=keeler
Wouter Verhelst <w@uter.be> - Sun, 01 Oct 2017 12:10:20 +0200 - rev 682942
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1404421 - Add an empty slot to the test PKCS#11 module r=keeler It is helpful to have a slot which never has a token, so that the absense of a token can be asserted in unit tests. Add a third token that is always empty, and update a number of unit tests to check for it. MozReview-Commit-ID: 4apvRRhZJus
77edd9d741494c058a49d75737223a0fe947fdf6: Bug 1409619 Resolve signed/unsigned comparison warning by fixing function definitions to be signed in widget/windows/TSFTextStore r=jimm
Tom Ritter <tom@mozilla.com> - Tue, 17 Oct 2017 23:37:31 -0500 - rev 682941
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1409619 Resolve signed/unsigned comparison warning by fixing function definitions to be signed in widget/windows/TSFTextStore r=jimm The functions changed are given signed arguments (that are converted to unsigned). Changing them to signed resolves the warnings and preserves the original values. MozReview-Commit-ID: BxIAECFiuQR
95d7bf09b27077f8affebbd61555aeef5fff5118: Bug 1409620 Move definition of inline function from .cpp to .h in widget/windows/KeyboardLayout r=jimm
Tom Ritter <tom@mozilla.com> - Tue, 17 Oct 2017 23:58:37 -0500 - rev 682940
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1409620 Move definition of inline function from .cpp to .h in widget/windows/KeyboardLayout r=jimm inline functions are supposed to be declared in the header file, so the compiler can inline them. gcc complains about this, but clang/msvc apparently do not. We also needed to move the DeadKey struct and class into the header, as the function calls a method on the DeadKey class, and you can't do that on a forward declared class. MozReview-Commit-ID: 8NxP59AXuZi
404101537948219eafd5f6729615a5d51e4cb5f8: Backed out changeset 3219e7712baa (bug 1401207) for eslint failures in testing/talos/talos/tests/devtools/addon/content/damp.js. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 19 Oct 2017 00:06:26 +0200 - rev 682939
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Backed out changeset 3219e7712baa (bug 1401207) for eslint failures in testing/talos/talos/tests/devtools/addon/content/damp.js. r=backout
278cb714534f3aed4c024f7f561b1ea45c8f124b: Backed out changeset f42923db714b (bug 1401207)
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 19 Oct 2017 00:06:20 +0200 - rev 682938
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Backed out changeset f42923db714b (bug 1401207)
4c04fd25fe125ecb1bb6fdd59461b1101f234644: No bug - Revendor rust dependencies
Servo VCS Sync <servo-vcs-sync@mozilla.com> - Wed, 18 Oct 2017 20:56:50 +0000 - rev 682937
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
No bug - Revendor rust dependencies
a814d00df24809dd6509f458ebc268fdbabf3f15: servo: Merge #18938 - Replace all uses of the `heapsize` crate with `malloc_size_of` (from nnethercote:bug-1409255); r=SimonSapin
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 18 Oct 2017 13:56:05 -0500 - rev 682936
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
servo: Merge #18938 - Replace all uses of the `heapsize` crate with `malloc_size_of` (from nnethercote:bug-1409255); r=SimonSapin Servo currently uses `heapsize`, but Stylo/Gecko use `malloc_size_of`. `malloc_size_of` is better -- it handles various cases that `heapsize` does not -- so this patch changes Servo to use `malloc_size_of`. This patch makes the following changes to the `malloc_size_of` crate. - Adds `MallocSizeOf` trait implementations for numerous types, some built-in (e.g. `VecDeque`), some external and Servo-only (e.g. `string_cache`). - Makes `enclosing_size_of_op` optional, because vanilla jemalloc doesn't support that operation. - For `HashSet`/`HashMap`, falls back to a computed estimate when `enclosing_size_of_op` isn't available. - Adds an extern "C" `malloc_size_of` function that does the actual heap measurement; this is based on the same functions from the `heapsize` crate. This patch makes the following changes elsewhere. - Converts all the uses of `heapsize` to instead use `malloc_size_of`. - Disables the "heapsize"/"heap_size" feature for the external crates that provide it. - Removes the `HeapSizeOf` implementation from `hashglobe`. - Adds `ignore` annotations to a few `Rc`/`Arc`, because `malloc_size_of` doesn't derive those types, unlike `heapsize`. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1409255 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because testing is on the Gecko side. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 4c538b642e4bdfbf42c522c5a59c258a6d14546e
f42923db714b07f652d7e66913160824862784af: Bug 1401207 - Implement ./mach talos --subtests to allow filtering DAMP tests. r=jmaher
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 17 Oct 2017 09:00:00 -0700 - rev 682935
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1401207 - Implement ./mach talos --subtests to allow filtering DAMP tests. r=jmaher MozReview-Commit-ID: BAaVYjOofJE
3219e7712baaa518edb336535cbc7b27c3b4055b: Bug 1401207 - Refactor DAMP to more easily filter subtests. r=bgrins
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 17 Oct 2017 08:59:17 -0700 - rev 682934
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1401207 - Refactor DAMP to more easily filter subtests. r=bgrins MozReview-Commit-ID: GXpujntQ5F2
bf32a14dfacff945c3dbc516525c497663f9e467: Bug 1408552 - Make sure we only instantiate CacheStorageService in the main process r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 18 Oct 2017 21:10:22 +0200 - rev 682933
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1408552 - Make sure we only instantiate CacheStorageService in the main process r=mayhemer * A memory leak occurs when this happens in the content process * I added an assertion that we only create it in the parent process MozReview-Commit-ID: 1UTyusRg0qx
c072884b1b905a6e00f756c7d3697df3447e7b63: Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop
Mark Banner <standard8@mozilla.com> - Wed, 11 Oct 2017 15:43:51 +0100 - rev 682932
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop MozReview-Commit-ID: 9m9iss3jUJJ
55c5290c0147d4ee22c2e5b964484a06cd740536: Bug 1230373 - Add an ESLint rule to prefer using Services.jsm rather than getService. r=mossop
Mark Banner <standard8@mozilla.com> - Fri, 06 Oct 2017 17:03:38 +0100 - rev 682931
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1230373 - Add an ESLint rule to prefer using Services.jsm rather than getService. r=mossop MozReview-Commit-ID: G9dp4PxcyT7
dcd89150bf7d1049b0022a52ee6650a17e83c304: Bug 1230373 - Fix an issue with eslint-plugin-mozilla not detecting the global scope properly when arrow functions are used. r=mossop
Mark Banner <standard8@mozilla.com> - Mon, 16 Oct 2017 15:08:26 +0100 - rev 682930
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1230373 - Fix an issue with eslint-plugin-mozilla not detecting the global scope properly when arrow functions are used. r=mossop MozReview-Commit-ID: IOCM8Fjl0xQ
5985d54ddaca1a24f002de09b61e032a7e307850: Bug 1405853 - Change about page logo. r=walkingice
Nevin Chen <cnevinchen@gmail.com> - Wed, 18 Oct 2017 14:29:18 +0800 - rev 682929
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1405853 - Change about page logo. r=walkingice MozReview-Commit-ID: IOzO9cE4h1M
e713e2a6b0bdd5537476bf3d8024dbf465c04003: Bug 1409769 - Properly disable idle-daily for mochitests, to avoid background interactions. r=jmaher
Mark Banner <standard8@mozilla.com> - Wed, 18 Oct 2017 16:29:37 +0100 - rev 682928
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1409769 - Properly disable idle-daily for mochitests, to avoid background interactions. r=jmaher MozReview-Commit-ID: 6yS6zwFjphd
4577afc2a13d756331d1d196c10d5d4a29e700a5: Bug 1409158 - Use LC_TIME to retrieve OSPreferences::GetRegionalPrefsLocales on Unix. r=jfkthame
Zibi Braniecki <zbraniecki@mozilla.com> - Mon, 16 Oct 2017 13:55:51 -0700 - rev 682927
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1409158 - Use LC_TIME to retrieve OSPreferences::GetRegionalPrefsLocales on Unix. r=jfkthame MozReview-Commit-ID: ImjQCggy8yk
6af3f537a0632e321bc6c718e780bfb10c41c05c: Bug 1408670 - Use PBU.isContentWindowPrivate instead of PBU.isBrowserPrivate in ContextMenu.jsm. r=Felipe
Ian Moody <moz-ian@perix.co.uk> - Sat, 14 Oct 2017 16:43:38 +0100 - rev 682926
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1408670 - Use PBU.isContentWindowPrivate instead of PBU.isBrowserPrivate in ContextMenu.jsm. r=Felipe Follow up correction to bug 1399429. isBrowserPrivate causes console spam, probably not e10s safe going forward. MozReview-Commit-ID: JMoTVbc3SAx
1347bb0b084bf245ff9315d07e3646547aa0c8e0: servo: Merge #18937 - style: Use a proper flattened tree iterator if we're under a shadow tree (from emilio:shadow-proper-flattened-tree); r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Oct 2017 12:44:32 -0500 - rev 682925
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
servo: Merge #18937 - style: Use a proper flattened tree iterator if we're under a shadow tree (from emilio:shadow-proper-flattened-tree); r=heycam Source-Repo: https://github.com/servo/servo Source-Revision: eea678c1412e2bb7db7f9a7459d1b68ef57c55f2
075ed3f2e94ccfd88d90a6925e11c5249f72865b: Bug 1405210 - Part 3: Apply clang-format to added print dialog widget code. r?jimm draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Thu, 19 Oct 2017 11:04:50 +0900 - rev 682924
Push 85208 by mantaroh@gmail.com at Thu, 19 Oct 2017 02:07:22 +0000
Bug 1405210 - Part 3: Apply clang-format to added print dialog widget code. r?jimm ./mach clang-format --path widget/windows/nsPrintDialog* MozReview-Commit-ID: T1WuQ41GAN
389f337fb9c76f097d9177e1aafe29be402f20d3: Bug 1405210 - Part 2: Move native printing dialog code to windows widget. r?jimm draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Thu, 19 Oct 2017 11:04:30 +0900 - rev 682923
Push 85208 by mantaroh@gmail.com at Thu, 19 Oct 2017 02:07:22 +0000
Bug 1405210 - Part 2: Move native printing dialog code to windows widget. r?jimm This patch will * Move native print dialog code to the PrintDialogService of widget. * Toolkit call PrintDialogService instead of calling the native print dialog. * Change SetWindowText/CreateWindow to SetWindowTextW/CreateWindowW in order to treat localized string correctly. MozReview-Commit-ID: DOgp3STaJ4t
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip