93657f8dedaafa384bcd49c71b52e195ec968de8: Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Sep 2016 15:01:16 +1000 - rev 409139
Push 28403 by bmo:gasolin@mozilla.com at Fri, 02 Sep 2016 09:05:40 +0000
Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm. The new name makes the sense of the condition much clearer. E.g. compare: NS_WARN_IF_FALSE(!rv.Failed()); with: NS_WARNING_ASSERTION(!rv.Failed()); The new name also makes it clearer that it only has effect in debug builds, because that's standard for assertions.
d8b7827cca8303713e401363e701bdcc6553a8c4: Bug 1297961 (part 2) - Use nsIURI::GetSpecOrDefault() for comparisons to fixed URIs. r=hurley.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 26 Aug 2016 16:02:32 +1000 - rev 409138
Push 28403 by bmo:gasolin@mozilla.com at Fri, 02 Sep 2016 09:05:40 +0000
Bug 1297961 (part 2) - Use nsIURI::GetSpecOrDefault() for comparisons to fixed URIs. r=hurley.
b516e1d6e46165d5553ec894fadc55ce514f862c: Bug 1297961 (part 1) - Introduce nsURI::GetSpecOrDefault(). r=hurley.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 26 Aug 2016 16:02:31 +1000 - rev 409137
Push 28403 by bmo:gasolin@mozilla.com at Fri, 02 Sep 2016 09:05:40 +0000
Bug 1297961 (part 1) - Introduce nsURI::GetSpecOrDefault(). r=hurley. This function is an infallible alternative to nsIURI::GetSpec(). It's useful when it's appropriate to handle a GetSpec() failure with a failure string, e.g. for log/warning/error messages. It allows code like this: nsAutoCString spec; uri->GetSpec(spec); printf("uri: %s", spec.get()); to be changed to this: printf("uri: %s", uri->GetSpecOrDefault().get()); This introduces a slight behavioural change. Previously, if GetSpec() failed, an empty string would be used here. Now, "[nsIURI::GetSpec failed]" will be produced instead. In most cases this failure string will make for a clearer log/warning/error message than the empty string. * * * Bug 1297961 (part 1b) - More GetSpecOrDefault() additions. r=hurley. I will fold this into part 1 before landing.
f514d79fe0679a7c565bacc90b2d21e62cbf8de2: Backed out changeset 5ad925dd2e4e for epic build bustage.
Mike Conley <mconley@mozilla.com> - Fri, 02 Sep 2016 02:21:39 -0400 - rev 409136
Push 28403 by bmo:gasolin@mozilla.com at Fri, 02 Sep 2016 09:05:40 +0000
Backed out changeset 5ad925dd2e4e for epic build bustage. MozReview-Commit-ID: 2TwkxThgvV4
d6246f5ede4a75deda1b0294be758cb4aad855de: Bug 1300007 - Don't close a stream in an assertion. r=baku.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 02 Sep 2016 16:10:02 +1000 - rev 409135
Push 28403 by bmo:gasolin@mozilla.com at Fri, 02 Sep 2016 09:05:40 +0000
Bug 1300007 - Don't close a stream in an assertion. r=baku. Because assertions disappear in non-debug builds.
5ad925dd2e4e9f6943b228f0173d01278a74c2a8: Bug 1255843 - Add process memory reporting tool to about:performance. r=mconley
Rutuja Surve <rutuja.r.surve@gmail.com> - Fri, 02 Sep 2016 00:21:00 -0400 - rev 409134
Push 28403 by bmo:gasolin@mozilla.com at Fri, 02 Sep 2016 09:05:40 +0000
Bug 1255843 - Add process memory reporting tool to about:performance. r=mconley MozReview-Commit-ID: EHCkl6G3bTT
88dd53397d30e1853122f1284de94f103f6e4436: Bug 1299389 - Replace some raw pointers in nsThreadManager. r=froydnj.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 10 Jun 2016 16:04:49 +1000 - rev 409133
Push 28403 by bmo:gasolin@mozilla.com at Fri, 02 Sep 2016 09:05:40 +0000
Bug 1299389 - Replace some raw pointers in nsThreadManager. r=froydnj. nsThreadManager::get() can return a reference. This lets us remove some redundant assertions. nsThreadArray elements can be NotNull<>s.
c212e496d0ce0dcdd52828c8beaa592f29d240cb: Bug 1299066: Make NS_STYLE_DISPLAY_* an enum class. Prefer indexing instead of linear search in the frame constructor r=heycam,bz
Emilio Cobos Álvarez <ecoal95@gmail.com> - Sat, 27 Aug 2016 19:31:50 -0700 - rev 409132
Push 28403 by bmo:gasolin@mozilla.com at Fri, 02 Sep 2016 09:05:40 +0000
Bug 1299066: Make NS_STYLE_DISPLAY_* an enum class. Prefer indexing instead of linear search in the frame constructor r=heycam,bz The main renaming was generated with the following python script: ``` import sys import re CAMEL_CASE_REGEX = re.compile(r"(^|_|-)([A-Z])([A-Z]+)") DISPLAY_REGEX = re.compile(r"\bNS_STYLE_DISPLAY_([^M][A-Z_]+)\b") def to_camel_case(ident): return re.sub(CAMEL_CASE_REGEX, lambda m: m.group(2) + m.group(3).lower(), ident) def constant_to_enum(constant): return "StyleDisplay::" + to_camel_case(constant) + ("_" if constant == "NONE" else "") def process_line(line): return re.sub(DISPLAY_REGEX, lambda m: constant_to_enum(m.group(1)), line) lines = [] with open(sys.argv[1], "r") as f: for line in f: lines.append(process_line(line)) with open(sys.argv[1], "w") as f: for line in lines: f.write(line) ``` And the following shell commands: ``` find . -name '*.cpp' -exec python display.py {} \; find . -name '*.h' -exec python display.py {} \; ``` MozReview-Commit-ID: 91xYCbLC2Vf
9b827786ca68a923bacef503c9a52369381b3170: Back out changeset 58b07057fe25 (bug 1299159) on suspicion of breaking Windows PGO builds
Phil Ringnalda <philringnalda@gmail.com> - Thu, 01 Sep 2016 19:43:22 -0700 - rev 409131
Push 28403 by bmo:gasolin@mozilla.com at Fri, 02 Sep 2016 09:05:40 +0000
Back out changeset 58b07057fe25 (bug 1299159) on suspicion of breaking Windows PGO builds CLOSED TREE
a6943b0eaeea8c8a5ae189175cda6b036b001c53: Bug 1291946 - Append the latest video frames from updateTracks. r?pehrsons. draft
ctai <ctai@mozilla.com> - Wed, 10 Aug 2016 10:31:14 +0800 - rev 409130
Push 28402 by bmo:ctai@mozilla.com at Fri, 02 Sep 2016 08:54:28 +0000
Bug 1291946 - Append the latest video frames from updateTracks. r?pehrsons. In some cases, we need to resend missed VideoSegment to new added MediaStreamVideoSink. Append the latest video frames from updateTracks. MozReview-Commit-ID: 76RFs5fgKpY
fa82305e8d01176242cf40dc1ee40f04f606f22b: Bug 1274944 - Part 3: Test. draft
Boris Chiou <boris.chiou@gmail.com> - Thu, 01 Sep 2016 16:51:39 +0800 - rev 409129
Push 28401 by bmo:boris.chiou@gmail.com at Fri, 02 Sep 2016 08:52:09 +0000
Bug 1274944 - Part 3: Test. MozReview-Commit-ID: 5pMhC00vNIh
695f4ef68046212b2dc97302530dc7e58509ecaf: Bug 1274944 - Part 2: Implement SetSpacing(). draft
Boris Chiou <boris.chiou@gmail.com> - Wed, 31 Aug 2016 17:31:10 +0800 - rev 409128
Push 28401 by bmo:boris.chiou@gmail.com at Fri, 02 Sep 2016 08:52:09 +0000
Bug 1274944 - Part 2: Implement SetSpacing(). MozReview-Commit-ID: ASJHVK97gq6
89f016a1b9a1a9df4373352367d8232d6459de84: Bug 1274944 - Part 1: Add writable spacing attribute. draft
Boris Chiou <boris.chiou@gmail.com> - Wed, 31 Aug 2016 16:58:57 +0800 - rev 409127
Push 28401 by bmo:boris.chiou@gmail.com at Fri, 02 Sep 2016 08:52:09 +0000
Bug 1274944 - Part 1: Add writable spacing attribute. Use [SetterThrows] for KeyframeEffect.spacing because it throws if the input string is not conformed to the grammar. MozReview-Commit-ID: CkAnPu8TnV
38cf3424509fb51e32f8fa32dcc58b60b0445033: Bug 1299718 part 3 - call MarkAsContentSource() at where using video element as a source; r?gerald,kamidphish,mtseng draft
Kaku Kuo <kaku@mozilla.com> - Fri, 02 Sep 2016 16:31:52 +0800 - rev 409126
Push 28400 by bmo:kaku@mozilla.com at Fri, 02 Sep 2016 08:51:12 +0000
Bug 1299718 part 3 - call MarkAsContentSource() at where using video element as a source; r?gerald,kamidphish,mtseng MozReview-Commit-ID: LiP9B12DAkX
de6e4c3bdf4b4eb76aef0ae7b729e47a8e197b39: Bug 1299718 part 3 - call MarkAsContentSource() at where using video element as a source; r?gerald,kamidphish draft
Kaku Kuo <kaku@mozilla.com> - Fri, 02 Sep 2016 16:31:52 +0800 - rev 409125
Push 28399 by bmo:kaku@mozilla.com at Fri, 02 Sep 2016 08:46:32 +0000
Bug 1299718 part 3 - call MarkAsContentSource() at where using video element as a source; r?gerald,kamidphish MozReview-Commit-ID: LiP9B12DAkX
a47d91d4a0f225fdbae11609327287bf92b66a91: Bug 1299718 part 2 - implement the MarkAsContentSource() API; r?gerald,kamidphish draft
Kaku Kuo <kaku@mozilla.com> - Fri, 02 Sep 2016 16:37:23 +0800 - rev 409124
Push 28399 by bmo:kaku@mozilla.com at Fri, 02 Sep 2016 08:46:32 +0000
Bug 1299718 part 2 - implement the MarkAsContentSource() API; r?gerald,kamidphish MozReview-Commit-ID: 5ABZTv1iR6K
fba74df9d959e52be07e35fa14a3c9e3703a658f: Bug 1299718 part 1 - Histogram for VIDEO_AS_CONTENT_SOURCE; r?francois,gerald draft
Kaku Kuo <kaku@mozilla.com> - Fri, 02 Sep 2016 16:45:48 +0800 - rev 409123
Push 28399 by bmo:kaku@mozilla.com at Fri, 02 Sep 2016 08:46:32 +0000
Bug 1299718 part 1 - Histogram for VIDEO_AS_CONTENT_SOURCE; r?francois,gerald MozReview-Commit-ID: 8dGk1U7m3mc
67671b89a5cfd4db5441f9eab4f9c01237d4e764: Bug 1299718 part 3 - call MarkAsContentSource() at where using video element as a source; r?gerald,kamidphish draft
Kaku Kuo <kaku@mozilla.com> - Fri, 02 Sep 2016 16:31:52 +0800 - rev 409122
Push 28398 by bmo:kaku@mozilla.com at Fri, 02 Sep 2016 08:38:25 +0000
Bug 1299718 part 3 - call MarkAsContentSource() at where using video element as a source; r?gerald,kamidphish MozReview-Commit-ID: LiP9B12DAkX
03e23d485f467d0b5de2f5cf244334d2459953d2: Bug 1299718 part 2 - implement the MarkAsContentSource() API; r?gerald,kamidphish draft
Kaku Kuo <kaku@mozilla.com> - Fri, 02 Sep 2016 16:37:23 +0800 - rev 409121
Push 28398 by bmo:kaku@mozilla.com at Fri, 02 Sep 2016 08:38:25 +0000
Bug 1299718 part 2 - implement the MarkAsContentSource() API; r?gerald,kamidphish MozReview-Commit-ID: 5ABZTv1iR6K
e401ff28f8cf5969d8a909f0e0ec195597a4b6f5: Bug 1299718 part 3 - call MarkAsContentSource() at where using video element as a source; r?gerald,kamidphish draft
Kaku Kuo <kaku@mozilla.com> - Fri, 02 Sep 2016 16:31:52 +0800 - rev 409120
Push 28397 by bmo:kaku@mozilla.com at Fri, 02 Sep 2016 08:33:03 +0000
Bug 1299718 part 3 - call MarkAsContentSource() at where using video element as a source; r?gerald,kamidphish MozReview-Commit-ID: LiP9B12DAkX
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip