932c5acc1f86b26863abf895fed5890afe5c2ac7: Bug 1388728 - Add APIs to query module record errors and rename operations in line with spec r=bbouvier
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 22 Aug 2017 09:56:17 +0100 - rev 650889
Push 75530 by dwillcoxon@mozilla.com at Wed, 23 Aug 2017 01:12:42 +0000
Bug 1388728 - Add APIs to query module record errors and rename operations in line with spec r=bbouvier
2e4748827cda73771b02c8e9316e257505518a36: Bug 1374239 - Store and re-throw module instantiation and evaluation errors r=shu
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 09 Aug 2017 18:05:15 +0100 - rev 650888
Push 75530 by dwillcoxon@mozilla.com at Wed, 23 Aug 2017 01:12:42 +0000
Bug 1374239 - Store and re-throw module instantiation and evaluation errors r=shu
46d5697dc9e0b8ce53d5d02f7c5f228a5dab4914: Bug 1370843 - Provide correct triggeringPrincipal for dropLinks. r=smaug,tooru
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 22 Aug 2017 10:07:03 +0200 - rev 650887
Push 75530 by dwillcoxon@mozilla.com at Wed, 23 Aug 2017 01:12:42 +0000
Bug 1370843 - Provide correct triggeringPrincipal for dropLinks. r=smaug,tooru
7e6cd9dc49d54e193186c28fbe000da3630ca7e9: Bug 1364714 - (re-landing) Update Freetype to version 2.8, and fix/annotate tests affected by changes to font metrics & rasterization. r=dholbert,jwatt,ryanvm,jfkthame
Jonathan Kew <jkew@mozilla.com> - Tue, 22 Aug 2017 09:20:05 +0100 - rev 650886
Push 75530 by dwillcoxon@mozilla.com at Wed, 23 Aug 2017 01:12:42 +0000
Bug 1364714 - (re-landing) Update Freetype to version 2.8, and fix/annotate tests affected by changes to font metrics & rasterization. r=dholbert,jwatt,ryanvm,jfkthame
89df4227af85ff946e1611e73136c3525fdde353: Bug 1390489 - Port StatementRow to WebIDL bindings. r=asuth,qdot
Jan de Mooij <jdemooij@mozilla.com> - Tue, 22 Aug 2017 09:25:37 +0200 - rev 650885
Push 75530 by dwillcoxon@mozilla.com at Wed, 23 Aug 2017 01:12:42 +0000
Bug 1390489 - Port StatementRow to WebIDL bindings. r=asuth,qdot
f0ca192bde957b162bc123e989ec118d93731c80: Bug 1381704 - Remove unused Application Reputation telemetry probe. r?hchang,r?liuche draft
Francois Marier <francois@mozilla.com> - Tue, 22 Aug 2017 17:16:24 -0700 - rev 650884
Push 75529 by fmarier@mozilla.com at Wed, 23 Aug 2017 01:10:02 +0000
Bug 1381704 - Remove unused Application Reputation telemetry probe. r?hchang,r?liuche MozReview-Commit-ID: GLjgu8VP1z8
9856dd6586422be56a019ffc46ee22712f7e95f3: Bug 1385484 - Ensure that login reputation checks are disabled in tests. r?hchang draft
Francois Marier <francois@mozilla.com> - Tue, 22 Aug 2017 17:56:20 -0700 - rev 650883
Push 75528 by fmarier@mozilla.com at Wed, 23 Aug 2017 01:00:55 +0000
Bug 1385484 - Ensure that login reputation checks are disabled in tests. r?hchang The login reputation checks depend on a server lookup and therefore would render non-deterministic the performance and correctness of tests. MozReview-Commit-ID: Bil0rSZsGPT
33004b7849838f318a83ad130942aac2a56f1ae3: Bug 1385484 - Add the login reputation whitelist behind a pref. r?hchang draft
Francois Marier <francois@mozilla.com> - Tue, 08 Aug 2017 16:23:10 -0700 - rev 650882
Push 75528 by fmarier@mozilla.com at Wed, 23 Aug 2017 01:00:55 +0000
Bug 1385484 - Add the login reputation whitelist behind a pref. r?hchang MozReview-Commit-ID: Dbtl3WL5tMJ
cce3678b1ceca0ed1875cf6649dd26ed842f1570: Bug 1385484 - Remove obsolete prefs and add missing blockedURIs. r?hchang draft
Francois Marier <francois@mozilla.com> - Tue, 22 Aug 2017 17:55:28 -0700 - rev 650881
Push 75528 by fmarier@mozilla.com at Wed, 23 Aug 2017 01:00:55 +0000
Bug 1385484 - Remove obsolete prefs and add missing blockedURIs. r?hchang This should have been done when blockedURIs was added (bug 1237198), when safebrowsing.enabled was renamed (bug 1025965), and when the forbidden list format was removed (bug 1274893). MozReview-Commit-ID: AUWR5Efcb2x
4db702232be90496c0048d6ab18221072c782ef0: Bug 1390352 - Skip adding/accumulating the values which corresponding rect offset is auto. r?manishearth,birtles draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 23 Aug 2017 09:51:17 +0900 - rev 650880
Push 75527 by bmo:mantaroh@gmail.com at Wed, 23 Aug 2017 00:51:55 +0000
Bug 1390352 - Skip adding/accumulating the values which corresponding rect offset is auto. r?manishearth,birtles This patch will skip add_weighted() when self_portion + other_portion not equal to zero. (i.e. adding or accumulating). Gecko does same behavior since we can't add two auto value. MozReview-Commit-ID: 7vzF548nQuD
9dad69c21d9d67252d21d6cb2605f8c0652cae31: Bug 1390352 - Skip adding/accumulating the values which corresponding rect offset is auto. r?manishearth,birtles draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 23 Aug 2017 09:47:57 +0900 - rev 650879
Push 75526 by bmo:mantaroh@gmail.com at Wed, 23 Aug 2017 00:49:36 +0000
Bug 1390352 - Skip adding/accumulating the values which corresponding rect offset is auto. r?manishearth,birtles This patch will skip add_weighted() when self_portion + other_portion not equal to zero. (i.e. adding or accumulating). Gecko does same behavior since we can't add two auto value. MozReview-Commit-ID: 7vzF548nQuD
5a70c11a3dd62e7b99232af1d0510201a3574356: Bug 1392204 - Remove 'goog-badbinurl-proto' and 'goog-downloadwhite-proto' from SBv4 update list on fennec. draft
Henry Chang <hchang@mozilla.com> - Tue, 22 Aug 2017 12:20:57 +0800 - rev 650878
Push 75525 by hchang@mozilla.com at Wed, 23 Aug 2017 00:49:25 +0000
Bug 1392204 - Remove 'goog-badbinurl-proto' and 'goog-downloadwhite-proto' from SBv4 update list on fennec. The google SB v4 server would return 404 error if the request contains 'goog-badbinurl-proto' or 'goog-downloadwhite-proto' along with non-Desktop platform so we should override these two treat types on Fennec to old (v2) ones (i.e. 'goog-badbinurl-shavar' and 'goog-downloadwhite-digest256') MozReview-Commit-ID: 6TUBVxe455y
deb6fd1f21a5af695692207595c48e3a04d29e21: Bug 1381704 - Remove unused Application Reputation telemetry probe. r?hchang,r?liube draft
Francois Marier <francois@mozilla.com> - Tue, 22 Aug 2017 17:16:24 -0700 - rev 650877
Push 75524 by fmarier@mozilla.com at Wed, 23 Aug 2017 00:46:57 +0000
Bug 1381704 - Remove unused Application Reputation telemetry probe. r?hchang,r?liube MozReview-Commit-ID: GLjgu8VP1z8
fa99c03ae65d9b58b0bf6795bf39e6f786471f33: Bug 1381704 - Extend Safe Browsing telemetry probes. r?hchang,r?liuche draft
Francois Marier <francois@mozilla.com> - Tue, 22 Aug 2017 17:09:19 -0700 - rev 650876
Push 75524 by fmarier@mozilla.com at Wed, 23 Aug 2017 00:46:57 +0000
Bug 1381704 - Extend Safe Browsing telemetry probes. r?hchang,r?liuche MozReview-Commit-ID: 9Om2yuFH8xe
f161d72c3572c8f9acd236976457795b483f7ce9: Bug 1391476 - Add UID and GID to cache parameters; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Tue, 22 Aug 2017 16:49:26 -0700 - rev 650875
Push 75523 by gszorc@mozilla.com at Wed, 23 Aug 2017 00:42:07 +0000
Bug 1391476 - Add UID and GID to cache parameters; r?dustin The UID and GID that a task executes under is dynamic. As a result, caches need to be aware of the UID and GID that owns files otherwise subsequent tasks could run into permission denied errors. This is why `run-task --chown-recursive` exists. By recursively changing ownership of persisted files, we ensure the current task is able to read and write all existing files. When you take a step back, you realize that chowning of cached files is an expensive workaround. Yes, this results in cache hits. But the cost is you potentially have to perform hundreds of thousands of I/O system calls to mass chown. The ideal situation is that UID/GID is consistent across tasks on any given cache and potentially expensive permissions setting can be avoided. So, that's what this commit does. We add the task's UID and GID to run-task's requirements. When we first see a cache, we record a UID and GID with it and chown the empty cache directory to that UID and GID. Subsequent tasks using this cache *must* use the same UID and GID or else run-task will fail. Since run-task now guarantees that all cache consumers use the same UID and GID, we can avoid a potentially expensive recursive chown. But there is an exception. In untrusted environments (namely Try), we recursively chown existing caches if there is a uid/gid mismatch. We do this because Try is a sandbox and any random task could experiment with a non-standard uid/gid. That populated cache would "poison" the cache for the next caller. Or vice-versa. It would be annoying if caches were randomly poisoned due to Try pushes that didn't realize there was a UID/GID mismatch. We could outlaw "bad" UID and GIDs. But that makes the barrier to testing things on Try harder. So, we go with the flow and recursively chown caches in this scenario. This change will shine light on all tasks using inconsistent UID and GID values on the same cache. Bustage is anticipated. Unfortunately, we can't easily know what will break. So it will be one of those things where we will have to fix problems as they arise. Fortunately, because caches are now tied to the content of run-task, we only need to back out this change and tasks should revert to caches without UID and GID pinning requirements and everything will work again. MozReview-Commit-ID: 2ka4rOnnXIp
4a7e2e26087f5279ab47868164708f2f60649d1c: Bug 1391476 - Automatically set cache/volume permissions in run-task; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Tue, 22 Aug 2017 16:26:31 -0700 - rev 650874
Push 75523 by gszorc@mozilla.com at Wed, 23 Aug 2017 00:42:07 +0000
Bug 1391476 - Automatically set cache/volume permissions in run-task; r?dustin run-task's --chown and --chown-recursive are only used on volumes and caches - the only locations that aren't controlled by the Docker image itself and thus whose permissions could be "undefined." Previous commits have taught run-task about the locations of all caches and volumes. Therefore, we no longer need to manually define paths to chown. Instead, we can chown as a side-effect of the path being a cache or a volume. So, this commit changes run-task to chown caches and volumes automatically. Since we no longer have a use for --chown and --chown-recursive, those arguments are removed. There /could/ be some paths that are caches or volumes but aren't getting defined as such in Taskgraph. I consider this a bug in Taskgraph and the recourse is to properly define a path as a cache or a volume there. MozReview-Commit-ID: 1yqrhjil6gy
c7df9aec9234933051d83b94840c8ba259e72fb7: Bug 1391476 - Tell run-task about volumes so it can sanitize them; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Tue, 22 Aug 2017 16:48:54 -0700 - rev 650873
Push 75523 by gszorc@mozilla.com at Wed, 23 Aug 2017 00:42:07 +0000
Bug 1391476 - Tell run-task about volumes so it can sanitize them; r?dustin We recently introduced support for telling run-task about caches so it could sanitize them automatically. We also recently taught docker-worker and docker-engine how to declare volumes. Building on that work, we now pass a list of paths corresponding to Docker volumes to run-task. run-task now verifies volumes behave as expected. Unless the volume paths correspond to caches, run-task verifies they are empty and chowns them to an appropriate owner. MozReview-Commit-ID: 5lm2uIitrS3
a3010c14c6d45c6bd3765fd574c3900593f160b1: Bug 1391476 - Require that all cache paths be declared as volumes; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Tue, 22 Aug 2017 17:40:20 -0700 - rev 650872
Push 75523 by gszorc@mozilla.com at Wed, 23 Aug 2017 00:42:07 +0000
Bug 1391476 - Require that all cache paths be declared as volumes; r?dustin See the inline comment for the rationale here. Depending on the order transforms run in, it is possible to evade this check. But I think it is good enough. Plus subsequent commits will essentially make tasks without properly declared caches and volumes impossible to run without permissions failures. Several Dockerfile have been updated to add missing VOLUME so the check passes. In the case of desktop1604-test, we stopped removing /home/worker/.cache because you can't remove a mount point, which is what volumes are inside Docker containers. MozReview-Commit-ID: GEyNkkX00kN
186637c333da09e2619338d0ad3135418694d50d: Bug 1390203: Only get highlight images on wifi. r=sebastian draft
Michael Comella <michael.l.comella@gmail.com> - Tue, 22 Aug 2017 10:59:12 -0700 - rev 650871
Push 75522 by michael.l.comella@gmail.com at Wed, 23 Aug 2017 00:30:00 +0000
Bug 1390203: Only get highlight images on wifi. r=sebastian MozReview-Commit-ID: FtSDZ6Yu5Ql
4a42a080b37104fb49f1f1cfbec884edbab52ba2: Bug 1390203: Add NetworkUtils.isWifi. r=sebastian draft
Michael Comella <michael.l.comella@gmail.com> - Tue, 22 Aug 2017 17:27:19 -0700 - rev 650870
Push 75522 by michael.l.comella@gmail.com at Wed, 23 Aug 2017 00:30:00 +0000
Bug 1390203: Add NetworkUtils.isWifi. r=sebastian It doesn't appear we simply check for a wifi connection type anywhere so the existing code shouldn't need to be updated. MozReview-Commit-ID: 7MqIbdB7uRI
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip