932924c46af8234374988a51f1954ba50b8489f3: Bug 812687 part 4: Add an optional parameter which can make OrderAwareFrameIterator use the legacy "box-ordinal-group" property. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 02:48:12 -0700 - rev 556077
Push 52430 by dholbert@mozilla.com at Wed, 05 Apr 2017 09:49:35 +0000
Bug 812687 part 4: Add an optional parameter which can make OrderAwareFrameIterator use the legacy "box-ordinal-group" property. r?mats This patch just adds an optional codepath that isn't taken yet, so it shouldn't affect our behavior. The large code-comment that this patch adds is just taken verbatim from some nsFlexContainerFrame.cpp code (which will be removed by a later patch in this series, since it's obsoleted by this new mechanism). MozReview-Commit-ID: 9pkJ346rrXg
a83247843f797c271e8de3c3f896154cfc3f7b3a: Bug 812687 part 3: Move OrderAwareFrameIterator code to its own .h/.cpp file. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 02:39:17 -0700 - rev 556076
Push 52430 by dholbert@mozilla.com at Wed, 05 Apr 2017 09:49:35 +0000
Bug 812687 part 3: Move OrderAwareFrameIterator code to its own .h/.cpp file. r?mats This patch just moves code, so it should not affect our behavior at all. MozReview-Commit-ID: 4yxSR5rWUV1
aaa58d058c094900731efdb7feb1ba98f676bd66: Bug 812687 part 2: Rename GridItemCSSOrderIterator to OrderAwareFrameIterator (& similar for its Reverse form). r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 02:37:46 -0700 - rev 556075
Push 52430 by dholbert@mozilla.com at Wed, 05 Apr 2017 09:49:35 +0000
Bug 812687 part 2: Rename GridItemCSSOrderIterator to OrderAwareFrameIterator (& similar for its Reverse form). r?mats This patch is purely type-renames, so it should not affect our behavior at all. MozReview-Commit-ID: 51zRGFyVDtT
45396ae615919aa76c69a0165a07952b2b48a40e: Bug 812687 part 1: Rename GridItemCSSOrderIteratorT to OrderAwareFrameIteratorT, and drop "Grid" from its method names. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 02:37:16 -0700 - rev 556074
Push 52430 by dholbert@mozilla.com at Wed, 05 Apr 2017 09:49:35 +0000
Bug 812687 part 1: Rename GridItemCSSOrderIteratorT to OrderAwareFrameIteratorT, and drop "Grid" from its method names. r?mats This patch is purely type-renames & method-renames, so it should not affect our behavior at all. MozReview-Commit-ID: 5N7zru0uPfD
a8fbdc1d5372ee60a77e5f31e297789b679dd740: Bug 1353010 - Remove the unused director-manager/registry API; r=ochameau draft
Patrick Brosset <pbrosset@mozilla.com> - Wed, 05 Apr 2017 10:44:07 +0200 - rev 556073
Push 52429 by bmo:pbrosset@mozilla.com at Wed, 05 Apr 2017 09:45:43 +0000
Bug 1353010 - Remove the unused director-manager/registry API; r=ochameau MozReview-Commit-ID: 3TZUs0MAhAi
8270f894c3681d1de09cec4cc27e7b720341b6bf: BASEWIP draft
Patrick Brosset <pbrosset@mozilla.com> - Tue, 28 Feb 2017 11:40:11 +0100 - rev 556072
Push 52429 by bmo:pbrosset@mozilla.com at Wed, 05 Apr 2017 09:45:43 +0000
BASEWIP MozReview-Commit-ID: HwxqLjeDtYu
b48addd2f771ea913bb9243ce96384f807e554c1: Bug 1324533 - Moved class '.lean-more-link' to line 855. r?ntim draft
Locke Chen <locke12456@gmail.com> - Wed, 05 Apr 2017 17:40:38 +0800 - rev 556071
Push 52428 by bmo:locke12456@gmail.com at Wed, 05 Apr 2017 09:41:07 +0000
Bug 1324533 - Moved class '.lean-more-link' to line 855. r?ntim MozReview-Commit-ID: IN7i6pkFOwY
eebaa080da264b27ab73af7456e95e560303f6d6: Bug 1350887 - Warn when non-loopback connections are allowed; r=whimboo draft
Andreas Tolfsen <ato@mozilla.com> - Tue, 28 Mar 2017 17:06:06 +0100 - rev 556070
Push 52427 by bmo:ato@mozilla.com at Wed, 05 Apr 2017 09:39:48 +0000
Bug 1350887 - Warn when non-loopback connections are allowed; r=whimboo MozReview-Commit-ID: LG8f5q5QbD6
4a604a224db9e4106f6da1e898f33195c6fc82d2: Bug 1350887 - Propagate errors thrown when starting server.TCPListener; r=whimboo draft
Andreas Tolfsen <ato@mozilla.com> - Tue, 28 Mar 2017 16:48:20 +0100 - rev 556069
Push 52427 by bmo:ato@mozilla.com at Wed, 05 Apr 2017 09:39:48 +0000
Bug 1350887 - Propagate errors thrown when starting server.TCPListener; r=whimboo Errors thrown are printed to console and there is no point in having a custom catch to print it. This also makes it possible to start Marionette programmatically without worrying about disappearing errors. MozReview-Commit-ID: GGhyCyYqJg
f7b7752a227dadbfe91990a79c71b1da4d9e0311: Bug 1350887 - Bind sacrificial goat to ephemeral port; r=whimboo draft
Andreas Tolfsen <ato@mozilla.com> - Tue, 28 Mar 2017 16:46:54 +0100 - rev 556068
Push 52427 by bmo:ato@mozilla.com at Wed, 05 Apr 2017 09:39:48 +0000
Bug 1350887 - Bind sacrificial goat to ephemeral port; r=whimboo Port 666 is in the protected port range and can not normally be bound to unless the process is running with sudo permissions. We can instead bind to port 0, which will give us a system-defined port in the epemeral range. MozReview-Commit-ID: Ld6BDMhtbck
bc16298be5cfba70f8687b7932586945053bb3c1: Bug 1350887 - Fall back to deprecated pref if it exists; r=whimboo draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 27 Mar 2017 14:28:32 +0100 - rev 556067
Push 52427 by bmo:ato@mozilla.com at Wed, 05 Apr 2017 09:39:48 +0000
Bug 1350887 - Fall back to deprecated pref if it exists; r=whimboo This is a follow-up to address a fallout caused by bug 1344748 whereby deprecated preferences relevant to Marionette are no longer being picked up. This is preventing trace logs from being emitted in CI. The old logic related to falling back to a deprecated preference is faulty in that it the preferred, new preference always exists through the power of testing/marionette/prefs.js. This patch introduces a new helper method getPref that first looks at whether the preferred pref is set, and only falls back to the deprecated if it isn't set and the deprecation preference exists. MozReview-Commit-ID: 8DeawLAELyK
cb8d7ac746540d2f7ad50bf57dd27ab5be1761df: Bug 1350887 - Include Marionette prefs amongst defaults; r=ted,whimboo draft
Andreas Tolfsen <ato@mozilla.com> - Wed, 29 Mar 2017 18:25:55 +0100 - rev 556066
Push 52427 by bmo:ato@mozilla.com at Wed, 05 Apr 2017 09:39:48 +0000
Bug 1350887 - Include Marionette prefs amongst defaults; r=ted,whimboo The Marionette component ships in Firefox, but is not enabled by default. We want to facilitate activating Marionette at runtime by flipping the marionette.enabled preference, and showing the Marionette related preferences in about:config helps discoverability. It is also useful to rely on the preferences' default values so that they do not have to be hardcoded in the component. When Marionette is enabled by setting marionette.enabled to true, a set of recommended automation preferences found in testing/marionette/server.js are set if the user has not overriden/user-defined one of them and marionette.prefs.recommended is true (default). When Marionette is stopped, the altered preferences are reset. MozReview-Commit-ID: 3HLnEI0TEBB
ecb1b454285cbce6044c7232ba64a655f1f97a95: Bug 1350887 - Skip recommended Marionette prefs for reftests; r?whimboo draft
Andreas Tolfsen <ato@mozilla.com> - Tue, 04 Apr 2017 16:34:03 +0100 - rev 556065
Push 52427 by bmo:ato@mozilla.com at Wed, 05 Apr 2017 09:39:48 +0000
Bug 1350887 - Skip recommended Marionette prefs for reftests; r?whimboo The recommended Marionette preferences for use in automation are not so useful when testing the browser itself. Many of the tests for Firefox have highly specific requirements, and setting the recommended Marionette preferences could for these mean a deterioration of test coverage. The majority of test harnesses utilising Marionette use it to install unsigned add-ons at runtime, and these preferences are not relevant in this context. To avoid an unfortunate and unintended regression in test coverage, we skip using the recommended Marionette preferences when we test the browser itself. MozReview-Commit-ID: 4DeHZfQEX7d
39e98771948eb7baa8df3a68fc1023c573964374: Bug 1350887 - Add general overview documentation to Marionette; r=whimboo draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 03 Apr 2017 15:00:05 +0100 - rev 556064
Push 52427 by bmo:ato@mozilla.com at Wed, 05 Apr 2017 09:39:48 +0000
Bug 1350887 - Add general overview documentation to Marionette; r=whimboo MozReview-Commit-ID: HwMOQVxwIDN
a5f275ed051eac659e89b55e8dfe950b67885618: Bug 1350887 - Ensure Marionette prefs file has sensible name; r=maja_zf draft
Andreas Tolfsen <ato@mozilla.com> - Thu, 30 Mar 2017 14:52:16 +0100 - rev 556063
Push 52427 by bmo:ato@mozilla.com at Wed, 05 Apr 2017 09:39:48 +0000
Bug 1350887 - Ensure Marionette prefs file has sensible name; r=maja_zf Files appended to JS_PREFERENCE_FILES are moved into the objdir/dist/bin/defaults/pref directory, shared with default global preferences from other parts of Gecko. To ensure Marionette's preference file ends up in this directory with a sensible name, we put it in testing/marionette/prefs/marionette.js so that it ends up in the objdir as dist/bin/defaults/pref/marionette.js. MozReview-Commit-ID: 9YJ7vysDjSJ
755052c137434b10b5bc5bd6017e6399d49d6921: Bug 1353389 - Fix network monitor sidebar panel scrollbars. r=Honza draft
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 05 Apr 2017 11:38:38 +0200 - rev 556062
Push 52426 by bmo:ntim.bugs@gmail.com at Wed, 05 Apr 2017 09:39:11 +0000
Bug 1353389 - Fix network monitor sidebar panel scrollbars. r=Honza MozReview-Commit-ID: AYAaFNTAw1N
d57be7623f46a737260ef7e465d2df1bbe7039aa: Bug 812687 part 6: Rename & invert polarity of a flexbox frame-state-bit, for consistency with grid. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 02:17:39 -0700 - rev 556061
Push 52425 by dholbert@mozilla.com at Wed, 05 Apr 2017 09:35:10 +0000
Bug 812687 part 6: Rename & invert polarity of a flexbox frame-state-bit, for consistency with grid. r?mats This patch is just flipping some logic in a way that should produce the same outcome, so it shouldn't affect behavior. MozReview-Commit-ID: LM4HbJD3D9w
0b86c343924db2cf2d2984482c27b11021d94cb1: Bug 812687 part 5: Adjust nsFlexContainerFrame to use OrderAwareFrameIterator instead of reordering its child frame list. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 02:16:26 -0700 - rev 556060
Push 52425 by dholbert@mozilla.com at Wed, 05 Apr 2017 09:35:10 +0000
Bug 812687 part 5: Adjust nsFlexContainerFrame to use OrderAwareFrameIterator instead of reordering its child frame list. r?mats This shouldn't change our layout order or paint order for flex items (though it will change our behavior for the better when an abspos child is present, as discussed in bug 1345873). This *will* change the tab-focus order of flex items. Previously, the tab order would match the visual order (respecting "order") -- because it depends on the frame tree, and we sorted the frame tree by "order". Now, the tab order will match the DOM order, as the spec requires. MozReview-Commit-ID: 9OsqQX1sEn3
ce51baa94591885d0a3f71e5d55a94cfd6a87c5e: Bug 812687 part 4: Add an optional parameter which can make OrderAwareFrameIterator use the legacy "box-ordinal-group" property. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 01:57:36 -0700 - rev 556059
Push 52425 by dholbert@mozilla.com at Wed, 05 Apr 2017 09:35:10 +0000
Bug 812687 part 4: Add an optional parameter which can make OrderAwareFrameIterator use the legacy "box-ordinal-group" property. r?mats This patch just adds an optional codepath that isn't taken yet, so it shouldn't affect our behavior. The large code-comment that this patch adds is just taken verbatim from some nsFlexContainerFrame.cpp code (which will be removed by a later patch in this series, since it's obsoleted by this new mechanism). MozReview-Commit-ID: 9pkJ346rrXg
6d9484d356b9ebcf391449c38ec4e6ef968957ce: Bug 812687 part 3: Move OrderAwareFrameIterator code to its own .h/.cpp file. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 01:34:17 -0700 - rev 556058
Push 52425 by dholbert@mozilla.com at Wed, 05 Apr 2017 09:35:10 +0000
Bug 812687 part 3: Move OrderAwareFrameIterator code to its own .h/.cpp file. r?mats This patch just moves code, so it should not affect our behavior at all. MozReview-Commit-ID: 4yxSR5rWUV1
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip