9200d40aeb5b8314cd4493de5e4abbf9f7d46c08: Bug 1356843 - Fix -Wcomma warnings in xpcom/io/nsLocalFileUnix.cpp. r=froydnj draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 03 Apr 2017 11:05:57 -0700 - rev 563963
Push 54487 by cpeterson@mozilla.com at Tue, 18 Apr 2017 06:09:29 +0000
Bug 1356843 - Fix -Wcomma warnings in xpcom/io/nsLocalFileUnix.cpp. r=froydnj clang's -Wcomma warning warns about suspicious use of the comma operator such as calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter. xpcom/io/nsLocalFileUnix.cpp:725:48 [-Wcomma] possible misuse of comma operator here xpcom/io/nsLocalFileUnix.cpp:1053:39 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: aebrgc5Wqk
fdb84091f2c2e12932a35918ce1e419c08c36db6: Bug 1356843 - Fix -Wcomma warnings in widget/cocoa/nsDeviceContextSpecX.mm. r=spohl draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:26:25 -0700 - rev 563962
Push 54487 by cpeterson@mozilla.com at Tue, 18 Apr 2017 06:09:29 +0000
Bug 1356843 - Fix -Wcomma warnings in widget/cocoa/nsDeviceContextSpecX.mm. r=spohl clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. widget/cocoa/nsDeviceContextSpecX.mm:246:26 [-Wcomma] possible misuse of comma operator here widget/cocoa/nsDeviceContextSpecX.mm:247:32 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: GhZQgNemLAE
ea0874923d6713da61b4f0fcb659ebc19008f2d1: Bug 1352069 - Introduce a pref that allows for disabling cosmetic animations draft
Jim Porter <jporter@mozilla.com> - Tue, 11 Apr 2017 13:47:31 -0500 - rev 563961
Push 54486 by bmo:squibblyflabbetydoo@gmail.com at Tue, 18 Apr 2017 06:09:01 +0000
Bug 1352069 - Introduce a pref that allows for disabling cosmetic animations This rolls browser.tabs.animate, browser.fullscreen.animate, and alerts.disableSlidingEffect into a single pref; if any of these are disabled, we'll disable the new pref too (toolkit.cosmeticAnimations.enabled). Most future animations will also be subject to this pref. MozReview-Commit-ID: 77pLMtERDna
97b75f5eef1a31e8deeeef8d528eb920f12a5b75: Bug 1356843 - Fix -Wcomma warnings in dom/base/ and dom/xml/. r?bz draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 19:41:50 -0700 - rev 563960
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warnings in dom/base/ and dom/xml/. r?bz clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression. This warning indicates that nsXMLFragmentContentSink::CloseElement() has been calling aContent->IsHTMLElement() but not using its return value to determine whether to call PreventExecution(). This was a regression from bug 1134280 back in 2015. dom/base/nsGlobalWindow.cpp:9344:55 [-Wcomma] possible misuse of comma operator here dom/xml/nsXMLFragmentContentSink.cpp:227:50 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: DontBxeHqGI
8c9c9b65e6c73d2a48e9ed55c665d7b1a2e24043: Bug 1356843 - Fix -Wcomma warnings in js/. r?jorendorff draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 09 Apr 2017 21:15:01 -0700 - rev 563959
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warnings in js/. r?jorendorff clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression. js/src/builtin/MapObject.cpp:786:48 [-Wcomma] possible misuse of comma operator here js/src/builtin/MapObject.cpp:1371:48 [-Wcomma] possible misuse of comma operator here js/src/builtin/RegExp.cpp:1266:62 [-Wcomma] possible misuse of comma operator here js/src/jit/x64/BaseAssembler-x64.h:624:99 [-Wcomma] possible misuse of comma operator here js/src/jsarray.cpp:2416:27 [-Wcomma] possible misuse of comma operator here js/src/jscompartment.cpp:120:48 [-Wcomma] possible misuse of comma operator here js/src/jsstr.cpp:3346:14 [-Wcomma] possible misuse of comma operator here js/xpconnect/src/XPCWrappedNativeJSOps.cpp:316:71 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: BbT4otUXczV
197f24d5f726ee9e4b12b8406527bd595f5a7d1d: Bug 1356843 - Fix -Wcomma warning in intl/uconv/util/nsUCSupport.cpp. r?jshin draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 08 Apr 2017 01:05:19 -0700 - rev 563958
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warning in intl/uconv/util/nsUCSupport.cpp. r?jshin clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. intl/uconv/util/nsUCSupport.cpp:552:34 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: Emk05qDJHbm
6476c1cedde8fedaad12fb39d39cddd27e82ede2: Bug 1356843 - Enable -Wcomma clang warnings. r=glandium draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 08 Apr 2017 12:36:48 -0700 - rev 563957
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Enable -Wcomma clang warnings. r=glandium Warn about possible misuse of the comma operator such as between two statements or to call a function for side effects within an expression. Only enable these -Wcomma warnings for C++ code because there are almost two hundred -Wcomma warnings in third-party C libraries. I reviewed the C warnings and confirmed none of them were latent bugs. We won't fix these libraries' warnings so they are just noise. MozReview-Commit-ID: 1JXJumg6DsJ
e050c19d337ef5580b3bc0fafe7c28a467274125: Bug 1356843 - Fix -Wcomma warning in xpfe/appshell/nsXULWindow.cpp. r=mstange draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 08 Apr 2017 00:59:47 -0700 - rev 563956
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warning in xpfe/appshell/nsXULWindow.cpp. r=mstange clang's -Wcomma warning warns about suspicious use of the comma operator such as calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter. xpfe/appshell/nsXULWindow.cpp:2154:50 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: Dbe4NDDhqY1
260dd4da2c6c0992ce904c750c8cf4d7abab27b6: Bug 1356843 - Fix -Wcomma warnings in xpcom/io/nsLocalFileUnix.cpp. r=froydnj draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 03 Apr 2017 11:05:57 -0700 - rev 563955
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warnings in xpcom/io/nsLocalFileUnix.cpp. r=froydnj clang's -Wcomma warning warns about suspicious use of the comma operator such as calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter. xpcom/io/nsLocalFileUnix.cpp:725:48 [-Wcomma] possible misuse of comma operator here xpcom/io/nsLocalFileUnix.cpp:1053:39 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: aebrgc5Wqk
d46d151a6829dc8998301e6c58be48c761f357cb: Bug 1356843 - Fix -Wcomma warnings in widget/cocoa/nsDeviceContextSpecX.mm. r=spohl draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:26:25 -0700 - rev 563954
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warnings in widget/cocoa/nsDeviceContextSpecX.mm. r=spohl clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. widget/cocoa/nsDeviceContextSpecX.mm:246:26 [-Wcomma] possible misuse of comma operator here widget/cocoa/nsDeviceContextSpecX.mm:247:32 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: GhZQgNemLAE
be6944854d5110d2f930b1deeb9881b78119f0b8: Bug 1356843 - Fix -Wcomma warning in tools/profiler/lul/LulDwarf.cpp. r?jseward draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 09 Apr 2017 21:43:29 -0700 - rev 563953
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warning in tools/profiler/lul/LulDwarf.cpp. r?jseward clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. tools/profiler/lul/LulDwarf.cpp:604:15: warning: possible misuse of comma operator here [-Wcomma] MozReview-Commit-ID: 6ZP79hgtrAD
efd3de3df6e15da9cc3bc6d31417f732f39cbf63: Bug 1356843 - Fix -Wcomma warnings in toolkit/. r=mossop draft
Chris Peterson <cpeterson@mozilla.com> - Wed, 05 Apr 2017 01:23:45 -0700 - rev 563952
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warnings in toolkit/. r=mossop clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter. toolkit/components/startup/nsAppStartup.cpp:436:58 [-Wcomma] possible misuse of comma operator here toolkit/components/statusfilter/nsBrowserStatusFilter.cpp:165:66 [-Wcomma] possible misuse of comma operator here toolkit/xre/CreateAppData.cpp:60:51 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: HuZRoOjQTGj
2caaedd75d43b6ce4364d01d75823c43c621e82a: Bug 1356843 - Fix -Wcomma warning in netwerk/protocol/http/Http2Stream.cpp. r=jhao draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:42:21 -0700 - rev 563951
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warning in netwerk/protocol/http/Http2Stream.cpp. r=jhao clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. netwerk/protocol/http/Http2Stream.cpp:436:59 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: AsmNPTjKlYB
d25658a39026821bf0b455967872001fb4816da5: Bug 1356843 - Fix -Wcomma warning in modules/libjar/nsZipArchive.cpp. r=aklotz draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:39:36 -0700 - rev 563950
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warning in modules/libjar/nsZipArchive.cpp. r=aklotz clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression. modules/libjar/nsZipArchive.cpp:651:25 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: 9PjB915D81f
226579518bb9989b0812ef217499c7bc69a84806: Bug 1356843 - Fix -Wcomma warnings in layout/. r=dholbert draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 09 Apr 2017 21:11:45 -0700 - rev 563949
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warnings in layout/. r=dholbert clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression. In addition to fixing the warnings, replace some char16_t(' ') casts of char literals with shorter UTF-16 character literals u' '. layout/painting/FrameLayerBuilder.cpp:3647:31 [-Wcomma] possible misuse of comma operator here layout/painting/FrameLayerBuilder.cpp:3657:41 [-Wcomma] possible misuse of comma operator here layout/painting/nsCSSRenderingBorders.cpp:3336:33 [-Wcomma] possible misuse of comma operator here layout/painting/nsCSSRenderingBorders.cpp:3336:60 [-Wcomma] possible misuse of comma operator here layout/painting/nsCSSRenderingBorders.cpp:3337:33 [-Wcomma] possible misuse of comma operator here layout/painting/nsCSSRenderingBorders.cpp:3337:60 [-Wcomma] possible misuse of comma operator here layout/style/Declaration.cpp:808:41 [-Wcomma] possible misuse of comma operator here layout/style/Declaration.cpp:812:42 [-Wcomma] possible misuse of comma operator here layout/style/FontFaceSet.cpp:1118:60 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: 9tfcIsnnBwM
829f756d04a3f3e06669e3700e4e373ca9cf5adc: Bug 1356843 - Fix -Wcomma warnings in gfx/layers/Layers.cpp. r=mchang draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:29:42 -0700 - rev 563948
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warnings in gfx/layers/Layers.cpp. r=mchang clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. gfx/layers/Layers.cpp:1944:33 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1945:33 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1946:33 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1949:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1950:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1951:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1952:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1953:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1954:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1955:37 [-Wcomma] possible misuse of comma operator here gfx/layers/Layers.cpp:1956:37 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: 9lMJZrPRtTV
ed9a0bf53f232a887d40918d2ff7d9ca63a45455: Bug 1356843 - Fix -Wcomma warning in extensions/spellcheck/src/mozSpellChecker.cpp. r=masayuki draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Mar 2017 21:24:35 -0700 - rev 563947
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warning in extensions/spellcheck/src/mozSpellChecker.cpp. r=masayuki clang's -Wcomma warning warns about suspicious use of the comma operator such as calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter. extensions/spellcheck/src/mozSpellChecker.cpp:532:54 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: 3GnKVvx8Nu4
5ab03d10f255179f68aeb9559e9a64600c313b42: Bug 1356843 - Fix -Wcomma warnings in dom/svg/SVGGeomeetryElement.h. r=dholbert draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 17 Apr 2017 22:22:51 -0700 - rev 563946
Push 54485 by cpeterson@mozilla.com at Tue, 18 Apr 2017 05:57:33 +0000
Bug 1356843 - Fix -Wcomma warnings in dom/svg/SVGGeomeetryElement.h. r=dholbert clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. dom/svg/SVGGeometryElement.h:117:21 [-Wcomma] possible misuse of comma operator here dom/svg/SVGGeometryElement.h:117:41 [-Wcomma] possible misuse of comma operator here dom/svg/SVGGeometryElement.h:128:14 [-Wcomma] possible misuse of comma operator here dom/svg/SVGGeometryElement.h:128:23 [-Wcomma] possible misuse of comma operator here MozReview-Commit-ID: CfNOsfcJTEp
527ca85795986e93fc5158be3b08ba32780cf450: Bug 1352069 - Introduce a pref that allows for disabling cosmetic animations draft
Jim Porter <jporter@mozilla.com> - Tue, 11 Apr 2017 13:47:31 -0500 - rev 563945
Push 54484 by bmo:squibblyflabbetydoo@gmail.com at Tue, 18 Apr 2017 05:44:59 +0000
Bug 1352069 - Introduce a pref that allows for disabling cosmetic animations This rolls browser.tabs.animate, browser.fullscreen.animate, and alerts.disableSlidingEffect into a single pref. Future animations will also be subject to this pref. MozReview-Commit-ID: 77pLMtERDna
6cbe6ac4290ba3e4ac5938583872e679e6fa665d: Bug 1356957 - call updateRequest once when update request in netmonitor-controller;r=rickychien draft
Fred Lin <gasolin@mozilla.com> - Mon, 17 Apr 2017 14:21:59 +0800 - rev 563944
Push 54483 by bmo:gasolin@mozilla.com at Tue, 18 Apr 2017 05:42:26 +0000
Bug 1356957 - call updateRequest once when update request in netmonitor-controller;r=rickychien MozReview-Commit-ID: J6lLXNlnJnM
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip