91dc62bd6c4319219366d6040dfaabefcdb4e965: Bug 1426555 - Use mozconfig.no-compile in non-compiling android jobs. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Dec 2017 09:54:20 +0900 - rev 714337
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1426555 - Use mozconfig.no-compile in non-compiling android jobs. r=chmanchester Instead of manually unsetting a few variables and adding --disable-compile-environment, we can rely on the mozconfig that does all that.
0052f68e4f792b2da308909387c6f12f14a59b9c: Bug 1426555 - Make autospider builds use --enable-stdcxx-compat on Linux only. r=sfink
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Dec 2017 09:50:16 +0900 - rev 714336
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1426555 - Make autospider builds use --enable-stdcxx-compat on Linux only. r=sfink Some of the variants are multi-platforms, and having --enable-stdcxx-compat in their definition will break when the option is moved over to python configure. While here, prepare for --enable-stdcxx-compat actually doing something (it currently doesn't), by adding an exception for it in check_vanilla_allocations.py.
a931893981e5cc287ac2feb90f60d5eab5f20fa3: Bug 1423801: Include trust-domain in the scopes to use for sccache; r=dustin
Tom Prince <mozilla@hocat.ca> - Thu, 21 Dec 2017 14:43:38 -0700 - rev 714335
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1423801: Include trust-domain in the scopes to use for sccache; r=dustin MozReview-Commit-ID: KepwpXJFo8X
38d0846ab899566e513c24014f47645e914b47f1: Bug 1420533: Add crashtest. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Dec 2017 00:49:32 +0100 - rev 714334
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1420533: Add crashtest. r=me MozReview-Commit-ID: EemfowpZSqp
39bcda54a789453e8e018f2dd6ccfd4f70ce204b: Bug 1359396 - Redesign HTMLEditRules::IsEmptyBlock() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 20 Dec 2017 22:25:12 +0900 - rev 714333
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1359396 - Redesign HTMLEditRules::IsEmptyBlock() r=m_kato HTMLEditRules::IsEmptyBlock() won't return error in most cases. Additionally, HTMLEditRules::WillInsertBreak() doesn't check it. So, just returning bool is simpler. MozReview-Commit-ID: 5DfRv7lIyuS
2a84ee8f73414ef95ab094cf7fe928971289a3f1: Bug 1359405 - Redesign HTMLEditor::IsVisTextNode() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 20 Dec 2017 15:07:37 +0900 - rev 714332
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1359405 - Redesign HTMLEditor::IsVisTextNode() r=m_kato Despite of its name, HTMLEditor::IsVisTextNode() returns true with its out argument when the given text node is empty. And although it returns nsresult, it's almost always NS_OK because it returns error only when the editor isn't usual condition. So, it should return bool and true when the given text node is visible. This patch separates the method. One is for checking the node with frames, called IsInVisibleTextFrames(). The other is for checking it only with its text, called IsVisibleTextNode(). MozReview-Commit-ID: EdQmkOxfNxO
278ae84e7aeae7dca895fb1f11594e0199bcfbe5: Bug 1425412 - part 12: Create factory methods for DeleteRangeTransaction, EditAggregateTransaction and PlaceholderTransaction for consistency with the other transaction classes r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 18 Dec 2017 18:08:43 +0900 - rev 714331
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 12: Create factory methods for DeleteRangeTransaction, EditAggregateTransaction and PlaceholderTransaction for consistency with the other transaction classes r=m_kato Although, we don't need factory methods for DeleteRangeTransaction, EditAggregateTransaction nor PlaceholderTransaction, for consistency with the other transaction classes, they should have factory methods for making easier to write the code. For not making the performance slow down, they should be inline methods. MozReview-Commit-ID: 7jl5yZNFYmP
98e9140f291df5b7e2f69f53a7311627cc1e8929: Bug 1425412 - part 11: Create factory methods for ChangeStyleTransaction and remove CSSEditUtils::CreateCSSPropertyTxn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 18 Dec 2017 17:46:57 +0900 - rev 714330
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 11: Create factory methods for ChangeStyleTransaction and remove CSSEditUtils::CreateCSSPropertyTxn() r=m_kato This patch creates factory methods for ChangeStyleTransaction and removes CSSEditUtils::CreateCSSPropertyTxn(). MozReview-Commit-ID: 1h8ZAj2PP5O
bfbe1d3bf3776836a8d08c2fb490f152777301a0: Bug 1425412 - part 10: Create factory methods for AddStyleSheetTransaction and RemoveStyleSheetTransaction, and remove EditorBase::CreateTxnForAddStyleSheet() and EditorBase::CreateTxnForRemoveStyleSheet() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 18 Dec 2017 17:29:32 +0900 - rev 714329
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 10: Create factory methods for AddStyleSheetTransaction and RemoveStyleSheetTransaction, and remove EditorBase::CreateTxnForAddStyleSheet() and EditorBase::CreateTxnForRemoveStyleSheet() r=m_kato This patch creates factory methods for AddStyleSheetTransaction and RemoveStyleSheetTransaction, and removes EditorBase::CreateTxnForAddStyleSheet() and EditorBase::CreateTxnForRemoveStyleSheet() instead. MozReview-Commit-ID: 6dnZctDtNik
d4351f088a6e6ace7c52838b45a17694513b12de: Bug 1425412 - part 9: Create factory methods of ChangeAttributeTransaction and remove EditorBase::CreateTxnForSetAttribute() and EditorBase::CreateTxnForRemoveAttribute() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 18 Dec 2017 17:07:52 +0900 - rev 714328
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 9: Create factory methods of ChangeAttributeTransaction and remove EditorBase::CreateTxnForSetAttribute() and EditorBase::CreateTxnForRemoveAttribute() r=m_kato This patch creates two factory methods of ChangeAttributeTransaction. One is for setting an attribute to specific value. The other is for removing an attribute. So, EditorBase::CreateTxnForSetAttribute() and EditorBase::CreateTxnForRemoveAttribute() are unnecessary anymore. MozReview-Commit-ID: 2fEVd3pDXsf
adacb161f91707a1ccd8e20e806067cf01e1628d: Bug 1425412 - part 8: Create JoinNodeTransaction::MaybeCreate() and remove EditorBase::CreateTxnForJoinNode() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 15 Dec 2017 21:53:08 +0900 - rev 714327
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 8: Create JoinNodeTransaction::MaybeCreate() and remove EditorBase::CreateTxnForJoinNode() r=m_kato EditorBase::CreateTxnForJoinNode() just hides what it does. For making the caller clearer, let's create a factory method, JoinNodeTransaction::MaybeCreate(). MozReview-Commit-ID: 8vADXdzMeuV
1af2984c6a7c7967feca04fb4b1e7b13f1f79f88: Bug 1425412 - part 7: Create SplitNodeTransaction::Create() and remove EditorBase::CreateTxnForSplitNode() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 15 Dec 2017 21:37:23 +0900 - rev 714326
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 7: Create SplitNodeTransaction::Create() and remove EditorBase::CreateTxnForSplitNode() r=m_kato SplitNodeTransaction::Create() just hides what it does. For making its caller clearer, let's create a factory method, SplitNodeTransaction::Create(). MozReview-Commit-ID: KDiC8dDrLuQ
be2bafa5c666bc1fc9a9cf0bc3a719ac16611427: Bug 1425412 - part 6: Create DeleteNodeTransaction::MaybeCreate() and remove EditorBaseTransaction::CreateTxnForDeleteNode() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 15 Dec 2017 21:24:33 +0900 - rev 714325
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 6: Create DeleteNodeTransaction::MaybeCreate() and remove EditorBaseTransaction::CreateTxnForDeleteNode() r=m_kato EditorBaseTransaction::CreateTxnForDeleteNode() just hides what it does. Instead, let's create a factory method, DeleteNodeTransaction::MaybeCreate() for making callers clearer. MozReview-Commit-ID: 8WUYN0BjKSU
05aab5d7c6fa683e0973295a1b34a5308b145cbe: Bug 1425412 - part 5: Create some factory methods of DeleteTextTransaction and remove EditorBase::CreateTxnForDeleteText() and EditorBase::CreateTxnForDeleteCharacter() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 15 Dec 2017 20:43:26 +0900 - rev 714324
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 5: Create some factory methods of DeleteTextTransaction and remove EditorBase::CreateTxnForDeleteText() and EditorBase::CreateTxnForDeleteCharacter() r=m_kato DeleteTextTransaction should have 3 factory methods. One is, simply to create an instance with a pair of offset and length. The others are, to create an instance for deleting a previous or next character at offset. The former was EditorBase::CreateTxnForDeleteText() and the latter was EditorBase::CreateTxnForDeleteCharacter(), but this patch creates DeleteTextTransaction::MaybeCreate() for the former, DeleteTextTransaction::MaybeCreateForPreviousCharacter() and DeleteTextTransaction::MaybeCreateForNextCharacter() for the latter. MozReview-Commit-ID: DFELbmAJDo3
cbde98b345fcaedb2131cc6a0010b799dc912555: Bug 1425412 - part 4: Create CompositionTransaction::Create() and remove EditorBase::CreateTxnForComposition() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 15 Dec 2017 18:26:37 +0900 - rev 714323
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 4: Create CompositionTransaction::Create() and remove EditorBase::CreateTxnForComposition() r=m_kato EditorBase::CreateTxnForComposition() just hides what it does. For its caller, creating a factory method, CompositionTransaction::Create(), is clearer what it does. Additionally, capsuling the creation in CompositionTransaction class can make the text node information in TextComposition updated automatically. So, now, it might be better to update them in DoTransaction() because there is a lag between creating the transaction and calling DoTransaction(). However, this patch doesn't want to change any existing behavior. So, this doesn't fix this issue. MozReview-Commit-ID: K8ci7ytwh1u
35cddb12f139e28775c5cc787f91207dbc180fb3: Bug 1425412 - part 3: Create CreateElementTransaction::Create() and remove EditorBase::CreateTxnForCreateElement() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 15 Dec 2017 17:54:10 +0900 - rev 714322
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 3: Create CreateElementTransaction::Create() and remove EditorBase::CreateTxnForCreateElement() r=m_kato EditorBase::CreateTxnForCreateElement() just hides what it does. Let's make the caller what it does with creating CreateElementTransaction::Create(). MozReview-Commit-ID: DYcfQV6KiUZ
d692dc23699b887aac003eaceb25346e8919fd86: Bug 1425412 - part 2: Create InsertNodeTransaction::Create() and remove EditorBase::CreateTxnForInsertNode() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 15 Dec 2017 17:34:52 +0900 - rev 714321
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 2: Create InsertNodeTransaction::Create() and remove EditorBase::CreateTxnForInsertNode() r=m_kato EditorBase::CreateTxnForInsertNode() just hides what it does. Let's create InsertNodeTransaction::Create() and make the caller clearer. MozReview-Commit-ID: 2J2WV73cdsm
41a28234be872e4c729bb3f06b38964b33ed30cb: Bug 1425412 - part 1: Create InsertTextTransaction::Create() and remove EditorBase::CreateTxnForInsertText() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 15 Dec 2017 17:26:52 +0900 - rev 714320
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1425412 - part 1: Create InsertTextTransaction::Create() and remove EditorBase::CreateTxnForInsertText() r=m_kato EditorBase::CreateTxnForInsertText() just hides what it exactly does. Rewriting it with a static factory method, InsertTextTransaction::Create() should be clearer for its caller. MozReview-Commit-ID: Er7Zlhtbnb0
d0d8308550d80553b6f70143a9bafe56cc164cd4: Bug 1365574 - Release event loop between react module loading and toolbox react rendering. r=pbro
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 30 Nov 2017 08:34:05 -0800 - rev 714319
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Bug 1365574 - Release event loop between react module loading and toolbox react rendering. r=pbro MozReview-Commit-ID: D1M9n3VFdHJ
cbf35483a00ba5f0ac234bf3be28da56133b6254: Merge mozilla-central to autoland r=merge a=merge on a CLOSED TREE
arthur.iakab <aiakab@mozilla.com> - Fri, 22 Dec 2017 00:25:54 +0200 - rev 714318
Push 93894 by bmo:emilio@crisal.io at Fri, 22 Dec 2017 10:21:06 +0000
Merge mozilla-central to autoland r=merge a=merge on a CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip