91befb137e9f23b7a556cfb6a5fea37915e7e6ba: Bug 1443231 - Follow-up to fix warning-as-error on Windows. r=bustage, CLOSED TREE draft
Botond Ballo <botond@mozilla.com> - Mon, 05 Mar 2018 16:38:17 -0500 - rev 763370
Push 101434 by bballo@mozilla.com at Mon, 05 Mar 2018 21:40:55 +0000
Bug 1443231 - Follow-up to fix warning-as-error on Windows. r=bustage, CLOSED TREE MozReview-Commit-ID: 52PVwcjRVu3
ff674d8345ca8626350e671bdaf1cf6bdd28a900: Bug 1407383 - [wdspec] Re-enable test keys.py. draft
Henrik Skupin <mail@hskupin.info> - Fri, 16 Feb 2018 11:51:42 +0100 - rev 763369
Push 101433 by bmo:hskupin@gmail.com at Mon, 05 Mar 2018 21:39:50 +0000
Bug 1407383 - [wdspec] Re-enable test keys.py. MozReview-Commit-ID: E4LvVQWiZs4
3358d242db1b2b96f422d7b5e8441ea413f9f237: Bug 1407383 - [wdspec] Remove unused imports from fixtures module. draft
Henrik Skupin <mail@hskupin.info> - Mon, 05 Mar 2018 22:33:48 +0100 - rev 763368
Push 101433 by bmo:hskupin@gmail.com at Mon, 05 Mar 2018 21:39:50 +0000
Bug 1407383 - [wdspec] Remove unused imports from fixtures module. MozReview-Commit-ID: LgAI7fOhyqB
00691e602cb6103efef6fe6bc93190cabcb40e9b: Bug 1407383 - [wdspec] Remove usage of mozlog to prevent process lock. draft
Henrik Skupin <mail@hskupin.info> - Mon, 05 Mar 2018 22:32:57 +0100 - rev 763367
Push 101433 by bmo:hskupin@gmail.com at Mon, 05 Mar 2018 21:39:50 +0000
Bug 1407383 - [wdspec] Remove usage of mozlog to prevent process lock. Due to misbehavior of the threading module in how threads are forked, the mozlog module and specifically the Lock instance in StructuredLogger can cause a hang of random duration when trying to require the lock. Given that mozlog isn't used anywhere workaround this problem by removing all instances of it. MozReview-Commit-ID: 10yrUIb0XW4
28cfb89c62e65f28b1e78cb656b1eed5f86f3a3d: Bug 1443231 - Follow-up to fix warning-as-error on Windows. r=bustage draft
Botond Ballo <botond@mozilla.com> - Mon, 05 Mar 2018 16:38:17 -0500 - rev 763366
Push 101432 by bballo@mozilla.com at Mon, 05 Mar 2018 21:39:34 +0000
Bug 1443231 - Follow-up to fix warning-as-error on Windows. r=bustage MozReview-Commit-ID: 52PVwcjRVu3
1abf2296d0f6afad7ef96edeef807d7190fea68f: Bug 1443231 - Ensure we are in the NOTHING state after a pinch gesture, if both fingers are lifted and no animation is triggered. r=kats draft
Botond Ballo <botond@mozilla.com> - Mon, 05 Mar 2018 13:53:21 -0500 - rev 763365
Push 101432 by bballo@mozilla.com at Mon, 05 Mar 2018 21:39:34 +0000
Bug 1443231 - Ensure we are in the NOTHING state after a pinch gesture, if both fingers are lifted and no animation is triggered. r=kats MozReview-Commit-ID: HexeLTlfbuq
faf0d953cba483a41980605bae19597181122959: Bug 1407383 - [wdspec] Re-enable test keys.py. draft
Henrik Skupin <mail@hskupin.info> - Fri, 16 Feb 2018 11:51:42 +0100 - rev 763364
Push 101431 by bmo:hskupin@gmail.com at Mon, 05 Mar 2018 21:34:41 +0000
Bug 1407383 - [wdspec] Re-enable test keys.py. MozReview-Commit-ID: E4LvVQWiZs4
09526a6ff198cbbd419edd22b5f026548986f87e: Bug 1407383 - [wdspec] Remove unused imports from fixtures module. draft
Henrik Skupin <mail@hskupin.info> - Mon, 05 Mar 2018 22:33:48 +0100 - rev 763363
Push 101431 by bmo:hskupin@gmail.com at Mon, 05 Mar 2018 21:34:41 +0000
Bug 1407383 - [wdspec] Remove unused imports from fixtures module. MozReview-Commit-ID: LgAI7fOhyqB
bb0290fb88823de4c79440d46ef334468b79fb8f: Bug 1407383 - [wdspec] Remove usage of mozlog to prevent process lock. draft
Henrik Skupin <mail@hskupin.info> - Mon, 05 Mar 2018 22:32:57 +0100 - rev 763362
Push 101431 by bmo:hskupin@gmail.com at Mon, 05 Mar 2018 21:34:41 +0000
Bug 1407383 - [wdspec] Remove usage of mozlog to prevent process lock. Due to misbehavior of the threading module in how threads are forked, the mozlog module and specifically the Lock instance in StructuredLogger can cause a hang of random duration when trying to require the lock. Given that mozlog isn't used anywhere workaround this problem by removing all instances of it. MozReview-Commit-ID: 10yrUIb0XW4
accd33b1268c88f772f0cdbdb9c18c0f0b8075bc: Bug 1442861 - Clear mNeedStyleFlush flag after ProcessPendingRestyles(). r?emilio draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 06 Mar 2018 06:34:02 +0900 - rev 763361
Push 101430 by hikezoe@mozilla.com at Mon, 05 Mar 2018 21:34:23 +0000
Bug 1442861 - Clear mNeedStyleFlush flag after ProcessPendingRestyles(). r?emilio mNeedStyleFlush is also set by animation restyle request. So it's possible that the flag is set again in PostRestyleForThrottledAnimations() or in sequential tasks for updating animations after the flag is cleared at the top DoFlushPendingNotifications(). MozReview-Commit-ID: KPSS6cJb4HX
1efcba99aaed0109b653fdd44cef6b5c1344646c: Bug 335545 - Add test to verify that overflowing clipboard data survives draft
Rob Wu <rob@robwu.nl> - Sun, 25 Feb 2018 19:08:12 +0100 - rev 763360
Push 101429 by bmo:rob@robwu.nl at Mon, 05 Mar 2018 21:19:52 +0000
Bug 335545 - Add test to verify that overflowing clipboard data survives I accidentally broke the ability to retrieve a big string from the clipboard, and there was no test that failed. So this provides a new test that does the following: 1. Store a big string in a nsTransferable. 2. Copy it to the clipboard. 3. Create a new nsTransferable, initialize with small data. 4. Populate the nsTransferable with (big) data from the clipboard. 5. Populate the nsTransferable with small data. After each step, the test checks whether the transferable holds the expected data and length, and (on non-Windows) checks that the big data is backed by a file, and small data is not. MozReview-Commit-ID: 9yuXZxVqD6R
efdfa5bdaf6aef1af9e410c33d731610ecd96918: Bug 335545 - Make DataStruct non-copyable draft
Rob Wu <rob@robwu.nl> - Sun, 25 Feb 2018 17:36:08 +0100 - rev 763359
Push 101429 by bmo:rob@robwu.nl at Mon, 05 Mar 2018 21:19:52 +0000
Bug 335545 - Make DataStruct non-copyable DataStruct cannot safely be copied if its mCacheFD member is set. Currently there is no code for this case, but to avoid problems later, mark the copy and assignment constructors private and delete them. A move-constructor was added to compensate for the deleted copy constructor. nsTransferable::AddDataFlavor uses this new constructor instead of the previous implicit default copy constructor. MozReview-Commit-ID: 3N5xjFXOUKB
54971344845e2991ed27d4d4e355db11b32ba2a3: Bug 335545 - Count FD instead of looking for clipboardcache in test_bug1123480.xul r?mstange draft
Rob Wu <rob@robwu.nl> - Sun, 25 Feb 2018 17:30:13 +0100 - rev 763358
Push 101429 by bmo:rob@robwu.nl at Mon, 05 Mar 2018 21:19:52 +0000
Bug 335545 - Count FD instead of looking for clipboardcache in test_bug1123480.xul r?mstange - Count open file descriptors instead of testing the existence of a file (because the clipboard is now only reachable through file descriptors, and not through a file path). - Use a fixed string instead of a random string. The previous way of generating a string was non-deterministic, and there was a very small chance that the generated string was not large enough to trigger the cache-to-disk-mode. - Use "text/unicode" instead of "text/plain", because JavaScript strings use two bytes, not one bytes each. - The cache file is already created when the Transferable is created, so check the cache file after assigning data to the nsITransferable, but before copying it to the clipboard. MozReview-Commit-ID: KOkYOm280Oh
6cd66479ec2b6bea984939df3354a3549039d350: Bug 335545 - Store clipboard data in memory XOR file draft
Rob Wu <rob@robwu.nl> - Sun, 03 Sep 2017 03:21:45 +0200 - rev 763357
Push 101429 by bmo:rob@robwu.nl at Mon, 05 Mar 2018 21:19:52 +0000
Bug 335545 - Store clipboard data in memory XOR file Ensure that only DataStruct::mData + mDataLen, XOR DataStruct::mCacheFD is used. (Previously it was possible that all of these members were populated, which is a waste of memory.) The effect of this change is visible when SetTransferData is called multiple times with the same flavor, but with one below the threshold for storing in-memory, and the other above (=store in a file). MozReview-Commit-ID: 4UlkKAYsjf
76ca4fcb40fc13a370e7edd68ed3cebdb66cbab2: Bug 335545 - Use nsAnonymousTemporaryFile for clipboard cache draft
Rob Wu <rob@robwu.nl> - Sun, 03 Sep 2017 02:29:10 +0200 - rev 763356
Push 101429 by bmo:rob@robwu.nl at Mon, 05 Mar 2018 21:19:52 +0000
Bug 335545 - Use nsAnonymousTemporaryFile for clipboard cache The cache file is never directly exposed to consumers of DataStruct, so it does not make sense to keep the clipboardcache file around forever. The only change in this commit is to switch from using a filename to using a file descriptor. In the destructor, the FD is explicitly closed (which releases the file data). nsAnonymousTemporaryFile takes care of removing the file when the destructor is not called (e.g. crashes). Previously, the clipboard cache was stored in a file called: TmpD/clipboardcache-N As of this commit, the clipboard cache is stored at: TmpD/mozilla-temp-randomN (macOS and Linux) TmpD/mozilla-temp-files/mozilla-temp-randomN (Windows) (see xpcom/io/nsAnonymousTemporaryFile.{h,cpp} for more details) To verify that these files are really gone: 1. Create a document with 500k+ characters, open it in Firefox. 2. Copy its content - this will trigger the clipboard cache. 3. Look for the open file descriptor of the deleted file: ( macOS and Linux: ) lsof +L1 | grep mozilla-temp 4. Copy anything (under the 500k threshold), or quit/kill Firefox. 5. Repeat step 3 and observe that the number of file descriptors has decreased. MozReview-Commit-ID: 85GlKQrNUl5
cc1fe9c6c5b03e8e889cdf95819af3560f7a6084: Bug 1443229 - Add a 'command' event listener for the urlbar search suggestions checkbox. r?gijs draft
Jared Wein <jwein@mozilla.com> - Mon, 05 Mar 2018 16:17:25 -0500 - rev 763355
Push 101428 by bmo:jaws@mozilla.com at Mon, 05 Mar 2018 21:18:11 +0000
Bug 1443229 - Add a 'command' event listener for the urlbar search suggestions checkbox. r?gijs This was inadvertently removed when the preference attribute was removed to clean up a race condition. MozReview-Commit-ID: 8yNPMwkGS3u
37ef4bf990fc081e9884f604dbad0afc5cbeaf95: Bug 1437694 - Gracefully recover from hit testing bugs affecting scrollbar dragging. r=kats draft
Botond Ballo <botond@mozilla.com> - Mon, 12 Feb 2018 17:58:36 -0500 - rev 763354
Push 101427 by bballo@mozilla.com at Mon, 05 Mar 2018 21:17:29 +0000
Bug 1437694 - Gracefully recover from hit testing bugs affecting scrollbar dragging. r=kats The recovery is only enabled for release builds, to avoid papering over such hit testing bugs. On nightly builds, a diagnostic assert is issued. MozReview-Commit-ID: Aos0j0jv6Lb
3f8dcfc7d84cd403de99df3fc463f94ce7185fe8: Bug 1396823 - Added tests for special keys that use multiple codepoints draft
Greg Fraley <gsfraley@gmail.com> - Mon, 05 Mar 2018 16:02:38 -0500 - rev 763353
Push 101426 by bmo:gsfraley@gmail.com at Mon, 05 Mar 2018 21:03:25 +0000
Bug 1396823 - Added tests for special keys that use multiple codepoints MozReview-Commit-ID: G3SCO5kIap
827a7dba479867a1269e9563fdcc709d8d3cc565: Bug 1396823 - Use unicode-segmentation to iterate graphemes instead of chars draft
Greg Fraley <gsfraley@gmail.com> - Sat, 03 Mar 2018 22:05:08 -0500 - rev 763352
Push 101426 by bmo:gsfraley@gmail.com at Mon, 05 Mar 2018 21:03:25 +0000
Bug 1396823 - Use unicode-segmentation to iterate graphemes instead of chars MozReview-Commit-ID: AjqoVxdCSLR
bd5ca37740ec2b4264712f8c6a547f1a4c6ef3b7: Bug 1442560 - Add a note for deprecating passing a storage option to indexedDB.open(). r=asuth draft
Johann Hofmann <jhofmann@mozilla.com> - Mon, 05 Mar 2018 20:01:00 +0100 - rev 763351
Push 101425 by jhofmann@mozilla.com at Mon, 05 Mar 2018 20:55:29 +0000
Bug 1442560 - Add a note for deprecating passing a storage option to indexedDB.open(). r=asuth MozReview-Commit-ID: 44yCmYrPP26
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip