906b8bdd2002b75be1ec731694d818b7aff02187: Bug 1400347 - Update test_ext_tabs_captureVisibleTab.html to comply with new toplevel data: URI navigation policy. r=smaug
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Fri, 15 Sep 2017 21:01:00 +0200 - rev 665729
Push 80151 by mozilla@noorenberghe.ca at Fri, 15 Sep 2017 21:11:42 +0000
Bug 1400347 - Update test_ext_tabs_captureVisibleTab.html to comply with new toplevel data: URI navigation policy. r=smaug
4360d673edef90dc3b3397b60d1cfdcc1ed0c312: Bug 1380959: Block oplevel data: URI navigations in Nightly and early Beta. r=bz
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Fri, 15 Sep 2017 18:23:01 +0200 - rev 665728
Push 80151 by mozilla@noorenberghe.ca at Fri, 15 Sep 2017 21:11:42 +0000
Bug 1380959: Block oplevel data: URI navigations in Nightly and early Beta. r=bz
722569a89186be92efbaebfa99005e5c46e27cf5: Bug 1380649 - Assert if we remap a purged SourceSurfaceVolatileBuffer. r=jrmuizel
Andrew Osmond <aosmond@mozilla.com> - Fri, 15 Sep 2017 14:47:52 -0400 - rev 665727
Push 80151 by mozilla@noorenberghe.ca at Fri, 15 Sep 2017 21:11:42 +0000
Bug 1380649 - Assert if we remap a purged SourceSurfaceVolatileBuffer. r=jrmuizel There have been reports of images remaining in the surface cache but no longer containing the previously decoded data. Instead these appear as transparent (BGRA) or black (BGRX). This suggests that somehow the image surface buffer was reset to all zeroes. Additionally this seems to be correlated with suspend and resume. One possibility is that the OS purged our volatile buffers on suspend. This is because we are supposed to be able to regenerate the contents anyways, so it could choose to not preserve the data on suspend. In general we should recover from this however and clearly we are not. This patch adds a diagnostic assert to ensure that a buffer which was previously purged is not reused later, as we should be discarding said buffers.
6376aca2f6858261ca913fa0f613cbdb9be2b4bf: Bug 1400072: Specify card size in onBind instead of onCreate. r=liuche draft
Michael Comella <michael.l.comella@gmail.com> - Fri, 15 Sep 2017 14:05:21 -0700 - rev 665726
Push 80150 by michael.l.comella@gmail.com at Fri, 15 Sep 2017 21:05:44 +0000
Bug 1400072: Specify card size in onBind instead of onCreate. r=liuche I believe this doesn't affect this bug because I think the ViewHolders are recreated on rotation but for any other type of change, only bind will be called so for correctness, we should update the size in bind. MozReview-Commit-ID: 3ojO4TF89i4
134037803d696b36a81fa9dcb962248a1e79b063: Bug 1400072: Rm unused variable tilesMargin. r=liuche draft
Michael Comella <michael.l.comella@gmail.com> - Fri, 15 Sep 2017 10:51:50 -0700 - rev 665725
Push 80150 by michael.l.comella@gmail.com at Fri, 15 Sep 2017 21:05:44 +0000
Bug 1400072: Rm unused variable tilesMargin. r=liuche MozReview-Commit-ID: G6Z3dUnKWLl
4e0f35f391d8174f02930a0a39a8981bc048c8ee: Bug 1400072: Cache tilesSize in swapCursor. r=liuche draft
Michael Comella <michael.l.comella@gmail.com> - Fri, 15 Sep 2017 10:48:28 -0700 - rev 665724
Push 80150 by michael.l.comella@gmail.com at Fri, 15 Sep 2017 21:05:44 +0000
Bug 1400072: Cache tilesSize in swapCursor. r=liuche In this sense, it acts as a refresh function, binding all of our UI state at the same time, helping to prevent bugs where the UI gets out of sync. For example, this fixes this bug because now the tileSize gets updated when we swap the cursor, not just when we the page is initially constructed. MozReview-Commit-ID: 7V2gFyiOJ1R
f6c0e40c150ec1419b5fecb5ef6b8e5f8b534373: Bug 1400072: Pass in tilesSize when needed, rather than caching. r=liuche draft
Michael Comella <michael.l.comella@gmail.com> - Fri, 15 Sep 2017 10:39:36 -0700 - rev 665723
Push 80150 by michael.l.comella@gmail.com at Fri, 15 Sep 2017 21:05:44 +0000
Bug 1400072: Pass in tilesSize when needed, rather than caching. r=liuche This will help prevent the cache from going out of date. MozReview-Commit-ID: GdUXF0oOSiK
7ea79634c5e03fdc17a9df977f231f48244c3ca3: Bug 1400072: Make num tiles a constant. r=liuche draft
Michael Comella <michael.l.comella@gmail.com> - Fri, 15 Sep 2017 10:30:08 -0700 - rev 665722
Push 80150 by michael.l.comella@gmail.com at Fri, 15 Sep 2017 21:05:44 +0000
Bug 1400072: Make num tiles a constant. r=liuche Since it's a constant, there's no reason to keep passing it around everywhere. Also, the code that relied on it being a dynamic value is probably broken so there's no reason to continue passing it around. That being said, there is bug 1397854, which would have TopSites be 4 rows with no pages, but this code is quite messy so I think it'd be worth trying to refactor this code further before trying to implement that. MozReview-Commit-ID: IoMNHVt67c4
4a58a064889664fb4d220f53c1af90ad02e85d5c: Bug 1400072: Move TOP_SITE_COLUMNS/ROWS -> TopSitesPage. r=liuche draft
Michael Comella <michael.l.comella@gmail.com> - Fri, 15 Sep 2017 10:26:19 -0700 - rev 665721
Push 80150 by michael.l.comella@gmail.com at Fri, 15 Sep 2017 21:05:44 +0000
Bug 1400072: Move TOP_SITE_COLUMNS/ROWS -> TopSitesPage. r=liuche The TopSitesPage should really own details about the appearance of top sites. MozReview-Commit-ID: LPfHGcUTv00
eb4a9b4c68aa9b5eb70c1ce59d7da8f1dfa07af7: Bug 1399546: Implement the tables inherit from body quirk in a more straight-forward way. r=heycam draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Sep 2017 22:54:59 +0200 - rev 665720
Push 80149 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 21:03:46 +0000
Bug 1399546: Implement the tables inherit from body quirk in a more straight-forward way. r=heycam MozReview-Commit-ID: 8mtd4CsoSlU
746607682b9271172199d8a77e45b5be6d7fd12e: Bug 1399546: Implement the tables inherit from body quirk in a more straight-forward way. r=heycam draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Sep 2017 22:54:59 +0200 - rev 665719
Push 80148 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 20:59:22 +0000
Bug 1399546: Implement the tables inherit from body quirk in a more straight-forward way. r=heycam MozReview-Commit-ID: 8mtd4CsoSlU
15cadfb0d81411ec285e2d5232fb4dd90399682e: Bug 1399546: Remove broken code for handling the body text color. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Sep 2017 22:52:26 +0200 - rev 665718
Push 80148 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 20:59:22 +0000
Bug 1399546: Remove broken code for handling the body text color. MozReview-Commit-ID: AfAT9DgzvI7
d6a3a83d9ce3c16773a5c818b5f754ff7728f665: Backed out changeset 67769dac78c4 for busting builds CLOSED TREE
Wes Kocher <wkocher@mozilla.com> - Fri, 15 Sep 2017 13:38:03 -0700 - rev 665717
Push 80148 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 20:59:22 +0000
Backed out changeset 67769dac78c4 for busting builds CLOSED TREE MozReview-Commit-ID: 82QTBjYc0jC
a6d9e37a9122e0848b67c072b7a101fe4b058716: Bug 1400378 - Add layers logging support for Point3D. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 15 Sep 2017 16:08:12 -0400 - rev 665716
Push 80148 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 20:59:22 +0000
Bug 1400378 - Add layers logging support for Point3D. r=mattwoodrow MozReview-Commit-ID: 9W3gDi7wyQF
9cc10d12de94bda1dee61a03e0681f5e73df5ee6: Bug 1392874 - Force gSync initialization in browser_sync.js test. r=markh
Edouard Oger <eoger@fastmail.com> - Fri, 15 Sep 2017 11:28:19 -0700 - rev 665715
Push 80148 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 20:59:22 +0000
Bug 1392874 - Force gSync initialization in browser_sync.js test. r=markh MozReview-Commit-ID: 9ZEK4dc6QEe
f083cad6e8e6e96157ea3648062d62869caf04ef: servo: Merge #18031 - Fix Android build errors on macOS (from jhlin:android-build-on-macos); r=mbrubeck
John Lin <jolin@mozilla.com> - Fri, 15 Sep 2017 14:05:00 -0500 - rev 665714
Push 80148 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 20:59:22 +0000
servo: Merge #18031 - Fix Android build errors on macOS (from jhlin:android-build-on-macos); r=mbrubeck - Add sysroot path to environment variable 'CPPFLAGS': When checking C preprocessor, the 'configure' script of libbacktrace uses 'CPPFLAGS' rather than 'CFLAGS' and doesn't get the correct search path. (#15758) This check passes on Linux because the '/lib/cpp' fallback is available there. - Introduce CMake toolchain file for Android cross compiling: CMake needs several variables [1] to cross compile for Android. It works (accidentally) on Linux because cmake-rs sets compilers correctly and binutils for Linux & Android are pretty much the same. [1] https://cmake.org/cmake/help/v3.7/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15758 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it's a fix to build errors. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: a3b85cbd6cd74090b6e9f09e3d0980045e8f6a1b
6159e19a7c0fffd202134027abff82b6e0bd22e6: Bug 1397971 - Share strings in URLDataValue with Rust. r=heycam
Josh Matthews <josh@joshmatthews.net> - Fri, 15 Sep 2017 13:11:37 -0700 - rev 665713
Push 80148 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 20:59:22 +0000
Bug 1397971 - Share strings in URLDataValue with Rust. r=heycam
aa02aa853d370a776efc59c699895a34a8671777: No bug - Revendor rust dependencies
Servo VCS Sync <servo-vcs-sync@mozilla.com> - Fri, 15 Sep 2017 19:46:43 +0000 - rev 665712
Push 80148 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 20:59:22 +0000
No bug - Revendor rust dependencies
d0e83cfaff2ffa3512c4fb066ad4fbb3acb17eb7: servo: Merge #18527 - Revert "Measure ImageValue objects." (from mbrubeck:revert); r=mbrubeck
Matt Brubeck <mbrubeck@limpet.net> - Fri, 15 Sep 2017 12:44:23 -0700 - rev 665711
Push 80148 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 20:59:22 +0000
servo: Merge #18527 - Revert "Measure ImageValue objects." (from mbrubeck:revert); r=mbrubeck This reverts commit a185393ceea46f1e61dfd7134b589b150d6e27c3 (#18515). Source-Repo: https://github.com/servo/servo Source-Revision: fb00fc222a1fd4c3c664f3d5dfbe5cacecb0c681
867559d318f3d860fcb1c29608b58e1a1273be16: servo: Merge #18521 - Fix running `cargo test -p stylo_test` from repo root (from servo:cargotest); r=nox
Simon Sapin <simon.sapin@exyr.org> - Fri, 15 Sep 2017 12:44:12 -0700 - rev 665710
Push 80148 by bmo:emilio@crisal.io at Fri, 15 Sep 2017 20:59:22 +0000
servo: Merge #18521 - Fix running `cargo test -p stylo_test` from repo root (from servo:cargotest); r=nox … in order to add it to Rust CI though https://github.com/rust-lang/rust/blob/master/src/tools/cargotest/main.rs Source-Repo: https://github.com/servo/servo Source-Revision: f1da967ef707bbc77f023daf28093201e96e19c5
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip