903992e46e072238158b289a6bf494280e478a13: Bug 1379565 - Overhaul ProfileBuffer::StreamSamplesToJSON. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 05 Jul 2017 21:29:29 +1000 - rev 606764
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1379565 - Overhaul ProfileBuffer::StreamSamplesToJSON. r=mstange. The profiler writes ProfileBuffer entries in a particular order, and then later has to parse them, mostly in StreamSamplesToJSON(). That function's parsing code is poorly structured and rather gross, at least partly because no explicit grammar is identified. This patch identifies the grammar in a comment, and in the same comment also includes some examples of the more complicated subsequences. Once written down, the grammar is obviously suboptimal -- the |Sample| entries serve no useful purpose, for example -- but I will leave grammar improvements as follow-ups. The patch also rewrites the parser in a more typical fashion that obviously matches the grammar. The new parser is slightly more verbose but far easier to understand.
824f3b09c46f3107e1f7f657ebee98461f33e4ff: Bug 1377687 - Clear cached resources in WebRenderBridgeParent::RecvClearCachedResources() r=nical
sotaro <sotaro.ikeda.g@gmail.com> - Tue, 11 Jul 2017 09:13:15 +0900 - rev 606763
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1377687 - Clear cached resources in WebRenderBridgeParent::RecvClearCachedResources() r=nical
63131a56d410f72a897a757ca449703d9d9989ca: Bug 1379721: Add separate AsyncShutdown blocker for embedded extension shutdown. r=rhelmer
Kris Maglione <maglione.k@gmail.com> - Mon, 10 Jul 2017 12:29:27 -0700 - rev 606762
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1379721: Add separate AsyncShutdown blocker for embedded extension shutdown. r=rhelmer MozReview-Commit-ID: CognGxT3BGp
12383fa36e6b42ed97a5a097f2b0b754bde54962: Bug 1367896: Include script filename in crash reason. r=shu data-r=bsmedberg
Kris Maglione <maglione.k@gmail.com> - Wed, 05 Jul 2017 18:02:20 -0700 - rev 606761
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1367896: Include script filename in crash reason. r=shu data-r=bsmedberg If the scope that we're trying to clone is actually a function script, this should give us the script URL. If it's not (presumably due to some sort of data corruption), it should give us a different crash, which should hopefully give us more information. MozReview-Commit-ID: Fppi0qt4GJP
5e2692f8a367cdd899d4a4653a5372d7123a1ec6: Backed out changeset 7b267e692c04 (bug 1379864) for assertion failure in stylo tests
Carsten "Tomcat" Book <cbook@mozilla.com> - Tue, 11 Jul 2017 09:07:53 +0200 - rev 606760
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Backed out changeset 7b267e692c04 (bug 1379864) for assertion failure in stylo tests
0067e00809a3b588d3a724b36dad506eaea54e3f: Backed out changeset 57800baf24a3 (bug 1379864)
Carsten "Tomcat" Book <cbook@mozilla.com> - Tue, 11 Jul 2017 09:06:27 +0200 - rev 606759
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Backed out changeset 57800baf24a3 (bug 1379864)
d65149585e2dd688fbe95c713f2128dd37e36353: Bug 1379890 - Remove unused mozjemalloc stats. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 11 Jul 2017 14:42:57 +0900 - rev 606758
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1379890 - Remove unused mozjemalloc stats. r=njn Since bug 1378258 remove malloc_print_stats, there are a bunch of allocator stats that are now unused, reducing the memory footprint of allocator metadata.
d816a7f555299b4f66b9690dbdd59c2a7afa9440: Bug 1379878 - Use C++ templates to make _malloc_message calls cleaner. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 11 Jul 2017 14:15:04 +0900 - rev 606757
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1379878 - Use C++ templates to make _malloc_message calls cleaner. r=njn
0b90c93540de031ee412f75b3ad1ff9d5f00e2a2: Bug 1379878 - Remove umax2s, its last use was removed in bug 1378258. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 11 Jul 2017 14:09:09 +0900 - rev 606756
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1379878 - Remove umax2s, its last use was removed in bug 1378258. r=njn
094ae2ae92c5fcebc8a41f4349ba82a4d95a98aa: Bug 1360772 - Allow to initialize non-zeroed arena chunks. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Jul 2017 17:05:23 +0900 - rev 606755
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1360772 - Allow to initialize non-zeroed arena chunks. r=njn When initializing a new chunk for use as an arena, we started by zeroing out the chunk (if that wasn't the case) and then initializing a new arena chunk in there. It turns out this can have a noticeable overhead, especially when e.g. the new arena chunk is used for a large allocation filled out by something that is realloc()ated. OTOH, the chunk recycle code only ever keeps zeroed or arena chunks around (there is a "recycled" type too, but in practice, at the moment, this means they were arena chunks before). Arena chunks that were recycled were totally emptied, so all the runs they may contain will contain zeroed-out or poisoned data. They also contain a header, that is overwritten by the new arena chunk initialization. This means we can get away with reusing non-zeroed recycled chunks without zeroing them, as long as the arena chunk header marks the runs as madvised instead of zeroed. Code-wise, this would benefit from getting a ChunkType out of chunk_alloc, but this would require more refactoring than I'm willing to do at the moment.
9f73e5f2dc3cd7544a9c95ad65841025815242f4: Bug 1360772 - Indicate to chunk_recycle callers that pages_commit has zeroed the chunk. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Jul 2017 16:58:18 +0900 - rev 606754
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1360772 - Indicate to chunk_recycle callers that pages_commit has zeroed the chunk. r=njn Before returning a chunk, chunk_recycle calls pages_commit (when MALLOC_DECOMMIT is enabled), which is guaranteed to zero the chunk. The code further zeroing the chunk afterwards, which is now moved out to chunk_alloc callers, never took advantage of that fact, duplicating the effort of zeroing the chunk on Windows. By indicating to the callers that the chunk has already been zeroed, we allow callers to skip zeroing on their own.
9c930946021994fcac8affd794d18c1dcf728bd1: Bug 1360772 - Make chunk_alloc callers handle zeroing when they need it. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Jul 2017 15:51:25 +0900 - rev 606753
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1360772 - Make chunk_alloc callers handle zeroing when they need it. r=njn The current code only allows chunk_calloc() callers to tell whether they want zeroed memory or not, but some might be okay either way, assuming they act accordingly afterwards. So move the zeroing out of chunk_alloc.
bd8104b689560ca5045dd9adc7bb966d216c078b: Bug 1360772 - Store the chunk type in chunk recycling queue. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Fri, 07 Jul 2017 10:16:31 +0900 - rev 606752
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1360772 - Store the chunk type in chunk recycling queue. r=njn
3edd431c888d13a661c5d459b523bda930926a72: Bug 1360772 - Make pages_purge return whether the pages were purged. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Fri, 07 Jul 2017 09:46:04 +0900 - rev 606751
Push 67803 by bmo:ato@sny.no at Tue, 11 Jul 2017 12:43:48 +0000
Bug 1360772 - Make pages_purge return whether the pages were purged. r=njn Many functions in the mozjemalloc codebase like to return the opposite boolean one would tend to expect. Pages_purge is one of them, and this reverses the logic to match expectations. Also make it static.
dff3cd0956712d26fa6e12106cb7b726db03ef0c: Bug 1376925 - In the bookmarks folder tree of the edit dialog, don't invalidate elements whilst we are editing. Also improve the stability of browser_bookmarksProperties.js. r?mak draft
Mark Banner <standard8@mozilla.com> - Tue, 04 Jul 2017 14:27:44 +0100 - rev 606750
Push 67802 by bmo:standard8@mozilla.com at Tue, 11 Jul 2017 12:20:46 +0000
Bug 1376925 - In the bookmarks folder tree of the edit dialog, don't invalidate elements whilst we are editing. Also improve the stability of browser_bookmarksProperties.js. r?mak MozReview-Commit-ID: IRDgLVACMxG
e964c16ff493ad74d2237676ba99b9a6fdfdec40: Bug 1376925 - Avoid some warnings about this._paneInfo being undefined in editBookmarkOverlay.js when an event happens during closing the dialog. r?mak draft
Mark Banner <standard8@mozilla.com> - Tue, 04 Jul 2017 14:18:11 +0100 - rev 606749
Push 67802 by bmo:standard8@mozilla.com at Tue, 11 Jul 2017 12:20:46 +0000
Bug 1376925 - Avoid some warnings about this._paneInfo being undefined in editBookmarkOverlay.js when an event happens during closing the dialog. r?mak MozReview-Commit-ID: GZKe4z6kpGP
a48a904947271c0ccafb83c6eb089ec79f8c7b2b: Bug 1376925 - Modernise browser_bookmarksProperties.js to use async functions and assert. r?mak draft
Mark Banner <standard8@mozilla.com> - Tue, 04 Jul 2017 13:20:53 +0100 - rev 606748
Push 67802 by bmo:standard8@mozilla.com at Tue, 11 Jul 2017 12:20:46 +0000
Bug 1376925 - Modernise browser_bookmarksProperties.js to use async functions and assert. r?mak MozReview-Commit-ID: 26PBBgP9tSf
961f6a7a8adc5f911a9cd40de6231732a5a15f11: Bug 1308566 - Add a mochitest for the ObjectInspector in the console. r=bgrins draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 11 Jul 2017 09:55:40 +0200 - rev 606747
Push 67801 by bmo:nchevobbe@mozilla.com at Tue, 11 Jul 2017 12:08:43 +0000
Bug 1308566 - Add a mochitest for the ObjectInspector in the console. r=bgrins MozReview-Commit-ID: GDiZEo7xfPJ
771b74b6816f2b9181520769ebd9ba12cf980637: Bug 1308566 - Fixes broken tests due to the ObjectInspector switch. r=bgrins draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 29 Jun 2017 09:15:16 -0700 - rev 606746
Push 67801 by bmo:nchevobbe@mozilla.com at Tue, 11 Jul 2017 12:08:43 +0000
Bug 1308566 - Fixes broken tests due to the ObjectInspector switch. r=bgrins Some tests were failing after switching to ObjectInspector. Here we remove the ones that are specific to the VariableView, and fix the "store as global" one. MozReview-Commit-ID: 4IhNp4MTC2k
f761e2d3e28a57e4fee3e4f93091e7aeec5bffb9: Bug 1308566 - Release actors from loaded properties. r=bgrins, Honza draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 28 Jun 2017 16:51:46 -0700 - rev 606745
Push 67801 by bmo:nchevobbe@mozilla.com at Tue, 11 Jul 2017 12:08:43 +0000
Bug 1308566 - Release actors from loaded properties. r=bgrins, Honza Because we need to check in an another property from the store for actors to release, a little refactor of how we deal with actors to be released was needed. So instead of tracking removed messages from the store, we directly track removed actors. We can compute this list directly in the reducer, and it even allow us to simplify the enhancer a bit. Some tests where added to make sure we do handle loaded properties in the store. MozReview-Commit-ID: 72F2wl3UaLA
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip