8fc2c103027ba37bd50dec5e2fe8b79d3d68c28c: Bug 1442313 part 1. Make xpc::IsInAutomation a bit faster. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 01 Mar 2018 14:24:17 -0500 - rev 762208
Push 101102 by bmo:jkt@mozilla.com at Thu, 01 Mar 2018 22:11:20 +0000
Bug 1442313 part 1. Make xpc::IsInAutomation a bit faster. r=bholley MozReview-Commit-ID: HTs3RwEOmZ4
cf67ac6f58d0fc08af06d9bd6f0247e9288e0568: Bug 1438994 - Make all fields final in AuthenticationOptions, MediaSource, and Choice classes. r=snorp,jchen
Dylan Roeh <droeh@mozilla.com> - Thu, 01 Mar 2018 14:20:25 -0500 - rev 762207
Push 101102 by bmo:jkt@mozilla.com at Thu, 01 Mar 2018 22:11:20 +0000
Bug 1438994 - Make all fields final in AuthenticationOptions, MediaSource, and Choice classes. r=snorp,jchen Make all fields final in AuthenticationOptions, MediaSource, and Choice classes in GeckoSession. Also updates BasicGeckoViewPrompt and GeckoViewActivity to work around these restrictions.
2e915e01f05d02c2e39161733615af6f16982f29: Bug 1441622 - Expose the OpenType Font Variations data to the fonts redux store. r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 01 Mar 2018 15:25:10 -0500 - rev 762206
Push 101102 by bmo:jkt@mozilla.com at Thu, 01 Mar 2018 22:11:20 +0000
Bug 1441622 - Expose the OpenType Font Variations data to the fonts redux store. r=pbro
01d017ee38c0491e353ead6d274e16d658a719f4: Bug 1441523 - Remove the first declaration of "start" and set it in each condition r=erahm
Victor <miraty@lilo.org> - Tue, 27 Feb 2018 14:37:19 +0100 - rev 762205
Push 101102 by bmo:jkt@mozilla.com at Thu, 01 Mar 2018 22:11:20 +0000
Bug 1441523 - Remove the first declaration of "start" and set it in each condition r=erahm
3ce55799da20fcf99ceb7a209db65b2830f38630: Bug 1404297 - Change the way we iterate over our links to update. r=smaug
Blake Kaplan <mrbkap@gmail.com> - Thu, 01 Mar 2018 11:26:54 -0800 - rev 762204
Push 101102 by bmo:jkt@mozilla.com at Thu, 01 Mar 2018 22:11:20 +0000
Bug 1404297 - Change the way we iterate over our links to update. r=smaug MozReview-Commit-ID: BTADrB9itjh
1d53ede1a1d3c1afd847fb50f31aa9ab3e48cc21: Bug 1404297 - Add a move constructor to SegmentedVector. r=smaug
Blake Kaplan <mrbkap@gmail.com> - Thu, 01 Mar 2018 11:26:54 -0800 - rev 762203
Push 101102 by bmo:jkt@mozilla.com at Thu, 01 Mar 2018 22:11:20 +0000
Bug 1404297 - Add a move constructor to SegmentedVector. r=smaug Given that we have a SegmentedVector of nsCOMPtrs, it's probably worth avoiding copying it. MozReview-Commit-ID: GHyfVLrdnlQ
ed0c321f39cc093bcf7466b6c8fadfbbfa698d42: Bug 1440938 - Fall back to cairo's glyph metrics API if FreeType fails in some way, or if we're not using a variation font: Add back annotations for failing Android reftests. r=test-fix CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 01 Mar 2018 21:41:25 +0200 - rev 762202
Push 101102 by bmo:jkt@mozilla.com at Thu, 01 Mar 2018 22:11:20 +0000
Bug 1440938 - Fall back to cairo's glyph metrics API if FreeType fails in some way, or if we're not using a variation font: Add back annotations for failing Android reftests. r=test-fix CLOSED TREE
8474740da082541ef65f90d0f54091ca15fd2e2c: Backed out 3 changesets (bug 1432846) for build bustage on Windows at dom/serviceworkers/ServiceWorkerRegistrationImpl.cpp:301. CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 01 Mar 2018 21:34:05 +0200 - rev 762201
Push 101102 by bmo:jkt@mozilla.com at Thu, 01 Mar 2018 22:11:20 +0000
Backed out 3 changesets (bug 1432846) for build bustage on Windows at dom/serviceworkers/ServiceWorkerRegistrationImpl.cpp:301. CLOSED TREE Backed out changeset 5e3b28d03b34 (bug 1432846) Backed out changeset a2ae02b5fe72 (bug 1432846) Backed out changeset a92cc56bbaa4 (bug 1432846)
e948bafc583f91177530ce00ec26c69619a7f8f9: Bug 1442419 - Fix failure to open files after downloading with snap r=jlorenzo draft
Ken VanDine <ken.vandine@canonical.com> - Thu, 01 Mar 2018 22:02:21 +0000 - rev 762200
Push 101101 by bmo:ken.vandine@canonical.com at Thu, 01 Mar 2018 22:02:59 +0000
Bug 1442419 - Fix failure to open files after downloading with snap r=jlorenzo This fix does several things: * Removes the mime cache generated by the desktop-gtk3 remote part * Installs a stub shared-mime-info database * Set default association for all types to use xdg-open Note: There is still work[1] to be completed in snapd, adding OpenFile support to xdg-open. Landing this is harmless though, it will fail silently just as it does today but will start working when the snapd feature lands. 1. https://github.com/snapcore/snapd/pull/4766 opening requested files, MozReview-Commit-ID: 1eeOLeVN8xQ
be20f5c799041ec6fabebdadd34fbc108d3f09cf: Bug 1441333: Part 6 - Use proper async caller location in normalizeError. r?zombie draft
Kris Maglione <maglione.k@gmail.com> - Mon, 26 Feb 2018 16:08:35 -0800 - rev 762199
Push 101100 by maglione.k@gmail.com at Thu, 01 Mar 2018 22:02:12 +0000
Bug 1441333: Part 6 - Use proper async caller location in normalizeError. r?zombie Currently, when we create an error object at the end of an aysnc operation, we only get a useful caller location if async stacks are enabled. This patch changes our behavior to use the saved caller location we've already stored when creating an Error object based on a plain string message. MozReview-Commit-ID: DDO0lAUHYRO
ebabe3777d82db47d2b451e1a67131f1b20226aa: Bug 1441333: Part 5 - Use caller location in error reports for StrongPromise errors. r?zombie draft
Kris Maglione <maglione.k@gmail.com> - Mon, 26 Feb 2018 15:25:23 -0800 - rev 762198
Push 101100 by maglione.k@gmail.com at Thu, 01 Mar 2018 22:02:12 +0000
Bug 1441333: Part 5 - Use caller location in error reports for StrongPromise errors. r?zombie We currently report a useful location in error reports when extensions fail to resolve a promise or call a response callback, but in some slightly less-than-ideal ways. We currently generate a complete stack and parse its string value (which is expensive), and then report the caller location as part of the message, rather than as the error's location and stack. This patch changes that behavior to store a single SavedStack frame, and to properly report that as the location of the error. MozReview-Commit-ID: Jmtf4C1O6pW
c4d6ab6da491632205b78674c0edefb37f64ea0b: Bug 1441333: Part 4 - Add caller location to async API errors. r?zombie draft
Kris Maglione <maglione.k@gmail.com> - Mon, 26 Feb 2018 15:25:03 -0800 - rev 762197
Push 101100 by maglione.k@gmail.com at Thu, 01 Mar 2018 22:02:12 +0000
Bug 1441333: Part 4 - Add caller location to async API errors. r?zombie When we report errors generated by async API operations, they are currently not tied to any relevant extension source location. Instead, the locations in the error reports point to the location in the framework code which reported the error, which makes things extremely difficult to diagnose. This change saves the extension caller location at the beginning of async API operations, and adds it to the error reports genearted by that operation. This should give extension developers a useful starting point for debugging them. MozReview-Commit-ID: AkknkKEosFt
8159dbd0b8efce6e0b60414609ab54c4871cb07e: Bug 1441333: Part 3 - Add helper to create a JS error with a saved stack. draft
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Mar 2018 14:00:00 -0800 - rev 762196
Push 101100 by maglione.k@gmail.com at Thu, 01 Mar 2018 22:02:12 +0000
Bug 1441333: Part 3 - Add helper to create a JS error with a saved stack. There's no standard way to create a JS error with full stack and location information from a saved stack. Since we need this functionality in order to reject promises with useful Error objects, this patch adds a simple helper to make that possible. MozReview-Commit-ID: FyGuo4UjfsQ
f7094de974be4ac92fccfdc2aff000df6fe5a30d: Bug 1441333: Part 2 - Allow passing an error stack to reportError. draft
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Mar 2018 13:57:27 -0800 - rev 762195
Push 101100 by maglione.k@gmail.com at Thu, 01 Mar 2018 22:02:12 +0000
Bug 1441333: Part 2 - Allow passing an error stack to reportError. Building on top of part 1, we need a way to link a saved caller location to a reported error message. This change allows us to pass a stack to `reportError` when called with a string. This part was written before part 3, and could probably be removed in favor of using createError in every call. But this method also has the advantage of being more consise and somewhate more efficient. MozReview-Commit-ID: 39jfCg9AerY
504a29a6b3349502e7cee39df382cbe9b2556d9d: Bug 1441333: Part 1 - Add helper to retrieve closest stack frame with a given principal. draft
Kris Maglione <maglione.k@gmail.com> - Sat, 11 Nov 2017 17:39:16 -0800 - rev 762194
Push 101100 by maglione.k@gmail.com at Thu, 01 Mar 2018 22:02:12 +0000
Bug 1441333: Part 1 - Add helper to retrieve closest stack frame with a given principal. Most WebExtension APIs are async, and have fairly complicated error reporting semantics. As a result, when we report an error, the current JS stack has very little to do with the JS caller that triggered the error, which makes it difficult to diagnose. In order to improve the situation, we need to store the location of the caller at the start of an async operation, so we can tie the error to some marginally useful location. We don't have a reasonable way to do that now other than proactively creating an error object when the API is called, or creating a promise with a full async stack, both of which are too expensive. This helper instead returns a single SavedStack frame with a given principal, which should be considerably cheaper, and likely good enough to give a starting point for debugging cryptic errors. MozReview-Commit-ID: BTxhpZK9Fdz
879f24d8b894eaeeae1cbb6db964485d05e4f1e2: Bug 1442370 - Change SQLITE_TEMP_FILE_PREFIX to a Mozilla unique value. r=asuth draft
Marco Bonardo <mbonardo@mozilla.com> - Thu, 01 Mar 2018 20:55:18 +0100 - rev 762193
Push 101099 by mak77@bonardo.net at Thu, 01 Mar 2018 22:01:48 +0000
Bug 1442370 - Change SQLITE_TEMP_FILE_PREFIX to a Mozilla unique value. r=asuth MozReview-Commit-ID: 3VRCec9QI1F
9beb7e2ba06c6e49dccbd41f7bd64be030d37f56: Bug 1440664 - Update reftest annotation for changes in WR PR 2471. r?jrmuizel draft
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 01 Mar 2018 16:53:00 -0500 - rev 762192
Push 101098 by kgupta@mozilla.com at Thu, 01 Mar 2018 21:59:32 +0000
Bug 1440664 - Update reftest annotation for changes in WR PR 2471. r?jrmuizel MozReview-Commit-ID: A75y6OtL4AR
629f5384e82626393f7342458879eaf6ff912899: Bug 1440664 - Update reftest annotation for WR PR 2443. r?jrmuizel draft
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 01 Mar 2018 16:52:51 -0500 - rev 762191
Push 101098 by kgupta@mozilla.com at Thu, 01 Mar 2018 21:59:32 +0000
Bug 1440664 - Update reftest annotation for WR PR 2443. r?jrmuizel MozReview-Commit-ID: L941zlptWWM
95acde5bf6e03d249bb6737f10ee67f0cb0e473e: Bug 1440664 - Re-generate FFI header. r?jrmuizel draft
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 01 Mar 2018 16:52:36 -0500 - rev 762190
Push 101098 by kgupta@mozilla.com at Thu, 01 Mar 2018 21:59:32 +0000
Bug 1440664 - Re-generate FFI header. r?jrmuizel MozReview-Commit-ID: 8oJcG2CPR2U
63bc628cf9c891c7b18bee794f8a2bf8f17308c6: Bug 1440664 - Update Cargo lockfiles and re-vendor rust dependencies. r?jrmuizel draft
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 01 Mar 2018 16:51:58 -0500 - rev 762189
Push 101098 by kgupta@mozilla.com at Thu, 01 Mar 2018 21:59:32 +0000
Bug 1440664 - Update Cargo lockfiles and re-vendor rust dependencies. r?jrmuizel MozReview-Commit-ID: IZncD4fgDk7
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip