8ea15f064e6ab0f943be5060cb01167da451b716: mozreview: use standard is_pushed function in isPush template filter (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 20:45:58 -0500 - rev 362214
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: use standard is_pushed function in isPush template filter (Bug 1244448). r=gps
5b146b119ee0bc1cd47b7360a59d5f98b6308da4: mozreview: move DISCARD_ON_PUBLISH_KEY and UNPUBLISHED_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 20:15:55 -0500 - rev 362213
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move DISCARD_ON_PUBLISH_KEY and UNPUBLISHED_KEY to CommitData from extra_data (Bug 1244448). r=gps
98501d7f4a175b73538caa6f91e148cb80679237: mozreview: move COMMITS_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 19:06:15 -0500 - rev 362212
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move COMMITS_KEY to CommitData from extra_data (Bug 1244448). r=gps
014c467c87200b03fac84706182e234be31e93ae: mozreview: move SQUASHED_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 18:03:58 -0500 - rev 362211
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move SQUASHED_KEY to CommitData from extra_data (Bug 1244448). r=gps
ba65b6e0f2b58bf6bbb55e684046b9473277fd23: mozreview: move BASE_COMMIT_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 16:36:02 -0500 - rev 362210
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move BASE_COMMIT_KEY to CommitData from extra_data (Bug 1244448). r=gps
cef3a7274b5df0ba9605943207892eb24940b50e: mozreview: move COMMIT_ID_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 15:40:35 -0500 - rev 362209
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move COMMIT_ID_KEY to CommitData from extra_data (Bug 1244448). r=gps Since COMMIT_ID_KEY was the last DRAFTED_EXTRA_DATA_KEY, remove the code for copying the drafted keys for the built-in extra data. Additionally, update some of the extra_data.py helper methods to take in a commit_data object for reuse.
601c5edf9f98b51579cb238c89a77e29a42c23d6: mozreview: move FIRST_PUBLIC_ANCESTOR_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 13:42:10 -0500 - rev 362208
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move FIRST_PUBLIC_ANCESTOR_KEY to CommitData from extra_data (Bug 1244448). r=gps
2fbcf9bf2a99435df0644385d334186050dc9c20: mozreview: move IDENTIFIER_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 11:59:30 -0500 - rev 362207
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move IDENTIFIER_KEY to CommitData from extra_data (Bug 1244448). r=gps
bc172352ab426c0579f139e99cdb5a7f5ac58478: mozreview: remove direct extra_data key usage from rbbz (Bug 1244448). r=mcote
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 11:28:00 -0500 - rev 362206
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: remove direct extra_data key usage from rbbz (Bug 1244448). r=mcote To make moving the extra_data storage location easier we remove the final direct usage of extra_data KEY constants from rbbz. We should now be able to completely switch the storage location of the extra data without touching rbbz.
bb937917ebd0daa9b98078f62ce3b57a110d7036: mozreview: move review_request_closed signal handlers into MozReview from rbbz (Bug 1244448). r=mcote
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 11:19:06 -0500 - rev 362205
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move review_request_closed signal handlers into MozReview from rbbz (Bug 1244448). r=mcote
7ed0a2d2486ae7893c6e8ae3036a4e48f6db03e5: mozreview: move on_review_request_reopened into MozReview from rbbz (Bug 1244448). r=mcote
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 10:51:01 -0500 - rev 362204
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move on_review_request_reopened into MozReview from rbbz (Bug 1244448). r=mcote This commit mostly just moves code from rbbz into MozReview, centered around what was needed to move on_review_request_reopened(). A few of the functions relating to extra data, and accessing it, were changed from the implementations present in rbbz to those in mozreview.extra_data, but functionality should remain the same.
57ec870d176e8175156172a3b425a8accd9942a0: mozreview: copy draft_extra_data to extra_data for drafted CommitData (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 10:09:46 -0500 - rev 362203
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: copy draft_extra_data to extra_data for drafted CommitData (Bug 1244448). r=gps We'll need a similar mechanism for having certain extra_data keys be moved from draft_extra_data to extra_data as we used for the built-in extra_data. This is particularly important because using a ReviewRequestField backed by our CommitData won't take care of this for us - we'll need to do this for any key which supports a draft value as well as the published value.
eda2c378c2dd1a8def8a95f138b692700a0f9a0f: mozreview: copy commit extra_data to draft_extra_data on draft creation (Bug 1244448). r=mdoglio r=mcote r=gps
Steven MacLeod <smacleod@mozilla.com> - Tue, 02 Feb 2016 18:51:42 -0500 - rev 362202
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: copy commit extra_data to draft_extra_data on draft creation (Bug 1244448). r=mdoglio r=mcote r=gps In order to mimic the semantics of the built-in extra data for ReviewRequest and ReviewRequestDraft we need to copy CommitData.extra_data to CommitData.draft_extra_data when a draft is created. Handling clearing the data isn't necessary as we will always gate access to draft_extra_data by checking if the draft exists first. Any stale data will be overwritten when a draft is next created for the ReviewRequest.
09910a4073a75db18ace5932b79d1863121ee0ed: mozreview: move on_draft_pre_delete into MozReview from rbbz (Bug 1244448). r=mdoglio r=gps
Steven MacLeod <smacleod@mozilla.com> - Tue, 02 Feb 2016 17:54:18 -0500 - rev 362201
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move on_draft_pre_delete into MozReview from rbbz (Bug 1244448). r=mdoglio r=gps This commit mostly just moves code from rbbz into MozReview, centered around what was needed to move on_draft_pre_delete(). A few of the functions relating to extra data, and accessing it, were changed from the implementations present in rbbz to those in mozreview.extra_data, but functionality should remain the same.
c69c4c9453d1b2618c22e3d2d48dc228062294e8: mozreview: print CommitData during tests (Bug 1244448). r=gps r=mdoglio
Steven MacLeod <smacleod@mozilla.com> - Tue, 02 Feb 2016 16:06:27 -0500 - rev 362200
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: print CommitData during tests (Bug 1244448). r=gps r=mdoglio We will need to print the data from our CommitData model for review requests in order to test any use of it. We now print this data when dumping a review request.
bd5cadc40e39b0b286a046f70be9b3a23ee0c97d: mozreview: cleanup extra_data key use (Bug 1244448). r=mcote r=mdoglio r=gps
Steven MacLeod <smacleod@mozilla.com> - Tue, 02 Feb 2016 13:04:54 -0500 - rev 362199
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: cleanup extra_data key use (Bug 1244448). r=mcote r=mdoglio r=gps We were using string literals all over mozreview to reference extra_data keys, making it harder to be confident about where a particular key was in use. All of the important extra_data key usage has been updated to use constants defined in extra_data.py
dca33aff6e84f21d3110d567b4b8e1640af8dbb5: mozreview: Add model to replace extra_data use (Bug 1244448). r=mdoglio
Steven MacLeod <smacleod@mozilla.com> - Mon, 01 Feb 2016 11:14:38 -0500 - rev 362198
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: Add model to replace extra_data use (Bug 1244448). r=mdoglio We need a quick and dirty solution for storing our extra_data which the review request author can't modify. CommitData acts as a simple JSON store tied to the review request where we can transition our data. This should make migration very simple as we can directly copy the JSON to our new table.
cb10b621c65981d5ffa05b8d1f71035df9d8ee72: mozreview: prevent publishing of unverified DiffSets (Bug 1244448). r=mdoglio r=gps
Steven MacLeod <smacleod@mozilla.com> - Sun, 31 Jan 2016 15:33:32 -0500 - rev 362197
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: prevent publishing of unverified DiffSets (Bug 1244448). r=mdoglio r=gps We now prevent any publish operation on a review request if it contains a DiffSet without a corresponding DiffSetVerification. This prevents any DiffSet which didn't come from the review server from being published. This should fix the most obvious security issue of a fake DiffSet being uploaded to represent the underlying commit. We still need to move away from extra_data completely in order to prevent other issues.
8af4660232ca9033a741a559c3b0c006500ca137: mozreview: move on_review_request_publishing into MozReview from rbbz (Bug 1244448). r=mdoglio r=mcote
Steven MacLeod <smacleod@mozilla.com> - Sat, 30 Jan 2016 18:43:16 -0500 - rev 362196
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move on_review_request_publishing into MozReview from rbbz (Bug 1244448). r=mdoglio r=mcote This commit mostly just moves code from rbbz into MozReview, centered around what was needed to move on_review_request_publishing(). Several new files were created to hold various utility functions which were part of rbbz's extenion.py but the code should mostly just be a copy. A few of the functions relating to extra data, and accessing it, were changed from the implementations present in rbbz to those in mozreview.extra_data, but functionality should remain the same.
4f9ad400ee1112454038cc0d89b8005aa4511271: mozreview: create a signal_handlers.py (Bug 1244448). r=mdoglio r=gps
Steven MacLeod <smacleod@mozilla.com> - Sat, 30 Jan 2016 16:42:06 -0500 - rev 362195
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: create a signal_handlers.py (Bug 1244448). r=mdoglio r=gps To prepare for moving a number of signal handlers from rbbz to MozReview create a signal_handlers.py where they will live. The first signal to be part of this file comes from MozReview itself and has been moved from extension.py (with no changes to functionality). I did take this chance to rename the signal handler and add a docstring to explain its functionality. I also cleaned up the import styling for both files and removed some unused imports.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip