8d861b9e4ab327eaf41df77525a7ebe90ae6ad8d: Bug 1371450 - Recreate style context only if the element was restyled during the traversal. r?emilio
draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Jul 2017 13:09:54 +0900 - rev 609303
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1371450 - Recreate style context only if the element was restyled during the traversal. r?emilio
MozReview-Commit-ID: CBYTB5FeikP
3e8118e3620f83f05df6c6ed63677ea0ddc630e6: Bug 1371450 - Preserve restyle hints after ForThrottledAnimationFlush restyle. r?emilio
draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Jul 2017 13:09:35 +0900 - rev 609302
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1371450 - Preserve restyle hints after ForThrottledAnimationFlush restyle. r?emilio
Those remaining restyle hints are needed for normal traversal later.
MozReview-Commit-ID: DswGYGQwgfw
34cf6aada7da842b9696c34d17e6984950d65404: Bug 1371450 - Don't traverse normal dirty elements in ProcessPostTraversal when we process throttled animations restyle for event handling. r?emilio
draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Jul 2017 13:09:14 +0900 - rev 609301
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1371450 - Don't traverse normal dirty elements in ProcessPostTraversal when we process throttled animations restyle for event handling. r?emilio
When we process throttled animations restyle for event handling, we skip normal
traversal at all, so after Servo_TraverseSubtree, normally there remains
unstyled elements which have to be processed in normal traversal later. These
elements should be skipped in ProcessPostTraversal too since it's not yet styled!
MozReview-Commit-ID: LgyWQpiFZ8e
21ad388349046abc675dc39f3b9c10a6c1b369ba: Bug 1371450 - Rename TraversalRestyleBehavior::ForAnimationOnly to TraversalRestyleBehavior::ForThrottledAnimationFlush. r?birtles,emilio
draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 15 Jul 2017 13:08:47 +0900 - rev 609300
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1371450 - Rename TraversalRestyleBehavior::ForAnimationOnly to TraversalRestyleBehavior::ForThrottledAnimationFlush. r?birtles,emilio
ForAnimationOnly is somewhat misleading, it means actually we process
*only* animation-only restyle without normal restyle. The purpose of
ForAnimationOnly is for updating throttled animations to get correct position
of the animations when we need to handle events. Currently we do also update
unthrottled animations though.
MozReview-Commit-ID: HBCCluKrZs9
f13be03f8d58d06e5e496a0a68a69730578f3069: Bug 1378691 P4 - skip to next key frame if the playback position is very close to it; r=jwwang
Kaku Kuo <kaku@mozilla.com> - Wed, 12 Jul 2017 17:03:45 +0800 - rev 609299
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1378691 P4 - skip to next key frame if the playback position is very close to it; r=jwwang
MozReview-Commit-ID: Gm0iZAHVLpS
3cc786b7ef6c62682788b79186517a1798fe4f72: Bug 1378691 P3 - return next key frame time back to MDSM; r=jwwang
Kaku Kuo <kaku@mozilla.com> - Tue, 11 Jul 2017 10:15:33 +0800 - rev 609298
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1378691 P3 - return next key frame time back to MDSM; r=jwwang
MozReview-Commit-ID: LVhJ0DpM24c
8fa579e5d0d55b2e12559319337824a3583bcb29: Bug 1378691 P2 - trigger skip-to-next-key-frame if the video decoding is too slow; r=jwwang
Kaku Kuo <kaku@mozilla.com> - Tue, 11 Jul 2017 09:59:13 +0800 - rev 609297
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1378691 P2 - trigger skip-to-next-key-frame if the video decoding is too slow; r=jwwang
MozReview-Commit-ID: B0stJG3eOKU
1d5c83d5f9f55d11b8aafbae141630328d0a91d1: Bug 1378691 P1 - drop video until catch up playbak position for video-only seek; r=jwwang
Kaku Kuo <kaku@mozilla.com> - Tue, 11 Jul 2017 09:56:09 +0800 - rev 609296
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1378691 P1 - drop video until catch up playbak position for video-only seek; r=jwwang
MozReview-Commit-ID: 86BhQDbM7xV
c3844f8b2be015b7eb4212768d90f64fb503f11f: Bug 1355380 - Part 2: Make Servo's rounding of image-orientation values agree with Gecko's, and pass orientations directly as an enum instead of as angles. r=manishearth
Jonathan Chan <jyc@eqv.io> - Mon, 10 Jul 2017 11:32:08 -0700 - rev 609295
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1355380 - Part 2: Make Servo's rounding of image-orientation values agree with Gecko's, and pass orientations directly as an enum instead of as angles. r=manishearth
Both Servo and Gecko store the specified value of the image-orientation
property as a single-precision float, but Gecko does the conversion to radians
and the computation to identify which quarter-turn the angle is closest to
using doubles.
We add Angle::radians64 to perform the conversion to radians using doubles,
just as Gecko does, and then update image_orientation to perform the
computation the same exact way Gecko does in
nsStyleImageOrientation::CreateAsAngleAndFlip. This lets the previously failing
reftests pass.
We also update Gecko_SetImageOrientation to take an orientation directly
instead of an angle (otherwise we'd be doing the which-quarter-turn-is-closest
computation twice).
Finally this lets us re-enable the reftests for image-orientation previously
marked as fails-if(styloVsGecko||stylo).
MozReview-Commit-ID: 2zMMzQlsYEC
055d1bde2a28da8f36ce86559f115223c0622603: Bug 1355380 - Part 1: Have nsStyleImageOrientation::CreateAsAngleAndFlip handle negative angles correctly. r=manishearth
Jonathan Chan <jyc@eqv.io> - Fri, 07 Jul 2017 16:03:37 -0700 - rev 609294
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1355380 - Part 1: Have nsStyleImageOrientation::CreateAsAngleAndFlip handle negative angles correctly. r=manishearth
Previously we just took the input angle mod 2π, which will leave negative input
angles as negative. By checking if the input mod 2π is negative and if so
adding 2π and then taking that mod 2π again we can ensure that we end up with a
an angle in the range [0, 2π].
We only do this if the result of the initial mod is negative because this adds
rounding error that is enough to mess up whether 135 is determined to be closer
to 90 or 180, for example.
We add a test for this as well.
Also fix property_database.js to account for this (we assert that -90deg should
compute to the same value as the initial value, but it should actually compute
to 270deg).
MozReview-Commit-ID: Faf0f7wIEg3
e3c2ff59c9eb630a192c7dc5293a659e5de02bb8: servo: Merge #17696 - Sync Servo / Gecko image-orientation rounding; pass as enum (from jyc:image-orientation-redux); r=Manishearth
Jonathan Chan <jyc@eqv.io> - Fri, 14 Jul 2017 18:54:45 -0700 - rev 609293
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
servo: Merge
#17696 - Sync Servo / Gecko image-orientation rounding; pass as enum (from jyc:image-orientation-redux); r=Manishearth
Make Servo's rounding of image-orientation values agree with Gecko's,
and pass orientations directly as an enum instead of as angles.
Depends on a Gecko change to be subsequently landed in m-c.
Were reviewed here: https://reviewboard.mozilla.org/r/155336/
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix [Bugzilla
Bug 1355380](https://bugzilla.mozilla.org/show_bug.cgi?id=1355380) (github issue number if applicable).
<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because they
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo:
https://github.com/servo/servo
Source-Revision:
3fb309c7554e1a2ee2917348da8572e9b6d98c98
acb1cfbc7e4b8de4315c5458362a5a11c270ee9b: servo: Merge #17738 - Don't retrieve the CSS source when a parse error is reported (from jdm:no-css-text); r=bholley
Josh Matthews <josh@joshmatthews.net> - Fri, 14 Jul 2017 17:53:12 -0700 - rev 609292
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
servo: Merge
#17738 - Don't retrieve the CSS source when a parse error is reported (from jdm:no-css-text); r=bholley
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1381045 retrieving the CSS source is an unnecessary performance hit for Stylo.
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they are tested by Gecko.
Source-Repo:
https://github.com/servo/servo
Source-Revision:
fe98a8001bd5f983956bd5bab8e3b192b936d2f2
e84711b4665d4f9bd64c35db94f926ab8da60e8d: Bug 1341802 - Update test expectations after servo/servo#17737 r=me
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 14 Jul 2017 18:10:12 -0700 - rev 609291
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1341802 - Update test expectations after servo/servo#17737 r=me
c89cd5371520492a3fb9e75d87dc673aff7fb073: servo: Merge #17737 - Convert TrackList's `values` field to store only TrackSize (from canaltinova:same-grid-but-better); r=Manishearth,wafflespeanut
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 14 Jul 2017 16:50:04 -0700 - rev 609290
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
servo: Merge
#17737 - Convert TrackList's `values` field to store only TrackSize (from canaltinova:same-grid-but-better); r=Manishearth,wafflespeanut
It was storing both TrackSize and TrackRepeat before and TrackRepeat have to be
converted into sequence of TrackSize during serialization. Instead of doing this
in serialization process(which is hard and hacky), we converted to do this in
parsing process. We were doing this conversion in the ComputedValue conversion.
So we only had to move this process to parsing.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo:
https://github.com/servo/servo
Source-Revision:
124a23b207d645d994eddc27efd409c22dc0aa28
c3337a381ff45d5a586d870b15416c4f287efae4: Merge m-c to autoland, a=merge
Wes Kocher <wkocher@mozilla.com> - Fri, 14 Jul 2017 17:27:36 -0700 - rev 609289
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Merge m-c to autoland, a=merge
MozReview-Commit-ID: GOb2bgdUd36
bd1b6a4e5d8e1184a89ae60a74fd86d3d4a9e95c: Merge inbound to central, a=merge
Wes Kocher <wkocher@mozilla.com> - Fri, 14 Jul 2017 17:14:43 -0700 - rev 609288
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Merge inbound to central, a=merge
MozReview-Commit-ID: 8nlqm5dHCUQ
b292385f25f7621f56409342a964ce6c6973c7a4: Backed out changeset 15c280b7d53b (bug 1380387) for Linux cgc failure in js1_8_5/extensions/collect-gray.js. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Jul 2017 21:25:36 +0200 - rev 609287
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Backed out changeset 15c280b7d53b (
bug 1380387) for Linux cgc failure in js1_8_5/extensions/collect-gray.js. r=backout
9ee8ecd9aca1f72aa0c090c20ef9bd26f20a37e7: Backed out changeset e029feccd0c0 (bug 1380967) for Linux cgc failure in js1_8_5/extensions/collect-gray.js. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Jul 2017 21:24:55 +0200 - rev 609286
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Backed out changeset e029feccd0c0 (
bug 1380967) for Linux cgc failure in js1_8_5/extensions/collect-gray.js. r=backout
037c6e4b26f269998dc1c29bf350e3842ac0c199: Fix mask coordinates when rendered into intermediate surfaces with Advanced Layers. (bug 1380744, r=mattwoodrow)
David Anderson <danderson@mozilla.com> - Fri, 14 Jul 2017 11:47:54 -0700 - rev 609285
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Fix mask coordinates when rendered into intermediate surfaces with Advanced Layers. (
bug 1380744, r=mattwoodrow)
e029feccd0c06792ec5b623ba2c1343272c195ab: Bug 1380967 - Add a separate reason code for minor GC performed at the start of major GC r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 14 Jul 2017 19:02:09 +0100 - rev 609284
Push
68544 by hikezoe@mozilla.com at Sat, 15 Jul 2017 04:14:13 +0000
Bug 1380967 - Add a separate reason code for minor GC performed at the start of major GC r=sfink