8b2db0ef4134816c16ea395fa44c4e56ec920cbb: Second try. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 14 May 2018 12:42:18 +0200 - rev 798846
Push 110855 by bmo:emilio@crisal.io at Wed, 23 May 2018 15:28:30 +0000
Second try. MozReview-Commit-ID: Oh6VqnFD25
844efa76d6cc3f20760ec1499efcf86f6318f47f: Bug 1460382: Remove NODE_IS_NATIVE_ANONYMOUS. r?bz,heycam draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 10 May 2018 18:48:08 +0200 - rev 798845
Push 110855 by bmo:emilio@crisal.io at Wed, 23 May 2018 15:28:30 +0000
Bug 1460382: Remove NODE_IS_NATIVE_ANONYMOUS. r?bz,heycam Instead of inheriting from the closest non-NAC ancestor, we inherit from the closest native anonymous root's parent, only if we're a pseudo-element. That prevents the two issues that caused this flag to be created: * Following weird NAC inheritance rules in XBL bindings bound to NAC. - This is no longer a problem since we only apply the rule only if we're a pseudo-element, and all pseudo-elements hold from NAC. * Inheriting from the wrong thing if we're a nested NAC subtree. - We no longer look past our NAC subtree. MozReview-Commit-ID: IDKYt3EJtSH
1e2c1a5272f812fb7074bc6c83b793c103cb2db2: Adjust <details> and <summary> to the spec. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 19 May 2018 13:12:59 +0200 - rev 798844
Push 110855 by bmo:emilio@crisal.io at Wed, 23 May 2018 15:28:30 +0000
Adjust <details> and <summary> to the spec. MozReview-Commit-ID: 8SoqkRgGiYO
3b31d07cce5fdc7a31117f54f62d27f820224d8a: Bug 1461974: Account for ongoing shell destruction on both code paths. r?hiro draft
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 16 May 2018 16:51:28 +0200 - rev 798843
Push 110855 by bmo:emilio@crisal.io at Wed, 23 May 2018 15:28:30 +0000
Bug 1461974: Account for ongoing shell destruction on both code paths. r?hiro If the shell is being destroyed and the canvas is not in the doc then we may try to call ResolveForDeclarations on a being-destroyed shell. MozReview-Commit-ID: 51sB49Tgepw
8b814aca44804a1740ae1d7e6d9ce573f0b9001d: Le XBL hack. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 01 May 2018 19:04:50 +0200 - rev 798842
Push 110855 by bmo:emilio@crisal.io at Wed, 23 May 2018 15:28:30 +0000
Le XBL hack. MozReview-Commit-ID: Kk5WRHmPL2d
3cf026d47b57c89b1417d37022b19eb1077edda0: Bug 1458192: Merge CascadeLevel and ShadowCascadeOrder. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 01 May 2018 11:38:02 +0200 - rev 798841
Push 110855 by bmo:emilio@crisal.io at Wed, 23 May 2018 15:28:30 +0000
Bug 1458192: Merge CascadeLevel and ShadowCascadeOrder. MozReview-Commit-ID: 9hBswUoJDBH
7e2fc534c11f4d73beb6f954882caa42275ba44f: Bug 1458192: Undo the packing in ApplicableDeclarationBlock. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 01 May 2018 09:21:07 +0200 - rev 798840
Push 110855 by bmo:emilio@crisal.io at Wed, 23 May 2018 15:28:30 +0000
Bug 1458192: Undo the packing in ApplicableDeclarationBlock. It will get in the way of the next refactor, which puts the shadow order in the cascade level. It's not a regression with respect of what we had last week anyway, and we can always pack them again in a smart way, but I doubt it's that worth it, and it was more unsafe code which I'd rather avoid. MozReview-Commit-ID: 81mWF3GP86h
b201a7bc08b3aeccad4474362229f49a151d334e: Bug 1458192: Make ShadowCascadeOrder a newtype. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 01 May 2018 09:15:21 +0200 - rev 798839
Push 110855 by bmo:emilio@crisal.io at Wed, 23 May 2018 15:28:30 +0000
Bug 1458192: Make ShadowCascadeOrder a newtype. MozReview-Commit-ID: EhCwMMNGM6S
9674122cf64cd44cbd4c6950ad6231d322bf5c1a: Bug 1459750 - Remove unused principal variable draft
Rob Wu <rob@robwu.nl> - Tue, 08 May 2018 11:31:57 +0200 - rev 798838
Push 110854 by bmo:rob@robwu.nl at Wed, 23 May 2018 15:08:07 +0000
Bug 1459750 - Remove unused principal variable Variable `principal` is only used when `this.isExtensionPage` is false. So move this inside the branch where this condition is satisfied, and remove the `else if (this.isExtensionPage) { ... }` block. (This is a follow-up to bug 1214658, where the check was introduced that obsoleted the principal variable when `this.isExtensionPage` due to the use of `contentWindow` instead of `principal`). (`principal = contentPrincipal` was already unused at its introduction in bug 1317697) MozReview-Commit-ID: F7VX9vAH8MM
c3e7df7b85a7b112758e2717ec249bcdf620db7f: Bug 1459750 - Add JSDoc to ExtensionContent.Script constructor draft
Rob Wu <rob@robwu.nl> - Tue, 08 May 2018 01:59:48 +0200 - rev 798837
Push 110854 by bmo:rob@robwu.nl at Wed, 23 May 2018 15:08:07 +0000
Bug 1459750 - Add JSDoc to ExtensionContent.Script constructor `contentScripts` in extension-process-script.js lazily instantiates `ExtensionContent.Script` using the key as "matcher". This "matcher" is usually a `WebExtensionContentScript`, except in case of "Extension:Execute". Then the object is a `WebExtensionContentScript`, extended with some expando properties. MozReview-Commit-ID: 3hMAy9Ff1lr
6221959b4be077b6b2d41eb3441d4fc68c8738e9: Bug 1459750 - Rename extension to policy where applicable draft
Rob Wu <rob@robwu.nl> - Mon, 07 May 2018 23:45:44 +0200 - rev 798836
Push 110854 by bmo:rob@robwu.nl at Wed, 23 May 2018 15:08:07 +0000
Bug 1459750 - Rename extension to policy where applicable This only changes some variable names. There is still work to do, e.g. renaming "extension" in WebExtensionContentScript to "policy". That will be handled in bug 1441886. MozReview-Commit-ID: AqQErPyeFe7
0cb102a167cecdba3c8af1da3b185164db56103f: Bug 1459750 - Remove unused BrowserExtensionContent.scripts draft
Rob Wu <rob@robwu.nl> - Mon, 07 May 2018 22:32:53 +0200 - rev 798835
Push 110854 by bmo:rob@robwu.nl at Wed, 23 May 2018 15:08:07 +0000
Bug 1459750 - Remove unused BrowserExtensionContent.scripts This "scripts" getter started to become unused in: https://hg.mozilla.org/mozilla-central/rev/1267d47eca93 The "extension" in the "extension.scripts" above was changed from "BrowserExtensionContent" to "StubExtension". (and this "StubExtension" does not exist in the current code base any more, as it has been replaced with "WebExtensionPolicy" - see the bug). MozReview-Commit-ID: HkNhy4QOB15
85489b5cd4f21781af2cfd4c242c0887809fb0ad: Bug 1457719 - Part 2 - Remove the "autorepeatbutton" element. r=bz draft
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 23 May 2018 15:32:48 +0100 - rev 798834
Push 110853 by paolo.mozmail@amadzone.org at Wed, 23 May 2018 14:56:08 +0000
Bug 1457719 - Part 2 - Remove the "autorepeatbutton" element. r=bz The DoMouseClick helper is also removed because no other caller can now pass a null aEvent. Other MouseClicked implementations are also updated since aEvent cannot be null, which was already the case. MozReview-Commit-ID: 3bTJ6cZW9ZA
64397f101015297e4a826927f135ecb06bab6bb2: Bug 1457719 - Part 1 - Replace "autorepeatbutton" with "toolbarbutton" in the base "arrowscrollbox" binding. r=enn draft
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 23 May 2018 15:32:36 +0100 - rev 798833
Push 110853 by paolo.mozmail@amadzone.org at Wed, 23 May 2018 14:56:08 +0000
Bug 1457719 - Part 1 - Replace "autorepeatbutton" with "toolbarbutton" in the base "arrowscrollbox" binding. r=enn This aligns the markup of the base "arrowscrollbox" binding with the "clicktoscroll" derived binding, while still keeping different event handlers. MozReview-Commit-ID: 9eYt1kyjgP9
1c11159988f03ab90638c49d974ad99ab1c92a0b: Bug 1463766 - Change do_send_remote_message/do_await_remote_message to allow passing data r=Gijs draft
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 23 May 2018 16:51:58 +0200 - rev 798832
Push 110852 by valentin.gosu@gmail.com at Wed, 23 May 2018 14:52:56 +0000
Bug 1463766 - Change do_send_remote_message/do_await_remote_message to allow passing data r=Gijs MozReview-Commit-ID: 4OuzgmQlhn5
2cca2b6aeeded287e61207d4b9d5d76f3647cdd1: Bug 1463758: Don't use sequentially consistent atomic operations in RacyFeatures. r?mstange draft
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 23 May 2018 16:44:53 +0200 - rev 798831
Push 110851 by bmo:emilio@crisal.io at Wed, 23 May 2018 14:47:09 +0000
Bug 1463758: Don't use sequentially consistent atomic operations in RacyFeatures. r?mstange Relaxed is more than enough for this use. MozReview-Commit-ID: 6BGfEU83s7Y
71987b91708bfdaca1a2402572b61a8927116bec: Bug 1462725 - Add 'end_study' event; r=rhelmer draft
Bianca Danforth <bdanforth@mozilla.com> - Wed, 23 May 2018 07:29:32 -0700 - rev 798830
Push 110850 by bdanforth@mozilla.com at Wed, 23 May 2018 14:32:53 +0000
Bug 1462725 - Add 'end_study' event; r=rhelmer This `end_study` event will be recorded when an ending condition has been met: the study has expired, the user is ineligible, or the study has been disabled (the study pref has been turned off). MozReview-Commit-ID: 6WKL4hqWliz
89f4cf563a85d3ee0f070da0d294b54de20e01c9: Bug 1462725 - Add study expiration and testing override pref; r=rhelmer draft
Bianca Danforth <bdanforth@mozilla.com> - Wed, 23 May 2018 07:27:10 -0700 - rev 798829
Push 110850 by bdanforth@mozilla.com at Wed, 23 May 2018 14:32:53 +0000
Bug 1462725 - Add study expiration and testing override pref; r=rhelmer The study will shutdown on its own after a specified period of time. The testing override pref allows for changing the study duration from the default, which is 4 weeks. MozReview-Commit-ID: 6QBB1qqs6TJ
df171745b6e5a16b53643ce3ea7a2fb66c9782c1: Bug 1462725 - Add eligibility check; r=rhelmer draft
Bianca Danforth <bdanforth@mozilla.com> - Wed, 23 May 2018 07:25:20 -0700 - rev 798828
Push 110850 by bdanforth@mozilla.com at Wed, 23 May 2018 14:32:53 +0000
Bug 1462725 - Add eligibility check; r=rhelmer On startup, ends the study if auto private browsing mode is enabled. I did not add a pref observer for this, since when the pref is changed, the changes won't take effect until the next startup anyway. MozReview-Commit-ID: DqABLEai8zx
954b1b69a2b6e5e67e3c1122a47464648d73a73d: Bug 1462725 - Uninit study on Firefox shutdown; r=rhelmer draft
Bianca Danforth <bdanforth@mozilla.com> - Wed, 23 May 2018 07:23:44 -0700 - rev 798827
Push 110850 by bdanforth@mozilla.com at Wed, 23 May 2018 14:32:53 +0000
Bug 1462725 - Uninit study on Firefox shutdown; r=rhelmer Intended to undo study-related changes that don't need to persist between sessions: clear prefs, remove observers, etc. MozReview-Commit-ID: 4Eyyq7vMm13
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip