84e06cd9eebd1bc0928e07de84c8c5444edcbbc5: Bug 1444479 - P3. Add Channels(ChannelMap) method. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 16 Mar 2018 16:47:41 +0100 - rev 769396
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1444479 - P3. Add Channels(ChannelMap) method. r?padenot MozReview-Commit-ID: 9sYeh30NHFF
822125df1ffe91a0493862560d8f294cc418b1ce: Bug 1444479 - P2. Make AudioConverter works with unknown layout. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 16 Mar 2018 16:45:13 +0100 - rev 769395
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1444479 - P2. Make AudioConverter works with unknown layout. r?padenot If a channel layout is unsupported, the AudioConverter will instead just use the channel count information to leave the data as-is, only trimming extra channels, or inserting silence if needed. MozReview-Commit-ID: CXOjcSRsRwI
b1c3beed574a507dbf2d32376ff8a1a188014976: Bug 1444479 - P1. Remove 8 channels limitation in AudioConfig. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 16 Mar 2018 16:37:27 +0100 - rev 769394
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1444479 - P1. Remove 8 channels limitation in AudioConfig. r?padenot Instead we place it at 32. Future changes will change the meaning of this limit to when we can deal with channel layout. If outside that limit the audio will be played on a best attempt basis. MozReview-Commit-ID: EavmmcxjLI0
f115bf2867f4d33401a6e0fc237bee57c0aff512: fixes to build draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 14 Mar 2018 17:46:48 +0100 - rev 769393
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
fixes to build MozReview-Commit-ID: 7qDEqNFo4KG
67836e5957764f1e7f67bd47601c577e7cab9fa8: Bug 1432779 - P14. If a layout is unknown or invalid, always treat it as plain stereo or mono. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 15 Mar 2018 17:40:42 +0100 - rev 769392
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P14. If a layout is unknown or invalid, always treat it as plain stereo or mono. r?padenot MozReview-Commit-ID: F9FhLJoP4BO
75ba006b7ead8fa284fa6aa8dcc0bb67cb854aa6: Bug 1432779 - P13. Fix input mixing and clarify frames vs samples terminology. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 15 Mar 2018 17:39:54 +0100 - rev 769391
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P13. Fix input mixing and clarify frames vs samples terminology. r?padenot MozReview-Commit-ID: 7M9xJB7HDMB
dbbf351356875a979dfb754150a3cbce390a91cd: Bug 1432779 - P12. User proper sample size when calculating offsets. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 15 Mar 2018 01:03:54 +0100 - rev 769390
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P12. User proper sample size when calculating offsets. r?padenot Should the user data be of a different types to what the AudioUnit output is set to, we would have written outside the end of our allocated buffer. MozReview-Commit-ID: 4oLTyHmm6OZ
eed67dd42d532e26f6174b5b9af18a988347673b: Bug 1432779 - P11. Make cubeb_mixer creation infallible. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Mar 2018 22:10:25 +0100 - rev 769389
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P11. Make cubeb_mixer creation infallible. r?padenot Rather than ignore nonsensical layouts, we attempt to play it according to the stream channels count instead. The audio data will be played as-is, dropping the extra channels or inserting silence where needed. MozReview-Commit-ID: 7bygAJMu93Z
989528895fca339610da4681a731ea1f571e3df7: Bug 1432779 - P10. Fix remixing on mac, windows and pulse backend. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Mar 2018 18:49:18 +0100 - rev 769388
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P10. Fix remixing on mac, windows and pulse backend. r?padenot MozReview-Commit-ID: HmUtV5T7lUV
27ec1662f2ef1049093459385121df2aac7d71e9: Bug 1432779 - P9. Rework cubeb_mixer. r?padenot,r?kamidphish draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 08 Mar 2018 22:17:12 +0100 - rev 769387
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P9. Rework cubeb_mixer. r?padenot,r?kamidphish This completely replace the existing remixer which had serious limitations: 1- Had no memory bound checks 2- Could only downmix 5.1 and 7.1 to stereo. This mixer allows to convert from any sane layout to any other and work directly on interleaved samples. This cubeb_mixer doesn't have an API compatible with the previous one. This commit is non-fonctional, and was split for ease of review. MozReview-Commit-ID: ECsGE7VMzbE
71c30f6a9d1bec827d95b60b901cb71c9552c581: Bug 1432779 - P8. Add cubeb_sample_size convenience method. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 08 Mar 2018 20:28:48 +0100 - rev 769386
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P8. Add cubeb_sample_size convenience method. r?padenot MozReview-Commit-ID: 9tLegCyLTOL
1c8e32bec47beb53fc68e19770f8d006ef00cb9f: Bug 1432779 - P7. Use typedef rather than actual type. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 06 Mar 2018 17:13:31 +0100 - rev 769385
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P7. Use typedef rather than actual type. r?padenot this improve readability. MozReview-Commit-ID: IYfrLMZ5djX
4920f287b83981cdc752805778cf01951650faf3: Bug 1432779 - P6. Remove CHANNEL_MONO concept. r?padenot, r?kamidphish draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 01 Feb 2018 10:25:45 +0100 - rev 769384
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P6. Remove CHANNEL_MONO concept. r?padenot, r?kamidphish MozReview-Commit-ID: 6Ui4aWBBeq9
94cc5877002e0ffaf18cf1f365526e0ae1600db4: Bug 1432779 - P5. Remove no longer used variables. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 31 Jan 2018 19:25:25 +0100 - rev 769383
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P5. Remove no longer used variables. r?padenot MozReview-Commit-ID: LqOuM1F0NC2
f8f17d6b5daa46e16271b5a71a354ad889c62439: Bug 1432779 - P4. Remove the concept of preferred layout. r?padenot,r?kamidphish draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 31 Jan 2018 19:08:51 +0100 - rev 769382
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P4. Remove the concept of preferred layout. r?padenot,r?kamidphish Channel layout is derived by the content being played. The concept of preferred layout is meaningless. Either we have a layout defined, or we don't. There's no in-between. So we remove it. MozReview-Commit-ID: CSCAInNmzMS
00fd8be2ed13855e7a8aa1dd7aeb7f131ba6baf8: Bug 1432779 - P3. Properly set channel map layout after seeking. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Mar 2018 15:36:55 +0100 - rev 769381
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P3. Properly set channel map layout after seeking. r?padenot MozReview-Commit-ID: 5FY9hdaijhf
1cfeab27191a98b97348a2ef0f4b1b640f29084c: Bug 1432779 - P2. Add L3F2_BACK layout shortcuts. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Mar 2018 13:51:40 +0100 - rev 769380
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P2. Add L3F2_BACK layout shortcuts. r?padenot MozReview-Commit-ID: LKVt88dWKdg
21a10636842095e0ef5f067afcf348b43ceb47f1: Bug 1432779 - P1. Fix ChannelLayout calculation for uncommon layouts. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Mar 2018 13:44:11 +0100 - rev 769379
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1432779 - P1. Fix ChannelLayout calculation for uncommon layouts. r?padenot MozReview-Commit-ID: Fi5ESBhziOp
835304102bc92905bc2fc7f252514dafa3243c2f: Bug 1431221 - P13. Remove dual mono layout. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 31 Jan 2018 10:54:05 +0100 - rev 769378
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1431221 - P13. Remove dual mono layout. r?padenot It makes no sense to have a case for those as the data structure used (a bitmask) do not allow to represent this channel layout (a channel can only be present once). As such it was a non-functional layout MozReview-Commit-ID: FjA0fojFcJp
932ef971334fc0e361bf0f7d468953377de715d9: Bug 1431221 - P12. Fix Force Stereo Mode. r?padenot draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 01 Feb 2018 15:59:21 +0100 - rev 769377
Push 103110 by bmo:jyavenard@mozilla.com at Mon, 19 Mar 2018 14:36:56 +0000
Bug 1431221 - P12. Fix Force Stereo Mode. r?padenot MozReview-Commit-ID: DEoKXNk3d4E
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip