84dfa535f53ae5ec7a03a318e945684a2f8ca519: Bug 1295486 - Decode YAML files to UTF-8 at read time; r=dustin draft
Gregory Szorc <gps@mozilla.com> - Thu, 18 Aug 2016 08:58:59 -0700 - rev 413298
Push 29400 by bmo:gps@mozilla.com at Wed, 14 Sep 2016 00:02:37 +0000
Bug 1295486 - Decode YAML files to UTF-8 at read time; r=dustin Before, we'd open files and feed bytes to yaml.load(). When a str is fed to yaml.load(), it attempts to guess the encoding. It defaults to UTF-8 unless somebody set us up the BOM. This is probably OK. Except if the file isn't valid UTF-8, the exception will be raised in the bowels of YAML parsing and it may not be obvious the failure is due to invalid UTF-8 input versus say Python str/unicode coercion foo. We change all call sites that load YAML from a file to use codecs.open() to open the file in UTF-8 and perform UTF-8 decoding/validation at file read time. This should make any UTF-8 failures more obvious. Furthermore, it reinforces that our YAML files are UTF-8 and not some other encoding. I discovered this issue as part of trying to get emoji symbols to render on Treeherder. Unfortunately, it appears pyyaml detects many emoji as unprintable characters and refuses to load them. This makes me sad and makes me want to abandon pyyaml/YAML in favor of something that supports emoji :P MozReview-Commit-ID: AOvAruZFfnK
f4d1be71f91322d33fe07d9a8583d68e18104fdd: Bug 1295486 - Mock codecs.open with MockedOpen; r?glandium draft
Gregory Szorc <gps@mozilla.com> - Tue, 13 Sep 2016 16:07:40 -0700 - rev 413297
Push 29400 by bmo:gps@mozilla.com at Wed, 14 Sep 2016 00:02:37 +0000
Bug 1295486 - Mock codecs.open with MockedOpen; r?glandium TaskCluster's unit tests test MockedOpen. A future change I want to make introduces usage of codecs.open(). This resulted in test failures because codecs.open() isn't mocked by MockedOpen. This commit teaches MockedOpen to handle codecs.open(). As part of this, the mocked open() function was taught a "buffering" argument because codecs.open() calls __builtins__.open() with this argument. I had to introduce a new class to represent a mocked file opened with codecs.open() because files opened in this mode must raise errors when encodings aren't sane or why str/bytes instances are seen. The io.StringIO type fortunately enforces most of this for us. MozReview-Commit-ID: Bo1Ke516pxn
e4489160d703562e52e8907390623367f34f982d: Bug 1295486 - Refactor MockedOpen API; r?glandium draft
Gregory Szorc <gps@mozilla.com> - Tue, 13 Sep 2016 16:07:37 -0700 - rev 413296
Push 29400 by bmo:gps@mozilla.com at Wed, 14 Sep 2016 00:02:37 +0000
Bug 1295486 - Refactor MockedOpen API; r?glandium I'm not sure why we're using __call__ here. We appear to only use this class as a context manager. So we rename __call__ to _open. We also rename open to _orig_open to match the convention used elsewhere in the class. The only consumer of these APIs outside the module itself has been modified accordingly. MozReview-Commit-ID: 4xx8T5T57OI
25cc4e9b633c902fb200dc7947797fb32ccd5853: Bug 1301818 - Prepare BSPTree for integration with the layers code draft
Miko Mynttinen <mikokm@gmail.com> - Tue, 13 Sep 2016 15:27:31 -0700 - rev 413295
Push 29399 by bmo:mikokm@gmail.com at Wed, 14 Sep 2016 00:02:28 +0000
Bug 1301818 - Prepare BSPTree for integration with the layers code MozReview-Commit-ID: ADJvCZYSk6p
7aa1d44332716603bbfb6f0a872a34ade3d1e932: Bug 1260199 - Remove yet another use of CPOWs in this test. r=mconley draft
Blake Kaplan <mrbkap@gmail.com> - Tue, 13 Sep 2016 16:30:52 -0700 - rev 413294
Push 29398 by bmo:mrbkap@mozilla.com at Tue, 13 Sep 2016 23:31:16 +0000
Bug 1260199 - Remove yet another use of CPOWs in this test. r=mconley MozReview-Commit-ID: RxKqmcl0aC
6f475a98fe7381d92ec830566bdc001883be52ef: Bug 1302465: [MSE] Schedule eviction, even if previously the source buffer was full. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 14 Sep 2016 09:28:01 +1000 - rev 413293
Push 29397 by bmo:jyavenard@mozilla.com at Tue, 13 Sep 2016 23:28:47 +0000
Bug 1302465: [MSE] Schedule eviction, even if previously the source buffer was full. r?gerald Conditions may have changed (such as currentTime moving since the last attempt). So we try again. MozReview-Commit-ID: 2zexl1FzOd7
6cb46967ea38fab83b4cb63bb9c09d63b70ef35f: Bug 1300808 - Ignore options_ui on Android. r?kmag draft
Matthew Wein <mwein@mozilla.com> - Mon, 12 Sep 2016 15:46:02 -0700 - rev 413292
Push 29396 by mwein@mozilla.com at Tue, 13 Sep 2016 23:23:22 +0000
Bug 1300808 - Ignore options_ui on Android. r?kmag MozReview-Commit-ID: DF739YRjxOb
1caa1d8c1b2923eb39afdfc691f17eeb7721589b: bug 1280044 - handle subdirs in browser.downloads filenames, r?aswan draft 1280044-download-subdir
Tomislav Jovanovic <tomica@gmail.com> - Fri, 09 Sep 2016 19:38:01 +0200 - rev 413291
Push 29395 by bmo:tomica@gmail.com at Tue, 13 Sep 2016 23:12:51 +0000
bug 1280044 - handle subdirs in browser.downloads filenames, r?aswan MozReview-Commit-ID: B4WoMbdxYjV
0c9a7615e924cfb194f8ccaa09c205f73958d4ba: Bug 1284407 Generate addon id from the path for temporarily loaded xpis r?rhelmer draft
Andrew Swan <aswan@mozilla.com> - Mon, 12 Sep 2016 16:13:42 -0700 - rev 413290
Push 29394 by aswan@mozilla.com at Tue, 13 Sep 2016 23:05:13 +0000
Bug 1284407 Generate addon id from the path for temporarily loaded xpis r?rhelmer MozReview-Commit-ID: 4XChacM8xE0
4a8d1fe2ad563c3930106ded5bc9881814d5fc70: bug 1302140 - disable SHA-1 except for certificates issued by non-built-in CAs draft
David Keeler <dkeeler@mozilla.com> - Tue, 13 Sep 2016 15:05:21 -0700 - rev 413289
Push 29393 by dkeeler@mozilla.com at Tue, 13 Sep 2016 23:01:58 +0000
bug 1302140 - disable SHA-1 except for certificates issued by non-built-in CAs MozReview-Commit-ID: CCJ2jvZTuR7
2c30b60465e29ecdf6efc08c22fc557e7292576b: Bug 1301442 new layout for external l10n build support, r?Gijs draft
Shane Caraveo <scaraveo@mozilla.com> - Tue, 13 Sep 2016 15:51:11 -0700 - rev 413288
Push 29392 by mixedpuppy@gmail.com at Tue, 13 Sep 2016 22:51:30 +0000
Bug 1301442 new layout for external l10n build support, r?Gijs MozReview-Commit-ID: EizWc91jP3u
74097c4f8e13da2f54225ea95beafcc11d45e6cd: Bug 1301442 m-c removal of old pocket l10n, r=flod draft
Shane Caraveo <scaraveo@mozilla.com> - Tue, 13 Sep 2016 15:51:07 -0700 - rev 413287
Push 29392 by mixedpuppy@gmail.com at Tue, 13 Sep 2016 22:51:30 +0000
Bug 1301442 m-c removal of old pocket l10n, r=flod MozReview-Commit-ID: 1wq0dCCFrfG
9cc9a220e0342c110476dd7c40450dab6d5f57cb: Bug 1301442 new layout for external l10n build support, r?Gijs draft
Shane Caraveo <scaraveo@mozilla.com> - Tue, 13 Sep 2016 15:46:31 -0700 - rev 413286
Push 29391 by mixedpuppy@gmail.com at Tue, 13 Sep 2016 22:49:35 +0000
Bug 1301442 new layout for external l10n build support, r?Gijs MozReview-Commit-ID: 4X42twya00c
dc66a4554fa46a9d5625f925a8d58e7a3821c368: Bug 1301442 m-c removal of old pocket l10n, r?flod draft
Shane Caraveo <scaraveo@mozilla.com> - Tue, 13 Sep 2016 15:46:27 -0700 - rev 413285
Push 29391 by mixedpuppy@gmail.com at Tue, 13 Sep 2016 22:49:35 +0000
Bug 1301442 m-c removal of old pocket l10n, r?flod MozReview-Commit-ID: 4limtV3Maot
2e549398f46b10d259270093a03b80673e66ddcd: Bug 1271796 use raw bytes to calculate SRI hash r?francois draft
Kate McKinley <kmckinley@mozilla.com> - Mon, 05 Sep 2016 12:55:25 +0200 - rev 413284
Push 29390 by bmo:kmckinley@mozilla.com at Tue, 13 Sep 2016 22:25:29 +0000
Bug 1271796 use raw bytes to calculate SRI hash r?francois MozReview-Commit-ID: F62t5CnsYlJ
2a677909ffadec1bd52d5e98a910dfcc9177fb18: Bug 1302157 - removal of images-in-menu code as GTK has deprecated this option, removed all relevant CSS parsing and icons to match the windows layout r?dao draft
Jonathan Kingston <jkt@mozilla.com> - Tue, 13 Sep 2016 15:35:29 +0100 - rev 413283
Push 29389 by jkingston@mozilla.com at Tue, 13 Sep 2016 22:23:06 +0000
Bug 1302157 - removal of images-in-menu code as GTK has deprecated this option, removed all relevant CSS parsing and icons to match the windows layout r?dao MozReview-Commit-ID: Dq3RqIaPkVw
58a4b914a40ab2cbd504bf8cf8353d58f21990ea: Bug 670083 - expose placeholder as description if wasn't used as name r?surkov draft
Takeshi Kurosawa <taken.spc@gmail.com> - Wed, 24 Aug 2016 14:50:31 +0900 - rev 413282
Push 29388 by bmo:taken.spc@gmail.com at Tue, 13 Sep 2016 22:13:49 +0000
Bug 670083 - expose placeholder as description if wasn't used as name r?surkov - Pass nameFlag to NativeDescription to prepare further implementation of HTML Accessibility API Mappings - Use placeholder as description if it wasn't used as name MozReview-Commit-ID: ApuMKpUi8iM
ec53b485ef78823ab3d0f3da1aab36f7c2c2ace5: Bug 1300808 - Ignore options_ui on Android. r?kmag draft
Matthew Wein <mwein@mozilla.com> - Mon, 12 Sep 2016 15:46:02 -0700 - rev 413281
Push 29387 by mwein@mozilla.com at Tue, 13 Sep 2016 22:00:14 +0000
Bug 1300808 - Ignore options_ui on Android. r?kmag MozReview-Commit-ID: DF739YRjxOb
c87a0d7b409c8a7776e8e5b813b0c69599b4afdd: Bug 1300508 - Fix conformance fails for Windows 10; r?ethlin, jgilbert draft
Daosheng Mu <daoshengmu@gmail.com> - Tue, 13 Sep 2016 22:25:47 +0800 - rev 413280
Push 29386 by bmo:dmu@mozilla.com at Tue, 13 Sep 2016 21:41:58 +0000
Bug 1300508 - Fix conformance fails for Windows 10; r?ethlin, jgilbert MozReview-Commit-ID: 6kR4Xfgo2Vo
970529cac2dd8d3f95c1a1d462f03f2b666aa37c: Bug 1302148 - Fix potential race in toolbox.destroy. r=bgrins draft
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 12 Sep 2016 02:44:17 -0700 - rev 413279
Push 29385 by bmo:poirot.alex@gmail.com at Tue, 13 Sep 2016 21:37:11 +0000
Bug 1302148 - Fix potential race in toolbox.destroy. r=bgrins MozReview-Commit-ID: 8qSwjLVrRL6
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip