8497079ee6596ab6e34e8fe4bfec6c8a05959b3d: Bug 1462784 - Annotate idle stacks in the main thread event loop. r?froydnj
draft
Markus Stange <mstange@themasta.com> - Wed, 16 May 2018 13:26:51 -0400 - rev 797393
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Annotate idle stacks in the main thread event loop. r?froydnj
MozReview-Commit-ID: I4WSeZtXPBD
7944cb8ea08538bd6eed85af54ac2d9682ee30df: Bug 1462784 - Annotate idle stacks in the chromium event loop. r?froydnj
draft
Markus Stange <mstange@themasta.com> - Fri, 18 May 2018 18:17:21 -0400 - rev 797392
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Annotate idle stacks in the chromium event loop. r?froydnj
MozReview-Commit-ID: Ac8H02GKnmV
a9aa05093d4c5be5843a5b8bdc8e8c712e763341: Bug 1462784 - Add an IDLE category. r?njn
draft
Markus Stange <mstange@themasta.com> - Fri, 18 May 2018 18:15:46 -0400 - rev 797391
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Add an IDLE category. r?njn
MozReview-Commit-ID: JJ30AhXofBr
2a14ae7b16fb0fe63bcabe34e8e743804da0e82d: Bug 1462784 - Relabel various other stuff as being OTHER. r?njn
draft
Markus Stange <mstange@themasta.com> - Fri, 18 May 2018 17:58:43 -0400 - rev 797390
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Relabel various other stuff as being OTHER. r?njn
Any more specific work that is happening in these methods will have its own
specific category labeling in that specific code. The instances touched in this
patch are more on the outside and don't really know what kind of code is going
to be running inside.
MozReview-Commit-ID: 47NO1DZzkdH
dc75221157f9f1f451c090591df974c16d0cc0e2: Bug 1462784 - Remove the STORAGE category. r?njn
draft
Markus Stange <mstange@themasta.com> - Fri, 18 May 2018 17:55:18 -0400 - rev 797389
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Remove the STORAGE category. r?njn
This was used to label IndexedDB work and work in storage/mozStorage*.
I don't think this deserves its own category; categories are most useful for
the main thread, and most of the time-consuming database-related work happens
on helper threads. The main thread pieces are mostly for asynchronicity-
coordination and don't usually take up time.
This patch labels IndexedDB work as DOM instead (which is maybe debatable) and
the rest as OTHER.
MozReview-Commit-ID: 3UYhFFbi3Ry
53c36d8e8775782ea461f2a7caf93b003702c80e: Bug 1462784 - Add a DOM category and use it for the WebIDL binding stack labels. r?njn
draft
Markus Stange <mstange@themasta.com> - Fri, 18 May 2018 17:49:55 -0400 - rev 797388
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Add a DOM category and use it for the WebIDL binding stack labels. r?njn
MozReview-Commit-ID: AevGMqeBvXO
05abbc597ef803f09ef0fef746b2c4010dfb2423: Bug 1462784 - Annotate layout-related stacks with the LAYOUT category instead of the GRAPHICS category. r?njn
draft
Markus Stange <mstange@themasta.com> - Fri, 18 May 2018 17:46:59 -0400 - rev 797387
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Annotate layout-related stacks with the LAYOUT category instead of the GRAPHICS category. r?njn
MozReview-Commit-ID: 77lvtLaxgEE
1286b438982d5ffaead9d38c9c2f3bffdf6b8bb5: Bug 1462784 - Rename the CSS category to LAYOUT. r?njn
draft
Markus Stange <mstange@themasta.com> - Fri, 18 May 2018 17:40:52 -0400 - rev 797386
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Rename the CSS category to LAYOUT. r?njn
The next changeset is going to move over more annotations that Gecko developers
would count as "layout" into the LAYOUT category, and which is currently marked
as GRAPHICS.
We can add a subcategory for style resolution once we have subcategories, but
for now I think it makes more sense to put style resolution into the same bucket
as reflow and display list building.
MozReview-Commit-ID: 7r9eICVBA1Z
7076a24c567515d21513956ac4d3fb3f7a3f063f: Bug 1462784 - Remove EVENTS category. r?njn
draft
Markus Stange <mstange@themasta.com> - Fri, 18 May 2018 17:36:30 -0400 - rev 797385
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Remove EVENTS category. r?njn
Categories are useful to indicate: This much % of time was spent in this category.
The EVENTS category isn't a very good match for this. This category is currently
only set on labels of functions that handle the processing of an event. But
those functions are usually closer to the base of the stack, and the actual CPU
work during the processing of an event is usually in another category closer to
the top of the stack, e.g. in JS if we're running an event handler, or in LAYOUT
if we're hit testing the position of the event.
This changeset removes the EVENTS category and replaces all uses of it with the
OTHER category.
MozReview-Commit-ID: JPm5hQiBkvp
047ddb172d39f4c969042dff9d350d23cad2729d: Bug 1462784 - Merge GC and CC categories into one category. r?njn
draft
Markus Stange <mstange@themasta.com> - Fri, 18 May 2018 17:23:33 -0400 - rev 797384
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Merge GC and CC categories into one category. r?njn
They're very similar as far as most users of the profiler are concerned, I'd
say, and I don't believe it's worth giving them two different colors in the
activity graphs.
MozReview-Commit-ID: HTqjp56naL3
93c3fb63d8ad4586981abdc7868f158cf97d0cf7: Bug 1462784 - Change the enum ProfilingStackFrame::Category from a bitfield to a regular enum. r?njn
draft
Markus Stange <mstange@themasta.com> - Fri, 18 May 2018 17:06:13 -0400 - rev 797383
Push
110467 by bmo:mstange@themasta.com at Fri, 18 May 2018 23:16:12 +0000
Bug 1462784 - Change the enum ProfilingStackFrame::Category from a bitfield to a regular enum. r?njn
MozReview-Commit-ID: HmDu8Rri5AF
b5883d850b537064d0a60cf3adc1bd26ccc186d3: Bug 1462829: Refactor vector types. r?hiro,xidorn
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 18 May 2018 22:06:25 +0200 - rev 797382
Push
110466 by bmo:emilio@crisal.io at Fri, 18 May 2018 23:07:34 +0000
Bug 1462829: Refactor vector types. r?hiro,xidorn
This fixes clamping of mask-size and moves it out of mako while at it.
Also fixes completion keywords for vector types that allow "none", and removes a
bunch of duplicated list animation code.
MozReview-Commit-ID: 9hiTe63odna
82716ab200d168b951d110b6aa0088025dd41a1f: Bug 1457336: Teach nsFind about display in general. r?mats
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 27 Apr 2018 01:55:48 +0200 - rev 797381
Push
110466 by bmo:emilio@crisal.io at Fri, 18 May 2018 23:07:34 +0000
Bug 1457336: Teach nsFind about display in general. r?mats
I ended up not using the nsIFrame methods both for consistency with the plain
text serializer and because of include hell due to nsStyleStructInlines /
nsIFrameInlines.
Find doesn't care about nodes with no frames anyway, so it didn't seem worth
doing the fallback if there's no style information.
I'll file a bug for IsHTMLBlock.
MozReview-Commit-ID: 3T317a4xCB
fc240c39b1171adbdaeef45a38c7391b4d876e3e: Bug 1462618: The restyle root machinery could work better. r?heycam
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 17 May 2018 19:55:48 +0200 - rev 797380
Push
110466 by bmo:emilio@crisal.io at Fri, 18 May 2018 23:07:34 +0000
Bug 1462618: The restyle root machinery could work better. r?heycam
Consider the test-case where we have:
<div>
<span id=a />
<span id=b />
</div>
We try to set one bit on "a", and a different one on "b".
Ideally we'll end up with <div> as the root with both bits. But with the current
code we'd go all the way to the document unnecessarily. This fixes it by
checking the bit's we've propagated up to the top instead of existingBits.
MozReview-Commit-ID: GfwjwCBpkuy
9ade9a80c9c6b464f4ab009dc4da52db07774423: Bug 1457286: Teach nsFind about display: contents. r?mats
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Apr 2018 22:38:31 +0200 - rev 797379
Push
110466 by bmo:emilio@crisal.io at Fri, 18 May 2018 23:07:34 +0000
Bug 1457286: Teach nsFind about display: contents. r?mats
MozReview-Commit-ID: LODyc8yuuSs
e1fafe357b36270b835acf86f17aef855ce76fa5: Merge inbound to mozilla-central. a=merge
Ciure Andrei <aciure@mozilla.com> - Sat, 19 May 2018 01:05:58 +0300 - rev 797378
Push
110466 by bmo:emilio@crisal.io at Fri, 18 May 2018 23:07:34 +0000
Merge inbound to mozilla-central. a=merge
b54f574a1dd21f6a1f0e07aa349b0aa3a7be29f2: Bug 1392106 - use 2 chunks for reftests on OS X to prevent timeout with quantumrender. r=kats a=permafail-fix
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 18 May 2018 22:48:00 +0300 - rev 797377
Push
110466 by bmo:emilio@crisal.io at Fri, 18 May 2018 23:07:34 +0000
Bug 1392106 - use 2 chunks for reftests on OS X to prevent timeout with quantumrender. r=kats a=permafail-fix
MozReview-Commit-ID: JbbWM59pAIX
8c6bdb5e72fea5c7ad660f7e81fa73533dec2fa7: Bug 1462497 - Add assertions to try diagnose which wrapper item went away. r=mstange
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 18 May 2018 20:50:04 +1200 - rev 797376
Push
110466 by bmo:emilio@crisal.io at Fri, 18 May 2018 23:07:34 +0000
Bug 1462497 - Add assertions to try diagnose which wrapper item went away. r=mstange
MozReview-Commit-ID: BkU5tTlgFum
5df1a6b69bd08eb7f31722faa58497ae869b34e6: Bug 1462613 - Added new task to upload wpt manifest, r=jgraham
Ahilya Sinha <asinha@mozilla.com> - Fri, 18 May 2018 17:16:33 +0530 - rev 797375
Push
110466 by bmo:emilio@crisal.io at Fri, 18 May 2018 23:07:34 +0000
Bug 1462613 - Added new task to upload wpt manifest, r=jgraham
MozReview-Commit-ID: K3D1o62cC3S
266c78fab1d6b9950a0ae2f5fb176cbe37d045ea: Bug 1462477 - Always initialize the value of aOutIsTransformedFixed, even we don't have an image to paint. r=mstange
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 18 May 2018 13:16:42 +1200 - rev 797374
Push
110466 by bmo:emilio@crisal.io at Fri, 18 May 2018 23:07:34 +0000
Bug 1462477 - Always initialize the value of aOutIsTransformedFixed, even we don't have an image to paint. r=mstange
This value is used to determine whether we should create nsDisplayFixedPosition, and if the result changes without an invalidation, then retained-dl gets confused with the insertion/removal of a wrap list.
MozReview-Commit-ID: JuXwCzKOxec