826dc2ff24fba2e7881ded8fa8ba846ce4551fef: bug 1396894 - Don't error out when rendering normally-structured pings r?gfritzsche draft
Chris H-C <chutten@mozilla.com> - Tue, 05 Sep 2017 14:37:06 -0400 - rev 659247
Push 78066 by bmo:chutten@mozilla.com at Tue, 05 Sep 2017 18:39:16 +0000
bug 1396894 - Don't error out when rendering normally-structured pings r?gfritzsche Acceptably-structured pings should render fine in about:telemetry and not trigger the panic mode of "Just show them the JSON!" that happens when an exception is thrown. Two things caught here: 1: Environment section without addon subsection 2: subsection searches MozReview-Commit-ID: 3Z0hud23XuD
5408a34a01f9d7cf6a3f21b208448656a5a1737e: Bug 1385713 - Library icon direction on the main toolbar is inconsistent with the one on the menu on RTL builds r?jaws draft
Tomer Cohen <tomer@tomercohen.com> - Sun, 30 Jul 2017 20:30:12 +0300 - rev 659246
Push 78065 by bmo:gijskruitbosch+bugs@gmail.com at Tue, 05 Sep 2017 18:28:21 +0000
Bug 1385713 - Library icon direction on the main toolbar is inconsistent with the one on the menu on RTL builds r?jaws MozReview-Commit-ID: G62Bg9jGkN
bd4313c911cabb4efb0df68c0907c17ef6d86369: Bug 1396211 - Use mozIntl for dates in aboutTelemetry.js, clean up unused code r?chutten draft
Francesco Lodolo (:flod) <flod@lodolo.net> - Sat, 02 Sep 2017 12:00:25 +0200 - rev 659245
Push 78064 by bmo:francesco.lodolo@gmail.com at Tue, 05 Sep 2017 18:22:08 +0000
Bug 1396211 - Use mozIntl for dates in aboutTelemetry.js, clean up unused code r?chutten MozReview-Commit-ID: KdUDzYNQqvD
b295df5c0af5afa6f34405bb5f53aec34820ed6b: Bug 1362382 - Move RegisterDragDrop to be called during idle time, if possible draft
Kirk Steuber <ksteuber@mozilla.com> - Wed, 30 Aug 2017 11:18:25 -0700 - rev 659244
Push 78063 by ksteuber@mozilla.com at Tue, 05 Sep 2017 18:20:55 +0000
Bug 1362382 - Move RegisterDragDrop to be called during idle time, if possible Additionally, do not call RegisterDragDrop for hidden windows. MozReview-Commit-ID: Fv8j9FntGGT
74cd7cbcea5e263658a034a21d2e4c536cc81ef4: Bug 1271998 - Part 4 - Use a touch delegate to increase the clickable area of the URL bar. r?walkingice,jwu draft
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 29 Aug 2017 20:34:17 +0200 - rev 659243
Push 78062 by mozilla@buttercookie.de at Tue, 05 Sep 2017 18:20:38 +0000
Bug 1271998 - Part 4 - Use a touch delegate to increase the clickable area of the URL bar. r?walkingice,jwu Originally, the listeners that trigger editing mode and the URL bar's context menu were attached to the BrowserToolbar itself. As this doesn't work properly in conjunction with wrapping the URL TextView into a ScrollView, the listeners were moved onto the TextView itself. Bug 1389164 reduced the height of the TextView in order to better support lightweight themes with the new toolbar design, which in conjunction with the changes to support the ScrollView has the unfortunate side effect of also reducing the URL bar's hit target area. Therefore, we increase it back to its old levels by using a TouchDelegate on the ScrollView. Because Android's ScrollView implementation doesn't support TouchDelegates, we have to add the missing bits of logic back in from the default View implementation. MozReview-Commit-ID: 1nTrrNGvBza
b89f3e004db350d5b740f36c708482bb8ce52c18: Bug 1271998 - Part 3 - Scroll the URL to focus the origin for overlength URLs. r?walkingice,jwu draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 24 Aug 2017 22:09:56 +0200 - rev 659242
Push 78062 by mozilla@buttercookie.de at Tue, 05 Sep 2017 18:20:38 +0000
Bug 1271998 - Part 3 - Scroll the URL to focus the origin for overlength URLs. r?walkingice,jwu If the domain is long enough that it doesn't fully fit within the URL bar, we scroll it such that the end of the domain aligns with the right side of the URL bar, taking any possible fadingEdge effect into account. That way, we always try to show as much of the most important part of the origin as possible. Chrome uses a similar approach, although their URL bar neither fades nor allows scrolling. MozReview-Commit-ID: Ep4H4kO4MRH
9e97442cdf91a20486f5d09841a90b6e45eab83b: Bug 1271998 - Part 2 - Make our URL bar scrollable. r?walkingice,jwu draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 27 Aug 2017 17:31:13 +0200 - rev 659241
Push 78062 by mozilla@buttercookie.de at Tue, 05 Sep 2017 18:20:38 +0000
Bug 1271998 - Part 2 - Make our URL bar scrollable. r?walkingice,jwu Limited space for URLs on mobile browsers has given rise to a class of phishing attacks that rely on a carefully crafted URL with a long subdomain being cut off such as to give the impression of another, legitimate URL [1]. We've experimented in the past with avoiding this by showing only the base domain or the EV certificate owner, but had to revert to the old behaviour because of users complaining about not being able to see as much of the URL as formerly possible. Making the displayed URL scrollable is therefore a nice solution: It allows us to choose the initial scroll position such as to put the focus on the base domain, while giving users the freedom to easily view all the rest of the URL without having to enter editing mode. To make the URL scrollable, we wrap the TextView with a HorizontalScrollView. Alternatively, it would have been possible to use a ScrollingMovementMethod with the TextView, however that way - flinging the text doesn't work out of the box - dragging the text around is still detected as a normal long-press as well and triggers the context menu [1]. E.g. https://manage-myaccount.paypal.com-webapps.verifcheck.com/signin/ (see https://twitter.com/ericlaw/status/900429796240277504 for an example screenshot). MozReview-Commit-ID: LPEXQA2kBvD
79a5527aa40d1da45e25dc15843bf47cc76457b7: Bug 1271998 - Part 1 - Provide a ScrollView with a more efficient fadingEdge implementation. r?walkingice,jwu draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 31 Aug 2017 20:06:33 +0200 - rev 659240
Push 78062 by mozilla@buttercookie.de at Tue, 05 Sep 2017 18:20:38 +0000
Bug 1271998 - Part 1 - Provide a ScrollView with a more efficient fadingEdge implementation. r?walkingice,jwu Our previous iteration of a more efficient fadingEdge implementation in FadedMultiColorTextView works by blending the text with a chosen colour. By choosing the same colour as the parent view onto which the TextView is placed, it was thus possible to achieve the impression of fading. With our new URL bar design this is no longer possible quite as easily, since the image used for a lightweight theme will now be displayed behind the URL itself as well. Since the implementation would have also needed more work to make it compatible with scrolling text or being placed in a ScrollView anyway, the fading effect is now achieved directly via the ScrollView instead. Android's built-in fadingEdge implementation calls Canvas.saveLayer (with CLIP_TO_LAYER_SAVE_FLAG omitted!) during a View's onDraw in order to fade out the contents of its children while preserving the background provided by its parents. This saveLayer call is rather expensive and is quite noticeable on a GPU profile even today. Therefore, we implement a more efficient variety of fadingEdges that paints over its children's content in onDrawForeground. To avoid any background content from being faded out, the whole view then has to be placed on a separate layer, however this is still much more efficient than calling Canvas.saveLayer and doesn't show up noticeably in a GPU profile. Prior to Marshmallow, onDrawForeground is not available, so we have to override draw instead in order to be able to paint over the content drawn by the ScrollView's descendants. This means that e.g. scrollbars would be faded out as well, but as we don't intend on showing a scrollbar within the context of this bug, it is an acceptable compromise. MozReview-Commit-ID: DCDPt6ogs0h
c18ce3c96c7c8848d29b60492adc1b291402230e: Bug 1271998 - Part 0 - Clean up imports. r? draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 27 Aug 2017 19:58:16 +0200 - rev 659239
Push 78062 by mozilla@buttercookie.de at Tue, 05 Sep 2017 18:20:38 +0000
Bug 1271998 - Part 0 - Clean up imports. r? MozReview-Commit-ID: 5y5C77jFYUg
c72365165e558d8106278b42d6ca0cb1c867b8cd: Local Gradle tweaks draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 28 Jul 2016 20:04:34 +0200 - rev 659238
Push 78062 by mozilla@buttercookie.de at Tue, 05 Sep 2017 18:20:38 +0000
Local Gradle tweaks MozReview-Commit-ID: H5pdKja8p2a
106d50b7452f466f57de67e488d070f7427b6232: Hobbesfox draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 12 Aug 2017 22:07:29 +0200 - rev 659237
Push 78062 by mozilla@buttercookie.de at Tue, 05 Sep 2017 18:20:38 +0000
Hobbesfox MozReview-Commit-ID: JVp98nUnBMo
e28d02c013df906d60f010dabf5c35db37f0b5e6: Bug 1396927 - Switch Diec2 (Catalan) search plugin to https r?mkaply draft
Francesco Lodolo (:flod) <flod@lodolo.net> - Tue, 05 Sep 2017 20:09:19 +0200 - rev 659236
Push 78061 by bmo:francesco.lodolo@gmail.com at Tue, 05 Sep 2017 18:10:06 +0000
Bug 1396927 - Switch Diec2 (Catalan) search plugin to https r?mkaply MozReview-Commit-ID: 7JWJhqCvRJV
1271bcb18f5d00ccbc22c345bf51e64dfe13b17f: Bug 1396930: Fix typo in partial update histogram description. r=rstrong draft
Chris AtLee <catlee@mozilla.com> - Tue, 05 Sep 2017 14:06:28 -0400 - rev 659235
Push 78060 by catlee@mozilla.com at Tue, 05 Sep 2017 18:07:53 +0000
Bug 1396930: Fix typo in partial update histogram description. r=rstrong MozReview-Commit-ID: 4utiTEgGqSj
b0b53dd19e1b436a6424dbd074f392288234c75f: Bug 1353013 - Be less aggressive about preloading about:newtab. r?florian draft
Mike Conley <mconley@mozilla.com> - Thu, 24 Aug 2017 15:23:18 -0700 - rev 659234
Push 78059 by mconley@mozilla.com at Tue, 05 Sep 2017 18:01:41 +0000
Bug 1353013 - Be less aggressive about preloading about:newtab. r?florian Based on a patch that Dão Gottwald <dao+bmo@mozilla.com> wrote. We used to preload about:newtab as soon as a tab had finished being opened, which meant that the first opened tab was _never_ preloaded, and that we risked janking the browser immediately after the user opened a new tab (which is, arguably, the worst time to do it, since the user is probably about to navigate that tab somewhere). This patch makes it so that about:newtab is preloaded after: 1) 1 second of user inactivity, and 2) When we have at least 40ms of idle time to spend in an idle callback. The 1s and 40ms thresholds were chosen arbitrarily, and we might tune them over time. MozReview-Commit-ID: J5xkPQvCdW6
973e8b890a62aee4b3170558ac3b608928162ef6: No bug, Automated HPKP preload list update from host bld-linux64-spot-307 - a=hpkp-update
ffxbld - Tue, 05 Sep 2017 10:36:00 -0700 - rev 659233
Push 78059 by mconley@mozilla.com at Tue, 05 Sep 2017 18:01:41 +0000
No bug, Automated HPKP preload list update from host bld-linux64-spot-307 - a=hpkp-update
e0fa99cd1bbdf06d18cfe5a55b048a1332357ec9: No bug, Automated HSTS preload list update from host bld-linux64-spot-307 - a=hsts-update
ffxbld - Tue, 05 Sep 2017 10:35:56 -0700 - rev 659232
Push 78059 by mconley@mozilla.com at Tue, 05 Sep 2017 18:01:41 +0000
No bug, Automated HSTS preload list update from host bld-linux64-spot-307 - a=hsts-update
0e73aca9498d177068cfd547710bbd7353373f69: Bug 1393565 - De-duplicate the JS code and CSS that sets the bookmark and pocket library animation. r?gijs draft
Jared Wein <jwein@mozilla.com> - Wed, 30 Aug 2017 15:58:24 -0400 - rev 659231
Push 78058 by bmo:jaws@mozilla.com at Tue, 05 Sep 2017 18:00:21 +0000
Bug 1393565 - De-duplicate the JS code and CSS that sets the bookmark and pocket library animation. r?gijs MozReview-Commit-ID: Z1kIdrY2Um
701ee7fdecbfdef000b91c30a93a0425282fc1d9: Bug 1290948 - Part 7: Update existing mochitests to track the spec fixes in previous parts. r?drno draft
Byron Campen [:bwc] <docfaraday@gmail.com> - Wed, 23 Aug 2017 16:16:29 -0500 - rev 659230
Push 78057 by bcampen@mozilla.com at Tue, 05 Sep 2017 17:47:51 +0000
Bug 1290948 - Part 7: Update existing mochitests to track the spec fixes in previous parts. r?drno MozReview-Commit-ID: 95YyFm3cRB6
ff86dc44c1a4c7e06c648f9326ff7edd006a7188: Bug 1290948 - Part 6: Remove some unused code. r?drno draft
Byron Campen [:bwc] <docfaraday@gmail.com> - Wed, 23 Aug 2017 16:15:11 -0500 - rev 659229
Push 78057 by bcampen@mozilla.com at Tue, 05 Sep 2017 17:47:51 +0000
Bug 1290948 - Part 6: Remove some unused code. r?drno MozReview-Commit-ID: G1uxg77wO78
b2918c3994a099acedb2a9b00b84d3292769d981: Bug 1290948 - Part 5: TransceiverImpl and some major refactoring. r?drno draft
Byron Campen [:bwc] <docfaraday@gmail.com> - Wed, 23 Aug 2017 16:12:43 -0500 - rev 659228
Push 78057 by bcampen@mozilla.com at Tue, 05 Sep 2017 17:47:51 +0000
Bug 1290948 - Part 5: TransceiverImpl and some major refactoring. r?drno MozReview-Commit-ID: 3IBAch7xVNG
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip