81e7b20e4ab6b3f37c87c1ef68cf6de6c22f8e78: Bug 1329797, part 3 - Convert BackgroundParent::Alloc to use Endpoint and return a bool. r=billm draft
Andrew McCreight <continuation@gmail.com> - Wed, 25 Jan 2017 12:42:18 -0800 - rev 466988
Push 43078 by bmo:continuation@gmail.com at Fri, 27 Jan 2017 00:13:37 +0000
Bug 1329797, part 3 - Convert BackgroundParent::Alloc to use Endpoint and return a bool. r=billm MozReview-Commit-ID: 1ypW8ePkPJC
e836abfa2d76e6a05b3c18b5212ea731d99df39f: Bug 1329797, part 2 - Convert ChildImpl::Alloc to use Endpoint and drop the return value. r=billm draft
Andrew McCreight <continuation@gmail.com> - Tue, 24 Jan 2017 13:58:35 -0800 - rev 466987
Push 43078 by bmo:continuation@gmail.com at Fri, 27 Jan 2017 00:13:37 +0000
Bug 1329797, part 2 - Convert ChildImpl::Alloc to use Endpoint and drop the return value. r=billm MozReview-Commit-ID: tnjRSdUrlq
0f48d09cc0c0511180ec8c3439415eaae5674110: Bug 1329797, part 1 - Remove child opens PBackground from PContent. r=billm draft
Andrew McCreight <continuation@gmail.com> - Tue, 24 Jan 2017 11:49:13 -0800 - rev 466986
Push 43078 by bmo:continuation@gmail.com at Fri, 27 Jan 2017 00:13:37 +0000
Bug 1329797, part 1 - Remove child opens PBackground from PContent. r=billm Also remove various alloc methods that won't be needed any more. MozReview-Commit-ID: 2c5SrCEAGyY
9f35ed8688aa0c76c7cfcbc7924b3c53f301ffef: Bug 1333608 - Package testaddon.xpi during artifact builds. draft
Chris Manchester <cmanchester@mozilla.com> - Thu, 26 Jan 2017 16:10:09 -0800 - rev 466985
Push 43077 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:27 +0000
Bug 1333608 - Package testaddon.xpi during artifact builds. We're already installing the plugin binaries to the objdir, so by packaging the addon during the build we can allow these builds to run tests using the addon. MozReview-Commit-ID: CnzrHXiWQjM
59f24a86d8f68cd5b86562351d4a424d184d6806: Bug 1333608 - Stop naming the testaddon on OSX for the benefit of universal builds. draft
Chris Manchester <cmanchester@mozilla.com> - Thu, 26 Jan 2017 16:10:09 -0800 - rev 466984
Push 43077 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:27 +0000
Bug 1333608 - Stop naming the testaddon on OSX for the benefit of universal builds. We were including toolchain info in the testaddon on OSX so we could separate xpis for universal builds. With universal builds going away, we can stop doing this. MozReview-Commit-ID: 4vqMfKJPGp3
5b1f3d2cf2c90ea3959467eac8fabebe7549638b: Bug 1333608 - Package testaddon.xpi during artifact builds. draft
Chris Manchester <cmanchester@mozilla.com> - Thu, 26 Jan 2017 16:09:43 -0800 - rev 466983
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1333608 - Package testaddon.xpi during artifact builds. We're already installing the plugin binaries to the objdir, so by packaging the addon during the build we can allow these builds to run tests using the addon. MozReview-Commit-ID: CnzrHXiWQjM
79e8f4b748e022474578069a650b79140577b7ba: Bug 1333608 - Stop naming the testaddon on OSX for the benefit of universal builds. draft
Chris Manchester <cmanchester@mozilla.com> - Thu, 26 Jan 2017 16:09:21 -0800 - rev 466982
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1333608 - Stop naming the testaddon on OSX for the benefit of universal builds. We were including toolchain info in the testaddon on OSX so we could separate xpis for universal builds. With universal builds going away, we can stop doing this. MozReview-Commit-ID: 4vqMfKJPGp3
f2911e11cc1fb94511d6dadc91ce2eb94e78f20c: Bug 1322025 - Provide variants of host and target that depend on --help. r?chmanchester draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 17:54:16 +0900 - rev 466981
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1322025 - Provide variants of host and target that depend on --help. r?chmanchester We want to avoid giving --help dependencies to host and target, so that they we don't spawn config.guess and config.sub when running configure --help, and don't need to reach out to the which module to find a suitable shell to execute them. So, when --help is given, we return a fake host/target namespace, and avoid the config.guess/config.sub-invoking code being executed. Then, by giving the --help option to the linter, it can properly find that the config.guess/config.sub-invoking code doesn't need the dependency on --help. This effectively unbreaks configure --help after bug 1313306. MozReview-Commit-ID: Dy5xypQlXV0
8f36a7886e84e7d393b3d67e6b2ff464c9c88188: Bug 1322025 - Allow to combine two DependsFunctions with "|". r?chmanchester draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 17:42:33 +0900 - rev 466980
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1322025 - Allow to combine two DependsFunctions with "|". r?chmanchester Ideally, it would have been better if it were "or", but it's not possible to override "or" in python ; __or__ is for "|". This does feel magic, but it's also shorter than adding something like @depends_any(), and while we're only adding "|" as of this change, we can add other operations such as "&" in the future, or __getattr__ for things like milestone.is_nightly. An alternative form in moz.configure could require the @depends function to be called, e.g. "a() | b()" instead of "a | b", but I'm not particularly convinced that one is less magic than the other. This feature is hooked up such that b is not resolved if a is true, although in practice, it will still be resolved in Sandbox.run... but not when --help is passed. In the long run, the forced resolution of @depends functions will be removed from Sandbox.run. MozReview-Commit-ID: r1PjRMM9Gw
2d11b642c09562c3b622ea2ac30d0909fd3bbfa9: Bug 1322025 - Don't automatically add --help dependencies to CombinedDependsFunctions. r?chmanchester draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 17:10:03 +0900 - rev 466979
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1322025 - Don't automatically add --help dependencies to CombinedDependsFunctions. r?chmanchester Adding those dependencies, retrospectively, only worked around the poor handling of --help requirements by the linter, that we fixed a few commits ago. This is now not necessary anymore. MozReview-Commit-ID: E5IfWek6w98
2f492bc1c7a855af446eb5f797eebf64af0c5a14: Bug 1322025 - Don't wrap the combination function in CombinedDependsFunction. r?chmanchester draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 16:50:29 +0900 - rev 466978
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1322025 - Don't wrap the combination function in CombinedDependsFunction. r?chmanchester Several things were wrong with the wrapping: - the equality test on functions was actually comparing the memoized functions, which have a type memoize, which inherits from dict. So they weren't comparing actual functions, but the dict used to store the cache of their invocation. - each CombinedDependsFunction created for the same combination function used a different wrapped function, so even if the dict problem wasn't there, the equality test still wouldn't work, except if the function wrapping itself was memoized. - the memoization was not particularly useful. Also, for upcoming changes, we'd actually like the combination function to take an iterable instead of a variable argument list, so that items of the iterable can be skipped. MozReview-Commit-ID: KWrqWuYoKtS
56f7b4ae58794b198012d6db684d8acb7e233b6e: Bug 1322025 - Make DependsFunction.func less public. r?chmanchester draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 16:32:03 +0900 - rev 466977
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1322025 - Make DependsFunction.func less public. r?chmanchester We're going to change the function signature for CombinedDependsFunction, so make it visible in the API that the function member is not meant to be used directly. The linter still does, though, because it needs to look in their guts. At the same time, avoid setting DependsFunction names via the function name itself, because in upcoming changes, it will not be modifiable in some cases. MozReview-Commit-ID: AzHnkGCD6is
4aaad7e4e07204e82342e32e4c4aa1735982f0e7: Bug 1322025 - Enforce --help requirement on option's when argument. r?chmanchester draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 14:37:34 +0900 - rev 466976
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1322025 - Enforce --help requirement on option's when argument. r?chmanchester Options with a `when` argument (either directly, or inherited through only_when() or an include) require --help per _value_for_option, but that code path is not exercised during a lint pass. With this change, along the previous one, we now correctly detect that bug 1316957 was not supposed to work as is. MozReview-Commit-ID: LUuMcxS9hT4
add39935b3cc1043f14a00d9db974a6b23067b7f: Bug 1322025 - Enforce --help requirement on indirect dependencies. r?chmanchester draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 14:25:58 +0900 - rev 466975
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1322025 - Enforce --help requirement on indirect dependencies. r?chmanchester Bug 1313306 relaxed the --help dependency requirement in some cases, but while doing so, the requirement was also removed in other, unexpected cases. Specifically, the --help dependency ended up not being required on indirect dependencies that should have had it, had the --help dependency been explicit on the direct dependency. MozReview-Commit-ID: GaHbFx67IfG
7988853558c383e07f8d2db0445e0e5714c079dc: Bug 1256730 - Add Mozilla and Google API files to artifact and cross-osx builds. r=dustin draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Aug 2016 20:03:04 +0900 - rev 466974
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1256730 - Add Mozilla and Google API files to artifact and cross-osx builds. r=dustin MozReview-Commit-ID: FewrBfC2Hc6
1966bd5d0caae8d4e89b1542d2bc1b1395fc6ddd: Bug 1256730 - Fail configure when API key files do not exist or are empty. r=chmanchester draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Aug 2016 18:17:35 +0900 - rev 466973
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1256730 - Fail configure when API key files do not exist or are empty. r=chmanchester MozReview-Commit-ID: DYQi6L9iVaA
9dee74ba6935051a44bc65a4c357fdb6cf6f34ce: Bug 1333516 - Fix windows path for API keys after bug 1294585. r?gps draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 06:48:20 +0900 - rev 466972
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1333516 - Fix windows path for API keys after bug 1294585. r?gps MozReview-Commit-ID: 2TkcNgwIn8A
71ec87a862dad12f0ce026085d175f362075fe40: Bug 1333081 - Avoid using the STL in nsXPCOMGlue.cpp to avoid allocator mismatch on Windows. r=froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 24 Jan 2017 08:44:42 +0900 - rev 466971
Push 43076 by bmo:cmanchester@mozilla.com at Fri, 27 Jan 2017 00:10:07 +0000
Bug 1333081 - Avoid using the STL in nsXPCOMGlue.cpp to avoid allocator mismatch on Windows. r=froydnj MozReview-Commit-ID: 85X7e1IAvHS
082fe5e18531d342befa1674509b63b6d038b436: Bug 1333979 - Adds a check in the WidevineVideoDecoder before shutting down r?cpearce draft
Jay Harris <jharris@mozilla.com> - Fri, 27 Jan 2017 10:54:04 +1300 - rev 466970
Push 43075 by bmo:jharris@mozilla.com at Fri, 27 Jan 2017 00:06:38 +0000
Bug 1333979 - Adds a check in the WidevineVideoDecoder before shutting down r?cpearce DeinitializeDecoder will now only be called if InitializeDecoder has been called first MozReview-Commit-ID: 93WexomWp92
c4520c954f2fbd77d3067fcd09f9a0b987c92722: Bug 1333262 Set notification text unconditionally r?florian draft
Andrew Swan <aswan@mozilla.com> - Mon, 23 Jan 2017 18:07:25 -0800 - rev 466969
Push 43074 by aswan@mozilla.com at Fri, 27 Jan 2017 00:03:33 +0000
Bug 1333262 Set notification text unconditionally r?florian MozReview-Commit-ID: DzzZaKWXrV8
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip