8141b2848c2c01542cdca4f068ebec284cac2889: Bug 1466231 Part 5: Update a wpt reftest to remove its reliance on fitting inline-blocks into a too-narrow space. r=dbaron
Brad Werth <bwerth@mozilla.com> - Wed, 13 Jun 2018 16:56:38 -0700 - rev 807943
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Bug 1466231 Part 5: Update a wpt reftest to remove its reliance on fitting inline-blocks into a too-narrow space. r=dbaron This reftest currently uses a container that is 1 pixel narrower than needed to fit two blocks side-by-side. That's useful for making the first two blocks land on separate lines, but it makes the test rely on the browser forcing the first inline block on a line to fit even if there is no space for it (in this case, the block that should be pushed to the right). MozReview-Commit-ID: IxtOR2yFNn6
2250da9a0dd06a3aeaf7a523a71a942effdd77bb: Bug 1466231 Part 4: Correct the size of an element in a submitted WPT test, that was only passing due to this bug. r=dbaron
Brad Werth <bwerth@mozilla.com> - Tue, 12 Jun 2018 11:28:38 -0700 - rev 807942
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Bug 1466231 Part 4: Correct the size of an element in a submitted WPT test, that was only passing due to this bug. r=dbaron This reftest was submitted by me with an incorrect size for the shape element. It was only passing in Firefox due to a related bug, which is now fixed. The updated size makes this test construct a polygon similar to the one in the shape-outside-polygon-012 test, which was the original intent. MozReview-Commit-ID: CuXe2vTmjS0
012e16dcc677f84d158aa4c47bb2d0ddbdc78c6b: Bug 1466231 Part 3: Change some reftests to expected pass, one with fuzziness. r=dbaron
Brad Werth <bwerth@mozilla.com> - Tue, 12 Jun 2018 14:39:14 -0700 - rev 807941
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Bug 1466231 Part 3: Change some reftests to expected pass, one with fuzziness. r=dbaron MozReview-Commit-ID: 2g6EvOuZqRg
332453c76ec7d09ba10dd1858bbbbc93ef837c4a: Bug 1466231 Part 2: Add a submitted WPT reftest. r=dbaron
Brad Werth <bwerth@mozilla.com> - Wed, 06 Jun 2018 13:21:31 -0700 - rev 807940
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Bug 1466231 Part 2: Add a submitted WPT reftest. r=dbaron MozReview-Commit-ID: 4OtqxvM4Gen
f926e605d5a945b5af0945080f09787f8803402e: Bug 1466231 Part 1: Change nsBlockFrame::PlaceLine to accept an nsFlowAreaRect and update flags if it shrinks the area due to a float. r=dbaron
Brad Werth <bwerth@mozilla.com> - Wed, 06 Jun 2018 12:02:36 -0700 - rev 807939
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Bug 1466231 Part 1: Change nsBlockFrame::PlaceLine to accept an nsFlowAreaRect and update flags if it shrinks the area due to a float. r=dbaron MozReview-Commit-ID: 4stQQfboUl7
e77ceef3485b65252fb67f9fa5a627a39dcae3d7: Bug 1468025 - Define lazy getter for TCPListener in Marionette component. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 09 Jun 2018 18:51:13 +0100 - rev 807938
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Bug 1468025 - Define lazy getter for TCPListener in Marionette component. r=whimboo This patch reorganises imports and getter definitions to match style used elsewhere, and defines TCPListener as a lazy getter. MozReview-Commit-ID: Dq2ufYzVcvE
f189e0da7e193f204a7f962bc2b1796a3cdddcbf: Backed out 3 changesets (bug 1466490) for ESlint failures on test_GeckoView_ScalarSemantics. CLOSED TREE
Cosmin Sabou <csabou@mozilla.com> - Fri, 15 Jun 2018 22:34:01 +0300 - rev 807937
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Backed out 3 changesets (bug 1466490) for ESlint failures on test_GeckoView_ScalarSemantics. CLOSED TREE Backed out changeset 5f13ed9de8a3 (bug 1466490) Backed out changeset 95048dd368eb (bug 1466490) Backed out changeset e3891caf027f (bug 1466490)
5f13ed9de8a3c256e934fdd5fff4cdf712baadac: Bug 1466490 - Add multi-process xpcshell test for scalar semantics. r=Dexter
Jan-Erik Rediger <jrediger@mozilla.com> - Thu, 14 Jun 2018 16:05:27 -0700 - rev 807936
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Bug 1466490 - Add multi-process xpcshell test for scalar semantics. r=Dexter This follows the documentation example: * Scalar deserialization is started * “test” scalar is incremented by “10” by the application -> The operation [test, add, 10] is recorded into the list. * The state of the “test” scalar is loaded off the persistence file, and the value “14” is set. * Deserialization is finished and the pending operations are applied. * The “test” scalar is incremented by “10”, the value is now “24” It does that in both the parent and the content process. MozReview-Commit-ID: FSIkuW2xYjD
95048dd368eb313a9d8952db4a8d2c4f9f5d688f: Bug 1466490 - Extract common test functionality into a header. r=Dexter
Jan-Erik Rediger <jrediger@mozilla.com> - Fri, 15 Jun 2018 09:49:02 -0700 - rev 807935
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Bug 1466490 - Extract common test functionality into a header. r=Dexter MozReview-Commit-ID: 81Gj0FyCBqG
e3891caf027f304b6b9c2a6040edc7053daba8ea: Bug 1466490 - Actually record non-main scalars on the main process after deserialization/recording. r=Dexter
Jan-Erik Rediger <jrediger@mozilla.com> - Thu, 14 Jun 2018 16:03:33 -0700 - rev 807934
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Bug 1466490 - Actually record non-main scalars on the main process after deserialization/recording. r=Dexter MozReview-Commit-ID: HNGq5kVVc3k
d1379e27688ec1fc1e1a072519267c221c4906ca: Bug 1466486 - Apply focus style to devtools selection button. r=nchevobbe
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 15 Jun 2018 10:52:09 -0700 - rev 807933
Push 113251 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 17:42:21 +0000
Bug 1466486 - Apply focus style to devtools selection button. r=nchevobbe The bug 1444793 introduced the focus devtools button style instead of using the outline style. However, devtools selection button didn't use this style. This patch apply the focus style to the devtools selection buttons. MozReview-Commit-ID: DQEDMRSThMr
6ddc19e7dfa16ec3a9586a1d6ec80b0b0a21b6ad: Bug 1344286 - Fix eslint errors from devtools files ignored previously; r?ntim draft
Hemanth Kumar Veeranki <hems.india1997@gmail.com> - Sat, 16 Jun 2018 15:45:58 +0530 - rev 807932
Push 113250 by bmo:hems.india1997@gmail.com at Sat, 16 Jun 2018 10:23:19 +0000
Bug 1344286 - Fix eslint errors from devtools files ignored previously; r?ntim MozReview-Commit-ID: CXVyorSle4l
6238b08a9a24fdd0f790d9453d8efefaf6cf31b8: Bug 1469076: Fix the broken invariants of the rule node cache. r?xidorn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 16 Jun 2018 02:50:28 -0700 - rev 807931
Push 113249 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 10:14:39 +0000
Bug 1469076: Fix the broken invariants of the rule node cache. r?xidorn We were spuriously reframing the <shadow> because it initially shared style with the <br>, which ended up being display: none, while the <shadow> should've been display: contents from the beginning. lookup_by_rules seems pretty prone to obscure bugs, and also it's pretty complex... Probably we should try to get rid of it, I'm unconvinced that it's worth it. Even with that, in a normal restyle the <details> wouldn't have ended up with a style. It of course never had it before the reframe because the <shadow> was display: none, but that doesn't mean it shouldn't have gotten one, since we detected we needed to go through kids in: https://searchfox.org/mozilla-central/rev/6eea08365e7386a2b81c044e7cc8a3daa51d8754/servo/components/style/matching.rs#500 That code did happen, but since it's an animation-only restyle, we don't look at unstyled stuff. That looks somewhat fishy, but I guess for now it's fine as long as display isn't animatable. MozReview-Commit-ID: B6NMSTNOKgK
a18682a0cc01465f80f21d18c385055eee418871: Bug 1422225: Test updates. r?xidorn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 16 Jun 2018 01:34:34 -0700 - rev 807930
Push 113248 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 09:07:13 +0000
Bug 1422225: Test updates. r?xidorn MozReview-Commit-ID: J2tag9ulUon
b12fe122a61a3e288ee0783087f9dddf11675425: Bug 1422225: Evaluate MediaConditions, and glue it all together. r?xidorn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 16 Jun 2018 00:59:04 -0700 - rev 807929
Push 113248 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 09:07:13 +0000
Bug 1422225: Evaluate MediaConditions, and glue it all together. r?xidorn MozReview-Commit-ID: 3MThE2FvfDf
c820fdf5d205ebe1603ed7e8fe754652f584f9a0: Bug 1422225: Add serialization code for MediaCondition. r?xidorn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Jun 2018 23:58:20 -0700 - rev 807928
Push 113248 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 09:07:13 +0000
Bug 1422225: Add serialization code for MediaCondition. r?xidorn MozReview-Commit-ID: AxQQottV1hG
36fc88f554e98b9198c67063f685a97af55e5e77: Bug 1422225: Add code to parse media conditions. r?xidorn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Jun 2018 23:51:07 -0700 - rev 807927
Push 113248 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 09:07:13 +0000
Bug 1422225: Add code to parse media conditions. r?xidorn Still unused. MozReview-Commit-ID: IQfxObw9BV5
724b4b21fb254dec4aa7e986831accadf32cae36: Bug 1422225: Rename Expression to MediaFeatureExpression. r?xidorn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Jun 2018 21:29:57 -0700 - rev 807926
Push 113248 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 09:07:13 +0000
Bug 1422225: Rename Expression to MediaFeatureExpression. r?xidorn Which is more appropriate, given it represents a `<media-feature>` per spec, and expression is a bit overloaded :) MozReview-Commit-ID: Fed1nJhHxDu
ecd7bad5ba4bc2a769777e40d722517bdc8f95e7: Bug 1422225: Allow parsing operators in media feature expressions. r?xidorn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Jun 2018 21:23:50 -0700 - rev 807925
Push 113248 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 09:07:13 +0000
Bug 1422225: Allow parsing operators in media feature expressions. r?xidorn The only bit from the spec which I haven't implemented to my knowledge is the bit that allows you to swap the position of the media feature and the value, because it unnecessarily complicates parsing (we parse the value in terms of the feature), and I don't think it's useful given how easy it is to switch from, e.g., `(500px > width)` to `(width <= 500px)`. I filed https://github.com/w3c/csswg-drafts/issues/2791 about it. MozReview-Commit-ID: 6xrdVl87S9X
321c4fd27f5590a942ac8dc91d462ca4ef51e886: HTMLSlotElement::FromNode is a bit of a footgun. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Jun 2018 20:19:45 -0700 - rev 807924
Push 113248 by bmo:emilio@crisal.io at Sat, 16 Jun 2018 09:07:13 +0000
HTMLSlotElement::FromNode is a bit of a footgun. MozReview-Commit-ID: ED9quoYDQAJ
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip