8112153e07938722d989d6079d0e98ca3cedbac4: Bug 1353074 - Use tuples for script arguments; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Mon, 03 Apr 2017 19:14:16 +0100 - rev 558288
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1353074 - Use tuples for script arguments; r=maja_zf The Python standard library uses tuples to define arguments for functions, whenever they are invoked through meta programming. The Marionette client only allows the list type for backwards compatibility, so we prefer tuples in this case. Another good argument for tuples is that tuples are immutable. MozReview-Commit-ID: 72zPzYvBz7Q
2670eec1ed8ab10cb44c7010d996fa28af565442: Bug 1353074 - Make unload event safe for introspection from content; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Mon, 03 Apr 2017 18:36:43 +0100 - rev 558287
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1353074 - Make unload event safe for introspection from content; r=maja_zf Marionette does not protect the unloadHandler in testing/marionette/evaluate.js from content introspection or modification, which can happen when web frameworks override window.addEventListener/window.removeEventListener. The script evaluation module used in Marionette relies on sandbox.window.addEventListener/removeEventListener to throw an error when script execution is aborted due to the document unloading itself. If the window.addEventListener/removeEventListener functions have been overridden to introspect the objects that are passed, they may inadvertently touch objects originating from chrome space, such as the unloadHandler. Because the Gecko sandboxing system put in place strict security measures to prevent accidental chrome-space modification from content, inspecting the unloadHandler will throw a permission denied error once the script has finished executing. We have found examples in the wild of this in particular with the Angular web framework. This patch makes the unloadHandler safe for introspection from web content. Fixes: https://github.com/mozilla/geckodriver/issues/515 MozReview-Commit-ID: E2LgPhLLuDT
4b2f57ec5a584f4c52638cf3024b8a3ddbf88cfe: Backed out changeset f898176c408d (bug 1281278) for xpcshell failures a=backout
Wes Kocher <wkocher@mozilla.com> - Thu, 06 Apr 2017 15:48:18 -0700 - rev 558286
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Backed out changeset f898176c408d (bug 1281278) for xpcshell failures a=backout
5fbd12b4d8e7f48343efa361ab8094ebaf1af6b9: Bug 1344038 - Remove --enable-gnomeui. r=karlt
Mike Hommey <mh+mozilla@glandium.org> - Wed, 08 Mar 2017 15:35:53 +0900 - rev 558285
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1344038 - Remove --enable-gnomeui. r=karlt
91f503f8385118a6f37e2c639a17c43a143e741d: Bug 1344038 - Remove --disable-gio. r=karlt
Mike Hommey <mh+mozilla@glandium.org> - Wed, 05 Apr 2017 14:06:25 +0900 - rev 558284
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1344038 - Remove --disable-gio. r=karlt
7ad4be04d16e0d86508c15c104f9686f2493061a: Bug 1344038 - Move the gio protocol handler under netwerk/protocol. r=chmanchester,karlt
Mike Hommey <mh+mozilla@glandium.org> - Wed, 05 Apr 2017 13:48:52 +0900 - rev 558283
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1344038 - Move the gio protocol handler under netwerk/protocol. r=chmanchester,karlt Historically, we had support for some GNOME VFS protocols through the gnomevfs library, and this was under extension. This may not have been built by default when it was introduced, but GNOME upstream moved those things into Gtk itself, and we then got support for the new Gio-based protocol, similar to what we had through the gnomevfs library. Time passes, and we switched off the gnomevfs library entirely, and enabled the Gio-based protocol handlers by default. We then removed everything related to the gnomevfs library. Fast forward to now, and disabling Gio support in Firefox just doesn't make sense, and leaving the gio protocol handler as an extension doesn't make sense either. As it is a protocol handler, its natural place is under netwerk/protocol, which is where we're moving it here. The netwerk/protocol subdirectories being handled automatically, we don't need to add the moved directory in any DIRS variable.
4b43dc3ad00134dc921acba0f6e1c571dd59d4c1: Bug 1354080 - Stop doing needless work in the parent process every time the refresh driver ticks. r=kats
Mike Conley <mconley@mozilla.com> - Thu, 06 Apr 2017 18:11:34 -0400 - rev 558282
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1354080 - Stop doing needless work in the parent process every time the refresh driver ticks. r=kats When we're animating, we tick the refresh driver. If that occurs in the parent process when e10s is enabled, then we currently run TabParent::DidRefresh which does some dimensions calculations and might send a message to the content process if the dimensions have changed. This was originally added to fix a B2G bug in bug 1153023. We don't need to do it anymore, since we don't set CSS transforms on content browser windows. MozReview-Commit-ID: JJ7AJHlSyWn
bd875ac1b42050e52e857e1c46be1a106f470c3f: Bug 1328758 - Better error messages for tabs.executeScript r=kmag
Tomislav Jovanovic <tomica@gmail.com> - Sun, 02 Apr 2017 01:05:37 +0200 - rev 558281
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1328758 - Better error messages for tabs.executeScript r=kmag MozReview-Commit-ID: PQhltZVepj
afccb72dba235d506af7b989cdc3c8d6aa4d6bb1: Bug 1295700 - Don't allow content processes to access the weave director on macOS r=haik
Alex Gaynor <agaynor@mozilla.com> - Thu, 06 Apr 2017 15:20:23 -0400 - rev 558280
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1295700 - Don't allow content processes to access the weave director on macOS r=haik These directories contain sensitive content, and access is not necessary now that we have file content processes. r=haik MozReview-Commit-ID: FiRJkMnlYUx
05a48259d0732cd1880c6cb82452b740135a6688: Merge m-c to autoland, a=merge
Wes Kocher <wkocher@mozilla.com> - Thu, 06 Apr 2017 15:10:53 -0700 - rev 558279
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Merge m-c to autoland, a=merge
f0792bb960b6e16be5d854366ba81ec2a604052c: Bug 1353493 - Cache the return value for nsIWidget::DefaultScaleOverride(). r=kanru
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Thu, 06 Apr 2017 23:30:09 +0900 - rev 558278
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1353493 - Cache the return value for nsIWidget::DefaultScaleOverride(). r=kanru MozReview-Commit-ID: ExP179bxbHe
b21110aa79591ea6556ca0c9781675ec039e6599: servo: Merge #16289 - Cascade the primary style before matching pseudos (from bholley:primary_before_pseudos); r=emilio
Bobby Holley <bobbyholley@gmail.com> - Thu, 06 Apr 2017 16:32:14 -0500 - rev 558277
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
servo: Merge #16289 - Cascade the primary style before matching pseudos (from bholley:primary_before_pseudos); r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1353960 Source-Repo: https://github.com/servo/servo Source-Revision: 3beaa8d2e98bd077ba8badf4a2e3bc3ddc51ed0e
68a13da9b6f255df1edde21d0ffb4669988a7cec: Bug 1352773 - Take into account DefaultScaleOverride in Screen::GetDefaultCSSScaleFactor. r=kanru
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Wed, 05 Apr 2017 22:11:34 +0900 - rev 558276
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1352773 - Take into account DefaultScaleOverride in Screen::GetDefaultCSSScaleFactor. r=kanru MozReview-Commit-ID: EJidy1NH3DX
a8a2f17897b583db07f5ba53450234b326201567: Bug 1353520 - Better default for environment envs for retriggerable jobs r=gbrown
William Lachance <wlachance@mozilla.com> - Tue, 04 Apr 2017 16:17:17 -0400 - rev 558275
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1353520 - Better default for environment envs for retriggerable jobs r=gbrown Use "MOZ_LOG", which reminds people that mozlog is available. MozReview-Commit-ID: 3h6ARVEUVhT
f898176c408dfbc68ef09fd5e5c8edbd06abb19a: Bug 1281278 - test coverage for h2 push with brotli r=nwgh
Patrick McManus <mcmanus@ducksong.com> - Thu, 06 Apr 2017 13:40:26 -0400 - rev 558274
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1281278 - test coverage for h2 push with brotli r=nwgh MozReview-Commit-ID: 84LZRLsefJD
e1af5dd01c02a31f20cf516322eba9613792d9ef: bug 1354289 - m-c l10n_bumper fixes. r=rail a=release DONTBUILD
Aki Sasaki <asasaki@mozilla.com> - Thu, 06 Apr 2017 13:42:12 -0700 - rev 558273
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
bug 1354289 - m-c l10n_bumper fixes. r=rail a=release DONTBUILD MozReview-Commit-ID: 7jVpr5RPoTy
f8f2cb57530f33c1c34a016b72c346f9ff59b8f6: Bug 1347226 - prevent an error thrown by LightWeightThemeManager when a temporary WebExtension theme addon is installed and make sure it's enabled correctly in the Addon Manager. r=mossop
Mike de Boer <mdeboer@mozilla.com> - Wed, 05 Apr 2017 16:27:25 +0200 - rev 558272
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1347226 - prevent an error thrown by LightWeightThemeManager when a temporary WebExtension theme addon is installed and make sure it's enabled correctly in the Addon Manager. r=mossop This is done by adding a check to LWTManager that ensures only valid LWTs are enabled/ disabled there. The temporary addon install flow never had to deal with addons that would be disabled by default before. Since WebExtension themes are, we need to explicitly set `userDisabled = true`. MozReview-Commit-ID: IkdNAq97cxI
dc314cde29d390514937204a4413181b4a15f9b1: servo: Merge #16284 - Use real clips when generating scroll roots (from mrobinson:scroll-root-clip); r=glennw
Martin Robinson <mrobinson@igalia.com> - Thu, 06 Apr 2017 14:32:16 -0500 - rev 558271
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
servo: Merge #16284 - Use real clips when generating scroll roots (from mrobinson:scroll-root-clip); r=glennw This is the first step toward removing inherited clips in favor of scroll roots for handling overflow and CSS clipping. This will allow us to more easily handle elements that should not be clipped. While we are still using inherited clips here, we now properly clip some types of content that wasn't clipped before. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 24cea409f24135769c4fbedddd0f87da9d7bd12b
9e5803e13afc789154e649f9a3e83622e9e4a124: servo: Merge #16283 - style: Multiple cleanups around parsing code (from emilio:cleanup-parse-non-negative); r=Wafflespeanut
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 Apr 2017 13:57:40 -0500 - rev 558270
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
servo: Merge #16283 - style: Multiple cleanups around parsing code (from emilio:cleanup-parse-non-negative); r=Wafflespeanut Source-Repo: https://github.com/servo/servo Source-Revision: 208d5dbfb6d8d9eed5ee5f5f21641221fe16e819
4c06dea25ef7ddb7c6bcfa5be2c3d7b56240be60: Bug 1350001 - Run cargo in a clean environment when running in a MozillaBuild shell. r=ted
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 06 Apr 2017 09:59:14 -0400 - rev 558269
Push 52860 by bmo:walkingice0204@gmail.com at Fri, 07 Apr 2017 13:29:26 +0000
Bug 1350001 - Run cargo in a clean environment when running in a MozillaBuild shell. r=ted This prevents the variables set in vcvars.bat from causing build failures when cargo tries to process build scripts in an environment where the default rust toolchain doesn't match the MozillaBuild shell (in terms of 32-bit or 64-bit). MozReview-Commit-ID: 5VRnQToYUYf
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip