809036cfd7d9caa8f384efc5cfffd236c337c8a8: Bug 1364364 - Part 5.2: Remove browser.sessionhistory.cache_subframes and fix test cases relying on it. r=smaug
Samael Wang <freesamael@gmail.com> - Tue, 05 Sep 2017 16:02:04 +0800 - rev 662577
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1364364 - Part 5.2: Remove browser.sessionhistory.cache_subframes and fix test cases relying on it. r=smaug browser.sessionhistory.cache_subframes has been disabled for 12yrs. It's not actually maintained and it leaks content viewers. Using this unreliable feature in test cases is a bad practice, so remove the pref completely and fix existing test cases. MozReview-Commit-ID: 3tQLpsqmmaq
c394b06dc30c91f0e465d28351255e656c3286b5: Bug 1364364 - Part 5.1: Rename frame/iframe.html of to-be-modifed test cases. r=smaug
Samael Wang <freesamael@gmail.com> - Tue, 05 Sep 2017 15:57:21 +0800 - rev 662576
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1364364 - Part 5.1: Rename frame/iframe.html of to-be-modifed test cases. r=smaug Since git lacks of native rename command, git-cinnabar can only recognize and convert plain mv to hg rename, so I need a separated patch for renaming. MozReview-Commit-ID: 4M6n5wIWoFl
c5a737bbfdebce7fcf3472047bc118aac955dc08: Bug 1364364 - Part 4: Add test case. r=smaug
Samael Wang <freesamael@gmail.com> - Wed, 30 Aug 2017 17:00:12 +0800 - rev 662575
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1364364 - Part 4: Add test case. r=smaug MozReview-Commit-ID: BozQDPdx0MI
21ee8f318a478dc0e8210710d95e9f03f1dff683: Bug 1364364 - Part 3: Clear dynamic subframe entries in RemoveFromBFCacheSync/Async. r=smaug
Samael Wang <freesamael@gmail.com> - Thu, 24 Aug 2017 15:17:39 +0800 - rev 662574
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1364364 - Part 3: Clear dynamic subframe entries in RemoveFromBFCacheSync/Async. r=smaug MozReview-Commit-ID: F8OTxbWIp5O
074475da0f2ca66b29b9a26dd40067938f7191ce: Bug 1364364 - Part 2: Extract a part of EvictExpiredContentViewerForEntry to a new function FindTransactionForBFCache, and implement RemoveDynEntriesForEntry on top of it. r=smaug
Samael Wang <freesamael@gmail.com> - Thu, 24 Aug 2017 14:32:23 +0800 - rev 662573
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1364364 - Part 2: Extract a part of EvictExpiredContentViewerForEntry to a new function FindTransactionForBFCache, and implement RemoveDynEntriesForEntry on top of it. r=smaug MozReview-Commit-ID: EzK2U0c94v8
de6c153ec533cd99d2f6bf6ea998e88e0c7d9188: Bug 1364364 - Part 1: Why are we declaring private virtual functions? r=smaug
Samael Wang <freesamael@gmail.com> - Thu, 24 Aug 2017 11:27:11 +0800 - rev 662572
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1364364 - Part 1: Why are we declaring private virtual functions? r=smaug MozReview-Commit-ID: KQxFTrEO1aq
52e22eaebe72688c17dbc9f41aaf84ae3fb94533: Bug 1351511 - Support nsDisplaySolidColorRegion to WR DisplayItems r=mstange
Chih-Yi Leu <subsevenx2001@gmail.com> - Tue, 15 Aug 2017 16:58:47 +0800 - rev 662571
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1351511 - Support nsDisplaySolidColorRegion to WR DisplayItems r=mstange MozReview-Commit-ID: LMs5ON8NC2p
c064f73753411327b8e037be8f51b3288f323728: Bug 1398712 - update Coverity modelling file in order to support NS_PRECONDITION. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Mon, 11 Sep 2017 14:55:37 +0300 - rev 662570
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1398712 - update Coverity modelling file in order to support NS_PRECONDITION. r=sylvestre MozReview-Commit-ID: 3CzHJkjrikI
cdd9f6610d88cffa99941c814c8c817e58e2ab37: Bug 1355735 - Add util to pick name for default browser r=jwu
Julian_Chu <walkingice0204@gmail.com> - Sat, 09 Sep 2017 00:47:44 +0800 - rev 662569
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1355735 - Add util to pick name for default browser r=jwu The util PackageUtil helps to get ResolveInfo of default browser, then we can use it in CustomTabs menu. If user hasn't set any default browser, instead we display "..." for browser name. MozReview-Commit-ID: 6DkFkZ8Ovzq
994883c61ef580925e5669360a4bb619886f9615: servo: Merge #18372 - TEST: fix and add case of po-observe.any.js (from tigercosmos:userTimingApi); r=ferjm
tigercosmos <b04209032@ntu.edu.tw> - Mon, 11 Sep 2017 05:26:46 -0500 - rev 662568
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
servo: Merge #18372 - TEST: fix and add case of po-observe.any.js (from tigercosmos:userTimingApi); r=ferjm <!-- Please describe your changes on the following line: --> 1. implementing step 3 from the [`PerformanceObserver.observe()`](https://w3c.github.io/performance-timeline/#dom-performanceobserver-observe()) method spec properly. 2. also add cases about step 1 & 2 work on the top of #18283 r? @ferjm --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18285 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 6a09b1d21abd66d6954d8107f4439c33054ee264
629ebf9fa7259fc0a4e7ea4dbf62f88d61ccb105: servo: Merge #18429 - style: Remove a few uses of ComputedValueAsSpecified (from emilio:cvas-die); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Sep 2017 04:31:10 -0500 - rev 662567
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
servo: Merge #18429 - style: Remove a few uses of ComputedValueAsSpecified (from emilio:cvas-die); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: 7fc2c435513feadf1dc666e7873095884dfd6d84
4e34fdb8b3ff80c1518c68f4626f6eb5d5ef93c4: Bug 1398450 - Fix prefs test regression. r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 09 Sep 2017 16:58:54 +0100 - rev 662566
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1398450 - Fix prefs test regression. r=jgraham The marionette.defaultPrefs.port preference was changed to marionette.port, but because we currently do not run tests in CI we missed updating the test. MozReview-Commit-ID: LKstRYmJcMO
0f9e4072dbf82fb750bc0adbcfc093f3e50cdf7b: Bug 1396465 - Make onboarding images smaller. r=jwu
Nevin Chen <cnevinchen@gmail.com> - Mon, 04 Sep 2017 10:16:05 +0800 - rev 662565
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1396465 - Make onboarding images smaller. r=jwu MozReview-Commit-ID: LKFOlBd5bdv
8be3c451ff86b00894d66754f1975b8343440abd: Bug 1382369 - stylo: store specified value of grid layout repeat() function. Tests. r=mats
Fernando Jimenez Moreno <ferjmoreno@gmail.com> - Mon, 11 Sep 2017 11:30:04 +0200 - rev 662564
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1382369 - stylo: store specified value of grid layout repeat() function. Tests. r=mats
ecae1c71816b6d2aa21e520cb444f2cefb21ff91: Bug 1271998 - Part 4 - Use a touch delegate to increase the clickable area of the URL bar. r=jwu
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 29 Aug 2017 20:34:17 +0200 - rev 662563
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1271998 - Part 4 - Use a touch delegate to increase the clickable area of the URL bar. r=jwu Originally, the listeners that trigger editing mode and the URL bar's context menu were attached to the BrowserToolbar itself. As this doesn't work properly in conjunction with wrapping the URL TextView into a ScrollView, the listeners were moved onto the TextView itself. Bug 1389164 reduced the height of the TextView in order to better support lightweight themes with the new toolbar design, which in conjunction with the changes to support the ScrollView has the unfortunate side effect of also reducing the URL bar's hit target area. Therefore, we increase it back to its old levels by using a TouchDelegate on the ScrollView. Because Android's ScrollView implementation doesn't support TouchDelegates, we have to add the missing bits of logic back in from the default View implementation. MozReview-Commit-ID: 1nTrrNGvBza
953adb3e5e838f53df4a3a590a40b4c6f2c62949: Bug 1271998 - Part 3 - Scroll the URL to focus the origin for overlength URLs. r=jwu
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 24 Aug 2017 22:09:56 +0200 - rev 662562
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1271998 - Part 3 - Scroll the URL to focus the origin for overlength URLs. r=jwu If the domain is long enough that it doesn't fully fit within the URL bar, we scroll it such that the end of the domain aligns with the right side of the URL bar, taking any possible fadingEdge effect into account. That way, we always try to show as much of the most important part of the origin as possible. Chrome uses a similar approach, although their URL bar neither fades nor allows scrolling. MozReview-Commit-ID: Ep4H4kO4MRH
c8aa9b29b27834382b0b9ce67114927c2f348925: Bug 1271998 - Part 2 - Make our URL bar scrollable. r=jwu
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 27 Aug 2017 17:31:13 +0200 - rev 662561
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1271998 - Part 2 - Make our URL bar scrollable. r=jwu Limited space for URLs on mobile browsers has given rise to a class of phishing attacks that rely on a carefully crafted URL with a long subdomain being cut off such as to give the impression of another, legitimate URL [1]. We've experimented in the past with avoiding this by showing only the base domain or the EV certificate owner, but had to revert to the old behaviour because of users complaining about not being able to see as much of the URL as formerly possible. Making the displayed URL scrollable is therefore a nice solution: It allows us to choose the initial scroll position such as to put the focus on the base domain, while giving users the freedom to easily view all the rest of the URL without having to enter editing mode. To make the URL scrollable, we wrap the TextView with a HorizontalScrollView. Alternatively, it would have been possible to use a ScrollingMovementMethod with the TextView, however that way - flinging the text doesn't work out of the box - dragging the text around is still detected as a normal long-press as well and triggers the context menu [1]. E.g. https://manage-myaccount.paypal.com-webapps.verifcheck.com/signin/ (see https://twitter.com/ericlaw/status/900429796240277504 for an example screenshot). MozReview-Commit-ID: LPEXQA2kBvD
fe02dfd16dc37b13888abd56e279b2d5b08a8d9e: Bug 1271998 - Part 1 - Provide a ScrollView with a more efficient fadingEdge implementation. r=jwu
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 31 Aug 2017 20:06:33 +0200 - rev 662560
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1271998 - Part 1 - Provide a ScrollView with a more efficient fadingEdge implementation. r=jwu Our previous iteration of a more efficient fadingEdge implementation in FadedMultiColorTextView works by blending the text with a chosen colour. By choosing the same colour as the parent view onto which the TextView is placed, it was thus possible to achieve the impression of fading. With our new URL bar design this is no longer possible quite as easily, since the image used for a lightweight theme will now be displayed behind the URL itself as well. Since the implementation would have also needed more work to make it compatible with scrolling text or being placed in a ScrollView anyway, the fading effect is now achieved directly via the ScrollView instead. Android's built-in fadingEdge implementation calls Canvas.saveLayer (with CLIP_TO_LAYER_SAVE_FLAG omitted!) during a View's onDraw in order to fade out the contents of its children while preserving the background provided by its parents. This saveLayer call is rather expensive and is quite noticeable on a GPU profile even today. Therefore, we implement a more efficient variety of fadingEdges that paints over its children's content in onDrawForeground. To avoid any background content from being faded out, the whole view then has to be placed on a separate layer, however this is still much more efficient than calling Canvas.saveLayer and doesn't show up noticeably in a GPU profile. Prior to Marshmallow, onDrawForeground is not available, so we have to override draw instead in order to be able to paint over the content drawn by the ScrollView's descendants. This means that e.g. scrollbars would be faded out as well, but as we don't intend on showing a scrollbar within the context of this bug, it is an acceptable compromise. MozReview-Commit-ID: DCDPt6ogs0h
d509047f7935f8cdd4f5bad571c52966fa95ba3b: Bug 1271998 - Part 0 - Clean up imports. r=JanH
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 27 Aug 2017 19:58:16 +0200 - rev 662559
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
Bug 1271998 - Part 0 - Clean up imports. r=JanH MozReview-Commit-ID: 5y5C77jFYUg
064df3f608f52f4cd3287b1bf392b8a1b1403e04: servo: Merge #18206 - stylo: store specified value of grid layout repeat() function (from ferjm:bug1382369.grid.repeat.function); r=wafflespeanut
Fernando Jiménez Moreno <ferjmoreno@gmail.com> - Mon, 11 Sep 2017 02:32:38 -0500 - rev 662558
Push 79127 by kgupta@mozilla.com at Mon, 11 Sep 2017 21:06:14 +0000
servo: Merge #18206 - stylo: store specified value of grid layout repeat() function (from ferjm:bug1382369.grid.repeat.function); r=wafflespeanut - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [Bug 1382369](https://bugzilla.mozilla.org/show_bug.cgi?id=1382369) Source-Repo: https://github.com/servo/servo Source-Revision: 8129cf5563ba91f420f51a09cff9d9a317683ba6
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip