7f91cdb13b55a8a07c646a1dcf64388e988f93b2: Bug 1277978 - Part 4 - Actually cache the recent tabs count when it updates. r=liuche
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 20 Aug 2016 18:23:41 +0200 - rev 409703
Push
28519 by mozilla@buttercookie.de at Sun, 04 Sep 2016 13:51:35 +0000
Bug 1277978 - Part 4 - Actually cache the recent tabs count when it updates. r=liuche
MozReview-Commit-ID: JUsM3qdxhIr
0992680112099e1d8deb65740bb4115712c9a725: Bug 1277978 - Part 3 - Allow the RecentTabsAdapter to indicate whether the tab count is reliable. r=liuche
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 20 Aug 2016 17:49:34 +0200 - rev 409702
Push
28519 by mozilla@buttercookie.de at Sun, 04 Sep 2016 13:51:35 +0000
Bug 1277978 - Part 3 - Allow the RecentTabsAdapter to indicate whether the tab count is reliable. r=liuche
After we've set the cached tabs count to display within the history adapter, we don't want to revise that number downwards as long as the RecentTabsAdapter hasn't yet checked all of its data sources.
MozReview-Commit-ID: BMpiaEb3kGQ
146d00ace3ab1909657dd41bf7464e10e9bb47ae: Bug 1277978 - Part 2 - Allow saving a cached recent tabs count in BrowserApp. r=liuche
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 29 Aug 2016 20:03:12 +0200 - rev 409701
Push
28519 by mozilla@buttercookie.de at Sun, 04 Sep 2016 13:51:35 +0000
Bug 1277978 - Part 2 - Allow saving a cached recent tabs count in BrowserApp. r=liuche
Getting the total number of recently closed tabs involves waiting for Gecko to actually send the closed tabs to the Java UI. This means that (unless there are some "Tabs from last time" present) when showing the history panel we always start out with the Recently closed folder hidden and then unhide (and animate) it once we've finally received the closed tabs.
Because this is visually distracting, we should cache the closed tabs count somewhere, so we can decide on the smart folder visibility as soon as the CombinedHistoryAdapter initialises.
MozReview-Commit-ID: 8uYCbM7eiSt
fd48896a8d9d2a6b90720ccb4c7ad1b3cbea2d56: Bug 1277978 - Part 1 - Hide Recent Tabs smart folder if there aren't any closed tabs to be shown. r=liuche
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 04 Sep 2016 15:16:20 +0200 - rev 409700
Push
28519 by mozilla@buttercookie.de at Sun, 04 Sep 2016 13:51:35 +0000
Bug 1277978 - Part 1 - Hide Recent Tabs smart folder if there aren't any closed tabs to be shown. r=liuche
This involves making the number of visible smart folders dynamic, so the history adapter can properly display its contents.
MozReview-Commit-ID: 6b4V6IHB7BE
377dc1450522997393005e563f12dce7f4396778: Bug 1271765 - Desktop video control visual refresh. r?jaws
draft
Ray Lin <ralin@mozilla.com> - Tue, 09 Aug 2016 15:45:24 +0800 - rev 409699
Push
28518 by bmo:ralin@mozilla.com at Sun, 04 Sep 2016 13:45:03 +0000
Bug 1271765 - Desktop video control visual refresh. r?jaws
MozReview-Commit-ID: 1GfyGmrhgCs
e9ca1d928e35ae987bf3265408b48f04620badf5: Bug 1299070 - Merge all startup strings in startup.properties;r=bgrins
Julian Descottes <jdescottes@mozilla.com> - Fri, 02 Sep 2016 17:45:22 +0200 - rev 409698
Push
28517 by jdescottes@mozilla.com at Sun, 04 Sep 2016 12:30:27 +0000
Bug 1299070 - Merge all startup strings in startup.properties;r=bgrins
MozReview-Commit-ID: 99zWNTHid21
7aaba7598abbdb64c0f0e48f3ba26c1a659008e4: Bug 1299070 - Move l10n.ELLIPSIS behind getter;r=bgrins
Julian Descottes <jdescottes@mozilla.com> - Thu, 01 Sep 2016 16:26:09 +0200 - rev 409697
Push
28517 by jdescottes@mozilla.com at Sun, 04 Sep 2016 12:30:27 +0000
Bug 1299070 - Move l10n.ELLIPSIS behind getter;r=bgrins
This avoids loading the ellipsis properties file on browser startup.
MozReview-Commit-ID: 8lfAeltfn10
e89e35de316467fa16035fb61907b26680e68e1b: Bug 1300337 - Replace None_ variants from nsStyleConsts.h with None; r?heycam
draft
Manish Goregaokar <manishsmail@gmail.com> - Sun, 04 Sep 2016 00:16:58 +0530 - rev 409696
Push
28516 by bmo:manishearth@gmail.com at Sun, 04 Sep 2016 11:49:01 +0000
Bug 1300337 - Replace None_ variants from nsStyleConsts.h with None; r?heycam
MozReview-Commit-ID: CxHzbEzjLxT
eeb5f0911a6503ca702d69bbd8506a342e0aad97: Bug 1300296: P2. Don't rely on MP4 container to properly report if a frame is a keyframe. r?kentuckyfriedtakahe
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 04 Sep 2016 21:33:23 +1000 - rev 409695
Push
28515 by bmo:jyavenard@mozilla.com at Sun, 04 Sep 2016 11:48:34 +0000
Bug 1300296: P2. Don't rely on MP4 container to properly report if a frame is a keyframe. r?kentuckyfriedtakahe
There are too many cases where the MP4 is improperly muxed and frames are incorrectly reported as keyframe.
Instead we now look inside the H264 stream and check for IDR frames.
We also ensure that the first frame returned after a seek or reset is always a keyframe.
For plain MP4, seeking in those broken files will lead to broken A/V sync. The only way to fix this would be to check for the frame type when reading the samples table. However, this would require to read the entire stream which isn't viable.
MozReview-Commit-ID: Cpv5y7HVD0N
1d2699f1c6720a20fae0e72a0a2d258575020adb: Bug 1300296: P1. Add method to determine if an H264 frame is an I-Frame. r?jesup
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 04 Sep 2016 21:28:24 +1000 - rev 409694
Push
28515 by bmo:jyavenard@mozilla.com at Sun, 04 Sep 2016 11:48:34 +0000
Bug 1300296: P1. Add method to determine if an H264 frame is an I-Frame. r?jesup
We do so by checking the frame data for NAL of type 5 as per ISO IEC 14496-2.
MozReview-Commit-ID: JFeLysrZ6aG
8015e1a2cbf44af95dd6029b1c1ba097654dfb43: Bug 961335 - ICODecoder Robocop tests; r?ahunt
draft
Benjamin Dahse <ronoueb@gmail.com> - Sun, 04 Sep 2016 13:37:57 +0200 - rev 409693
Push
28514 by bmo:ronoueb@gmail.com at Sun, 04 Sep 2016 11:44:18 +0000
Bug 961335 - ICODecoder Robocop tests; r?ahunt
MozReview-Commit-ID: 9jtcfZCjAbd
b4bac1a4e597620b43f39b1edcf967d0f3c67ad3: Bug 1300385 - Fix flaws in SimpleTest.isDeeply
draft
Rob Wu <rob@robwu.nl> - Sat, 03 Sep 2016 22:00:45 -0700 - rev 409692
Push
28513 by bmo:rob@robwu.nl at Sun, 04 Sep 2016 09:51:39 +0000
Bug 1300385 - Fix flaws in SimpleTest.isDeeply
- When one of the parameters to isDeeply is an object/function
and the other is not, isDeeply returned false. Well, isDeeply
is supposed to report an error instead of returning a value...
- Change the implementation of isDeeply to have SameValue semantics
instead of weak equality.
- Change the representation of arrays to look like an array, instead
of its default toString() value which is indistinguishable from a
string due to the lack of brackets and quotes.
- Account for holey arrays and missing object properties;
Distinguish them from "undefined" with the special DNE tag.
MozReview-Commit-ID: F1OJhbXcptl
d5942a43dbc5e6deba7b5480462f770418ad81a1: Bug 1298710 - Remove ByteReader::DiscardRemaining and AutoByteReader - r?jya
draft
Gerald Squelart <gsquelart@mozilla.com> - Sun, 04 Sep 2016 18:33:30 +1000 - rev 409691
Push
28512 by gsquelart@mozilla.com at Sun, 04 Sep 2016 09:51:31 +0000
Bug 1298710 - Remove ByteReader::DiscardRemaining and AutoByteReader - r?jya
DiscardRemaning was needed to prevent debug-time assertion that the buffer was
read completely or explicitly discarded.
However this required extra work in cases where buffer didn't need to be read
to the end.
And also it could cause crashes (in debug versions) if a buffer was not fully
read, be it because the parser was incorrect or because the media file itself
was wrong (though possibly still readable despite that).
Finding parser issues is still possible by manually instrumenting ByteReader
during development.
And reading media file with small recoverable errors is a bonus.
MozReview-Commit-ID: 2RUYzaYAeRW
556ac64f9c6404ff9007df52fc69271e9e743bab: Bug 1300385 - Fix flaws in SimpleTest.isDeeply
draft
Rob Wu <rob@robwu.nl> - Sat, 03 Sep 2016 22:00:45 -0700 - rev 409690
Push
28511 by bmo:rob@robwu.nl at Sun, 04 Sep 2016 08:28:15 +0000
Bug 1300385 - Fix flaws in SimpleTest.isDeeply
- When one of the parameters to isDeeply is an object/function
and the other is not, isDeeply returned false. Well, isDeeply
is supposed to report an error instead of returning a value...
- Change the implementation of isDeeply to have SameValue semantics
instead of weak equality.
- Change the representation of arrays to look like an array, instead
of its default toString() value which is indistinguishable from a
string due to the lack of brackets and quotes.
- Account for holey arrays and missing object properties;
Distinguish them from "undefined" with the special DNE tag.
MozReview-Commit-ID: F1OJhbXcptl
de4887928f1092f8c352b698c94ce914285ca632: Bug 1300045 part 2 - Split KeyframeEffect.cpp into KeyframeEffect{ReadOnly}.cpp
draft
Brian Birtles <birtles@gmail.com> - Sun, 04 Sep 2016 16:34:21 +0900 - rev 409689
Push
28510 by bbirtles@mozilla.com at Sun, 04 Sep 2016 07:36:02 +0000
Bug 1300045 part 2 - Split KeyframeEffect.cpp into KeyframeEffect{ReadOnly}.cpp
MozReview-Commit-ID: DdBEicunApv
b6d80ae5efe2c168126843f901b2b38c86410753: Bug 1300045 part 1 - Tidy up some missing includes
draft
Brian Birtles <birtles@gmail.com> - Sun, 04 Sep 2016 16:33:38 +0900 - rev 409688
Push
28510 by bbirtles@mozilla.com at Sun, 04 Sep 2016 07:36:02 +0000
Bug 1300045 part 1 - Tidy up some missing includes
I came across these while working on a different bug that changed the grouping
in the unified build. Adding these as a separate step will hopefully remove a
little noise from the next patch in the series.
MozReview-Commit-ID: Km7wTcVWG9n
8f8e21f56e5339b82b3969218bdbab84da543923: Bug 1297306 - part7:replace StyleClear related NS_ASSERTION with MOZ_ASSERT.
draft
Jeremy Chen <jeremychen@mozilla.com> - Sun, 04 Sep 2016 14:52:05 +0800 - rev 409687
Push
28509 by jichen@mozilla.com at Sun, 04 Sep 2016 06:52:46 +0000
Bug 1297306 - part7:replace StyleClear related NS_ASSERTION with MOZ_ASSERT.
MozReview-Commit-ID: Dzd3uOoQCI
01fe76d56307f1b35ef2449190703785e99eab63: Bug 1297306 - part6:replace NS_STYLE_CLEAR_* with StyleClear enum class.
draft
Jeremy Chen <jeremychen@mozilla.com> - Sun, 04 Sep 2016 14:52:05 +0800 - rev 409686
Push
28509 by jichen@mozilla.com at Sun, 04 Sep 2016 06:52:46 +0000
Bug 1297306 - part6:replace NS_STYLE_CLEAR_* with StyleClear enum class.
After using enum class, a switch-case warning in CombineBreakType is caught.
This is one of such kind safty checks that we would like to gain.
Fix it by adding default case for switch-case in CombineBreakType.
MozReview-Commit-ID: BdS3LPN6qzX
fc1daccdca2d935bf755be3faa6be870879e640a: Bug 1297306 - part5:create enum constructors for EnumTable.
draft
Jeremy Chen <jeremychen@mozilla.com> - Sun, 04 Sep 2016 14:52:05 +0800 - rev 409685
Push
28509 by jichen@mozilla.com at Sun, 04 Sep 2016 06:52:46 +0000
Bug 1297306 - part5:create enum constructors for EnumTable.
Enable nsAttrValue::EnumTable to be initialized with enum. So, we could get rid
of the castings in EnumTable. Fix EnumTable initialization comment.
For those untyped enumerations, declare them with uint8_t, as to other typed
enumerations with type size larger than int16_t, force casting to int16_t.
Use {nullptr,0} instead of {0} to represent the last entry.
MozReview-Commit-ID: 7Dma3Apkmxj
e24d3005e17dda30e111677727b0be7afa575256: Bug 1297306 - part4:move IsEnumFittingWithin to mfbt/EnumTypeTraits.h.
draft
Jeremy Chen <jeremychen@mozilla.com> - Sun, 04 Sep 2016 14:52:05 +0800 - rev 409684
Push
28509 by jichen@mozilla.com at Sun, 04 Sep 2016 06:52:46 +0000
Bug 1297306 - part4:move IsEnumFittingWithin to mfbt/EnumTypeTraits.h.
With this change, we could share this EnumTypeTraits between files easily.
MozReview-Commit-ID: 9Q2augati7l