7d38c920f81ad04972bf57b4cdae91cee244cf13: Bug 1403347 - Set dialog titles in createDialogItems. r=liuche, a=sledru
Michael Comella <michael.l.comella@gmail.com> - Tue, 26 Sep 2017 16:22:21 -0700 - rev 673546
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1403347 - Set dialog titles in createDialogItems. r=liuche, a=sledru We manipulate the data before the dialog is shown, rather than manipulating the Views after the dialog is shown: this is more stable. One question is what is the value of isHidden, which we branch on, when we're manipulating the data. isHidden is set: - When the preference is constructed (previous commit) - When the preference is set as the default (e.g. the default panel was hidden) - When "Hide" or "Show" is clicked in the preference Thus the preference (and hidden state) outlives the dialog and each time we reread the value of isHidden to set the dialog items. This would fix the bug but the dialog values are actually cached so we'll need to fix/remove that cache: coming up in the next changeset. MozReview-Commit-ID: 86v1RDNFZHZ
cfed66643774a87e0335d3879fa1c9a18b4a305a: Bug 1403347 - Move initial setHidden to panel preference constructor. r=liuche, a=sledru
Michael Comella <michael.l.comella@gmail.com> - Tue, 26 Sep 2017 16:32:20 -0700 - rev 673545
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1403347 - Move initial setHidden to panel preference constructor. r=liuche, a=sledru This is a code clean-up. Functionally, this is the same to the previous implementation. setHidden was originally called right after the constructor is called and so should just be called from the constructor. If it's not called from the constructor, there can be a period of confusion where a developer wonders, "Has isHidden been initialized by the time this other method I care about has been called?" This should make those questions disappear. This commit does not need to be uplifted (to change less in 57 and that the other code does not depend on it) but I'm placing it first so it's clearer to my reviewer when isHidden is initialized (which is relevant to my other patches). MozReview-Commit-ID: 80KXFDB1poY
d37c4ff7807c023e78a0bb0cd8d52c231a89f3ed: Bug 1403282 - stylo: Add reftests for whitespace in attr(). r=bz, a=sledru
Manish Goregaokar <manishearth@gmail.com> - Tue, 26 Sep 2017 13:54:22 -0700 - rev 673544
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1403282 - stylo: Add reftests for whitespace in attr(). r=bz, a=sledru MozReview-Commit-ID: IMXFY7bpKGf
318aab4f559397c6e661db77f0d8f75ba6bb72e5: Bug 1403282 - stylo: Don't error out on trailing whitespace in attr(). r=bz, a=sledru
Manish Goregaokar <manishearth@gmail.com> - Tue, 26 Sep 2017 23:56:15 -0500 - rev 673543
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1403282 - stylo: Don't error out on trailing whitespace in attr(). r=bz, a=sledru Source-Repo: https://github.com/servo/servo Source-Revision: 97227aaca3613e22afc832554d29f7f7fdfb7220
2399e64d6af2cb9c8be4aff60f7d8b45c0598df6: Bug 1401009 - Add border between notification buttons when highlight is disabled. r=johannh, a=sledru
Michael Kaply <mozilla@kaply.com> - Tue, 26 Sep 2017 14:25:33 -0500 - rev 673542
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1401009 - Add border between notification buttons when highlight is disabled. r=johannh, a=sledru MozReview-Commit-ID: 4YGdUZstiDk
3ab379041f96a8a4c135a72b02f8dff9935e7232: Bug 1390276 - Make the options_ui background transparent. r=rhelmer, a=sledru
Mark Striemer <mstriemer@mozilla.com> - Wed, 20 Sep 2017 12:31:37 -0500 - rev 673541
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1390276 - Make the options_ui background transparent. r=rhelmer, a=sledru MozReview-Commit-ID: Imowx5I5YK4
f8eb0cd96943082953eca6728f70fb6e4bb430b3: Bug 1403028 - Crashtest. r=heycam, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 Sep 2017 07:26:58 +0200 - rev 673540
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1403028 - Crashtest. r=heycam, a=sledru MozReview-Commit-ID: 68vEodg5jzR
c363a41fc89928a55ccd7aaf9ab835bd1299c6c1: Bug 1403028 - Ensure the parent is in the composed doc before marking it as dirty. r=heycam, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 Sep 2017 09:38:18 +0200 - rev 673539
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1403028 - Ensure the parent is in the composed doc before marking it as dirty. r=heycam, a=sledru We could do the check earlier, but the end result is effectively the same, and this makes it easier to remove. MozReview-Commit-ID: 5c8TFHK1ciD
995866fb3357e7fa89c7e83877a0cf9fe4e3f957: Bug 1363028 - Update bookmark toolbar icons to photon styles. r=johannh, a=sledru
Towkir Ahmed <towkir17@gmail.com> - Fri, 22 Sep 2017 11:52:00 -0400 - rev 673538
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1363028 - Update bookmark toolbar icons to photon styles. r=johannh, a=sledru
13e98e34ff2811f68cbee69c9b181ae2eaca3353: Bug 1402366 - Crashtest. r=me, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 25 Sep 2017 10:16:36 +0200 - rev 673537
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1402366 - Crashtest. r=me, a=sledru MozReview-Commit-ID: 8ZcVBHKNntj
12d437dedc4d2724ece4135596d4687a8fe38cd0: Bug 1402366 - Mark datetimebox as not needing xul.css. r=bholley, r=jessica, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 21:23:11 +0200 - rev 673536
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1402366 - Mark datetimebox as not needing xul.css. r=bholley, r=jessica, a=sledru We create a datetimebox in content documents that gets an XBL binding on nsDateTimeControlFrame::CreateAnonymousContent. This is done during frame construction, and loading a datetimebox insert xul.css in the document, which causes invalidation to run. datetimebox styles are in html.css, and there's no rule in xul.css that styles it, so we don't need to load the stylesheet at all. MozReview-Commit-ID: 2SbIOoER2uB
9c121063b2ae8913327355783439839a515a2cf8: Bug 1397619 - Test paint-order specified value serialization. r=me, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 25 Sep 2017 16:16:31 +0200 - rev 673535
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1397619 - Test paint-order specified value serialization. r=me, a=sledru MozReview-Commit-ID: ICtzbZVix1u Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
772fb56b0982b210b49374b5b52aaa952987307c: Bug 1397619 - Test border-spacing specified value serialization. r=me, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 25 Sep 2017 16:15:12 +0200 - rev 673534
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1397619 - Test border-spacing specified value serialization. r=me, a=sledru MozReview-Commit-ID: 1L5mjfvYRLQ Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
dea074a3264f0f6526fc10c002afb7c3d8539d85: Bug 1397619 - stylo: test border-radius longhand specified values serialization. r=emilio, a=sledru
Fernando Jimenez Moreno <ferjmoreno@gmail.com> - Mon, 25 Sep 2017 16:14:42 +0200 - rev 673533
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1397619 - stylo: test border-radius longhand specified values serialization. r=emilio, a=sledru MozReview-Commit-ID: FWN56IcctTJ Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
6e4272e16bb2ad4103900c7595643a229d9337af: Bug 1397619 - servo: style: paint-order serialization fixes. r=nox, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 25 Sep 2017 09:35:38 -0500 - rev 673532
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1397619 - servo: style: paint-order serialization fixes. r=nox, a=sledru See each commit for details. Source-Repo: https://github.com/servo/servo Source-Revision: bbb5c8436edb89235fe030e8dc965b9bef43c071
cda60381e179196bd55dcb09ba9d114bec41c59a: Bug 1387171 - Prevent tabs scrolling when enter / leaving customise move. r=dao, a=sledru
Dale Harvey <dale@arandomurl.com> - Sat, 23 Sep 2017 12:04:23 +0100 - rev 673531
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1387171 - Prevent tabs scrolling when enter / leaving customise move. r=dao, a=sledru MozReview-Commit-ID: LKUT3ecfzKJ
7aab168eac85e464896fb7b5e9c14e8c92da8682: Bug 1352453 - Add crashtest for this bug. r=heycam, a=sledru
Ethan Lin <ethlin@mozilla.com> - Sat, 23 Sep 2017 15:20:05 +0800 - rev 673530
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1352453 - Add crashtest for this bug. r=heycam, a=sledru MozReview-Commit-ID: 97vLPFkTYli
41166905e77a9bb91dd86037141156a29fc35df6: Bug 1352453 - Check image dimension when computing border space size. r=heycam, a=sledru
Ethan Lin <ethlin@mozilla.com> - Sat, 23 Sep 2017 15:06:07 +0800 - rev 673529
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1352453 - Check image dimension when computing border space size. r=heycam, a=sledru MozReview-Commit-ID: LQcf9UGyUUq
2324642ef3dbe0dacd502ff2e7bf02a62faa32c5: Bug 1387476 - Import time zone detection patch from ICU to improve tz handling in newer Linuxes and macOS 10.13. r=gandalf, a=sledru
André Bargull <andre.bargull@gmail.com> - Thu, 21 Sep 2017 21:39:12 +0200 - rev 673528
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1387476 - Import time zone detection patch from ICU to improve tz handling in newer Linuxes and macOS 10.13. r=gandalf, a=sledru
38f4bb54aa797c90303ded0863fe6a2f153ba290: Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons. r=dao, a=sledru
Nihanth Subramanya <nhnt11@gmail.com> - Thu, 21 Sep 2017 05:12:59 +0530 - rev 673527
Push 82597 by bmo:edilee@mozilla.com at Mon, 02 Oct 2017 17:24:38 +0000
Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons. r=dao, a=sledru MozReview-Commit-ID: Lun7GjOZhmy
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip