7cfbd0d2d797490a88bff3fd1094683eaad3692e: (No bug) - Improve comment in IDecodingTask.cpp. r=me
Seth Fowler <mark.seth.fowler@gmail.com> - Mon, 01 Aug 2016 15:33:13 -0700 - rev 395378
Push 24763 by bmo:mh+mozilla@glandium.org at Tue, 02 Aug 2016 04:27:00 +0000
(No bug) - Improve comment in IDecodingTask.cpp. r=me
4c6dc34d653dfcf789e1782e0ead3c7d1c50d81d: Bug 1291019 - Take the value of |aDoomed| in NS_ReleaseOnMainThread() if we're going to leak anyway. r=froydnj
Seth Fowler <mark.seth.fowler@gmail.com> - Mon, 01 Aug 2016 15:25:58 -0700 - rev 395377
Push 24763 by bmo:mh+mozilla@glandium.org at Tue, 02 Aug 2016 04:27:00 +0000
Bug 1291019 - Take the value of |aDoomed| in NS_ReleaseOnMainThread() if we're going to leak anyway. r=froydnj
8351f6e097ebecc28be5b1e8314d4fbed3fb2528: Merge m-c to inbound, a=merge
Wes Kocher <wkocher@mozilla.com> - Mon, 01 Aug 2016 17:49:07 -0700 - rev 395376
Push 24763 by bmo:mh+mozilla@glandium.org at Tue, 02 Aug 2016 04:27:00 +0000
Merge m-c to inbound, a=merge
9d668735beb37a324c6b17337cfacf0b181849d4: Bug 1290759 - Convert frame number check in Decoder::AllocateFrame() into an assert. r=edwin
Seth Fowler <mark.seth.fowler@gmail.com> - Sun, 31 Jul 2016 14:41:10 -0700 - rev 395375
Push 24763 by bmo:mh+mozilla@glandium.org at Tue, 02 Aug 2016 04:27:00 +0000
Bug 1290759 - Convert frame number check in Decoder::AllocateFrame() into an assert. r=edwin
7d45b49f61d5026ac5ad5f0c36509a018dea3926: Bug 1290747 - Fix bad assert in RasterImage::NotifyProgress(). r=edwin
Seth Fowler <mark.seth.fowler@gmail.com> - Sun, 31 Jul 2016 14:35:37 -0700 - rev 395374
Push 24763 by bmo:mh+mozilla@glandium.org at Tue, 02 Aug 2016 04:27:00 +0000
Bug 1290747 - Fix bad assert in RasterImage::NotifyProgress(). r=edwin
0ccc93566e33f04ecca6286bd8a01c699d2c8633: Bug 1290987 - #version needs to be on the first line. CLOSED TREE
Jeff Gilbert <jgilbert@mozilla.com> - Mon, 01 Aug 2016 15:37:59 -0700 - rev 395373
Push 24763 by bmo:mh+mozilla@glandium.org at Tue, 02 Aug 2016 04:27:00 +0000
Bug 1290987 - #version needs to be on the first line. CLOSED TREE MozReview-Commit-ID: D5FMDOKiSLY
5b1be27318392cb6fbaea9b0a3caed8967ed1d1d: Bug 1290364 - clear mOwner in Shutdown(). draft
JW Wang <jwwang@mozilla.com> - Fri, 29 Jul 2016 14:44:22 +0800 - rev 395372
Push 24762 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:55:31 +0000
Bug 1290364 - clear mOwner in Shutdown(). MozReview-Commit-ID: 2CsYKcSrEOJ
bd3617094017f4b9156316cb0f1fa175c11ae4df: Bug 1290028 - Remove the check for IsShutdown() from MediaDecoder::OwnerHasError(). r?gerald draft
JW Wang <jwwang@mozilla.com> - Thu, 28 Jul 2016 17:21:09 +0800 - rev 395371
Push 24761 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:53:05 +0000
Bug 1290028 - Remove the check for IsShutdown() from MediaDecoder::OwnerHasError(). r?gerald MozReview-Commit-ID: Cg5UoFngxFr
6269d6fb335c3301e01c79c38a251a6dbc83a30e: Bug 1291009 - Fix closed caption button icon in hidpi mode. r?jaws draft
Ray Lin <ralin@mozilla.com> - Tue, 02 Aug 2016 11:34:40 +0800 - rev 395370
Push 24760 by bmo:ralin@mozilla.com at Tue, 02 Aug 2016 03:41:24 +0000
Bug 1291009 - Fix closed caption button icon in hidpi mode. r?jaws MozReview-Commit-ID: lDumJxyzTr
3442c78bc832cbc02c229bc885d1631fbf21ef06: Bug 1290780. Part 9 - Assert IsShutdown() is false in DurationChanged(). r?kaku draft
JW Wang <jwwang@mozilla.com> - Thu, 28 Jul 2016 16:57:09 +0800 - rev 395369
Push 24759 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:40:59 +0000
Bug 1290780. Part 9 - Assert IsShutdown() is false in DurationChanged(). r?kaku 1. The watch manager disconnect callbacks in Shutdown(). 2. SetExplicitDuration() asserts !IsShutdown(). 3. SetInfinite() asserts !IsShutdown(). MozReview-Commit-ID: FwWf4m5OAOP
1ebdac42e80bc827f69056ebfd627643a85713b1: Bug 1290780. Part 8 - Assert IsShutdown() is false in SetExplicitDuration(). r?kaku draft
JW Wang <jwwang@mozilla.com> - Thu, 28 Jul 2016 16:54:53 +0800 - rev 395368
Push 24759 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:40:59 +0000
Bug 1290780. Part 8 - Assert IsShutdown() is false in SetExplicitDuration(). r?kaku It is called from MediaSourceDecoder::SetMediaSourceDuration() which asserts !IsShutdown(). MozReview-Commit-ID: LF8rRPZhkA2
a20e7f37b7658f94cc983c4389a0172b4b5badfe: Bug 1290780. Part 7 - We don't want to trigger DurationChanged(). So just set mExplicitDuration without calling SetExplicitDuration(). r?jya draft
JW Wang <jwwang@mozilla.com> - Thu, 28 Jul 2016 16:50:10 +0800 - rev 395367
Push 24759 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:40:59 +0000
Bug 1290780. Part 7 - We don't want to trigger DurationChanged(). So just set mExplicitDuration without calling SetExplicitDuration(). r?jya MozReview-Commit-ID: 5yWLhteUgQt
0801d5f8ef7bc8a834946c108c2d36467824a148: Bug 1290780. Part 6 - Assert IsShutdown() is false in SetMediaSourceDuration(). r?jya draft
JW Wang <jwwang@mozilla.com> - Thu, 28 Jul 2016 15:52:30 +0800 - rev 395366
Push 24759 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:40:59 +0000
Bug 1290780. Part 6 - Assert IsShutdown() is false in SetMediaSourceDuration(). r?jya 1. It is called from SetInitialDuration() when mMediaSource is non-null which happens before Shutdown() which clears |mMediaSource|. 2. It is called from MediaSource::SetDuration() which happens before MediaSourceDecoder::Shutdown() for |mDecoder| is non-null. 3. It is called from MediaSource::DurationChange() where |mDecoder| is non-null. MozReview-Commit-ID: 56AmWRLkkiv
fb65cdf719306e129e7c95b6b96af991c526c81b: Bug 1290780. Part 5 - Assert IsShutdown() is false in PlaybackEnded() since the callback is disconnect in Shutdown(). r?kaku draft
JW Wang <jwwang@mozilla.com> - Thu, 28 Jul 2016 15:16:32 +0800 - rev 395365
Push 24759 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:40:59 +0000
Bug 1290780. Part 5 - Assert IsShutdown() is false in PlaybackEnded() since the callback is disconnect in Shutdown(). r?kaku MozReview-Commit-ID: hYJjKZFhA6
d2380610ec88916aecdfc9ae9c3d789f83d13305: Bug 1290780. Part 4 - Assert IsShutdown() is false in SeekingStarted() since the callback is disconnected in Shutdown(). r?kaku draft
JW Wang <jwwang@mozilla.com> - Thu, 28 Jul 2016 15:13:31 +0800 - rev 395364
Push 24759 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:40:59 +0000
Bug 1290780. Part 4 - Assert IsShutdown() is false in SeekingStarted() since the callback is disconnected in Shutdown(). r?kaku MozReview-Commit-ID: 7Q9EAhy3O7w
424b1441e2145768f49e232142fa045a746b1875: Bug 1290780. Part 3 - Assert IsShutdown() is false in UpdateLogicalPositionInternal(). r?kaku draft
JW Wang <jwwang@mozilla.com> - Thu, 28 Jul 2016 15:09:03 +0800 - rev 395363
Push 24759 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:40:59 +0000
Bug 1290780. Part 3 - Assert IsShutdown() is false in UpdateLogicalPositionInternal(). r?kaku 1. It is called from OnSeekResolved() which asserts !IsShutdown(). 2. It is called from UpdateLogicalPosition which asserts !IsShutdown(). MozReview-Commit-ID: J8iuHdUamLS
01feb66ac705ae81f15e6e3cb0cae4298a737c64: Bug 1290780. Part 2 - Assert IsShutdown() is false in MediaDecoder::OnSeekResolved() since the seek request is disconected in Shutdown(). r?kaku draft
JW Wang <jwwang@mozilla.com> - Thu, 28 Jul 2016 15:04:36 +0800 - rev 395362
Push 24759 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:40:59 +0000
Bug 1290780. Part 2 - Assert IsShutdown() is false in MediaDecoder::OnSeekResolved() since the seek request is disconected in Shutdown(). r?kaku MozReview-Commit-ID: Cc0iF3Lc7d2
bca1ddbc093511ff9b0dbdc90fe16032b380aa7e: Bug 1290780. Part 1 - Assert IsShutdown() is false in MediaDecoder::UpdateLogicalPosition(). r?kaku draft
JW Wang <jwwang@mozilla.com> - Thu, 28 Jul 2016 14:43:50 +0800 - rev 395361
Push 24759 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:40:59 +0000
Bug 1290780. Part 1 - Assert IsShutdown() is false in MediaDecoder::UpdateLogicalPosition(). r?kaku 1. Callbacks from the watch manager are disconnected in Shutdown(). 2. It is called from MediaOmxCommonDecoder::NotifyOffloadPlayerPositionChanged() which will not happen after Shutdown(). 3. It is called from MediaOmxCommonDecoder::ResumeStateMachine() which returns early when IsShutdown() is true. MozReview-Commit-ID: COmPFaQzNTq
c1a1a6f8f1b997f95d9964e77aab6fc1bf07ca37: Bug 1290338. Part 2 - don't call back to owner functions if the watcher is destroyed. draft
JW Wang <jwwang@mozilla.com> - Fri, 29 Jul 2016 11:30:16 +0800 - rev 395360
Push 24758 by jwwang@mozilla.com at Tue, 02 Aug 2016 03:18:40 +0000
Bug 1290338. Part 2 - don't call back to owner functions if the watcher is destroyed. MozReview-Commit-ID: FQkJYtLTBNQ
d7fd858720c430b99ef46c0c41d85a6d491db979: Bug 1286751 - Close the channel when window destroyed. r=rillian draft
bechen <bechen@mozilla.com> - Tue, 02 Aug 2016 10:52:16 +0800 - rev 395359
Push 24757 by bechen@mozilla.com at Tue, 02 Aug 2016 02:57:53 +0000
Bug 1286751 - Close the channel when window destroyed. r=rillian MozReview-Commit-ID: 4FSPOfT5F6R
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip